summaryrefslogtreecommitdiffstats
path: root/chrome/browser/browser.h
Commit message (Collapse)AuthorAgeFilesLines
* Cleanup: Include browser.h -> ui/browser.h [Final].jhawkins@chromium.org2010-11-181-13/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5197001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66668 0039d316-1c4b-4281-b951-d872f2087c98
* Move browser.cc,h and browser_window.h to browser/uiben@chromium.org2010-11-081-1084/+3
| | | | | | | | | | TBR=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/4694002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65438 0039d316-1c4b-4281-b951-d872f2087c98
* First cut of the about:conflicts page, listing all DLLs loaded in the Chrome ↵finnur@chromium.org2010-11-081-0/+1
| | | | | | | | | | | process. BUG=http://crbug.com/51105, http://crbug.com/57239 TEST=Unit tests included. Review URL: http://codereview.chromium.org/4524002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65366 0039d316-1c4b-4281-b951-d872f2087c98
* Make all browser code use browser::Navigate to open tabs.ben@chromium.org2010-11-021-48/+0
| | | | | | | | | BUG=none TEST=existing unittests. Also, test all places where new tabs and windows are opened from UI, e.g. links in options, new tab button, Ctrl+T, popup windows, etc. Review URL: http://codereview.chromium.org/3834002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64745 0039d316-1c4b-4281-b951-d872f2087c98
* Part 3 of immutable Extension refactor.mpcomplete@chromium.org2010-10-291-6/+6
| | | | | | | | | | | | | Make ExtensionsService hold const Extension pointers only. This ensures that extensions can't be modified after they're created, and lets us share them between threads. BUG=56558 TEST=no functional change Review URL: http://codereview.chromium.org/4138006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64517 0039d316-1c4b-4281-b951-d872f2087c98
* Add policy to disable Developer-Tools.markusheintz@chromium.org2010-10-221-0/+6
| | | | | | | | | BUG=49600 TEST=none Review URL: http://codereview.chromium.org/3965003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63520 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 62881 - Moves instant back into flags.sky@chromium.org2010-10-171-0/+3
| | | | | | | | | | | | | | | I'm TBRing this since it's mostly a revert. TBR=ben@chromium.org BUG=59298 TEST=make sure instant isn't in preferences anymore. Review URL: http://codereview.chromium.org/3809005 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/3777009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62883 0039d316-1c4b-4281-b951-d872f2087c98
* Moves instant back into flags.sky@chromium.org2010-10-171-3/+0
| | | | | | | | | | | | I'm TBRing this since it's mostly a revert. TBR=ben@chromium.org BUG=59298 TEST=make sure instant isn't in preferences anymore. Review URL: http://codereview.chromium.org/3809005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62881 0039d316-1c4b-4281-b951-d872f2087c98
* Remove --apps-panel switch.tfarina@chromium.org2010-10-161-5/+0
| | | | | | | | | | | Also remove AppLauncher class (it's not used anymore). BUG=56236,57371 TEST=build and ran it. Review URL: http://codereview.chromium.org/3852001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62866 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 62641 - Remove the dashboard link from the Prefs, since it's now in ↵avi@chromium.org2010-10-151-0/+1
| | | | | | | | | | | | | | | | Clear Browsing Data. Essentially a revert of r52258, though done by hand. xib: Removed the link from the sync group, removed continuation array, resized everything else to close the gap. BUG=59095 TEST=go into options, find no "go to Google Dashboard" link Review URL: http://codereview.chromium.org/3761005 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/3799004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62778 0039d316-1c4b-4281-b951-d872f2087c98
* Indicate if window is closing in tabs.onRemoved callbackjstritar@chromium.org2010-10-151-1/+3
| | | | | | | | | | | This adds a removeInfo object to the chrome.tabs.onRemoved callback that indicates if the tab's window is also closing. BUG=56592 TEST=ExtensionApiTest Review URL: http://codereview.chromium.org/3692004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62755 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for SINGLETON_TAB disposition to BrowserNavigator.ben@chromium.org2010-10-141-4/+11
| | | | | | | | | | | Also makes Browser support browser::NavigatorDelegate. BUG=none TEST=BrowserNavigatorTest.Disposition_SingletonTab* Review URL: http://codereview.chromium.org/3734003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62653 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the dashboard link from the Prefs, since it's now in Clear Browsing ↵avi@chromium.org2010-10-141-1/+0
| | | | | | | | | | | | | Data. Essentially a revert of r52258, though done by hand. xib: Removed the link from the sync group, removed continuation array, resized everything else to close the gap. BUG=59095 TEST=go into options, find no "go to Google Dashboard" link Review URL: http://codereview.chromium.org/3761005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62641 0039d316-1c4b-4281-b951-d872f2087c98
* Launch apps directly into NTPjstritar@chromium.org2010-10-141-9/+15
| | | | | | | | | | | Applications that are configured to be launched in a tab are now opened directly in the NTP, rather than opening a new tab and closing the NTP. BUG=57476 TEST=Try launching an application from the new tab page. If it's set to open as a tab, a pinned tab, or full-screen, the application should launch directly into the existing new tab page. The new tab page should close when opening an application with panel launch type. Review URL: http://codereview.chromium.org/3673006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62560 0039d316-1c4b-4281-b951-d872f2087c98
* Use CommandUpdater for disabling commands that were disabled by plugins.jam@chromium.org2010-10-131-0/+7
| | | | | | Review URL: http://codereview.chromium.org/3742002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62475 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented cellular plan details in DOM UI.zelidrag@chromium.org2010-10-131-0/+1
| | | | | | | | | BUG=chromium-os:7617 TEST=open chrome:settings, select cellular plan options, observer payment info being displayed at the top Review URL: http://codereview.chromium.org/3762001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62428 0039d316-1c4b-4281-b951-d872f2087c98
* Moves instant out of labs and into prefs.sky@chromium.org2010-10-121-0/+6
| | | | | | | | | | BUG=58772 TEST=make sure that there is an entry in prefs for instant. See that it works. Review URL: http://codereview.chromium.org/3726002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62250 0039d316-1c4b-4281-b951-d872f2087c98
* Add the Windows dialog for setting default search provider from js.levin@chromium.org2010-10-111-0/+4
| | | | | | | | | | | Document with the dialog: http://sites.google.com/a/chromium.org/dev/developers/design-documents/chromium-search-provider-js-support BUG=38475 TEST=Used a custom html page which calls window.external.AddSearchProvider(url, true). Review URL: http://codereview.chromium.org/3673002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62199 0039d316-1c4b-4281-b951-d872f2087c98
* chromium-os:7243: Fix so that extensions create popup windows of TYPE_APP_POPUP.stevenjb@google.com2010-10-061-17/+5
| | | | | | | | | | | | Refactor Browser::BuildPopupWindow as Browser::CreatePopupWindow and call it from ExtensionHost::ShowCreatedWindow. BUG=http://code.google.com/p/chromium-os/issues/detail?id=7243 TEST=Test popup windows in general. See issue for specific test case. Review URL: http://codereview.chromium.org/3532011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61657 0039d316-1c4b-4281-b951-d872f2087c98
* Make the "Send System Information" link always open the correct page.tfarina@chromium.org2010-10-061-1/+2
| | | | | | | | | BUG=chromium-os:7336 TEST=see bug Review URL: http://codereview.chromium.org/3620004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61628 0039d316-1c4b-4281-b951-d872f2087c98
* Renames and moves match preview classes to instant. This doesn'tsky@chromium.org2010-10-051-15/+15
| | | | | | | | | | | | contain any changes other than renaming/moving, as such I'm TBRing. BUG=54833 TEST=none TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/3602015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61553 0039d316-1c4b-4281-b951-d872f2087c98
* Replace Browser::AddTabWithURL(...) with:ben@chromium.org2010-10-051-28/+43
| | | | | | | | | | | | | | - Browser::AddSelectedTabWithURL(const GURL& url, PageTransition::Type transition) -> A good many callsites just wanted a way to open a tab somewhere and select it. - Browser::AddTabWithURL(AddTabWithURLParams* params) -> For the callsites with specialized needs, this new signature allows the parameter set to change as features are added without having to update a bunch of callers every time. BUG=none TEST=existing unit tests Review URL: http://codereview.chromium.org/3599006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61517 0039d316-1c4b-4281-b951-d872f2087c98
* Changes instant around to support multiple loaders. This issky@chromium.org2010-10-041-1/+1
| | | | | | | | | | | | | | | | | | | | | necessitated by needing to hold off on showing instant results until I know if the server really supports instant. This change is mostly refactoring to enable this. Most of what was MatchPreview has been moved into MatchPreviewLoader. LoaderManager is used to determine which MatchPreviewLoader to use as well as keeping around a cache of them. MatchPreview for the most part delegates to LoaderManager and MatchPreviewLoader now. I'll rename all these classes to instant (and move into its own directory) next. BUG=54833 TEST=none Review URL: http://codereview.chromium.org/3541008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61441 0039d316-1c4b-4281-b951-d872f2087c98
* chromium-os:5166 Panel/popup cleanup for ChromeOSstevenjb@google.com2010-10-041-2/+3
| | | | | | | | | | | | | | | | | | | | * Move size based disposition override for ChromeOS from tab_container to browser. * TYPE_APP_PANEL |= TYPE_POPUP so that special popup behavior applies to panels. * Removed confusing BrowserFrameChromeos::IsPanel(), replaced with BrowserView::IsBrowserTypePopup() calls. * Replaced now redundant checks against panel or popup types with 'browser->type() & Browser::TYPE_POPUP'. * Added size limiting code to PanelBrowserView. * Modified CreateWindowFunction::RunImpl() to create TYPE_APP_POPUP windows instead of TYPE_POPUP. BUG=http://code.google.com/p/chromium-os/issues/detail?id=5166 TEST=Test spawning popups/panels/tabs from web pages (e.g. gmail), extensions (e.g. chat manager), and apps More info: https://docs.google.com/document/edit?id=14nBjW6gHJW0kk44o8Z8vfDSnDi0ZT1sUU74Zc5wmwIQ&hl=en&authkey=CKT6-O8I !!! This commit didn't go through !!! Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29fe99e Review URL: http://codereview.chromium.org/3449007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61427 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Make 'Adobe flash..' and 'Disable individual plug-ins' open in a new tab.tfarina@chromium.org2010-10-021-0/+1
| | | | | | | | | BUG=53617 TEST=see bug Review URL: http://codereview.chromium.org/3550007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61311 0039d316-1c4b-4281-b951-d872f2087c98
* Policy to disable printinggfeher@chromium.org2010-10-011-0/+3
| | | | | | | | | | | | | Make Chrome refuse to print if the preference kPrintingEnabled is set to false. In this case, the 'Print...' option in the wrench menu is disabled, and if printing is invoked from JavaScript, then Chrome reports that no printer is installed. Changes to this preference after startup are also respected. BUG=54380 TEST=manual Review URL: http://codereview.chromium.org/3357011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61222 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome side of consolidating zoom code for pepper plugins (i.e. pdf) and the ↵jam@chromium.org2010-10-011-4/+0
| | | | | | | | rest of Chrome. Allows plugins to have different zoom ranges, and also to update zoom on its own. Review URL: http://codereview.chromium.org/3419023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61153 0039d316-1c4b-4281-b951-d872f2087c98
* Create a TabHandler object to decouple Browser from TabStripModel API.ben@chromium.org2010-09-281-27/+32
| | | | | | | | | | Currently it's just a pass-through so everything still works while I begin to move stuff out of Browser down into it. BUG=none TEST=existing unittests. Review URL: http://codereview.chromium.org/3412041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60860 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 60821 (build break) - Create a TabHandler object to decouple Browser ↵willchan@chromium.org2010-09-281-32/+27
| | | | | | | | | | | | | | | | from TabStripModel API. Currently it's just a pass-through so everything still works while I begin to move stuff out of Browser down into it. BUG=none TEST=existing unittests. Review URL: http://codereview.chromium.org/3447033 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/3423028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60824 0039d316-1c4b-4281-b951-d872f2087c98
* Create a TabHandler object to decouple Browser from TabStripModel API.ben@chromium.org2010-09-281-27/+32
| | | | | | | | | | | Currently it's just a pass-through so everything still works while I begin to move stuff out of Browser down into it. BUG=none TEST=existing unittests. Review URL: http://codereview.chromium.org/3447033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60821 0039d316-1c4b-4281-b951-d872f2087c98
* Changed the CloudPrintSetupFlow to not create a Browser object. Made the ↵sanjeevr@chromium.org2010-09-281-1/+0
| | | | | | | | | | | setup flow dialog modeless. Added a delegate to CloudPrintSetupFlow. Hooked up the expired token notifications handler to the CloudPrintSetupFlow dialog. BUG=None TEST=Test Cloud print proxy UI. Review URL: http://codereview.chromium.org/3433027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60814 0039d316-1c4b-4281-b951-d872f2087c98
* Makes instant support other open dispositions.sky@chromium.org2010-09-271-0/+4
| | | | | | | | | BUG=54833 TEST=none Review URL: http://codereview.chromium.org/3415026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60692 0039d316-1c4b-4281-b951-d872f2087c98
* Cloud print proxy management UI.scottbyer@chromium.org2010-09-271-0/+1
| | | | | | | | | | | Based in the Under-the-Hood section of options, this UI allows mere mortals to turn on and off the cloud print proxy. Currently working on Windows only, behind a flag. BUG=none TEST=Open up the options, turn CPP on and off. Review URL: http://codereview.chromium.org/3450021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60684 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for sending script when the user accepts instantsky@chromium.org2010-09-241-1/+1
| | | | | | | | | | | results. Also tweaks the delegate interface to be a bit more sensical. BUG=54833 TEST=see bug Review URL: http://codereview.chromium.org/3440025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60479 0039d316-1c4b-4281-b951-d872f2087c98
* Make app panels use popup type. Nuke refocus code and tests.skerner@chromium.org2010-09-241-10/+7
| | | | | | | | | BUG=55943 TEST=Manual. Review URL: http://codereview.chromium.org/3418027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60476 0039d316-1c4b-4281-b951-d872f2087c98
* Makes match preview send the dimensions of the omnibox to the page.sky@chromium.org2010-09-221-0/+1
| | | | | | | | | BUG=54833 TEST=none Review URL: http://codereview.chromium.org/3417011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60153 0039d316-1c4b-4281-b951-d872f2087c98
* Moves TabStripModelObserver/Delegate into their own headers.sky@chromium.org2010-09-161-20/+12
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3425009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59733 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Move Extension::LaunchContainer to extension_constants.h.erg@google.com2010-09-161-5/+6
| | | | | | | | | | | This makes browser.h not depend on extension.h. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3399008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59588 0039d316-1c4b-4281-b951-d872f2087c98
* Bunch of match preview tweaks:sky@chromium.org2010-09-141-2/+17
| | | | | | | | | | | | | | | | . Makes MatchPreview owned by Browser rather than each TabContents. . Makes MatchPreview dismiss when the omnibox closes. . Supports the ability to send script to the page rather than reloading on every keystroke. . Supports receiving results from the page that drives the suggest text in the omnbox. BUG=54833 TEST=none Review URL: http://codereview.chromium.org/3332022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59428 0039d316-1c4b-4281-b951-d872f2087c98
* Tabbed options: Support direct navigation to content settings subtabs.estade@chromium.org2010-09-141-1/+1
| | | | | | | | | BUG=54903 TEST=block cookies, go to almost any site, click little cookie in omnibox, manage cookies Review URL: http://codereview.chromium.org/3323021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59422 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SessionStoragejorlow@chromium.org2010-09-141-2/+5
| | | | | | | | | | | | | | | Apparently the session storage code was pretty horribly broken. It didn't correctly handle tabs being restored, didn't have the proper lifetime (this was the issue exposed in the bug), and had many leaks. To fix this, things had to be plumbed fairly differently. We need to pass session storage in on TabContents creation to ensure that the first RenderView will have the correct session storage id. When closing a tab, we need to save the session storage with the restoration service. When restoring a tab, we pass it back into the tab contents class. When duplicating a tab, we clone the storage. Lifetimes are now handled by standard reference counting code. A SessionStorageNamespace object wraps an ID. When it's instantiated, it allocates an ID. When it's destroyed, it deletes the ID. IDs make this process very lightweight (the heavyweight stuff is allocated on first use of SessionStorage) and it seperates the more complex lifetimes of SessionStorage namespaces (where less deterministic shutdown is more tollerable) from the LocalStorage namespace which needs to shutdown very precisely. BUG=52393 TEST=Set some variable on session storage; close the tab; re-open the tab; the variable should still be set. You can also run through the repro steps in the bug. Review URL: http://codereview.chromium.org/3325012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59350 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Reaplly the TabRestoreService::Observer into its own file commit.erg@google.com2010-09-021-3/+4
| | | | | | | | | | | | | This means browser.h no longer includes a large chunk of the tab restore system. Now with fixes to chromeos. BUG=none TEST=compiles First Review URL: http://codereview.chromium.org/3296003 Review URL: http://codereview.chromium.org/3358005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58382 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "FBTF: Move the TabRestoreService::Observer into its own file."erg@google.com2010-09-011-4/+3
| | | | | | | | | | | This reverts commit 4a76b908daffee441d9ebf9fbc74b4015d9145df (r58256) due to chromeos compile fail. TBR=akalin Review URL: http://codereview.chromium.org/3340007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58271 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Move the TabRestoreService::Observer into its own file.erg@google.com2010-09-011-3/+4
| | | | | | | | | | | | This means browser.h no longer includes a large chunk of the tab restore system. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3296003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58256 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Allowed incognito windows to be bookmark open target.yutak@chromium.org2010-09-011-0/+3
| | | | | | | | | | | | Patch contributed by Hajime Morita <morrita@google.com>. Original review URL: http://codereview.chromium.org/3217007 BUG=23547 TEST=manual Review URL: http://codereview.chromium.org/3225009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58141 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Move more and more automation bits to TestingAutomationProviderphajdan.jr@chromium.org2010-08-261-0/+1
| | | | | | | | | | | And now it seems to handle more automation messages than the original one. TEST=ui_tests, chrome_frame_tests BUG=52097 Review URL: http://codereview.chromium.org/3185030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57550 0039d316-1c4b-4281-b951-d872f2087c98
* Changes TabContentsDelegate::ShouldAddNavigationToHistory to be passedsky@chromium.org2010-08-261-1/+3
| | | | | | | | | | | | | the HistoryAddPageArgs so that they can be cached and used later on. Refactors some other code that interacts with history so that it can be called separately as well. BUG=none TEST=none Review URL: http://codereview.chromium.org/3158029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57458 0039d316-1c4b-4281-b951-d872f2087c98
* Move prefs-related files under chrome/browser/ into a prefs/ subdir.evan@chromium.org2010-08-261-1/+1
| | | | | | | | | | | | Rename includes, resort header include order in places where the rename changed the order. BUG=50548 TEST=compiles Review URL: http://codereview.chromium.org/3203008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57434 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding a previous CL (I fixed the ChromeOS build):jcivelli@chromium.org2010-08-231-2/+1
| | | | | | | | | | | | | | | Making window.focus()/blur() work only when there is a user gesture. Also making window.focus() select tab if it is not visible. The RenderViewHost now calls ActivateContent and the new DeactivateContent (instead of using the recently added TabContentsDelegate::Activate/Deactivate methods which have been removed). TBR=darin,sky BUG=29643,52346 TEST=Create a page with buttons that call window.focus()/blur() directly and with a timeout. When called directly, the calls should succeed (the browser should be activated/deactivated). When called with a timeout, nothing should happen. Also test that a popup calling window.opener.focus() cause the opening tab to become selected when it is not the current tab. Review URL: http://codereview.chromium.org/3174030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57124 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 57094 - Making window.focus()/blur() work only when there is a user ↵jcivelli@chromium.org2010-08-231-1/+2
| | | | | | | | | | | | | | | | | gesture. Also making window.focus() select tab if it is not visible. The RenderViewHost now calls ActivateContent and the new DeactivateContent (instead of using the recently added TabContentsDelegate::Activate/Deactivate methods which have been removed). BUG=29643,52346 TEST=Create a page with buttons that call window.focus()/blur() directly and with a timeout. When called directly, the calls should succeed (the browser should be activated/deactivated). When called with a timeout, nothing should happen. Also test that a popup calling window.opener.focus() cause the opening tab to become selected when it is not the current tab. Review URL: http://codereview.chromium.org/3156016 TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/3201008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57105 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-24 21:36:20 +0000