summaryrefslogtreecommitdiffstats
path: root/chrome/browser/browser.h
Commit message (Collapse)AuthorAgeFilesLines
* Mac: add Extensions to the Main Menu and to the Wrench Menu.viettrungluu@chromium.org2009-11-181-0/+1
| | | | | | | | | | | | | Changes to MainMenu.xib: Add Extensions (text: "^IDS_SHOW_EXTENSIONS_MAC", tag: IDC_MANAGE_EXTENSIONS, sends: -commandDispatch: to First Responder) to Main Menu -> Window, immediately below Downloads. Changes to Toolbar.xib: Add Extensions (text: "^IDS_SHOW_EXTENSIONS", others as above) to Wrench Menu, immediately below Downloads. Enable Extensions menu item when no browser window is open. BUG=25423 TEST=Make sure Extensions menu items in Main Menu -> Window and in the Wrench Menu work. Also make sure the former works when no browser window is open. Review URL: http://codereview.chromium.org/399072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32342 0039d316-1c4b-4281-b951-d872f2087c98
* Implement web app shortcuts natively per issue 25528xiyuan@chromium.org2009-11-171-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Implement a CreateApplicationShortcutView similar to the current Gears-based one; - Add a few profile prefs to persist user's last checked shortcut locations - Implement a web_app::CreateShortcut that stores icon under "<profile>/Web Applications" in a similar layout as gears (i.e. <host>/<scheme_port>/<web_app_title>.ico) and calls file_util code to creates shortcut on Windows; - Add Win7 taskbar pin/unpin support function to file_util; - Update TabContents to replace gears with new code; Note: - Gears dialog is modaless but this one is a modal dialog. - Gear's icon store is not migrated because gears icons could still be used by shortcuts created by gears and thus we could not delete them even after migration. And we are not using the local ico files in the dialog even if they exists. - New CreateApplicationShortcutView is included when TOOLKIT_VIEW is defined. However on platforms other than Windows, the actual CreateShortCut code is not implemented. Right now it calls ShellIntegration's CreateDesktopShort if OS_LINUX is defined and NOTREACHED() for other platforms. BUG=25528 TEST=Verify the new UI provides the same functionality as gears under XP/Vista and support pinning on Win 7. Review URL: http://codereview.chromium.org/372012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32165 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Hide the status bubble when the mouse nears it.derat@chromium.org2009-11-141-1/+5
| | | | | | | | | | | | | | | This isn't as slick as other platforms, in that the bubble just slides down and gets cropped instead of sliding down out of the browser window -- doing the latter will probably require reparenting the bubble into its own window when we want to move it. BUG=18311 TEST=ran "nc -l -p 8080", went to localhost:8080, and made sure that the bubble ran away with both LTR and RTL languages Review URL: http://codereview.chromium.org/392007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31984 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Animate the bookmark bar showing/hiding.viettrungluu@chromium.org2009-11-141-2/+2
| | | | | | | | | | | | | | | There's a huge refactoring of the bookmark bar controller in this CL, so that animation-related code is in only a few places (instead of scattered all over the place). Changes to BookmarkBar.xib: Since BookmarkBarToolbarView now inherits from AnimatableView, I had to hook up its delegate_ member to File's Owner (i.e., the BookmarkBarController). Not yet implemented: morphing between the detached bar (on the NTP) and anything else. BUG=25600 TEST=Go to a normal page, show/hide the bookmark bar (Shift-Cmd-B), watch it animate. Review URL: http://codereview.chromium.org/384105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31977 0039d316-1c4b-4281-b951-d872f2087c98
* Kiosk Mode implementation.mhm@chromium.org2009-11-091-0/+1
| | | | | | | | | | | | Kiosk mode will just hide the status bar and initially set it as full screen. Added some tests to add --kiosk mode as a command switch that tests if its in fullscreen state and doesn't have a status bubble. BUG=23145 TEST=Kiosk Mode functions and Run the ./ui_tests --gtest_filter=KioskModeTest.* Review URL: http://codereview.chromium.org/244003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31412 0039d316-1c4b-4281-b951-d872f2087c98
* Open the extensions manager tab in single-tab-per-window mode.aa@chromium.org2009-11-061-1/+1
| | | | | | | Review URL: http://codereview.chromium.org/372016 Patch from Akira <akira@yayakoshi.net>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31315 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Wire Ctrl+Shift+C to "Show JavaScript console".pfeldman@chromium.org2009-11-061-1/+1
| | | | | | Review URL: http://codereview.chromium.org/377005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31225 0039d316-1c4b-4281-b951-d872f2087c98
* Changes session restore to use a normal load rather than preferringsky@chromium.org2009-11-031-9/+6
| | | | | | | | | | | | the cache. We need to do this else we don't honor page expiration and end up showing stale data for some sites. BUG=21195 TEST=make sure session restore works. Review URL: http://codereview.chromium.org/341043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30892 0039d316-1c4b-4281-b951-d872f2087c98
* Rework the way the FindBrowserWithProfile/Type methods work.ben@chromium.org2009-10-311-3/+4
| | | | | | | | | | | | | | | | | We now always walk the last active list backwards rather than consulting the last active then walking the registered browser list forwards. I now also maintain a fallback to walk the entire registered list of browsers forward if the active scan fails. This is likely only in a testing environment where a Browser may never have been activated. This ensures that when the last active browser is a popup or app frame the last active TYPE_NORMAL browser is located when opening a new tab. http://crbug.com/17498 TEST=Open an app frame. Open a browser window (Ctrl+N) and load a page. Minimize it. Open another browser window and minimize it. Activate the app frame. Press Ctrl+T. The second browser window should be restored and have a new tab added to it rather than the first. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30531 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30659 Review URL: http://codereview.chromium.org/330013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30662 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: enable History, Downloads, and Open Location... with no windows open.viettrungluu@chromium.org2009-10-301-1/+4
| | | | | | | | | BUG=25620 TEST=Close all windows, try History->History (Cmd-Y); close window, try Window->Downloads (Shift-Cmd-J); close window, try Open Location... (Cmd-L). Review URL: http://codereview.chromium.org/329004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30615 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r30541 since it's still breaking browser_testsben@chromium.org2009-10-301-4/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30539 0039d316-1c4b-4281-b951-d872f2087c98
* Rework the way the FindBrowserWithProfile/Type methods work.ben@chromium.org2009-10-291-3/+4
| | | | | | | | | | | | | We now always walk the last active list backwards rather than consulting the last active then walking the registered browser list forwards. This ensures that when the last active browser is a popup or app frame the last active TYPE_NORMAL browser is located when opening a new tab. http://crbug.com/17498 TEST=Open an app frame. Open a browser window (Ctrl+N) and load a page. Minimize it. Open another browser window and minimize it. Activate the app frame. Press Ctrl+T. The second browser window should be restored and have a new tab added to it rather than the first. Review URL: http://codereview.chromium.org/330013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30531 0039d316-1c4b-4281-b951-d872f2087c98
* Fix and re-enable a test I broke with the find bar changes I made last night.ben@chromium.org2009-10-291-2/+7
| | | | | | | | | | | Remove Browser::find_bar(), make everyone use either Browser::GetFindBarController() which creates the FindBarController on demand, or a new method HasFindBarController(), which can be used to check for its existence (so as to avoid creating it unnecessarily). http://crbug.com/26231 TEST=interactive ui tests, standard find tests Review URL: http://codereview.chromium.org/348015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30507 0039d316-1c4b-4281-b951-d872f2087c98
* roll back r30430 because it causes bustage even though I don't know why.ben@chromium.org2009-10-291-4/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30435 0039d316-1c4b-4281-b951-d872f2087c98
* Lazily create the find bar.ben@chromium.org2009-10-291-0/+1
| | | | | | | | | | | http://crbug.com/21910 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30062 Review URL: http://codereview.chromium.org/334019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30434 0039d316-1c4b-4281-b951-d872f2087c98
* Rework the way the FindBrowserWithProfile/Type methods work.ben@chromium.org2009-10-291-3/+4
| | | | | | | | | | | | | We now always walk the last active list backwards rather than consulting the last active then walking the registered browser list forwards. This ensures that when the last active browser is a popup or app frame the last active TYPE_NORMAL browser is located when opening a new tab. http://crbug.com/17498 TEST=Open an app frame. Open a browser window (Ctrl+N) and load a page. Minimize it. Open another browser window and minimize it. Activate the app frame. Press Ctrl+T. The second browser window should be restored and have a new tab added to it rather than the first. Review URL: http://codereview.chromium.org/330013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30430 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Activate window when "Get themes" button is clicked.derat@chromium.org2009-10-281-0/+2
| | | | | | | | | | | This is a direct copy of the Views fix from r29949. BUG=24866 TESTED=verified that minimized browser window gets restored under metacity Review URL: http://codereview.chromium.org/334048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30286 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the browser_sync flag.zork@chromium.org2009-10-271-2/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/337034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30272 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2 at this. The only change between this and the first is to add the ↵sky@chromium.org2009-10-271-0/+3
| | | | | | | | | | | | | | | GetType message to the end of the list and to keep the old message for creating a new browser as well as adding one that takes the type. To change the params of the message requires updating the reference build. That's best done on a weekend when I'm bored. Makes session restore on Chrome OS restore popups. BUG=18862 TEST=none Review URL: http://codereview.chromium.org/329040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30255 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 30194 - Makes session restore on Chrome OS restore popups.sky@chromium.org2009-10-271-1/+0
| | | | | | | | | | | | BUG=18862 TEST=none Review URL: http://codereview.chromium.org/337030 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/335047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30204 0039d316-1c4b-4281-b951-d872f2087c98
* Makes session restore on Chrome OS restore popups.sky@chromium.org2009-10-271-0/+1
| | | | | | | | | BUG=18862 TEST=none Review URL: http://codereview.chromium.org/337030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30194 0039d316-1c4b-4281-b951-d872f2087c98
* CompactNavigationBar for toolkit views build, with some design change per ↵oshima@chromium.org2009-10-261-0/+3
| | | | | | | | | | | | | | | | | Cole's request. * Swapped the positions of entry field and navigation buttons. * Hide navigation buttions when the entry field gains focus. - To implement this, I added OnKillFocus in AutocompleteEditController, and updated corresponding files. * Added accelerator (shift-ctrl-0) to toggle compact navigation bar Changes to BrowserExtender * Made all virtual methods in BrowserExtender pure virtual. * Added HideToolbar method to control visibility of toolbar from Extender. Review URL: http://codereview.chromium.org/329009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30082 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 30062.glen@chromium.org2009-10-261-1/+0
| | | | | | Review URL: http://codereview.chromium.org/338022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30068 0039d316-1c4b-4281-b951-d872f2087c98
* Lazily create the find bar.ben@chromium.org2009-10-261-0/+1
| | | | | | | | | http://crbug.com/21910 TEST=none Review URL: http://codereview.chromium.org/334019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30062 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for issue 18228.xiyuan@chromium.org2009-10-221-0/+1
| | | | | | | | | | | Don't record browser history for navigations for tabs in app frame. BUG=18228 TEST=Open chrome in app frame (via "-app", application shortcut or convert a page to app), navigations in app frame should not appear in history. Review URL: http://codereview.chromium.org/306052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29830 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Enable help when there are no windows.viettrungluu@chromium.org2009-10-221-1/+6
| | | | | | | | | BUG=23825 TEST=Close all browser windows. Check that Help->Chromium Help (or Google Chrome Help) is enabled and works correctly. Review URL: http://codereview.chromium.org/303030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29744 0039d316-1c4b-4281-b951-d872f2087c98
* Rename CHROME_PERSONALIZATION to BROWSER_SYNC.nick@chromium.org2009-10-171-1/+1
| | | | | | | | | | Avoid #ifdef in general, favoring #if defined(). In one spot, use PlatformThread::Sleep instead of rolling our own. Review URL: http://codereview.chromium.org/267125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29360 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the NTP to be bookmarked.pkasting@chromium.org2009-10-091-3/+0
| | | | | | | | BUG=none TEST=Try to bookmark the NTP. Review URL: http://codereview.chromium.org/269028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28564 0039d316-1c4b-4281-b951-d872f2087c98
* * Add ctrl-shift-d to bookmark all tabs.pkasting@chromium.org2009-10-081-0/+4
| | | | | | | | | | | * Enable or disable bookmark commands based on whether we're actually going to be able to bookmark anything. * Rename IDC_STAR to IDC_BOOKMARK_PAGE, which is more obvious. BUG=2935 TEST=Hit ctrl-shift-d, make sure it bookmarks all tabs Review URL: http://codereview.chromium.org/266029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28480 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the ability to create a bookmark folder populated with a bookmarksky@chromium.org2009-10-081-0/+1
| | | | | | | | | | | | | | | for each open tab. I've currently wired this up on windows, will wire up rest of platforms in a separate cl. BUG=2935 TEST=on Windows open multiple tabs, right click on a tab and choose 'Bookmark all tabs'. You should then get the bookmark editor with no url field. Accepting the dialog should result in creating a new folder with a bookmark for each of the open tabs. Review URL: http://codereview.chromium.org/270021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28446 0039d316-1c4b-4281-b951-d872f2087c98
* cleanup: Change AddTabWithNavigationController to simply AddTab.evan@chromium.org2009-10-081-3/+2
| | | | | | | | Patch from Thiago Farina <thiago.farina@gmail.com>. Review URL: http://codereview.chromium.org/243013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28420 0039d316-1c4b-4281-b951-d872f2087c98
* Don't send tab switching/killing/creating keyboard accelerators to pages. ↵jam@chromium.org2009-10-021-0/+1
| | | | | | | | | | This avoids tabs maliciously preventing closing using ctrl+f4/ctrl+w/alt+f4, and also hung/slow renderers from making tab cycling sluggish. BUG=5496 TEST=added ui test Review URL: http://codereview.chromium.org/224023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27814 0039d316-1c4b-4281-b951-d872f2087c98
* The "Copy URL" link is always greyed out in the Chrome menu on popups ↵ericu@google.com2009-10-011-0/+1
| | | | | | | | | | | | | | [crbug.com/13488]. This turns out to be because it was never implemented. Tested manually on Windows; I'll test on Linux before submitting. BUG=13488 TEST=Tested manually on Windows and added a unit test for the new Clipboard function. Review URL: http://codereview.chromium.org/210042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27772 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all MemoryModel-related code, since we're unlikely to use it again. ↵pkasting@chromium.org2009-09-301-4/+0
| | | | | | | | | | | | Also changes some sample code to use a random generic name ("PruningAlgorithm") instead of MemoryModel in hopes that no one will be confused. This does not remove IdleTimer, even though it now has no users. I do plan to remove it, but I want to do that in a separate commit so it's easy to reference and revert if at some later point we want this functionality. BUG=none TEST=none Review URL: http://codereview.chromium.org/242079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27652 0039d316-1c4b-4281-b951-d872f2087c98
* Set new homepage preferences only if there is no existing value.kuchhal@chromium.org2009-09-301-2/+4
| | | | | | | | | BUG=23402 TEST=On a clean install, make sure Chrome has Homepage button enabled. Use master_preferences to disable homapage button and make sure it works. Review URL: http://codereview.chromium.org/255025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27614 0039d316-1c4b-4281-b951-d872f2087c98
* Integrate browser actions with the wrench menu. Browseraa@chromium.org2009-09-301-0/+1
| | | | | | | | | | | | actions always show up in a submenu of the wrench menu, and if they have an icon, they also show up in the toolbar area. BUG=23380,22883 TEST=Added new automated tests for the command handling, but we need to test that the menu items show up manually. To do that, run with no extension installed, you should see "extensions" in the wrench menu. Add an extension that adds a browser action, you should now see an "extensions" submenu with "manage extensions" and the browser action(s) in the submenu. Review URL: http://codereview.chromium.org/246037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27599 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanup. Converts Browser from storing a vector of pendingsky@chromium.org2009-09-251-10/+13
| | | | | | | | | | | updates to a map. This simplifies processing and removal. BUG=1209369 TEST=none Review URL: http://codereview.chromium.org/250003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27228 0039d316-1c4b-4281-b951-d872f2087c98
* This CL makes the browser focus tests faster by replacingjcampan@chromium.org2009-09-181-0/+1
| | | | | | | | | | | | some time-outs with notifications. BUG=22065 TEST=Run the interactive tests, especially BrowserFocusTest*FocusTraversal* These tests should run in few seconds. Review URL: http://codereview.chromium.org/210013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26597 0039d316-1c4b-4281-b951-d872f2087c98
* Add keyboard shortcuts to reorder tabs left or right on Linux.tony@chromium.org2009-09-141-0/+2
| | | | | | | | | | | | | | | It's standard in GTK+ for tabbed interfaces to be reorderable using ctrl+shift+pgup and ctrl+shift+pgdn (e.g., in Terminal). The plumbing is included on all platforms, but the shortcut is only hooked up on Linux. BUG=21594 Review URL: http://codereview.chromium.org/194088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26125 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk confirm form resubmission dialog.mattm@chromium.org2009-08-311-0/+1
| | | | | | | | | | | Refactor so that the dialog is shown by calling BrowserWindow::ShowRepostFormWarningDialog BUG=19761 TEST=see bug Review URL: http://codereview.chromium.org/174294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24930 0039d316-1c4b-4281-b951-d872f2087c98
* Experiment with dislodging the Extension Shelf and having it only appear on ↵finnur@chromium.org2009-08-301-0/+5
| | | | | | | | | | | the New Tab page. BUG=http://crbug.com/20415 TEST=With the extension toolstrip visible, go to the New Tab page and press Ctrl + Alt + B. Watch the toolstrip merge into the New Tab page and back again into a separate toolstrip (when you press Ctrl + Alt + B again). Also, when you do this on a regular webpage (as opposed to NTP) this should toggle the toolstrip visiblity. Review URL: http://codereview.chromium.org/175017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24864 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Gtk confirm form resubmission dialog." Broke linux views build.mattm@chromium.org2009-08-281-1/+0
| | | | | | | | | | This reverts commit e6ab23c81e56c6b9fbb062bbb090a648e6ebef12. TBR=beng Review URL: http://codereview.chromium.org/183006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24827 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk confirm form resubmission dialog.mattm@chromium.org2009-08-281-0/+1
| | | | | | | | | | | Refactor so that the dialog is shown by calling BrowserWindow::ShowRepostFormWarningDialog BUG=19761 TEST=see bug Review URL: http://codereview.chromium.org/174294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24826 0039d316-1c4b-4281-b951-d872f2087c98
* Change default homepage experience.kuchhal@chromium.org2009-08-281-0/+6
| | | | | | | | | | | We want to make google.com homepage by default and also show the home button (see the bug below). BUG=http://crbug.com/19392 TEST=Delete user profile and launch Chrome - homepage should be set to google.com and should be enabled. also home button should show up. Review URL: http://codereview.chromium.org/174030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24736 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce accesskeys for Chrome menus.mhm@chromium.org2009-08-261-0/+2
| | | | | | | | | | | Added ALT+E for Chrome Page Menu Added ALT+F for Chrome App Menu BUG=906 (http://crbug.com/906) TEST=Triggered ALT+A and ALT+P from the keyboard which successfully opened the corresponding menu. Review URL: http://codereview.chromium.org/174044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24410 0039d316-1c4b-4281-b951-d872f2087c98
* Remove personalization.h/cc by putting things in final resting placestim@chromium.org2009-08-201-0/+3
| | | | | | Review URL: http://codereview.chromium.org/173085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23833 0039d316-1c4b-4281-b951-d872f2087c98
* This changelist represents the necessary merger of two others:ben@chromium.org2009-08-191-4/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | http://codereview.chromium.org/172082 Create new event_utils.h file for Cocoa-specific event to WindowOpenDisposition cracking. Hook this up to BookmarkBarController so that clicks to bookmark items use the oracle function to determine where the bookmark should be opened. BUG=17301 TEST=Cmd+Click etc on bookmark items should work. See bug and unit test attached. http://codereview.chromium.org/174021 Convert users of the "get last active browser, get selected tab contents, open url" pattern to just call OpenURL on Browser directly. Makes GetOrCreateTabbedBrowser public on Browser, and makes it static so it can be called with a provided profile. BUG=none TEST=Try opening links from the bookmark/history menus on mac, with and without an existing window open, with an active incognito window, etc. The links should all open in the last active non-incognito window, or create a new non-incognito window if none is open. Review URL: http://codereview.chromium.org/173044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23693 0039d316-1c4b-4281-b951-d872f2087c98
* more linux automation porting: SendKeyPressNotifyWhenDoneestade@chromium.org2009-08-181-2/+1
| | | | | | | | | | also change the interface for SimulateOSKeyPress()/SendKeyPress() to take a VKEY_ value (defined in base/keyboard_codes.h) rather than a VK_ value. BUG=19076 Review URL: http://codereview.chromium.org/171079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23611 0039d316-1c4b-4281-b951-d872f2087c98
* Original change by Min-Yu Huang <minyu.huang@gmail.com> intc@google.com2009-08-051-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | http://codereview.chromium.org/160347 This is the very preliminary implementation to support printing on Linux and it has not been finished yet. For each page to be printed, we convert rendering actions on canvas into cairo APIs and generate a PS/PDF file. chrome/chrome.gyp: Include our newly added and renamed files. chrome/browser/browser.h: chrome/browser/browser.cc: Allow the user print the web page by hitting ctrl-p. chrome/browser/gtk/standard_menus.cc: Show "Print" in the menu. chrome/renderer/print_web_view_helper.cc: chrome/renderer/print_web_view_helper.h: chrome/renderer/print_web_view_helper_mac.cc chrome/renderer/print_web_view_helper_win.cc Move the class PrepareFrameAndViewForPrint to the header file and move platform dependent parts to their corresponding files. chrome/renderer/print_web_view_helper_linux.cc: Hard-coded parameters for printing. Only print the first page now. skia/ext/vector_canvas.cc: skia/ext/vector_canvas.h: skia/ext/vector_canvas_linux.cc: skia/ext/vector_canvas_win.cc: Move platform dependent parts to their corresponding files. skia/ext/vector_platform_device.h: skia/ext/vector_platform_device_linux.cc: skia/ext/vector_platform_device_linux.h We translate skia APIs into Cairo APIs here. A PDF file is also created and saved to the disk at this moment for testing purpose (you have to run chrome without the sandbox to save the file). There are still lots of bugs. skia/skia.gyp: Include our newly added files when compiling skia package on Linux. BUG=9847 Review URL: http://codereview.chromium.org/160673 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22522 0039d316-1c4b-4281-b951-d872f2087c98
* mole API - take 2erikkay@chromium.org2009-08-041-0/+7
| | | | | | | | | | originally reviewed / committed as http://codereview.chromium.org/160276 TBR=mpcomplete,phadjan.jr Review URL: http://codereview.chromium.org/159854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22382 0039d316-1c4b-4281-b951-d872f2087c98