summaryrefslogtreecommitdiffstats
path: root/chrome/browser/browser.h
Commit message (Collapse)AuthorAgeFilesLines
* Revert 50752 - Moves Browser::AddTypes to TabStripModel. This patch is primarilysky@chromium.org2010-06-241-2/+18
| | | | | | | | | | | | | | | | | | | | | | | | cleanup before I fix 29933, but has a couple of interesting bits beyond the enum change: . AddTabContents now supports adding pinned. . Nuked duplicate code in Browser::addTabWithURL that invoked wasHidden on the TabContents. This code is already in TabStripModel. . Moved code for setting visibility of tabcontents from TabStripModel::AddTabContents to InsertTabContentsAt. Since everything ends up in InsertTabContentsAt it should be there. . Converted InsertTabContents call in extensionstabmodule to pass in nothing (Rafael said old code was wrong). BUG=29933 TEST=none Review URL: http://codereview.chromium.org/2863021 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/2849025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50776 0039d316-1c4b-4281-b951-d872f2087c98
* Moves Browser::AddTypes to TabStripModel. This patch is primarilysky@chromium.org2010-06-241-18/+2
| | | | | | | | | | | | | | | | | | | | | cleanup before I fix 29933, but has a couple of interesting bits beyond the enum change: . AddTabContents now supports adding pinned. . Nuked duplicate code in Browser::addTabWithURL that invoked wasHidden on the TabContents. This code is already in TabStripModel. . Moved code for setting visibility of tabcontents from TabStripModel::AddTabContents to InsertTabContentsAt. Since everything ends up in InsertTabContentsAt it should be there. . Converted InsertTabContents call in extensionstabmodule to pass in nothing (Rafael said old code was wrong). BUG=29933 TEST=none Review URL: http://codereview.chromium.org/2863021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50752 0039d316-1c4b-4281-b951-d872f2087c98
* Improve toolbar keyboard accessibility.dmazzoni@chromium.org2010-06-181-0/+4
| | | | | | | | | | | | Design doc: https://docs.google.com/a/google.com/Doc?docid=0ATICCjR-gNReY2djdjkyNnNfNzl4ZnpiODQ2Mg&hl=en BUG=40745 BUG=36728 BUG=36222 TEST=New test added to focus_manager_unittest.cc Review URL: http://codereview.chromium.org/2737010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50234 0039d316-1c4b-4281-b951-d872f2087c98
* Enable domui options for use in browser using the switch:csilv@chromium.org2010-06-181-2/+4
| | | | | | | | | | --enable-tabbed-options BUG=none TEST=see description Review URL: http://codereview.chromium.org/2820007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50191 0039d316-1c4b-4281-b951-d872f2087c98
* Further refine the pinned tab navigation algorithm.estade@chromium.org2010-06-141-0/+13
| | | | | | | | | BUG=29281 TEST=included Review URL: http://codereview.chromium.org/2747011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49702 0039d316-1c4b-4281-b951-d872f2087c98
* Detach reload from omnibox, combine with stop, and eliminate go.pkasting@chromium.org2010-06-111-5/+4
| | | | | | | | | | This does the basic surgery on all three OSes without trying to fix up the visual appearance. As a result, things look pretty ugly. My intent is to at least put endcaps on the omnibox in a subsequent patch. BUG=45745,45762,45763 TEST=Reload and stop should be combined; go should be gone. Review URL: http://codereview.chromium.org/2677003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49492 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Fix a bug that caused AutoFill to not fill the field the user isjhawkins@chromium.org2010-06-101-1/+0
| | | | | | | | | | | | typing in. This change also conveniently removes filling the default profile, since this feature has been removed from AutoFill. BUG=46219 TEST=FormManagerTest.FillFormNonEmptyField Review URL: http://codereview.chromium.org/2766005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49454 0039d316-1c4b-4281-b951-d872f2087c98
* Rip out the multiprofile implementation.erg@chromium.org2010-06-101-3/+0
| | | | | | | | | | | Requested by Ben. Never worked on linux or OSX and apparently broken on Windows. Removal of the multiprofile code will make switching out the old AppMenuModel with the new WrenchMenuModel trivial. BUG=27177 TEST=none Review URL: http://codereview.chromium.org/2736001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49440 0039d316-1c4b-4281-b951-d872f2087c98
* Make the reload button respond to middle-clicks like back/forward/home ↵pkasting@chromium.org2010-06-101-7/+6
| | | | | | | | | | | | already do. This also makes GTK and Mac reset the location bar in the correct cases with various types of clicks on back/forward. BUG=none TEST=Middle-click reload. It should reload the page in a new background tab. Review URL: http://codereview.chromium.org/2779011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49350 0039d316-1c4b-4281-b951-d872f2087c98
* Add a context menu item to toggle app tab toolbars.aa@chromium.org2010-06-061-0/+1
| | | | | | Review URL: http://codereview.chromium.org/2690001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49016 0039d316-1c4b-4281-b951-d872f2087c98
* Pressing the search button brings the NTP or close it if it is opened.jcivelli@chromium.org2010-06-011-0/+1
| | | | | | | | | | | | Note: this requires the WebKit https://bugs.webkit.org/show_bug.cgi?id=39752 to work. BUG=3404 TEST=See bug. Review URL: http://codereview.chromium.org/2260004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48658 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Add FRIEND_TEST_ALL_PREFIXES, a FRIEND_TEST replacementphajdan.jr@chromium.org2010-06-011-2/+2
| | | | | | | | | | | that works with all test prefixes (DISABLED, FLAKY, FAILS). TEST=none BUG=44549 Review URL: http://codereview.chromium.org/2439001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48634 0039d316-1c4b-4281-b951-d872f2087c98
* Inform the command updater of the tab restore state.estade@chromium.org2010-05-271-5/+13
| | | | | | | | | BUG=14428 TEST=TabRestoreUITest.* Review URL: http://codereview.chromium.org/2228004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48437 0039d316-1c4b-4281-b951-d872f2087c98
* Implement upgrade notifications.finnur@chromium.org2010-05-261-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we detect that the installed version is newer than the version you are running we show a little throbbing orange dot over the wrench menu. If you open the wrench menu and close it again, the throbbing will stop. However, if you look at the contents of the wrench menu you'll notice that the About box menu item has been removed and in its place is a menu item "Update Chrome Now" with a bright orange icon to draw your attention to it. Clicking on the icon shows a dialog box asking whether you want to restart Chrome. If you do, the browser restarts with your session restored (even if you have Session Restore turned off). Known issues: - Currently this is Windows only. We'll have to port this to Linux and do something differnet for Mac (which doesn't have the wrench menu). - Showing an icon in front of Update Chrome causes the checkbox for the bookmark bar menu to go away. Given that we will soon redesign the menus I'm not going to spend much time trying to fix it. BUG=27941 TEST=Wait for Chrome to be upgraded in the background, an orange dot should appear over the wrench menu and if you select Update Chrome your session should be retained. Review URL: http://codereview.chromium.org/2225003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48318 0039d316-1c4b-4281-b951-d872f2087c98
* Don't let bookmark navigations change content of pinned tab.estade@chromium.org2010-05-251-0/+2
| | | | | | | | | | | This works for the bookmark bar + bookmark menus, but doesn't work for the bookmark manager. Fixing it for the bookmark manager is probably Not Easy. BUG=29281 TEST=manual Review URL: http://codereview.chromium.org/2128021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48203 0039d316-1c4b-4281-b951-d872f2087c98
* Removing the app launcher button in the ChromeOS browser and making the app ↵jcivelli@chromium.org2010-05-141-0/+5
| | | | | | | | | | | | | | launcher pinned to the location bar. BUG=3190 TEST=The app launcher icon on the top-left corner of the browser should be gone. Opening a new tab by pressing the + button or typing CTRL-T should bring the app launcher, it should be located on top of the location bar. Review URL: http://codereview.chromium.org/2060004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47314 0039d316-1c4b-4281-b951-d872f2087c98
* Move the refocus check so that the ntp code path hits it.skerner@chromium.org2010-05-111-0/+7
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2042006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46950 0039d316-1c4b-4281-b951-d872f2087c98
* Rename all occurrences of "app extension" with "extension app" since we were ↵aa@chromium.org2010-05-061-6/+6
| | | | | | | | using both and consistency is nice. Review URL: http://codereview.chromium.org/1924002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46576 0039d316-1c4b-4281-b951-d872f2087c98
* Second attempt at fix for Browser::AddTabWithURL. My first fix fixedsky@chromium.org2010-05-051-2/+18
| | | | | | | | | | | | | | | | the crash, but I don't think it was really what you were after. I believe this is it. I've changed various places in Browser to use CanSupportWindowFeature rather than SupportsWindowFeature. This gives us the old behavior while allowing app windows to have tabs, which I believe is what you wanted. BUG=42914 TEST=see bug Review URL: http://codereview.chromium.org/1932005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46510 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent navigations inside an app tab from clobbering the app tab.aa@chromium.org2010-05-041-2/+5
| | | | | | TBR=erikkay@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46332 0039d316-1c4b-4281-b951-d872f2087c98
* Adds ability for newly inserted tabs to appear before other tabs. I'llsky@chromium.org2010-05-031-0/+14
| | | | | | | | | | | wire this up to vertical tabs shortly. BUG=none TEST=none Review URL: http://codereview.chromium.org/1687020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46224 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at relanding your patch. I believe the problem was the removal of ↵sky@chromium.org2010-04-301-0/+5
| | | | | | | | | | | | the observer in ~TabStrip. By the time TabStrip's destructor was run the model's destructor had already run. I've changed BrowserView to explicitly delete the TabStrip before the browser. See the change between v1 and v2 of this patch in BrowserView for the relevant part. BUG=none TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/1817001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46071 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 45906 - Relands your patch to have an option for enabling vertical ↵sky@chromium.org2010-04-291-5/+0
| | | | | | | | | | | | | | | | | | tabs. I've added the following additions: . made the layout work for opaque_browser_frame. . Only show the menu if the user supplied enableverticaltabs. BUG=none TEST=none Review URL: http://codereview.chromium.org/1708014 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/1795010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45915 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land 45894. http://codereview.chromium.org/1732015aa@chromium.org2010-04-291-0/+15
| | | | | | | | TBR=erikkay@chromium.org Review URL: http://codereview.chromium.org/1705012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45914 0039d316-1c4b-4281-b951-d872f2087c98
* Change report bad webpage to be a web tab instead of native dialogfeldstein@chromium.org2010-04-291-0/+1
| | | | | | | | | | | | Change all 3 implementations of the report broken page dialog to just use one web form. BUG=none TEST=Make sure you can report bad pages on each platform Review URL: http://codereview.chromium.org/1737016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45908 0039d316-1c4b-4281-b951-d872f2087c98
* Relands your patch to have an option for enabling vertical tabs. I'vesky@chromium.org2010-04-291-0/+5
| | | | | | | | | | | | | added the following additions: . made the layout work for opaque_browser_frame. . Only show the menu if the user supplied --enable-vertical-tabs. BUG=none TEST=none Review URL: http://codereview.chromium.org/1708014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45906 0039d316-1c4b-4281-b951-d872f2087c98
* Nukes one of the AddTabWithURL variants.sky@chromium.org2010-04-291-13/+4
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1736022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45902 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 45894 - First cut at window affinity for apps. Window affinity means ↵aa@chromium.org2010-04-291-15/+0
| | | | | | | | | | | | | | | | | that app URLs tend to open in the window associated with them, and nonapp URLs tend to not open in app windows. After playing with this first attempt, I find it is unsatisfying because spreadsheets.google.com doesn't open in the docs app (different origin) and logging out of gmail directs you back to the browser. So I'm going to fix that by adding a browse extent, separately. But I still think this is a worthwhile stepping stone to check in. Review URL: http://codereview.chromium.org/1732015 TBR=aa@chromium.org Review URL: http://codereview.chromium.org/1759013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45898 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at window affinity for apps. Window affinity means that app URLs ↵aa@chromium.org2010-04-291-0/+15
| | | | | | | | | | | | | | tend to open in the window associated with them, and non-app URLs tend to not open in app windows. After playing with this first attempt, I find it is unsatisfying because spreadsheets.google.com doesn't open in the docs app (different origin) and logging out of gmail directs you back to the browser. So I'm going to fix that by adding a browse extent, separately. But I still think this is a worthwhile stepping stone to check in. Review URL: http://codereview.chromium.org/1732015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45894 0039d316-1c4b-4281-b951-d872f2087c98
* fullscreen window app launch containererikkay@chromium.org2010-04-281-7/+20
| | | | | | | | | BUG=42447 TEST=none Review URL: http://codereview.chromium.org/1730013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45862 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r45520. This adds a new browser type: EXTENSION_APP thataa@chromium.org2010-04-261-10/+28
| | | | | | | | | has a larger titlebar and a big icon, along with a tabstrip, but no titlebar. Review URL: http://codereview.chromium.org/1774003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45566 0039d316-1c4b-4281-b951-d872f2087c98
* Sigh. Revert r45520. Breaks ChromeOS.aa@chromium.org2010-04-241-28/+10
| | | | | | TBR=jamesr@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45523 0039d316-1c4b-4281-b951-d872f2087c98
* This adds a new kind of browser window: EXTENSION_APP. EXTENSION_APP windows ↵aa@chromium.org2010-04-241-10/+28
| | | | | | | | have a bigger titlebar with a giant icon and title, and supports tabs. Review URL: http://codereview.chromium.org/1730010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45520 0039d316-1c4b-4281-b951-d872f2087c98
* Don't select all when autofocusing the location bar on New Tab creation. ↵pkasting@chromium.org2010-04-231-2/+2
| | | | | | | | | | Users could already be typing in the omnibox before the load commits (e.g. due to a slow renderer process startup) and this typing would then be selected and overwritten. BUG=41466 TEST=On a very slow machine, typing before a new tab finishes loading should not be selected or cleared once the tab finishes loading. Review URL: http://codereview.chromium.org/1738004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45406 0039d316-1c4b-4281-b951-d872f2087c98
* Rename OnBlockedContentChange to OnContentSettingsChange.bulach@chromium.org2010-04-211-1/+1
| | | | | | | | | | | BUG=None TEST=compiles (Patch from Thiago Farina <thiago.farina@gmail.com> http://codereview.chromium.org/1664003/show) Review URL: http://codereview.chromium.org/1750002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45186 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 45065 - Relanding this. Originally landed as ↵ben@chromium.org2010-04-201-5/+0
| | | | | | | | | | | | | | | | http://codereview.chromium.org/1001003 but reverted due to reliability crashes. Relanding so I can see what those crashes are. Please do not revert without informing me. BUG=none TEST=none Review URL: http://codereview.chromium.org/1655010 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/1715001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45077 0039d316-1c4b-4281-b951-d872f2087c98
* Re-landing this. Originally landed as http://codereview.chromium.org/1001003 ↵ben@chromium.org2010-04-201-0/+5
| | | | | | | | | | | | | but reverted due to reliability crashes. Re-landing so I can see what those crashes are. Please do not revert without informing me. BUG=none TEST=none Review URL: http://codereview.chromium.org/1655010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45065 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Fill the default profile when the AutoFill accelerator combo is ↵jhawkins@chromium.org2010-04-091-0/+1
| | | | | | | | | | | pressed (ctrl-shift-a). BUG=39491 TEST=none Review URL: http://codereview.chromium.org/1521020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44149 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the distributor logo.glen@chromium.org2010-04-011-3/+0
| | | | | | Review URL: http://codereview.chromium.org/1366002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43412 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-311-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility interactive ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43216 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a regression appearing in r41875 where navigating back from an ↵bauerb@chromium.org2010-03-291-0/+3
| | | | | | | | | | | | | interstitial page wouldn't work. Also, factor out a method WindowDispositionShouldOpenNewTab that's used to decide if a given window disposition opens in a new tab or the current tab. BUG=39248 TEST=SSLUITest.TestHTTPSExpiredCertAndGoBackViaButton, SSLUITest.TestHTTPSExpiredCertAndGoBackViaMenu, manual test: Go to www.google.com, then to https://ebay.com to show the HTTPS interstitial, then navigate back using the toolbar. Review URL: http://codereview.chromium.org/1406001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42974 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting this CL to fix the interactive ui test failures.ananta@chromium.org2010-03-261-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert 42498 - Keyboard accessibility for the page and app menus. Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility interactive ui test. Review URL: http://codereview.chromium.org/660323 TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/1428001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42779 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-241-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility interactive ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42498 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42465 - Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-241-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reverting because newly added Test*MenuKeyboardAccess tests fail on some of the Windows buildbots, and possibly a XP Perf regression. Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/1257003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42468 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-241-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42465 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Keyboard accessibility for the page and app menus.", rev 42234 and ↵maruel@chromium.org2010-03-221-1/+0
| | | | | | | | | | 42236. TBR=dmazzoni Review URL: http://codereview.chromium.org/1158004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42239 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-221-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42234 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Keyboard accessibility for the page and app menus."maruel@chromium.org2010-03-221-1/+0
| | | | | | | | | | This reverts commit 42217. TBR=dmzazzoni Review URL: http://codereview.chromium.org/1154003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42218 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-221-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42217 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r42156, r42157, r42160. Allow dynamic switching in and out of ↵thestig@chromium.org2010-03-201-5/+0
| | | | | | | | | | | | sidetabs mode. Reliability bot and Linux CrOS browser_tests all had crashes in ~TabStrip. BUG=none TEST=none Review URL: http://codereview.chromium.org/1141005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42176 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 23:46:57 +0000