| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
reverted on trunk.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/9332013
TBR=csilv@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9330008
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@120610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=111900
TEST=Verify that the 'Manage extensions' contextual menu invokes the extensions page.
Review URL: https://chromiumcodereview.appspot.com/9318019
TBR=csilv@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9325006
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@120233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Forward settings and extensions URLS to the uber page.
- Add command-line switch and about flag for disabling uber page.
- Add support for invoking subpage URLS via the uber page.
BUG=110656
TEST=Exercise settings/extensions URLS with and without flag set.
Review URL: https://chromiumcodereview.appspot.com/9234010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Takes input text and display information about autocomplete suggestions.
There is an abbreviated mode and a detailed mode.
There is a mode to show all intermediate autocomplete updates and a mode
to show only the final suggestions.
This page is listed in chrome://about
This page is not internationalized. Because it's only for debug purposes,
I don't think it needs to be.
There are a lot of ways to improve this. We can display more information.
We can make the URL save-as-able. (Right now if you do save-as, you see
the empty page, not page with any content.) There are lots of things that
can be done, but I think this is good enough as is that it's worth
checking in.
BUG=79883
TEST=
Review URL: http://codereview.chromium.org/8888030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
NetworkActionPredictor database.
Review URL: http://codereview.chromium.org/8969004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
browser_about_handler.cc still exists to rewrite old about: URLs, but the
actual handling now takes place under webui. Thus BINDINGS_POLICY_WEB_UI
is applied to these as well.
BUG=104809
Review URL: http://codereview.chromium.org/8623001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
never set on that object, and is only used/set by chrome, so moved it out to memory_details.h:ProcessMemoryInformation.
BUG=98716
Review URL: http://codereview.chromium.org/8726022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
So we won't have a GpuUIHost with id 0. It starts from 1.
BUG=105044
TEST=GPUCrashTest.Kill on GPU bots
Review URL: http://codereview.chromium.org/8680035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
browser directory). Move everything into the content namespace and make the enums conform to the Content API convention.
BUG=98716
Review URL: http://codereview.chromium.org/8678019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
GPUProcessHostUIShim to hang/crash/clean the gpu process.
BUG=98716
Review URL: http://codereview.chromium.org/8548014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instructed to do so.
Design discussion is available here: http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/967eb64325c24f9c
BUG=None
TEST=base_unittests
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110021
Review URL: http://codereview.chromium.org/8505033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
interface is implemented by the RenderProcessHostImpl class which lives in content\browser\renderer_host\render_process_host_impl.cc/.h. The RenderProcessHostImpl class is a consolidation of the RenderProcessHost and BrowserRenderProcessHost classes.
The RenderProcessHost public interface was created from the now deleted RenderProcessHost class defined in content\browser\renderer_host\render_process_host.h.
Additional methods have been added to the interface to ensure that it works correctly with the MockRenderProcessHost class used by unit tests. I had to implement a number of overrides in the MockRenderProcessHost class to ensure that tests work correctly. This was because of assumptions in the tests that the MockRPH class was a real RPH which it was till now.
Added a TODO for the methods which could potentially be removed from this interface. Will revisit that in a subsequent CL.
BUG=98716
TEST=No change in functionality. Hopefully it all compiles and works.
Review URL: http://codereview.chromium.org/8515027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=10466
Review URL: http://codereview.chromium.org/8574078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=101600, 94925
TEST=none
TBR=mnissler
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110235
Review URL: http://codereview.chromium.org/8573021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It has been subsumed by about:profiler.
I also added a button to about:profiler that matches the behavior of "about:tracking/reset" (nukes the tracked objects). That way there shouldn't be any functionality loss in deleting about:tracking.
BUG=100992
Review URL: http://codereview.chromium.org/8568036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
initializers.
BUG=101600, 94925
TEST=none
TBR=mnissler
Review URL: http://codereview.chromium.org/8573021
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/8568039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=101600, 94925
TEST=none
TBR=mnissler
Review URL: http://codereview.chromium.org/8573021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=64263
TEST=None
R=willchan@chromium.org
Review URL: http://codereview.chromium.org/8552002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allow JSONWriter and JSONValueSerializer to ignore binary values when instructed to do so.
Design discussion is available here: http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/967eb64325c24f9c
BUG=None
TEST=base_unittests
Review URL: http://codereview.chromium.org/8505033
TBR=ericdingle@chromium.org
Review URL: http://codereview.chromium.org/8528051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instructed to do so.
Design discussion is available here: http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/967eb64325c24f9c
BUG=None
TEST=base_unittests
Review URL: http://codereview.chromium.org/8505033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
disabled code for OpenBSD:
- AdjustRendererOOMScore()
- SECCOMP_SANDBOX
BUG=
TEST=compile
Review URL: http://codereview.chromium.org/8341052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=owners
BUG=98716
Review URL: http://codereview.chromium.org/8437002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a reland of accumulated patches including CLs
8414036, 8425010, 8425013, 8424013.
It fully enables tracking of objects, as seen in about:tracking
in teh release build.
The problem this had in its initaial landing centered on
Mac instability in base_unittest. We were encountering crash
on exit of the tests, with a stack dump involving pthreads.
r=rtenneti
BUG=101856
Review URL: http://codereview.chromium.org/8429009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a re-land of:
http://codereview.chromium.org/8391019/
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107793
Original landing had trouble with message_loop_x.h, due to header
include ordering. I pulled out the structure that was really needed by
tracked_objects.h into a new file tracked_info.*. This allows tracked_objects
to inlude this tracked_info, but not have to include the message_loop.h
totality. I also removed a DCHECK that that was triggering on a test,
and added yet one more file (browser_main.cc) where I removed a #ifdef
for TRACKING_ALL_OBJECTS. The changes were minor, and I'm hoping to get
clear perf runs with tihs landing, so I'm going to TBR it and reland
early in the morning.
Comments from original landing:
Support is now controlled by the flag:
--enable-tracking
and the default is always on. To turn it off, use:
--enable-tracking=0
All profiler code is compiled now in release and official
builds (in addition to debug, where it was already active),
but most entry points can be disabled (turned into no-ops)
by a single const bool setting atop tracked_objects.cc (in
case folks want to revert the perf-impact of this change).
Transition to faster Now() service on Windows for the
profiler use only.
The TimeTicks::Now() function on Window uses locking
to get a 64 bit time value. This CL transitions
times used for profiling to more directly use a
32 bit Time interface, which is actually what drives the
64 bit TimeTicks. By using the smaller value, we avoid
the need for locks, or even atomic operations for the most
part in the tracking system. On linux, we just down-sample
the standard TimeTicks to 32 bits for consistency (clean
ability to snapshot asyncronously without atomics...
but I should verify that such is helpful to performance).
I've also put in yet more cleanup and refactoring.
tbr=rtenneti
bug=101856
Review URL: http://codereview.chromium.org/8414036
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/8430004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a re-land of:
http://codereview.chromium.org/8391019/
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107793
Original landing had trouble with message_loop_x.h, due to header
include ordering. I pulled out the structure that was really needed by
tracked_objects.h into a new file tracked_info.*. This allows tracked_objects
to inlude this tracked_info, but not have to include the message_loop.h
totality. I also removed a DCHECK that that was triggering on a test,
and added yet one more file (browser_main.cc) where I removed a #ifdef
for TRACKING_ALL_OBJECTS. The changes were minor, and I'm hoping to get
clear perf runs with tihs landing, so I'm going to TBR it and reland
early in the morning.
Comments from original landing:
Support is now controlled by the flag:
--enable-tracking
and the default is always on. To turn it off, use:
--enable-tracking=0
All profiler code is compiled now in release and official
builds (in addition to debug, where it was already active),
but most entry points can be disabled (turned into no-ops)
by a single const bool setting atop tracked_objects.cc (in
case folks want to revert the perf-impact of this change).
Transition to faster Now() service on Windows for the
profiler use only.
The TimeTicks::Now() function on Window uses locking
to get a 64 bit time value. This CL transitions
times used for profiling to more directly use a
32 bit Time interface, which is actually what drives the
64 bit TimeTicks. By using the smaller value, we avoid
the need for locks, or even atomic operations for the most
part in the tracking system. On linux, we just down-sample
the standard TimeTicks to 32 bits for consistency (clean
ability to snapshot asyncronously without atomics...
but I should verify that such is helpful to performance).
I've also put in yet more cleanup and refactoring.
tbr=rtenneti
bug=101856
Review URL: http://codereview.chromium.org/8414036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Support is now controlled by the flag:
--enable-tracking
and the default is always on. To turn it off, use:
--enable-tracking=0
All profiler code is compiled now in release and official
builds (in addition to debug, where it was already active),
but most entry points can be disabled (turned into no-ops)
by a single const bool setting atop tracked_objects.cc (in
case folks want to revert the perf-impact of this change).
Transition to faster Now() service on Windows for the
profiler use only.
The TimeTicks::Now() function on Window uses locking
to get a 64 bit time value. This CL transitions
times used for profiling to more directly use a
32 bit Time interface, which is actually what drives the
64 bit TimeTicks. By using the smaller value, we avoid
the need for locks, or even atomic operations for the most
part in the tracking system. On linux, we just down-sample
the standard TimeTicks to 32 bits for consistency (clean
ability to snapshot asyncronously without atomics...
but I should verify that such is helpful to performance).
I've also put in yet more cleanup and refactoring.
r=rtenneti
bug=101856
Review URL: http://codereview.chromium.org/8391019
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/8400073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Support is now controlled by the flag:
--enable-tracking
and the default is always on. To turn it off, use:
--enable-tracking=0
All profiler code is compiled now in release and official
builds (in addition to debug, where it was already active),
but most entry points can be disabled (turned into no-ops)
by a single const bool setting atop tracked_objects.cc (in
case folks want to revert the perf-impact of this change).
Transition to faster Now() service on Windows for the
profiler use only.
The TimeTicks::Now() function on Window uses locking
to get a 64 bit time value. This CL transitions
times used for profiling to more directly use a
32 bit Time interface, which is actually what drives the
64 bit TimeTicks. By using the smaller value, we avoid
the need for locks, or even atomic operations for the most
part in the tracking system. On linux, we just down-sample
the standard TimeTicks to 32 bits for consistency (clean
ability to snapshot asyncronously without atomics...
but I should verify that such is helpful to performance).
I've also put in yet more cleanup and refactoring.
r=rtenneti
bug=101856
Review URL: http://codereview.chromium.org/8391019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=jam@chromium.org
BUG=90442
TEST=browser_tests AllUrlsApiTest.Whitelisted Extension passes w/ a component build of content.
Review URL: http://codereview.chromium.org/8402016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only content/ now has the ability to create BrowserThread objects,
with the exception that tests can create the
content::TestBrowserThread subclass, and (temporarily) code in chrome/
can create the DeprecatedBrowserThread subclass.
A follow-up change will make content/ take care of its own thread
creation, remove DeprecatedBrowserThread, and move all state and
non-trivial constructors from BrowserThread down to BrowserThreadImpl.
Also moved BrowserProcessSubThread into content/ namespace. As part
of follow-up cleanup, chrome/ will stop using this class.
BUG=98716
TEST=existing
Review URL: http://codereview.chromium.org/8392042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
across histograms if the ranges in the ranges_ vector
is same. This change saves around 100k of memory in the
browser (around 400 histograms sharing the same ranges_
vector and each ranges_ vector has around 50 elements).
In each renderer process we are sharing ranges_ vector
for around 30 histograms (a savings of 6k of memory).
R=jar
TEST=histogram unit tests.
Review URL: http://codereview.chromium.org/7696017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=64263
TEST=None
R=willchan@chromium.org
Review URL: http://codereview.chromium.org/8256006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves all browser-side synchronous callers to use the asynchronous
PluginService interface.
BUG=17863,95114
TEST=Covered by tests. Plugins still work.
Review URL: http://codereview.chromium.org/8071013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This used to be about:tasks. That was taken over by
the task manager, and merged in several files as though
there was no distinction.
The new URL is about:tracking.
BUG=99121
r=msw
Review URL: http://codereview.chromium.org/8133016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"Discard" a tab by replacing its TabContents and TabContentsWrapper with empty objects, flagging the tab as dicarded in the TabStripModel, and reloading when the user
activates the tab.
BUG=chromium-os:18373
TEST=unit_tests --gtest_filter=TabStripModelTest.* && browser_tests --gtest_filter=OomPriorityManagerTest.*
Review URL: http://codereview.chromium.org/8038002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
By default, all chrome:// pages will get CSP with a whitelist of the exceptions.
BUG=98877
Review URL: http://codereview.chromium.org/8124010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv@chromium.org,ajwong@chromium.org
Review URL: http://codereview.chromium.org/8113025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeOS is now using platform numbers as intended, hence the hacks put in place to extract the platform numbers from the old ChromeOS version numbers are no longer needed. Removed them.
R=davemoore@chromium.org,evan@chromium.org,zelidrag@chromium.org
BUG=chromium-os:20934
TEST=Checked all places where the version shows up. On the latest build it was breaking, it shows correctly again after this fix.
Review URL: http://codereview.chromium.org/8068028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=64263
TEST=None
R=willchan@chromium.org
Review URL: http://codereview.chromium.org/8109004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Work in process on discarding a tab (for low memory conditions on CrOS). Also clean up the strings we use to describe system memory, and eliminate memory as an input for "interestingness" of tabs, since the OOM killer already includes memory as an input.
BUG=none
TEST=Open "about:discards". Click the "Discard Tab Now" link - the tab at the bottom of the list should close.
Review URL: http://codereview.chromium.org/7983042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BrowserProcessImpl
BUG=none
TEST=about:discards still shows a page listing open tabs
Review URL: http://codereview.chromium.org/7973001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(attempt 3).
I split up an API test because it times out (it is doing too much).
The other two modifications to the tests were needed because they were trying to open chrome://extensions in incognito.
In one case, the test just needed any page (so I switched to about:blank) and in the other we are testing for a condition that cannot happen anymorebecause chrome://extensions could be loaded in incognito but chrome://settingsdoesn't allow that -- it shunts the request to the non-incognito profile.
The test was testing that we don't crash in incognito, so I removed that test. Also change the URL for the Extension Settings page fromchrome://settings/extensionSettings -> chrome://settings/extensions.
BUG=87377, 96836
TEST=Well... type in chrome://extensions and notice it redirects.
TEST=chrome://settings/extensions (or chrome://extensions) should take you to the extension settings page, and chrome://settings/extensionSettings should not.
Review URL: http://codereview.chromium.org/7918019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=Launch about:discards to see System Memory Information which includes total, free, buffers, cached, committed, active/inactive anon memory, shared memory
Patch by amruthraj@motorola.com
Review URL: http://codereview.chromium.org/7890032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome://settings/chromeExtensions (attempt 2).
The two modifications to the tests were needed because they were trying to
open chrome://extensions in incognito.
In one case, the test just needed any page (so I switched to about:blank)
and in the other we are testing for a condition that cannot happen anymore
because chrome://extensions could be loaded in incognito but chrome://settings
doesn't allow that -- it shunts the request to the non-incognito profile.
The test was testing that we don't crash in incognito, so I removed that test.
BUG=87377
TEST=Well... type in chrome://extensions and notice it redirects.
Review URL: http://codereview.chromium.org/7885031
TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/7892031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(attempt 2).
The two modifications to the tests were needed because they were trying to
open chrome://extensions in incognito.
In one case, the test just needed any page (so I switched to about:blank)
and in the other we are testing for a condition that cannot happen anymore
because chrome://extensions could be loaded in incognito but chrome://settings
doesn't allow that -- it shunts the request to the non-incognito profile.
The test was testing that we don't crash in incognito, so I removed that test.
BUG=87377
TEST=Well... type in chrome://extensions and notice it redirects.
Review URL: http://codereview.chromium.org/7885031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome://settings/chromeExtensions.
The two modifications to the tests were needed because they were trying to
open chrome://extensions in incognito.
In one case, the test just needed any page (so I switched to about:blank)
and in the other we are testing for a condition that cannot happen anymore
because chrome://extensions could be loaded in incognito but chrome://settings
doesn't allow that -- it shunts the request to the non-incognito profile.
The test was testing that we don't crash in incognito, so I removed that test.
BUG=87377
TEST=Well... type in chrome://extensions and notice it redirects.
Review URL: http://codereview.chromium.org/7888010
TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/7890029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The two modifications to the tests were needed because they were trying to
open chrome://extensions in incognito.
In one case, the test just needed any page (so I switched to about:blank)
and in the other we are testing for a condition that cannot happen anymore
because chrome://extensions could be loaded in incognito but chrome://settings
doesn't allow that -- it shunts the request to the non-incognito profile.
The test was testing that we don't crash in incognito, so I removed that test.
BUG=87377
TEST=Well... type in chrome://extensions and notice it redirects.
Review URL: http://codereview.chromium.org/7888010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=94282
R=tfarina@chromium.org
Review URL: http://codereview.chromium.org/7864014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
left after a refactoring.
This function was moved at revision r57717 to another file but the declaration
was never removed.
See: http://codereview.chromium.org/3225003
TBR=erikkay@chromium.org,tommi@chromium.org
R=rsleevi@chromium.org
Review URL: http://codereview.chromium.org/7780025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Items of note:
- predictor_api is gone. Most functions in predictor_api.cc have moved into the chrome_browser_net::Predictor class or the Profile class.
- The predictor state is cleaned up in the Profile dtor.
- Predictor is owned by the ProfileIOData of the profile.
- InitialObserver class is gone since each profile keeps their own info, the non-OTR don't care if anyone is OTR.
- Predictor is created by the profile and then passed to the ProfileIOData. Then its initialization is finished on the IOThread.
- ConnectInterceptor now subclasses off of UrlRequestJobFactory::Interceptor.
- Updated Profile to create a SimpleShutdownPredictor with limited functionality when in unittests.
BUG=89937,90114
TEST=passes existing
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97446
Review URL: http://codereview.chromium.org/7467012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100555 0039d316-1c4b-4281-b951-d872f2087c98
|