summaryrefslogtreecommitdiffstats
path: root/chrome/browser/browser_accessibility_manager.cc
Commit message (Collapse)AuthorAgeFilesLines
* Use ScopedComPtr instead of CComPtr to reduce a dependency on ATL.jhawkins@chromium.org2009-09-041-1/+2
| | | | | | | | BUG=5027 TEST=none Review URL: http://codereview.chromium.org/201012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25498 0039d316-1c4b-4281-b951-d872f2087c98
* Replace the RenderProcessHost.PID function that returns the OS-generatedbrettw@chromium.org2009-08-311-4/+3
| | | | | | | | | | | | | | | | | | | | process ID with an internally-generated id() function. This allows us the guarantee that the IDs are unique over the entire run of the application. This also cleans up some code associated with managing the PID. The main potentially interesting change is now the PID is set uniquely for every creation of RenderProcessHost. It used to be set cleared if the process went away, and re-set if the process was re-created. The ID generation is in ChildProcesInfo so it is also unique between workers and plugins. I had to change some significant things in resource_dispatcher_host_unittest to take into account this new generation of IDs. BUG=17828 TEST=none Review URL: http://codereview.chromium.org/160203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24899 0039d316-1c4b-4281-b951-d872f2087c98
* Let RenderProcessHost provide a method HasConnection() instead of exposingbrettw@chromium.org2009-06-291-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | channel(). Motivation: Currently, components that are using RenderProcessHost are checking its liveness by null testing on channel(). I'd like to write unittests for those components, but to mock out RenderProcessHost instances, I have to also mock out the instance returned by RenderProcessHost::channel(), but there's no interface class prepared. SyncChannel is directly used in RenderProcessHost. Instead of dependency injection, I can let mock objects return invalid pointer such as 0x1, but its bad test design. Rather than that, I'd like to introduce HasConnection() method and override it to return true. In fact, most of those components are not accessing channel()'s methods directry. They're just checking channel() is null or not, and to issue IPCs, they are calling Send method. So, it's OK to hide channel pointer from users, I think. Original review: http://codereview.chromium.org/147077 Patch by tyoshino@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19493 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes an issue where the MSAA information was not reported back correctly to ↵klink@chromium.org2009-06-051-5/+0
| | | | | | | | the AT, upon the HWND containing the web content first receiving focus. Note that this is not a full fix for the bug below, but one more piece to resolving it.BUG=13291TEST=none Review URL: http://codereview.chromium.org/118206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17778 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "Use a NotificationRegistrar to listen for notifications.""evan@chromium.org2009-05-221-6/+2
| | | | | | This re-applies r16709. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16711 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Use a NotificationRegistrar to listen for notifications."evan@chromium.org2009-05-221-2/+6
| | | | | | This reverts commit r16709 (on pkasting's request). git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16710 0039d316-1c4b-4281-b951-d872f2087c98
* Use a NotificationRegistrar to listen for notifications.pkasting@chromium.org2009-05-221-6/+2
| | | | | | | BUG=2381 Review URL: http://codereview.chromium.org/113744 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16709 0039d316-1c4b-4281-b951-d872f2087c98
* Adds propagation and handling of render-side focus events, for the benefit ↵klink@chromium.org2009-05-201-82/+70
| | | | | | | | of assistive technologies (accessibility). Also cleans up the handling of WM_GETOBJECT in RenderWidgetHostViewWin and WidgetWin, as well as in BrowserAccessibilityManager. Review URL: http://codereview.chromium.org/115374 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16449 0039d316-1c4b-4281-b951-d872f2087c98
* Removes all use of COM and dependencies on Windows-specific classes ↵klink@chromium.org2009-03-201-13/+14
| | | | | | | | (including the use of AccessibleBase and AccessibleDocument) in the glue accessibility implementation.Introduces the GlueAccessibilityObject, which serves as a platform-independent wrapper directly around WebKit's AccessibilityObject (also platoform-independent).Updates naming/comments to reflect the independence of IAccessible both in glue and (where appropriate) in the browser-side accessibility. Review URL: http://codereview.chromium.org/46013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12207 0039d316-1c4b-4281-b951-d872f2087c98
* Finish taking out render_messages.h includes from headers.jam@chromium.org2009-02-051-3/+3
| | | | | | Review URL: http://codereview.chromium.org/20072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9209 0039d316-1c4b-4281-b951-d872f2087c98
* Commiting the changes from my previous cl that are specific to not including ↵jam@chromium.org2009-02-041-1/+2
| | | | | | | | | | render_messages.h/plugin_message.h unless necessary. TBR=mpcomplete Review URL: http://codereview.chromium.org/20059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9189 0039d316-1c4b-4281-b951-d872f2087c98
* Revert my change to get the tree green. Not sure why the tests became ↵jam@chromium.org2009-02-041-2/+1
| | | | | | | | | | flaky. I'll try to check them in again but in smaller chunks tomorrow. TBR=mpcomplete Review URL: http://codereview.chromium.org/21039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9132 0039d316-1c4b-4281-b951-d872f2087c98
* Make it easier/less work/less error-prone to create new IPC channel types ↵jam@chromium.org2009-02-041-1/+2
| | | | | | | | (i.e. renderer/plugin).Instead of having each message file include the internal one several times with different ifdefs, move that logic to ipc_message_macros.h. Also make the message class starting IDs come from an enum to ensure we don't use a value twice. I simplified the logging code a bit so we don't need X_messages.cc files.Clean up places that we were doing manual packing/unpacking. Most of this was in the automation code. I added a few new template functions to make it convenient to read the parameters from a message, and updated the code to use them.I also removed unnecessary includes of render/plugin_messages.h from headers to speed up compiling.I moved the traits of IPC structs beside the struct definition to make it more apparent what's going on, so we avoid people modifying the struct and forgetting to update the traits.Amit: please look at chrome/test/automation/tab_proxy.ccMarc-Antoine: chrome/browser/printing/*Matt: the rest Review URL: http://codereview.chromium.org/20015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9123 0039d316-1c4b-4281-b951-d872f2087c98
* Address a review comment I forgot in my previous patch.brettw@chromium.org2009-02-011-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9023 0039d316-1c4b-4281-b951-d872f2087c98
* Remove most header file dependencies on the notification type list. It isbrettw@chromium.org2009-02-011-2/+4
| | | | | | | | | | | really painful to add more types, since lots of headers include the notification service to derive from the notification observer. This splits that out, so much less of the project should end up including notification_types.h ---Paths modified but not in any changelist: Review URL: http://codereview.chromium.org/19744 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9020 0039d316-1c4b-4281-b951-d872f2087c98
* Move files out of browser and into either renderer_host or tab_contents.brettw@chromium.org2009-01-221-1/+1
| | | | | | | This also fixes a crash in the web contents unit test in a commented-out test and re-enable it. Review URL: http://codereview.chromium.org/18504 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8470 0039d316-1c4b-4281-b951-d872f2087c98
* Move functions required by the rest of the browser from RenderProcessHost to ↵brettw@chromium.org2009-01-161-1/+1
| | | | | | | | an interface and move the implementation to BrowserRenderProcessHost. This will allow me to write render view unit tests without using the actual renderer, but there are no tests yet. Review URL: http://codereview.chromium.org/18132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8188 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 5927 as John has a better fix for this issue.ananta@chromium.org2008-11-271-4/+0
| | | | | | | | | | | | | was as below:- R=jam Bug=4582 Review URL: http://codereview.chromium.org/12402 Review URL: http://codereview.chromium.org/10787 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6094 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a potential memory leak with a message creation.klink@chromium.org2008-11-241-4/+3
| | | | | | Review URL: http://codereview.chromium.org/11579 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5939 0039d316-1c4b-4281-b951-d872f2087c98
* Don't reenter Webkit, while it waits for outgoing sync calls to complete. Thisananta@chromium.org2008-11-241-0/+4
| | | | | | | | | | | | | | fixes bug http://code.google.com/p/chromium/issues/detail?id=4582, which is a crash in the renderer process, which occurs when the renderer receives a sync message requesting accessibility information from the browser, while it waits for the PluginDestroyed sync call to unwind. The ViewMsg_GetAccessibilityInfo has a timeout associated with it, which indicates that it is ok for the call to fail. We now turn off the unblock flag on the sync message which will ensure that it does not reenter Webkit in this scenario. R=jcampan Bug=4582 Review URL: http://codereview.chromium.org/12402 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5927 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a null pointer bug, and adds null checks around potentially dying ↵klink@chromium.org2008-10-111-5/+11
| | | | | | | | process and channel. Review URL: http://codereview.chromium.org/7099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3268 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in BrowserAccessibilityManager destructor (see ↵klink@chromium.org2008-10-091-3/+3
| | | | | | | | | | CPBrowsingContextManager for example of this type of fix). Also fixes small style issue, to be consistent with other Singleton implementations. Review URL: http://codereview.chromium.org/6282 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3078 0039d316-1c4b-4281-b951-d872f2087c98
* Adds MSAA/IAccessible exposure of web content.klink@chromium.org2008-09-301-0/+167
Review URL: http://codereview.chromium.org/4057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2738 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-30 13:03:13 +0000