| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
BrowserTest.ThirtyFourTabs on Mac. (This test takes <3 seconds on my
machine). Suspect low memory conditions (or whatever) on the bot;
this test is not problematic per se.
BUG=http://crbug.com/43862
TEST=bots stay green
Review URL: http://codereview.chromium.org/2900002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ran tests for a few hours on windows without seeing a failure.
BUG=44026
TEST=BrowserAppRefocusTest.*
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51362
Review URL: http://codereview.chromium.org/2870036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ran tests for a few hours on windows without seeing a failure.
BUG=44026
TEST=BrowserAppRefocusTest.*
Review URL: http://codereview.chromium.org/2870036
TBR=skerner@chromium.org
Review URL: http://codereview.chromium.org/2865031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Ran tests for a few hours on windows without seeing a failure.
BUG=44026
TEST=BrowserAppRefocusTest.*
Review URL: http://codereview.chromium.org/2870036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
attempt caused some flakiness on the new tab warm startup test. The
only difference between this and the last is that I'm leaving some
suspcious code in TabStripModel::InsertTabContents and
Browser::AddTabWithURL. I'll try to isolate why those changes caused
flakiness after I land the rest.
Here's the description:
Moves Browser::AddTypes to TabStripModel. This patch is primarily
cleanup before I fix 29933, but has a couple of interesting bits
beyond the enum change:
. AddTabContents now supports adding pinned.
. Converted InsertTabContents call in extensionstabmodule to pass in
nothing (Rafael said old code was wrong).
BUG=29933
TEST=none
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/2866024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cleanup before I fix 29933, but has a couple of interesting bits
beyond the enum change:
. AddTabContents now supports adding pinned.
. Nuked duplicate code in Browser::addTabWithURL that invoked
wasHidden on the TabContents. This code is already in TabStripModel.
. Moved code for setting visibility of tabcontents from
TabStripModel::AddTabContents to InsertTabContentsAt. Since everything
ends up in InsertTabContentsAt it should be there.
. Converted InsertTabContents call in extensionstabmodule to pass in
nothing (Rafael said old code was wrong).
BUG=29933
TEST=none
Review URL: http://codereview.chromium.org/2863021
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/2849025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cleanup before I fix 29933, but has a couple of interesting bits
beyond the enum change:
. AddTabContents now supports adding pinned.
. Nuked duplicate code in Browser::addTabWithURL that invoked
wasHidden on the TabContents. This code is already in TabStripModel.
. Moved code for setting visibility of tabcontents from
TabStripModel::AddTabContents to InsertTabContentsAt. Since everything
ends up in InsertTabContentsAt it should be there.
. Converted InsertTabContents call in extensionstabmodule to pass in
nothing (Rafael said old code was wrong).
BUG=29933
TEST=none
Review URL: http://codereview.chromium.org/2863021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
we may yet try them again shortly.
BUG=46852
TEST=none
Review URL: http://codereview.chromium.org/2833026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29281
TEST=included
Review URL: http://codereview.chromium.org/2747011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
already do.
This also makes GTK and Mac reset the location bar in the correct cases with various types of clicks on back/forward.
BUG=none
TEST=Middle-click reload. It should reload the page in a new background tab.
Review URL: http://codereview.chromium.org/2779011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
as flaky on Windows
BUG=46198
TEST=XP/Vista bots do not turn red due to this test.
TBR=jcivelli
Review URL: http://codereview.chromium.org/2739005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=tonyg
BUG=43061
TEST=none
Review URL: http://codereview.chromium.org/2231001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2212001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
only happening on Mac.
TBR=stuartmorgan
BUG=42865
TEST=BrowserAppRefocusTest.*
Review URL: http://codereview.chromium.org/2185003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
user. This will be used to determine if the tab should be restored on
startup or not.
BUG=4923
TEST=none
Review URL: http://codereview.chromium.org/2087012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* The following tests are no longer flaky:
BrowserTest.PageLanguageDetection (bug 42095)
AppApiTest.AppProcess (bug 42497)
ExtensionApiTest.Infobars (bug 40141)
FindInPageControllerTest.FindMovesWhenObscuring (bug 41124)
SessionRestoreUITest.TwoWindowsCloseOneRestoreOnlyOne (bug 39905)
RenderViewTest.OnHandleKeyboardEvent (no bug)
RenderViewTest.DidFailProvisionalLoadWithErrorForError (no bug)
AutomatedUITestBase.CloseTab (bug 14774)
AutomatedUITestBase.CloseBrowserWindow (bug 14774)
PluginTest.FlashLayoutWhilePainting (bug 21538)
HistoryTester.VerifyHistoryLength1 (bug 39785)
HistoryTester.ConsiderRedirectAfterGestureAsUserInitiated (bug 39785)
HistoryTester.ConsiderSlowRedirectAsUserInitiated (bug 39785)
* The following tests are not flaky, but disabled due to hangs:
BrowserAppRefocusTest.OpenTab (bug 44026)
* The following tests are not flaky, but seem to fail consistently:
ProcessSingletonLinuxTest.NotifyOtherProcessSuccess (bug 30953)
ProcessSingletonLinuxTest.NotifyOtherProcessHostChanged (bug 30953)
BrowserViewsAccessibilityTest.TestChromeWindowAccObj (bug 44486)
BUG=42095, 44026, 42497, 40141, 41124, 30953, 39905, 14774, 21538, 39785, 44486
TEST=this touches a lot of tests
Review URL: http://codereview.chromium.org/2128009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
on the past 2 days.
BUG=44026
TBR=huanr
Review URL: http://codereview.chromium.org/2012015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2042006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=bauerb
BUG=43862
Review URL: http://codereview.chromium.org/2023007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2027005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, add a comment to the previously disabled ExtensionApiJsonValidityTest.WithV8 test.
TBR=phajdan.jr
BUG=43862
TEST=Chromium Mac going green.
Review URL: http://codereview.chromium.org/2057005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
out.
BUG=43434
TEST=Verify the splitted tests no longer flakily times out on try bots and build bots.
Review URL: http://codereview.chromium.org/2040003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=xiyuan
TEST=none
BUG=43434
Review URL: http://codereview.chromium.org/2035005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
using both and consistency is nice.
Review URL: http://codereview.chromium.org/1924002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
invoked using --app-id=...
BUG=none
TEST=BrowserAppRefocusTest.*
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46208
Review URL: http://codereview.chromium.org/1693006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AutocompleteEditViewTest.EnterToSearch (bug 31732)
BrowserTest.SingleBeforeUnloadAfterWindowClose (bug 27039)
FindInPageControllerTest.PreferPreviousSearch (bug 32312)
SessionRestoreUITest.DontRestoreWhileIncognito (bug 39490)
SessionRestoreUITest.ShareProcessesOnRestore (bug 40181)
TabRestoreUITest.RestoreToDifferentWindow (bug 14132, the other test is still flaky)
TEST=no longer flaky
BUG=31732, 27039, 32312, 39490, 40181, 14132
Review URL: http://codereview.chromium.org/1697021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tab page or invoked using appid=...
Reverting due to massive buildbot failure.
BUG=none
TEST=BrowserAppRefocusTest.*
Review URL: http://codereview.chromium.org/1693006
TBR=skerner@chromium.org
Review URL: http://codereview.chromium.org/1836002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
investigated.
Revert this along with the initial change (r46208).
TBR=erikkay
BUG=43061
TEST=BrowserAppRefocusTest.*
Review URL: http://codereview.chromium.org/1840001
TBR=skerner@chromium.org
Review URL: http://codereview.chromium.org/1842001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=erikkay
BUG=43061
TEST=BrowserAppRefocusTest.*
Review URL: http://codereview.chromium.org/1840001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
invoked using --app-id=...
BUG=none
TEST=BrowserAppRefocusTest.*
Review URL: http://codereview.chromium.org/1693006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1736022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
favicons when changed via Javascript.
BUG=none
TEST=BrowserTest.FaviconChange
Review URL: http://codereview.chromium.org/1747015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=jcivelli
TEST=still flaky
BUG=42095
Review URL: http://codereview.chromium.org/1686001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BrowserTest.PageLanguageDetection.
BUG=40962
TEST=The test should not be flaky anymore.
Review URL: http://codereview.chromium.org/1642002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jcivelli
TEST=still crashy
BUG=40962
Review URL: http://codereview.chromium.org/1591033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[original revert broke compile; will disable tests in another CL instead]
use more ui_test_utils functions to simplify the code
expose more consistent and powerful utilities in ui_test_utils
minor style improvements
move some tests from DISABLED to FLAKY so we don't lose coverage
remove redundant timeouts
check more return values
TEST=browser_tests
BUG=none
Review URL: http://codereview.chromium.org/1571002
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/1520026
TBR=viettrungluu@chromium.org, phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/1518020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
use more ui_test_utils functions to simplify the code
expose more consistent and powerful utilities in ui_test_utils
minor style improvements
move some tests from DISABLED to FLAKY so we don't lose coverage
remove redundant timeouts
check more return values
TEST=browser_tests
BUG=none
Review URL: http://codereview.chromium.org/1571002
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/1520026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- use more ui_test_utils functions to simplify the code
- expose more consistent and powerful utilities in ui_test_utils
- minor style improvements
- move some tests from DISABLED to FLAKY so we don't lose coverage
- remove redundant timeouts
- check more return values
TEST=browser_tests
BUG=none
Review URL: http://codereview.chromium.org/1571002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
crashy.
BUG=40150
TEST=No crashy.
Review URL: http://codereview.chromium.org/1545015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
functions to use FilePaths.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1567009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
already running would end up creating an extra tab.
BUG=11594
TEST=open chrome with a single tabbed browser, turn on session
restore, navigate to a page with a popup, close the tabbed browser,
create a new window ala control-n (or double click on the desktop),
and make the restored window doesn't end upw
Review URL: http://codereview.chromium.org/1371002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=make tree greener
BUG=38522
Review URL: http://codereview.chromium.org/1216003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38522
TBR=maruel
Review URL: http://codereview.chromium.org/1081015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1073005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
last session, which means my test doesn't test what I want it to. I
could make the test exercise the paths I want on chromeos by changing
what to do on startup, but it didn't seem worth it given the default.
BUG=NONE
TBR=erikkay@chromium.org
Review URL: http://codereview.chromium.org/1079002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
bug unrelated to my cl.
TBR=erikkay@chromium.org
BUG=38522
Review URL: http://codereview.chromium.org/1118003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
restore.
BUG=23613
TEST=turn off session restore, pin a tab, restart chrome and make sure
you get back the pinned tab.
Review URL: http://codereview.chromium.org/1026005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=29424
TEST=Disabling JavascriptAlertActivatesTab.
TBR=pamg
Review URL: http://codereview.chromium.org/866004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27039
TEST=none
TBR=phajdan.jr
Review URL: http://codereview.chromium.org/778006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41199 0039d316-1c4b-4281-b951-d872f2087c98
|