summaryrefslogtreecommitdiffstats
path: root/chrome/browser/browser_commands_unittest.cc
Commit message (Collapse)AuthorAgeFilesLines
* Switched variable naming style from camelCase to hacker_style in ↵a.sarkar.arun2015-02-271-20/+20
| | | | | | | | | | | BrowserCommandsTests(browser_command_unittests). This is a followup CL to https://codereview.chromium.org/678343002/. BUG=none Review URL: https://codereview.chromium.org/960423004 Cr-Commit-Position: refs/heads/master@{#318470}
* Default zoom was never read from chrome://settingsa.sarkar.arun2015-02-261-23/+53
| | | | | | | | | | | | | | | The fix basically includes reading default zoom percent of a tab from a helper function in zoom_controller. BUG=427440 TESTs = Go to chrome://settings Expand to Webcontents under Advanced Settings Change the default Zoom percentage Expected result: All the open tabs would be changed to that particular zoom value and the "Actual Size" under View menu would be disabled. Review URL: https://codereview.chromium.org/678343002 Cr-Commit-Position: refs/heads/master@{#318191}
* Refactor to move chrome_page_zoom functions to components/ui/zoom.wjmaclean2015-01-151-6/+6
| | | | | | | | | | | | This refactor will allow non-chrome builds to access the functionality formerly provided by chrome_page_zoom. BUG=none TBR=sky@chromium.org Review URL: https://codereview.chromium.org/847703003 Cr-Commit-Position: refs/heads/master@{#311719}
* bookmarks: Move BookmarkModel into 'bookmarks' namespace.tfarina2015-01-121-0/+1
| | | | | | | | | | | BUG=370433 TEST=unit_tests, components_unittests R=sky@chromium.org TBR=joaodasilva@chromium.org (for components/policy) Review URL: https://codereview.chromium.org/820603005 Cr-Commit-Position: refs/heads/master@{#311074}
* Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added ↵deepak.m12014-12-151-1/+1
| | | | | | | | | | | | | | | | | extensions. Presently when we selects bookmark icon then it checks weather Ctrl+D has been set as overridden command for any extension if yes, then it executes extension popup for that extension. Changes done so that when bookmarking a page is done via bookmark icon by mouse click then bookmark overridden commands should not be considered as overriding happened for keyboard shortcuts. As user have overridden shortcut key for bookmark to launch extension pop up, not the bookmarking via selection of bookmark icon by mouse event. TBR=sky@chromium.org BUG=426791 Review URL: https://codereview.chromium.org/765043002 Cr-Commit-Position: refs/heads/master@{#308312}
* Move ZoomObserver, ZoomController and ZoomEventManager to components/.wjmaclean2014-12-091-1/+2
| | | | | | | | | | | | | | | | | | | | This CL moves the three classes into components, namespace ui_zoom, and moves their associated source files into components/ui/zoom so that they can be used in non-chrome configurations. BUG=none TBR=willchan@chromium.org chrome/browser/profiles TBR=fsamuel@chromium.org */web_view/* TBR=estade@chromium.org chrome/browser/ui/autofill TBR=pkasting@chromium.org chrome/browser/ui not covered above TBR=dgozman@chromium.org chrome/browser/devtools TBR=rsesek@chromium.org chrome/browser/browser_commands_unittest.cc TBR=sky@chromium.org chrome/browser/renderer_preferences_util.cc Review URL: https://codereview.chromium.org/769593003 Cr-Commit-Position: refs/heads/master@{#307470}
* bookmarks: Move bookmark_test_helpers.h into 'bookmarks' namespace.tfarina2014-10-231-1/+1
| | | | | | | | | | | BUG=370433 TEST=components_unittests, unit_tests R=sky@chromium.org TBR=joaodasilva@chromium.org Review URL: https://codereview.chromium.org/651753003 Cr-Commit-Position: refs/heads/master@{#300911}
* Move PageTransition from //content/public/common to //ui/baseSylvain Defresne2014-09-191-3/+3
| | | | | | | | | | | | | Move PageTransition enumeration from //content/public/common to //ui/base so that it can be used by iOS and layered components that are used on iOS. BUG=372373 R=avi@chromium.org, ben@chromium.org, wfh@chromium.org TBR=ben, nasko Review URL: https://codereview.chromium.org/562603002 Cr-Commit-Position: refs/heads/master@{#295686}
* Update the Zoom NSMenuItems (Zoom-In/Zoom-out/Actual-Size) when the zoom ↵a.sarkar.arun@gmail.com2014-08-041-0/+112
| | | | | | | | | | | | | | | | state changes. The fix basically works in the following way. Look at Zoom Observer overridden methods which is implemented in Browser.cc. When the zoom state changes send relevant messages to Command_Updater to enable / disable Zoom Menu Items. BUG=32919 TEST=Open a NTP , load a url. Zoom-In max and the Zoom-In menu item should be disabled likewise zoom-out max and the zoom-out menu should be disabled. When a NTP or a page is loaded by default the zoom scale is 100% hence the Actual size menu item should be disabled. R=ben@chromium.org Review URL: https://codereview.chromium.org/310913002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287401 0039d316-1c4b-4281-b951-d872f2087c98
* Move about://-related constants from //content to //urlblundell@chromium.org2014-06-101-1/+1
| | | | | | | | | | | kAboutScheme and kAboutBlankURL are used in code shared by iOS, and are general enough to live in //url instead of //content. TBR=yoz,benm Review URL: https://codereview.chromium.org/325443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275988 0039d316-1c4b-4281-b951-d872f2087c98
* Move bookmarks/core/... to bookmarks/...naiem.shaik@gmail.com2014-05-201-2/+2
| | | | | | | | | | | | | | Bookmarks is not a layered component, so there is no need for the two level deep hierarchy, switch code from components/bookmarks/core/... to components/bookmarks/... BUG=370434 TEST=components_unittests --gtest_filter=Bookmark* R=blundell@chromium.org,sdefresne@chromium.org TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/284893003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271675 0039d316-1c4b-4281-b951-d872f2087c98
* Move bookmarks' test support file to the bookmarks componentsdefresne@chromium.org2014-05-051-1/+1
| | | | | | | | | | | | Those files are used by a lot of tests and do not depends on chrome/ or content/ so they can be moved to the component in a new library that will be used by the test (eventually components_unittests). BUG=367839 Review URL: https://codereview.chromium.org/268673004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268282 0039d316-1c4b-4281-b951-d872f2087c98
* Move bookmarks' production code to components/bookmarkssdefresne@chromium.org2014-04-301-1/+1
| | | | | | | | | | | | | Move all the production code of bookmarks to the components folder as they form a cyclic graph and moving them separately would be more work for little gain. BUG=359565, 360637, 360640, 360643, 364881 TBR=willchan Review URL: https://codereview.chromium.org/253753005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267046 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Get rid of ui_test_utils.h entry from the exception list.tfarina@chromium.org2013-09-111-2/+2
| | | | | | | | | | | | | | In order to do this we move the WaitForBookmarkModelToLoad() function into a new helper file called bookmark_test_helpers.h. Eventually all the functions from bookmark_model_test_utils.h could be moved over there too. BUG=144783 TEST=unit_tests, browser_tests, interactive_ui_tests R=sky@chromium.org Review URL: https://codereview.chromium.org/23903027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222644 0039d316-1c4b-4281-b951-d872f2087c98
* Rename GetActiveURL to GetVisibleURL.nasko@chromium.org2013-07-221-4/+4
| | | | | | | | | | | GetVisibleURL is a more decriptive name and less ambiguous. Active is an overloaded term and doesn't reflect the fact that the visible URL is in fact not the current security context. BUG=237908 R=creis Review URL: https://chromiumcodereview.appspot.com/18546005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212960 0039d316-1c4b-4281-b951-d872f2087c98
* Move BrowserCommandsTest to new WebContents URL APInasko@chromium.org2013-07-181-10/+15
| | | | | | | | | | Converting BrowserCommandsTest to use GetLastCommittedURL instead of GetURL. BUG=237908 Review URL: https://chromiumcodereview.appspot.com/18569005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212387 0039d316-1c4b-4281-b951-d872f2087c98
* content: Move two more url constants into content namespace.tfarina@chromium.org2013-05-151-1/+1
| | | | | | | | TBR=joi@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/14698018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200165 0039d316-1c4b-4281-b951-d872f2087c98
* Explicitly construct/destruct UserManager and dependencies in testsbartfab@chromium.org2013-04-241-4/+0
| | | | | | | | | | | | | | | | | | | | | | | The ScopedTestUserManager initializes and subsequently tears down the UserManager singleton only if it has not been initialized already. This allows ScopedTestUserManagers to be nested but also means that it is never clear which ScopedTestUserManager actually did end up initializing the singleton. The same goes for ScopedTestCrosSettings. This CL makes the initialization and teardown explicit. The helper classes now explicitly manage the initialization and teardown of their respective singletons and cannot be nested anymore. BUG=None For tests that need to instantiate a UserManager: TBR=sky,rkc,aa,thestig,asvitkine,davemoore,kinuko,pkotwicz,davemoore,akalin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195811 Review URL: https://chromiumcodereview.appspot.com/14192040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195951 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 195811 "Explicitly construct/destruct UserManager and dep..."kalman@chromium.org2013-04-231-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | > Explicitly construct/destruct UserManager and dependencies in tests > > The ScopedTestUserManager initializes and subsequently tears down the > UserManager singleton only if it has not been initialized already. This > allows ScopedTestUserManagers to be nested but also means that it is > never clear which ScopedTestUserManager actually did end up initializing > the singleton. The same goes for ScopedTestCrosSettings. > > This CL makes the initialization and teardown explicit. The helper classes > now explicitly manage the initialization and teardown of their respective > singletons and cannot be nested anymore. > > BUG=None > > For tests that need to instantiate a UserManager: > TBR=sky,rkc,aa,thestig,asvitkine,davemoore,kinuko,pkotwicz,davemoore,akalin > > Review URL: https://codereview.chromium.org/14192040 TBR=bartfab@google.com Review URL: https://codereview.chromium.org/14436007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195821 0039d316-1c4b-4281-b951-d872f2087c98
* Explicitly construct/destruct UserManager and dependencies in testsbartfab@google.com2013-04-231-4/+0
| | | | | | | | | | | | | | | | | | | | | The ScopedTestUserManager initializes and subsequently tears down the UserManager singleton only if it has not been initialized already. This allows ScopedTestUserManagers to be nested but also means that it is never clear which ScopedTestUserManager actually did end up initializing the singleton. The same goes for ScopedTestCrosSettings. This CL makes the initialization and teardown explicit. The helper classes now explicitly manage the initialization and teardown of their respective singletons and cannot be nested anymore. BUG=None For tests that need to instantiate a UserManager: TBR=sky,rkc,aa,thestig,asvitkine,davemoore,kinuko,pkotwicz,davemoore,akalin Review URL: https://codereview.chromium.org/14192040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195811 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Get rid of TestingProfile::BlockUntilBookmarkModelLoaded().tfarina@chromium.org2013-03-251-3/+5
| | | | | | | | | | | | | | BlockUntilBookmarkModelLoaded() is just a tiny wrapper around WaitForBookmarkModelToLoad(), so it doesn't add much per se, and we ended up calling BookmarkModelFactory::GetForProfile() twice, either before or after the call to BlockUntilBookmarkModelLoaded(). BUG=144783 R=sky@chromium.org Review URL: https://codereview.chromium.org/12929016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190511 0039d316-1c4b-4281-b951-d872f2087c98
* Replace most BrowserList::empty() and BrowserList::size() calls by ↵gab@chromium.org2013-02-131-5/+5
| | | | | | | | | | | | | | | multi-desktop aware calls. Introducing chrome::GetTotalBrowserCount() in browser_finder.cc which counts browsers across all desktops and profiles (this is the desired count for most BrowserList::empty() and BrowserList::size() consumers). Otherwise calling a specific BrowserListImpl's size() when appropriate. BUG=129187 Review URL: https://chromiumcodereview.appspot.com/12212120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182178 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove more unneeded browser_thread.h includes.thestig@chromium.org2013-01-041-1/+0
| | | | | | Review URL: https://chromiumcodereview.appspot.com/11740018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175086 0039d316-1c4b-4281-b951-d872f2087c98
* Remove tabstrip wrappers in browser_tabstrip.avi@chromium.org2012-12-031-28/+31
| | | | | | | | | | BUG=none TEST=no functional change Review URL: https://chromiumcodereview.appspot.com/11419276 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170783 0039d316-1c4b-4281-b951-d872f2087c98
* Use the last committed entry for View Source.creis@chromium.org2012-08-141-6/+51
| | | | | | | | | | BUG=138140 TEST=Ctrl+U while a page load is in progress. Review URL: https://chromiumcodereview.appspot.com/10829308 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151512 0039d316-1c4b-4281-b951-d872f2087c98
* Removing instances of profile_->GetBookmarkModel() as part of converting ↵rlp@chromium.org2012-08-011-1/+3
| | | | | | | | | | | | | BookmarkModel to a PKS. BUG=112525 TEST=unittests, manual TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10834099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149532 0039d316-1c4b-4281-b951-d872f2087c98
* Move tab functions off Browser into browser_tabstrip and browser_tabrestore.ben@chromium.org2012-06-291-11/+12
| | | | | | | | http://crbug.com/133576 TEST=none Review URL: https://chromiumcodereview.appspot.com/10702029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145015 0039d316-1c4b-4281-b951-d872f2087c98
* Moves command handling from Browser to a new object, BrowserCommandController.ben@chromium.org2012-06-271-12/+9
| | | | | | | | | | | | | | Notes: . BrowserCommandController now owns the CommandUpdater. . CommandHandler's ExecuteCommand API was massaged a little so that ExecuteCommand/IsCommandEnabled/SupportsCommand methods are always called on it, rather than the wrapping controller. . The creation of BCC was performed as a svn cp so that history for the various Exec methods could be easily carried forward. . Various "CanFoo" methods were extracted from the UpdateFooState() methods and moved to CanFoo(const Browser* browser) in browser_commands. http://crbug.com/133576 TEST=none Review URL: https://chromiumcodereview.appspot.com/10677009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144597 0039d316-1c4b-4281-b951-d872f2087c98
* Move browser commands into a separate file.ben@chromium.org2012-06-251-4/+5
| | | | | | | | http://crbug.com/133576 TEST=none Review URL: https://chromiumcodereview.appspot.com/10657016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144028 0039d316-1c4b-4281-b951-d872f2087c98
* TabContentsWrapper -> TabContents, part 33.avi@chromium.org2012-06-111-3/+3
| | | | | | | | | | | | Loose files in browser/. BUG=131026 TEST=no change Review URL: https://chromiumcodereview.appspot.com/10538073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141465 0039d316-1c4b-4281-b951-d872f2087c98
* Move test_browser_thread.h from content\test to content\public\test. This ↵jam@chromium.org2012-06-041-1/+1
| | | | | | | | | | way we can enforce that internal content headers don't leak to embedders. BUG=98716 TBR=phajdan.jr Review URL: https://chromiumcodereview.appspot.com/10500016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140254 0039d316-1c4b-4281-b951-d872f2087c98
* Move a lot of ChromeOS stuff out of Browser and onto various Ash-related ↵ben@chromium.org2012-04-201-35/+0
| | | | | | | | | | | helpers. BUG=none TEST=none TBR=davemoore Review URL: https://chromiumcodereview.appspot.com/10035061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133138 0039d316-1c4b-4281-b951-d872f2087c98
* Made a ScopedMockUserManagerEnabler to simplify UserManager mocking life-cycle.pastarmovj@chromium.org2012-03-261-5/+2
| | | | | | | | | BUG=none TEST=unit_tests,browser_tests Review URL: https://chromiumcodereview.appspot.com/9826010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128870 0039d316-1c4b-4281-b951-d872f2087c98
* Fix UserManager to not leak the mock managers created for unit tests.pastarmovj@chromium.org2012-03-211-1/+17
| | | | | | | | | | | | | | All tests share the singletons and if mocks are leaked state will be leaked and possibly corrupted between the tests. This CL tries to force every test that needs a particular UserManager state to use its own mock object and set it in the wanted state. BUG=116996 TEST=unit_tests Review URL: https://chromiumcodereview.appspot.com/9705016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127946 0039d316-1c4b-4281-b951-d872f2087c98
* Replace Browser::GetTabContentsAt with GetWebContentsAt and update all callers.jam@chromium.org2012-01-041-6/+7
| | | | | | | | BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/9085006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116322 0039d316-1c4b-4281-b951-d872f2087c98
* Convert WebContents to return a content::NavigationController instead of the ↵jam@chromium.org2012-01-041-2/+2
| | | | | | | | | | implementation. Update all the headers in chrome to use the interface only. In a subsequent cl, I'll rename the implementation to NavigationControllerImpl and also get rid of content::NavigationController everywhere. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/8983010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116244 0039d316-1c4b-4281-b951-d872f2087c98
* Replace most of Browser::GetSelectedTabContents calls into ↵jam@chromium.org2012-01-031-6/+6
| | | | | | | | | | | | Browser::GetSelectedWebContents. I've converted the easy ones, I'll do the ones with more dependencies in a separate change to keep things trivial to review. I considered taking out GetSelectedTabContents altogether and having people just use GetSelectedTabContentsWrapper()->web_contents() per the existing comment in browser.h, but there are a lot of callers and it seemed too long to type. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/9015022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116122 0039d316-1c4b-4281-b951-d872f2087c98
* Convert unix_hacker functions on NavigationController that are used by ↵jam@chromium.org2011-12-291-1/+1
| | | | | | | | | | Chrome to CamelCase. This is in preparation for adding an interface around NavigationController. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/8989070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115937 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the remaining usages of NavigationEntry in chrome by converting a few ↵jam@chromium.org2011-12-281-1/+1
| | | | | | | | | | more NavigationController methods to return the interface. In a followup, I'll rename NavigationEntry to NavigationEntryImpl, then create an interface for NavigationController. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/9004045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115900 0039d316-1c4b-4281-b951-d872f2087c98
* Move the PageNavigator interface and GlobalRequestID struct to ↵jam@chromium.org2011-12-281-1/+5
| | | | | | | | | | content\public and put them in the content namespace. Make PageNavigator use WebContents instead of TabContents. While I'm touching all the callers, I've removed the deprecated PageNavigator function and converted users to the new one. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/8991012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115858 0039d316-1c4b-4281-b951-d872f2087c98
* Create a Content API around NavigationEntry that's in ↵jam@chromium.org2011-12-251-3/+3
| | | | | | | | | | content/public/browser. NavigationEntry will be renamed to NavigationEntryImpl in a later change. It now derives from content::NavigationEntry. Most of this change is changing unix_hacker functions to CamelCase and updating callers. BUG=98716 TBR=brettw Review URL: http://codereview.chromium.org/9007043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115766 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 115346. The change didn't break anything, the test was faulty. Will ↵jam@chromium.org2011-12-211-12/+12
| | | | | | | | | | | | | | | | | | | | disable in a followup. - Revert r115276, it broke PanelDownloadTest.Download in interactive_ui_tests on win,linux,mac. Original change: Rename TabContents::controller() to GetController and put it into the WebContents namespace. BUG=98716 TBR=dpranke Review URL: http://codereview.chromium.org/8956050 TBR=jam Review URL: http://codereview.chromium.org/9018016 TBR=thakis@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115428 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r115276, it broke PanelDownloadTest.Download in interactive_ui_teststhakis@chromium.org2011-12-211-12/+12
| | | | | | | | | | | | | | | | on win,linux,mac. Original change: Rename TabContents::controller() to GetController and put it into the WebContents namespace. BUG=98716 TBR=dpranke Review URL: http://codereview.chromium.org/8956050 TBR=jam Review URL: http://codereview.chromium.org/9018016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115346 0039d316-1c4b-4281-b951-d872f2087c98
* Rename TabContents::controller() to GetController and put it into the ↵jam@chromium.org2011-12-211-12/+12
| | | | | | | | | | WebContents namespace. BUG=98716 TBR=dpranke Review URL: http://codereview.chromium.org/8956050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115276 0039d316-1c4b-4281-b951-d872f2087c98
* Split BrowserThread into public API and private implementation, step 1.joi@chromium.org2011-10-281-1/+1
| | | | | | | | | | | | | | | | | | | | | Only content/ now has the ability to create BrowserThread objects, with the exception that tests can create the content::TestBrowserThread subclass, and (temporarily) code in chrome/ can create the DeprecatedBrowserThread subclass. A follow-up change will make content/ take care of its own thread creation, remove DeprecatedBrowserThread, and move all state and non-trivial constructors from BrowserThread down to BrowserThreadImpl. Also moved BrowserProcessSubThread into content/ namespace. As part of follow-up cleanup, chrome/ will stop using this class. BUG=98716 TEST=existing Review URL: http://codereview.chromium.org/8392042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107718 0039d316-1c4b-4281-b951-d872f2087c98
* Move PageTransition into content namespace. While I'm touching all these ↵jam@chromium.org2011-10-131-1/+1
| | | | | | | | | files, I've also updated it to use the enum naming convention in the Content API. BUG=98716 Review URL: http://codereview.chromium.org/8253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105254 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Make Search key never close the NTP.derat@chromium.org2011-10-031-0/+27
| | | | | | | | | | | | | | | | | | | The Search key had complicated behavior: pressing it would open the new tab page and focus its omnibox... unless the NTP was already open, in which case the key would close it. This was intended to provide an escape hatch for accidental presses, but it prevents users from just mashing the key and typing a URL whenever they want to load a page. This change gets rid of the closing behavior -- if the NTP is already open, we just focus the omnibox. BUG=chromium-os:8742 TEST=added a simple unit test (which doesn't cover the focusing change); also did manual testing: opened NTP, unfocused omnibox, and checked that Search key re-focuses it Review URL: http://codereview.chromium.org/8093012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103793 0039d316-1c4b-4281-b951-d872f2087c98
* Move more files from chrome/test to chrome/test/base, part #4phajdan.jr@chromium.org2011-08-011-2/+2
| | | | | | | BUG=90905 Review URL: http://codereview.chromium.org/7544021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94963 0039d316-1c4b-4281-b951-d872f2087c98
* More TabStripModel renaming:sky@chromium.org2011-04-181-3/+3
| | | | | | | | | | | | | | | | AddTabTypes::ADD_SELECTED -> ADD_ACTIVE SelectTabContentsAt -> ActivateTabAt BUG=none TEST=none R=ben@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/6840007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81947 0039d316-1c4b-4281-b951-d872f2087c98
* Renames TabStripModel and Browser's selected_index tosky@chromium.org2011-04-121-10/+10
| | | | | | | | | | | | | active_index. I plan on renaming more, but wanted to start with this one. BUG=none TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6823064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81268 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-06-08 20:27:25 +0000