summaryrefslogtreecommitdiffstats
path: root/chrome/browser/browser_encoding_browsertest.cc
Commit message (Collapse)AuthorAgeFilesLines
* Roll src/third_party/icu 8ac906f:d8b2a9d7 (svn 292317:292476)jshin2014-10-221-14/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Summary of changes available at: https://chromium.googlesource.com/chromium/deps/icu52/+log/8ac906f..6ea11f3 https://chromium.googlesource.com/chromium/deps/icu52/+log/6ea11f3..d8b2a9d In addition, change the encoding menu, encoding preferences, and browser tests accordingly; 1. unify iso-8859-1 with windows-1252 in the menu (the name to use is windows-1252) 2. update the encoding preference (default encoding, etc) for various locales. 3. update the test result/expectation. Re-enable tests disabled in https://codereview.chromium.org/643993004/ TBR=jsbell@chromium.org BUG=412053 TEST=browser_tests BrowserEncodingTest.TestEncodingAutoDetect BrowserEncodingTest.TestOverrideEncoding EncodingAliases/BrowserEncodingTest.TestEncodingAliasMapping SavePageBrowserTest.FileNameFromPageTitle SavePageBrowserTest.SaveCompleteHTML PrefsTabHelperBrowserTest.WebPrefs TEST=net_unittest --gtest_filter="*ilenameUtil*" TEST=base_unittests --gtest_filter="*Conv*" TEST=Blink: fast/encoding/* TEST=http://www.w3.org/International/tests/repository/encoding/indexes/results-indexes TEST=http://www.w3.org/International/tests/repository/encoding/indexes/results-aliases TEST=http://www.w3.org/International/tests/repository/run?manifest=encoding/indexes&test=windows-1253_test TEST=http://www.w3.org/International/tests/repository/run?manifest=encoding/indexes&test=windows-874_test Review URL: https://codereview.chromium.org/649413002 Cr-Commit-Position: refs/heads/master@{#300643}
* Standardize usage of virtual/override/final in chrome/browser/Daniel Cheng2014-10-211-5/+5
| | | | | | | | | BUG=417463 TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/648653003 Cr-Commit-Position: refs/heads/master@{#300440}
* Prepare for ISO-8859-1 to windows-1252 switchjshin2014-10-171-4/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The following Blink CL will make 'windows-1252' the canonical name for 'ISO-8859-1', 'US-ASCII' and 'windows-1252'. All three will be treated synonymously per the WHATWG Encoding spec. https://codereview.chromium.org/655083002/ We have some test results with 'ISO-8859-1'. Change them to use windows-1252 and disable them before landing the above Blink CL. For PrefsTabHelperBrowserTest.WebPrefs, I made the test more robust by setting 'windows-1251' (not '1252') as the default charset in the Test Preference file. Once the Blink CL is landed and rolled, we'll re-enable the disabled tests as a part of the following Cr CL: https://codereview.chromium.org/649413002/ , which rolls ICU 52 to the latest revision (the other side of ISO-8859-1 to windows-1252 transition). TBR=jochen,rdsmith,mnissler,jsbell BUG=412053 TEST=browser_tests the following tests (before and after the Blink roll) BrowserEncodingTest.TestEncodingAutoDetect BrowserEncodingTest.TestOverrideEncoding EncodingAliases/BrowserEncodingTest.TestEncodingAliasMapping SavePageBrowserTest.FileNameFromPageTitle SavePageBrowserTest.SaveCompleteHTML PrefsTabHelperBrowserTest.WebPrefs Review URL: https://codereview.chromium.org/643993004 Cr-Commit-Position: refs/heads/master@{#300069}
* Convert ARRAYSIZE_UNSAFE -> arraysize in chrome/browser/.viettrungluu2014-10-161-1/+1
| | | | | | | | | R=thestig@chromium.org BUG=423134 Review URL: https://codereview.chromium.org/655413002 Cr-Commit-Position: refs/heads/master@{#299837}
* replace OVERRIDE and FINAL with override and final in chrome/browser/[a-i]*mostynb2014-10-131-3/+3
| | | | | | | | | TBR=dgozman@chromium.org BUG=417463 Review URL: https://codereview.chromium.org/625113002 Cr-Commit-Position: refs/heads/master@{#299274}
* Move url_request_mock_http_job to net/test/url_request/xunjieli2014-09-101-4/+4
| | | | | | | | | | | | | | This CL is a part of the effort to move mock URLRequestJob files from content/test/net to net/test/url_request/. The reason for this refactoring is that Cronet will need to use these classes for testing, so it will be nice if they can be in net/test, as the dependency can work out nicely. BUG= Review URL: https://codereview.chromium.org/541743002 Cr-Commit-Position: refs/heads/master@{#294255}
* Change base/file_utils.h includes to base/files/file_utils.h in chrome/thestig2014-08-261-1/+1
| | | | | | Review URL: https://codereview.chromium.org/486843004 Cr-Commit-Position: refs/heads/master@{#291880}
* Disable BrowserEncodingTest.TestEncodingAutoDetectdmichael@chromium.org2014-03-121-1/+2
| | | | | | | | | | | BUG=351325 TBR=cpu,jochen NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/195373002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256556 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable TestEncodingAutoDetectccameron@chromium.org2013-10-181-1/+1
| | | | | | | | | | | | The assert this was triggering has been removed. BUG=174764 TBR=vitalybuka NOTRY=True (passed Mac, only affected platform) Review URL: https://codereview.chromium.org/27598002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229377 0039d316-1c4b-4281-b951-d872f2087c98
* Enable BrowserEncoding tests for EUC-KRjshin@chromium.org2013-10-101-10/+0
| | | | | | | | | | | | | | They're disabled while waiting for a Blink roll containing r=159125 The initial CL is https://codereview.chromium.org/25769005/ BUG=277027,95963 TEST=browser test: BrowserEncodingTest.* and EncodingAlias*. TBR=thakis Review URL: https://codereview.chromium.org/26504004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227863 0039d316-1c4b-4281-b951-d872f2087c98
* Canonical encoding name : windows-949 => EUC-KRjshin@chromium.org2013-10-081-5/+14
| | | | | | | | | | | | | | | | | | This is the chromium side of a blink change at https://codereview.chromium.org/25870005 Until the corresponding blink CL above is re-landed (it's landed but reverted), disable EUC-KR-related test temporarily. This is a copy of https://codereview.chromium.org/25769005/ (lgtm'd and approved). BUG=277027, 95963 TEST=browser test: BrowserEncodingTest.* and EncodingAlias*. TBR=thakis,robertshield Review URL: https://codereview.chromium.org/26439002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227506 0039d316-1c4b-4281-b951-d872f2087c98
* Move PathIsWritable, DirectoryExists, ContentsEqual, and TextContentsEqual ↵brettw@chromium.org2013-07-151-1/+1
| | | | | | | | | | to the base namespace. TBR=sky Review URL: https://codereview.chromium.org/19052005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211675 0039d316-1c4b-4281-b951-d872f2087c98
* content: Remove usage of NOTIFICATION_NAV_ENTRY_COMMITTED from contentphajdan.jr@chromium.org2013-06-051-6/+2
| | | | | | | | | BUG=170921 R=avi@chromium.org, jam@chromium.org Review URL: https://codereview.chromium.org/16273003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204320 0039d316-1c4b-4281-b951-d872f2087c98
* Move remaining non-test, non-Chrome-specific Prefs code to base/prefs/.joi@chromium.org2013-02-111-1/+1
| | | | | | | | | | | | | | This is a mostly-automated change, using ./tools/git/move_source_file.py to move files and fix up include guards and #includes from other files. Manual edits were limited to fixing up .gypi files and adding BASE_PREFS_EXPORT where needed. TBR=ben@chromium.org BUG=155525 Review URL: https://codereview.chromium.org/12211105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181707 0039d316-1c4b-4281-b951-d872f2087c98
* Merge branch 'master' into file_path_browserbrettw@chromium.org2013-02-101-16/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | version control markers Merge branch 'master' into file_path_browser remove version control Fix typo Merge branch 'master' into file_path_browser Conflicts: chrome/browser/intents/native_services_browsertest.cc chrome/browser/ui/intents/native_file_picker_service.cc Merge branch 'master' into file_path_browser Conflicts: chrome/browser/chromeos/drive/drive_file_system.cc chrome/browser/chromeos/drive/drive_file_system.h chrome/browser/chromeos/drive/drive_file_system_interface.h chrome/browser/chromeos/drive/drive_file_system_unittest.cc chrome/browser/chromeos/drive/file_system/drive_operations.cc chrome/browser/chromeos/login/wallpaper_manager.cc chrome/browser/chromeos/login/wallpaper_manager.h chrome/browser/chromeos/login/wallpaper_manager_browsertest.cc chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc chrome/browser/google_apis/gdata_wapi_operations.cc chrome/browser/google_apis/gdata_wapi_operations.h chrome/browser/google_apis/gdata_wapi_operations_unittest.cc chrome/browser/profiles/off_the_record_profile_impl.cc chrome/browser/profiles/off_the_record_profile_impl.h chrome/browser/profiles/profile_impl.cc chrome/browser/profiles/profile_impl.h chrome/browser/profiles/profile_impl_io_data.cc chrome/browser/profiles/profile_impl_io_data.h chrome/browser/sync_file_system/drive_file_sync_client_unittest.cc chrome/browser/ui/webui/options/manage_profile_handler.cc Long lines long lines some long lines. long lines long lines Beginning of lines. Rename FilePath -> base::FilePath in chrome/browser git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181638 0039d316-1c4b-4281-b951-d872f2087c98
* Disabled TestEncodingAutoDetect on MACvitalybuka@chromium.org2013-02-071-1/+1
| | | | | | | | | BUG=174764 TBR=jam Review URL: https://chromiumcodereview.appspot.com/12221053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181200 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TabStripModel wrapper use.avi@chromium.org2013-01-281-5/+8
| | | | | | | | | | BUG=167548 TEST=no functional change Review URL: https://chromiumcodereview.appspot.com/11953065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179199 0039d316-1c4b-4281-b951-d872f2087c98
* content: remove NOTIFICATION_SAVE_PACKAGE_SUCCESSFULLY_FINISHEDphajdan.jr@chromium.org2013-01-241-4/+38
| | | | | | | | BUG=170921 Review URL: https://codereview.chromium.org/11867023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178661 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 178351cpu@chromium.org2013-01-231-38/+4
| | | | | | | | | | | | | | | Seems to have broken aura on windows > content: remove NOTIFICATION_SAVE_PACKAGE_SUCCESSFULLY_FINISHED > > BUG=170921 > > Review URL: https://codereview.chromium.org/11867023 TBR=phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/11953064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178404 0039d316-1c4b-4281-b951-d872f2087c98
* content: remove NOTIFICATION_SAVE_PACKAGE_SUCCESSFULLY_FINISHEDphajdan.jr@chromium.org2013-01-231-4/+38
| | | | | | | | BUG=170921 Review URL: https://codereview.chromium.org/11867023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178351 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Split BrowserEncodingTest.TestEncodingAliasMapping into smaller tests.phajdan.jr@chromium.org2012-11-201-58/+59
| | | | | | | | | | | | This allows me to drop the SLOW_ prefix, and is one small step toward lowering the per-test timeout in browser_tests. BUG=none Review URL: https://chromiumcodereview.appspot.com/11412077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168676 0039d316-1c4b-4281-b951-d872f2087c98
* Move scoped_temp_dir from base to base/filesbrettw@chromium.org2012-11-161-2/+2
| | | | | | | | | | Also add to base namespace. BUG= Review URL: https://codereview.chromium.org/11359217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168281 0039d316-1c4b-4281-b951-d872f2087c98
* Move remaining content test code into the content namespace.jam@chromium.org2012-10-301-3/+3
| | | | | | Review URL: https://codereview.chromium.org/11346016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164789 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable BrowserEncodingTest.TestEncodingAliasMapping under ASandpolukhin@chromium.org2012-08-141-8/+1
| | | | | | | | | | BUG=127748 TEST=manual and on bot Review URL: https://chromiumcodereview.appspot.com/10834309 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151543 0039d316-1c4b-4281-b951-d872f2087c98
* Create content\public\test\test_utils.h to hold common test classes that are ↵jam@chromium.org2012-07-201-1/+1
| | | | | | | | | used by unit and browser tests. unit tests shouldn't be including ui_test_utils.h. BUG=90448 Review URL: https://chromiumcodereview.appspot.com/10807047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147602 0039d316-1c4b-4281-b951-d872f2087c98
* Move tab functions off Browser into browser_tabstrip and browser_tabrestore.ben@chromium.org2012-06-291-4/+5
| | | | | | | | http://crbug.com/133576 TEST=none Review URL: https://chromiumcodereview.appspot.com/10702029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145015 0039d316-1c4b-4281-b951-d872f2087c98
* Move browser commands into a separate file.ben@chromium.org2012-06-251-2/+3
| | | | | | | | http://crbug.com/133576 TEST=none Review URL: https://chromiumcodereview.appspot.com/10657016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144028 0039d316-1c4b-4281-b951-d872f2087c98
* TabContentsWrapper -> TabContents, part 33.avi@chromium.org2012-06-111-4/+4
| | | | | | | | | | | | Loose files in browser/. BUG=131026 TEST=no change Review URL: https://chromiumcodereview.appspot.com/10538073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141465 0039d316-1c4b-4281-b951-d872f2087c98
* Move more test headers from content\test to content\public\test. This way we ↵jam@chromium.org2012-06-021-3/+3
| | | | | | | | | | can enforce that internal content headers don't leak to embedders. Move these headers into the content namespace in the process. BUG=98716 TBR=phajdan.jr Review URL: https://chromiumcodereview.appspot.com/10497009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140199 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate the rest of the "global" prefs.falken@google.com2012-05-221-2/+2
| | | | | | | | | | | | This is a continuation of the work in r137835. TBR=gene for cloud print, mpcomplete for extension BUG=123812 TEST=browser_tests --gtest_filter=PrefsTab* and ExtensionApiTest.Font* Review URL: https://chromiumcodereview.appspot.com/10409046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138219 0039d316-1c4b-4281-b951-d872f2087c98
* Disable BrowserEncodingTest.TestEncodingAliasMapping under ASanglider@chromium.org2012-05-111-1/+8
| | | | | | | | BUG=127748 TBR=jnd Review URL: https://chromiumcodereview.appspot.com/10381107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136529 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the unload ui_tests to browser_tests.jam@chromium.org2012-04-111-1/+1
| | | | | | | | | I deleted CrossSiteInfiniteUnloadAsyncInputEvent because there's no non-flaky way of ensuring that something happens before one of two smaller timeouts (checked with original author that this is fine). BUG=121574 Review URL: https://chromiumcodereview.appspot.com/10034028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131873 0039d316-1c4b-4281-b951-d872f2087c98
* Load every testcase of BrowserEncodingTest.TestEncodingAliasMapping in a new ↵jam@chromium.org2012-04-061-9/+10
| | | | | | | | | | tab to avoid the race condition where the previous encoding is seen. BUG=122053 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130948 Review URL: https://chromiumcodereview.appspot.com/9997002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131148 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 130948 - Load every testcase of ↵dbeam@chromium.org2012-04-061-9/+9
| | | | | | | | | | | | | | BrowserEncodingTest.TestEncodingAliasMapping in a new tab to avoid the race condition where the previous encoding is seen. Timing out on XP Tests (dbg)(3). BUG=122053 Review URL: https://chromiumcodereview.appspot.com/9997002 TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10008039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131102 0039d316-1c4b-4281-b951-d872f2087c98
* Load every testcase of BrowserEncodingTest.TestEncodingAliasMapping in a new ↵jam@chromium.org2012-04-051-9/+9
| | | | | | | | | tab to avoid the race condition where the previous encoding is seen. BUG=122053 Review URL: https://chromiumcodereview.appspot.com/9997002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130948 0039d316-1c4b-4281-b951-d872f2087c98
* Mark BrowserEncodingTest.TestEncoding* as DISABLED on Windows.binji@chromium.org2012-04-041-3/+15
| | | | | | | | | | BUG=122053 TEST=BrowserEncodingTest.TestEncoding* TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/9992001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130764 0039d316-1c4b-4281-b951-d872f2087c98
* Convert browser encoding ui_tests to browser_tests. They should hopefully be ↵jam@chromium.org2012-04-041-0/+276
a lot less flakier now that they listen to notifications instead of polling the disk. I renabled the three tests which were disabled for being flaky. BUG=121574,82616,44668,44666 Review URL: https://chromiumcodereview.appspot.com/9950114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130520 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-09 21:17:42 +0000