summaryrefslogtreecommitdiffstats
path: root/chrome/browser/browser_encoding_uitest.cc
Commit message (Collapse)AuthorAgeFilesLines
* Revert 31419 - Commit Issue 255057: Unit Test for Toggling of Encoding ↵willchan@chromium.org2009-11-091-89/+2
| | | | | | | | | | | | | AutoDetect BUG=23617 TEST=BrowserEncodingTest.TestToggleAutoDetect TBR=rolandsteiner@chromium.org Review URL: http://codereview.chromium.org/378031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31465 0039d316-1c4b-4281-b951-d872f2087c98
* Commit Issue 255057: Unit Test for Toggling of Encoding Auto-Detectrolandsteiner@chromium.org2009-11-091-2/+89
| | | | | | | | BUG=23617 TEST=BrowserEncodingTest.TestToggleAutoDetect git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31419 0039d316-1c4b-4281-b951-d872f2087c98
* Use FilePath in URLRequestMocks.evan@chromium.org2009-10-141-3/+3
| | | | | | | | | BUG=24672 TEST=compiles Review URL: http://codereview.chromium.org/271066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29013 0039d316-1c4b-4281-b951-d872f2087c98
* TestOverrideEncoding hanging is because TabProxy::WaitForNavigation can not ↵jnd@chromium.org2009-10-041-1/+1
| | | | | | | | | | | | | | | | | | | get reply if current last last_navigation_time for tab _tracker is great than the input last_navigation_time. See AutomationProvider::WaitForNavigation, it is handled by IPC_MESSAGE_HANDLER_DELAY_REPLY, which means the message handler need to send the reply message by itself. According to current WaitForNavigation logic, if current last last_navigation_time for tab _tracker is less than the input last_navigation_time, the replay will be sent by NavigationNotificationObserver. Otherwise, the reply will never be sent. So if somehow the test machine is slow, the navigation has happened before calling AutomationProvider::WaitForNavigation, the caller will never get reply. That is why TestOverrideEncoding hangs sometimes. Please refer to http://chrome-svn/viewvc/chrome?view=rev&revision=9585 to see how the logic was changed before. The problem also happened on other two places. BUG=23121 TEST=BrowserEncodingTest.TestOverrideEncoding Review URL: http://codereview.chromium.org/242024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27966 0039d316-1c4b-4281-b951-d872f2087c98
* Update the TabContents::SavePage parameter to take FilePath instead of ↵rsesek@chromium.org2009-09-261-4/+2
| | | | | | | | | | | | wstring to avoid conversions "To and From wstring". BUG=None TEST=run unit_tests.exe Review URL: http://codereview.chromium.org/217008 Patch from tfarina. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27331 0039d316-1c4b-4281-b951-d872f2087c98
* Disable TestOverrideEncoding test. It's been hanging the XP Tests (dbg)(3) ↵thestig@chromium.org2009-09-251-1/+1
| | | | | | | | | | | ui_test all day. BUG=23121 TEST=none TBR=jnd Review URL: http://codereview.chromium.org/252007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27264 0039d316-1c4b-4281-b951-d872f2087c98
* Speed up the BrowserEncodingTest.TestEncodingAutoDetect.jnd@chromium.org2009-09-221-10/+10
| | | | | | | | | | | The main way is making the sleep timout shorter. BUG=22063 TEST=BrowserEncodingTest.TestEncodingAutoDetect. Review URL: http://codereview.chromium.org/209030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26787 0039d316-1c4b-4281-b951-d872f2087c98
* Convert std::wstring encoding names to std::string in a bunch of files.tony@chromium.org2009-09-041-54/+54
| | | | | | | | | | | | | | | BUG=8647 (http://crbug.com/8647) TEST=run unit_tests.exe and ui_tests.exe Original patch by Thiago Farina <thiago.farina@gmail.com> at http://codereview.chromium.org/179057/show Some linux related fixes by me. Review URL: http://codereview.chromium.org/192017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25529 0039d316-1c4b-4281-b951-d872f2087c98
* Alias 'US-ASCII' to 'ISO-8859-1' in our UI without touching webkit.BUG=15801jnd@chromium.org2009-09-021-0/+1
| | | | | | | TEST=Add US-ASCII encoding to browser encoding test Review URL: http://codereview.chromium.org/178017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25168 0039d316-1c4b-4281-b951-d872f2087c98
* Fix BrowserEncodingTest to use FilePaths and cleanup temporary files.thestig@chromium.org2009-09-021-122/+103
| | | | | | | | BUG=none TEST=Running this test should not leave extra files in the temp dir. Review URL: http://codereview.chromium.org/176057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25153 0039d316-1c4b-4281-b951-d872f2087c98
* Disable this test of encoding override on MacOS and Linux because on those ↵jnd@chromium.org2009-08-221-0/+5
| | | | | | | | | | | | | | platforms AutomationProvider::OverrideEncoding is not implemented yet. BUG=none TEST=none TBR=jshin Review URL: http://codereview.chromium.org/174305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24078 0039d316-1c4b-4281-b951-d872f2087c98
* Use size_t to fix compilation error.jnd@chromium.org2009-08-221-2/+2
| | | | | | | | TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24077 0039d316-1c4b-4281-b951-d872f2087c98
* Use ARRAYSIZE_UNSAFEjnd@chromium.org2009-08-221-2/+2
| | | | | | | | | BUG=none TEST=none TBR=jshik git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24076 0039d316-1c4b-4281-b951-d872f2087c98
* arraysize doesn't accept a type defined inside a function. In these rarejnd@chromium.org2009-08-221-2/+2
| | | | | | | | | | | cases, I have to use the unsafe ARRAYSIZE_UNSAFE() macro BUG=none TEST=none TRB=jshik git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24075 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compilation failure on Mac and Linuxjnd@chromium.org2009-08-221-11/+18
| | | | | | | | | | | BUG=none TEST=none TBR=jshin Review URL: http://codereview.chromium.org/174304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24074 0039d316-1c4b-4281-b951-d872f2087c98
* Add a UI test for "Encoding" menu. Please see crbug.com/5515 for more ↵jnd@chromium.org2009-08-221-0/+305
details.This change list is based on http://codereview.chromium.org/18417 which was written by xlyuan@chromiumBug=5515 ( http://crbug.com/5515 ) Review URL: http://codereview.chromium.org/165393 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24073 0039d316-1c4b-4281-b951-d872f2087c98