summaryrefslogtreecommitdiffstats
path: root/chrome/browser/browser_focus_uitest.cc
Commit message (Collapse)AuthorAgeFilesLines
* BSD ifdefs, etc. necessary for chrome/pvalchev@google.com2010-03-091-6/+6
| | | | | | Review URL: http://codereview.chromium.org/656009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41067 0039d316-1c4b-4281-b951-d872f2087c98
* Add a regression test for http://crbug.com/29473estade@chromium.org2009-12-141-2/+32
| | | | | | | | | BUG=29473 TEST=it passes Review URL: http://codereview.chromium.org/486037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34504 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the CL that made interactive UI tests run out-of-proc.jcampan@chromium.org2009-11-061-2/+0
| | | | | | | | | | | | | | | | | It was causing them to hang on Windows. I cannot repro on my box. I added a timeout to the ViewEventTest as I suspect they are the ones causing the timeout. Original review: http://codereview.chromium.org/355014/show TEST=None TBR=rafael Review URL: http://codereview.chromium.org/360016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31327 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to make interactive ui tests complete on Linux while I try to repro it.jam@chromium.org2009-10-271-0/+2
| | | | | | Review URL: http://codereview.chromium.org/333042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30169 0039d316-1c4b-4281-b951-d872f2087c98
* Implements tests for testing browser's overall key events handling behavior.suzhe@chromium.org2009-10-231-93/+40
| | | | | | | | | | | | This CL implements some basic tests for testing browser's overall key events handling behavior. This CL depends on http://codereview.chromium.org/235039 and http://codereview.chromium.org/195062. Currently, only Linux and Windows are supported. The tests assume US keyboard layout is used and no IME is activated. We still need to investigate how to write tests that involving different keyboard layout and input methods. BUG=none TEST=none Review URL: http://codereview.chromium.org/268035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29866 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a whole bunch of style nits.erg@google.com2009-10-131-1/+0
| | | | | | | | (Long term intention is to add a subset of cpplint.py to the presubmit script.) Review URL: http://codereview.chromium.org/276008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28914 0039d316-1c4b-4281-b951-d872f2087c98
* Factoring out the interactive UI tests in their own GYP file.jcampan@chromium.org2009-10-131-29/+12
| | | | | | | | | | | Although turning back on the browser focus tests that had been turned off last week because of my previous attempt at performing this refactoring (that change was reverted). BUG=None TEST=Build and run the interactive ui tests on Windows and Linux. Review URL: http://codereview.chromium.org/273029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28866 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling a interactive testjcampan@chromium.org2009-10-091-1/+2
| | | | | | | | | | | | | Disabling the last browser focus interactive UI tests. It mysteriously crashing, as with the rest of them that were disabled yesterday (this one was left out, probably unintentionaly). BUG=http://crbug.com/24400 TBR=estade Review URL: http://codereview.chromium.org/272016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28606 0039d316-1c4b-4281-b951-d872f2087c98
* Disable all browser focus tests on windows. They are hanging or crashing on ↵estade@chromium.org2009-10-091-9/+12
| | | | | | | | | | | the buildbot. BUG=24400 TBR=thakis Review URL: http://codereview.chromium.org/271030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28508 0039d316-1c4b-4281-b951-d872f2087c98
* Disable BrowserFocusTest.BrowsersRememberFocus as it is crashing thezork@google.com2009-10-081-1/+7
| | | | | | | | | | interactive UI tests in win. BUG=none TEST=none Review URL: http://codereview.chromium.org/270029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28447 0039d316-1c4b-4281-b951-d872f2087c98
* Disable BrowserFocusTest.ClickingMovesFocus as it is crashing the ↵jhawkins@chromium.org2009-10-081-1/+10
| | | | | | | | | | | interactive UI tests in win. TBR=zork BUG=none TEST=none Review URL: http://codereview.chromium.org/265043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28430 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a warning:nsylvain@chromium.org2009-10-031-2/+2
| | | | | | | | | | browser_focus_uitest.cc:401: warning: 'unfocused_browser' may be used uninitialized in this function browser_focus_uitest.cc:400: warning: 'focused_browser' may be used uninitialized in this function TBR:maruel Review URL: http://codereview.chromium.org/256050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27954 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling a filing test temporarily.jcampan@chromium.org2009-10-021-1/+2
| | | | | | | | | TEST=None BUG=23683 TBR=cpu Review URL: http://codereview.chromium.org/257040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27905 0039d316-1c4b-4281-b951-d872f2087c98
* Find-in-bar would steal focus when switching tab.jcampan@chromium.org2009-10-021-0/+38
| | | | | | | | BUG=23296 TEST=See bug. Review URL: http://codereview.chromium.org/243073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27901 0039d316-1c4b-4281-b951-d872f2087c98
* For some reason, if the interactive test that I added runs after inprocess ↵jam@chromium.org2009-10-021-41/+0
| | | | | | | | | | tests (still in interactive tests), it gives an assert in Linux before it starts because the existing process count is 2. Moving it to a different file solves the prolbem. TBR=jcampan BUG=5496 Review URL: http://codereview.chromium.org/259010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27823 0039d316-1c4b-4281-b951-d872f2087c98
* Don't send tab switching/killing/creating keyboard accelerators to pages. ↵jam@chromium.org2009-10-021-0/+40
| | | | | | | | | | This avoids tabs maliciously preventing closing using ctrl+f4/ctrl+w/alt+f4, and also hung/slow renderers from making tab cycling sluggish. BUG=5496 TEST=added ui test Review URL: http://codereview.chromium.org/224023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27814 0039d316-1c4b-4281-b951-d872f2087c98
* This CL makes the browser focus tests faster by replacingjcampan@chromium.org2009-09-181-39/+67
| | | | | | | | | | | | some time-outs with notifications. BUG=22065 TEST=Run the interactive tests, especially BrowserFocusTest*FocusTraversal* These tests should run in few seconds. Review URL: http://codereview.chromium.org/210013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26597 0039d316-1c4b-4281-b951-d872f2087c98
* Fix to use FilePath in more unittests.phajdan.jr@chromium.org2009-09-141-4/+4
| | | | | | | | | | | Landing patch for Thiago Farina, original review: http://codereview.chromium.org/187005 BUG=None TEST=run unit_tests.exe, base_unittests.exe. Review URL: http://codereview.chromium.org/193101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26142 0039d316-1c4b-4281-b951-d872f2087c98
* Couple of tweaks to ui_controls_linux:sky@chromium.org2009-08-261-1/+1
| | | | | | | | | | | | | | | | | | . Moves listening from DidProcess to WillProcess. This is necessitated by the bookmark bar (chrome menu) tests that spawn a nested run loop, which results in DidProcess not getting sent and the test wedging. This brings the code closer in line with Windows. . If there is a mouse/keyboard grab, mouse/keyboard events are sent to the grabbed widget. . Deals with a NULL widget for sending keyboard events (tries to find focused widget). BUG=none TEST=none Review URL: http://codereview.chromium.org/173392 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24420 0039d316-1c4b-4281-b951-d872f2087c98
* More interactive test porting for Linux.estade@chromium.org2009-08-211-122/+79
| | | | | | | | | | | Also fix a bug in the Windows implementation of SendMouseMoveNotifyWhenDone where the task would never be run if the cursor was already in the destination position before the call. BUG=19076 BUG=19881 Review URL: http://codereview.chromium.org/174201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24027 0039d316-1c4b-4281-b951-d872f2087c98
* Port more browser focus tests to linux.estade@chromium.org2009-08-191-105/+118
| | | | | | | | | | | | | | | | | | | Added a new test to make sure clicking sets focus, since I changed a lot of tests to programatically set focus instead of using clicking. Also set the actual time on our synthetic key events. I'm still not sure this is necessary but would like to avoid subtle bugs. Also get rid of the NineBox constructor that takes a theme provider and convert its callers to use cairo directly or the other NineBox constructor. This change was necessary because theme providers could go stale and then the NineBox would cause seg faults. Also, it was only being used for single images... and UniBox just sounds wrong. Also fix extension shelf to paint its image with the correct x/y (noticeable only with certain themes). Remove the notification observer stuff from the extension shelf, as I don't think there is any action to be taken when the theme changes. BUG=19076 BUG=19659 TEST=all the ported interactive ui tests (as well as all the already-working tests) pass. TEST=(Linux) things still render correctly (frame image, drop shadows, find box, extension shelf) Review URL: http://codereview.chromium.org/173030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23732 0039d316-1c4b-4281-b951-d872f2087c98
* Relands drop support:sky@chromium.org2009-08-191-3/+8
| | | | | | | | | | | | Adds drop support for views on gtk. As X lazily provides drop data I needed to tweak the views API a bit. BUG=none TEST=none Review URL: http://codereview.chromium.org/173025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23690 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts recent patch as broke build on toolkit_views.sky@chromium.org2009-08-181-8/+3
| | | | | | | | | TBR=ben BUG=none TEST=none Review URL: http://codereview.chromium.org/174023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23658 0039d316-1c4b-4281-b951-d872f2087c98
* Adds drop support for views on gtk. As X lazily provides drop data Isky@chromium.org2009-08-181-3/+8
| | | | | | | | | | | needed to tweak the views API a bit. BUG=none TEST=none Review URL: http://codereview.chromium.org/165407 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23653 0039d316-1c4b-4281-b951-d872f2087c98
* more linux automation porting: SendKeyPressNotifyWhenDoneestade@chromium.org2009-08-181-9/+15
| | | | | | | | | | also change the interface for SimulateOSKeyPress()/SendKeyPress() to take a VKEY_ value (defined in base/keyboard_codes.h) rather than a VK_ value. BUG=19076 Review URL: http://codereview.chromium.org/171079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23611 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable a failing ui test.estade@chromium.org2009-08-171-1/+2
| | | | | | | TBR=eroman git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23588 0039d316-1c4b-4281-b951-d872f2087c98
* Begin to port browser focus tests to linux.estade@chromium.org2009-08-171-15/+53
| | | | | | | | TEST=interactive ui tests builds and runs and BrowserFocusTest.TabInitialFocus passes Review URL: http://codereview.chromium.org/172059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23585 0039d316-1c4b-4281-b951-d872f2087c98
* Convert parts of errorpage_uitest.cc to be not flaky.phajdan.jr@chromium.org2009-08-151-3/+6
| | | | | | | | | TEST=Covered by browser_tests. http://crbug.com/19361, http://crbug.com/19395 Review URL: http://codereview.chromium.org/169002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23500 0039d316-1c4b-4281-b951-d872f2087c98
* The focus would be messed-up when reloading a crashed tab, also causing ↵jcampan@chromium.org2009-07-291-1/+50
| | | | | | | | | | | | accelerators to be broken. This CL also makes sure to keep the focus on the location bar when reloading the NTP. BUG=http://crbug.com/14954 TEST=See bug. Review URL: http://codereview.chromium.org/160206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21961 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable some focus UI tests. These failed for unknown reasons with a funnybrettw@chromium.org2009-07-231-4/+2
| | | | | | | | | | error from the notification service. This error seems to be fixed. BUG=15265 Test=This is a test Review URL: http://codereview.chromium.org/155858 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21392 0039d316-1c4b-4281-b951-d872f2087c98
* Add an ExtensionBrowserTest base class that allows in-process browser tests ↵aa@chromium.org2009-07-041-2/+2
| | | | | | | | of extensions using ExtensionsService directly, rather than TestExtensionLoaded. Use it to re-enable some old browser tests that had been disabled. Review URL: http://codereview.chromium.org/150213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19930 0039d316-1c4b-4281-b951-d872f2087c98
* This CL removes the last (major) Windows specific part out of the focus ↵jcampan@chromium.org2009-06-301-11/+11
| | | | | | | | | | | | | | | | | | | | | | | manager. It was previously landed and reverted because it broke the reliability tests. http://codereview.chromium.org/125148 The breakage was caused by constrained windows not getting a hold of the FocusManager when in unparented tabs. The fix is to ensure unparented tab still have a way to access their FocusManager for proper closure. Files changed from the previous patch that need reviewing: native_tab_contents_container_win.cc tab_contents_view_win.h tab_contents_view_win.cc BUG=None TEST=Run all tests (unit, ui, interactive). Extensively test the focus in Chrome. Review URL: http://codereview.chromium.org/146093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19617 0039d316-1c4b-4281-b951-d872f2087c98
* Disable failing tests until I can figure out what's going on.brettw@chromium.org2009-06-251-2/+4
| | | | | | Review URL: http://codereview.chromium.org/146127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19208 0039d316-1c4b-4281-b951-d872f2087c98
* By user request, focus should go to the location bar when about:blank is the ↵jcampan@chromium.org2009-06-221-0/+6
| | | | | | | | | | default new tab page. BUG=9966 TEST=Make "about:blank" your home page. Open a new tab. It should be showing about:blank and the location bar should be focused. Review URL: http://codereview.chromium.org/141028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18924 0039d316-1c4b-4281-b951-d872f2087c98
* Revert :nsylvain@chromium.org2009-06-221-11/+11
| | | | | | | | | | | | | | | | | | Changed by: jcampan@chromium.org Changed at: Fri 19 Jun 2009 21:22:47 Branch: src Revision: 18889 Comments: Relanding focus manager refactoring with build fix, see:http://codereview.chromium.org/125148BUG=NoneTEST=NoneTBR=ben Review URL: http://codereview.chromium.org/141013 Because it creates hundreds of new reliability crashes. TBR:jcampan Review URL: http://codereview.chromium.org/140064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18904 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding focus manager refactoring with build fix, ↵jcampan@chromium.org2009-06-201-11/+11
| | | | | | | | see:http://codereview.chromium.org/125148BUG=NoneTEST=NoneTBR=ben Review URL: http://codereview.chromium.org/141013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18889 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 18872.jcampan@chromium.org2009-06-191-11/+11
| | | | | | | | | | | | Broke the Windows build. BUG=None TEST=None TBR=ben Review URL: http://codereview.chromium.org/140023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18873 0039d316-1c4b-4281-b951-d872f2087c98
* Removed the last Windows specific part out of the focus manager. HWNDs are ↵jcampan@chromium.org2009-06-191-11/+11
| | | | | | | | not subclassed anymore.The FocusManager is now created and owned by top-level WidgetWins.BUG=NoneTEST=Run the unit tests, UI tests, interactive UI tests. Fully test the focus behavior in the browser: activate/deactivate the browser windows, make sure focus is remembered. Switch tabs, make sure focus is remembered for each tab. make sure accelerators work as expected. Test focus traversal in a web page, in the option dialog. Review URL: http://codereview.chromium.org/125148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18872 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the focus manager to not subclass HWNDs (but for the ↵jcampan@chromium.org2009-06-121-20/+26
| | | | | | | | top-windows).Components that have HWND now need to specifically let the FocusManager know when they get the native focus.This is the reason for the new GotFocus() notification on the RenderWidgetHostViewWin class.BUG=NoneTEST=Run the interactive tests, the unit-tests. Test that the focus is remembered correctly when switching windows, switching tabs. Test that focus traversal in the browser and in the option dialog works as expected. Review URL: http://codereview.chromium.org/122002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18301 0039d316-1c4b-4281-b951-d872f2087c98
* Turn BrowserView::GetBrowserViewForNativeView() into ↵davemoore@chromium.org2009-05-281-11/+13
| | | | | | | | | | | GetBrowserViewForNativeWindow() This simplifies things on linux where the native window is not the same type as the native view. Review URL: http://codereview.chromium.org/115830 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17043 0039d316-1c4b-4281-b951-d872f2087c98
* Renames BrowserView::GetBrowserViewForHWND tosky@chromium.org2009-05-261-11/+11
| | | | | | | | | | | | | GetBrowserViewForNativeView and implements the GTK side. I could have went with NativeWindow here, but we end up with more flexibility if we keep this as NativeView. BUG=none TEST=none Review URL: http://codereview.chromium.org/113842 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16882 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors TabContentsContainerView into TabContentsContainer and associated ↵ben@chromium.org2009-05-221-17/+30
| | | | | | | | | | | platform-specific inner classes. BUG=none TEST=make sure web page focus cycling in and out of the content area still works. Review URL: http://codereview.chromium.org/113784 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16810 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out a BrowserFrame interface, and move the existing Windows-based codebrettw@chromium.org2009-05-191-1/+1
| | | | | | | | | | | to a new class: BrowserFrameWin. The major other change I had to make was the way that the TabStrip is set in the BrowserRootView. Now there is a method on the frame that the view can call when it creats the tabstrip that will set the tabstrip on the root view. Review URL: http://codereview.chromium.org/113511 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16373 0039d316-1c4b-4281-b951-d872f2087c98
* Move src/chrome/views to src/views. RS=darin http://crbug.com/11387ben@chromium.org2009-05-081-3/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15604 0039d316-1c4b-4281-b951-d872f2087c98
* The last redesign of interstitial pages made them to be a render view ↵jcampan@chromium.org2009-05-061-1/+197
| | | | | | | | | | | | | painted on top of the normal page. Because they were not know from the tab contents container, the actual hidden page behind them would still get focus. That was particularly noticeable when tabbing. BUG=11505 TEST=Open a page that triggers an interstitial (ex: https://ebay.com). Press tab to cycle the focus. Make sure the focus is moved as expected. Review URL: http://codereview.chromium.org/113039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15446 0039d316-1c4b-4281-b951-d872f2087c98
* honor index in createTab()rafaelw@chromium.org2009-05-061-1/+1
| | | | | | | | | BUG=11200 R=brettw,beng Review URL: http://codereview.chromium.org/99300 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15392 0039d316-1c4b-4281-b951-d872f2087c98
* Replace all occurrances of WebContents with TabContents.brettw@chromium.org2009-05-041-3/+2
| | | | | | Review URL: http://codereview.chromium.org/99177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15194 0039d316-1c4b-4281-b951-d872f2087c98
* Migrating the SSL UI tests to be browser tests.jcampan@chromium.org2009-04-291-6/+8
| | | | | | | | | | | | | Reenabling all of them. Hopefully it'll help with flakiness. Note that I am keeping the SSL UI tests alive until the browser test framework has been ported to Mac and Linux. BUG=6584,2136 TEST=Run the browser tests. Review URL: http://codereview.chromium.org/101013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14901 0039d316-1c4b-4281-b951-d872f2087c98
* Move Browser implementation of callback interfaces into the private section.stoyan@chromium.org2009-04-231-2/+2
| | | | | | | Split TabContentsDelegate and PageNavigator. Review URL: http://codereview.chromium.org/88063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14375 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 10573: Dismissing Find-in page doesn't set focusfinnur@chromium.org2009-04-171-59/+4
| | | | | | | | | | | | | | | | | | | | | | | | | to the link found. We no longer use the selection controller to highlight the active match. Before this change, the focus would not be set if the user had changed the selection. After this change, the focus will be set unless the user has selected something on the page. I also wrote an in-browser unit test for this to catch this regression in the future, but it is disabled due to problem with running multiple in-process browser tests in a row (teardown problem). BUG=10573 TEST=Covered by in process browser test now, see bug for repro steps. Review URL: http://codereview.chromium.org/79024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13945 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 19:36:58 +0000