summaryrefslogtreecommitdiffstats
path: root/chrome/browser/browser_init.cc
Commit message (Collapse)AuthorAgeFilesLines
* Fix racing condition that blocks profiles menu showing upxiyuan@chromium.org2009-12-221-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | Chrome should show profiles menu when "enable-udd-profiles" is supplied on command line. This is broken while refactoring app menu code from ToolbarView into AppMenuModel. Previously, the profile submenu model is kept in ToolbarView and profiles menu would show up on 2nd time app menu showing up. After the refactoring, profile menu is moved into AppMenuModel, which is re-created everytime before we show app menu. In AppMenuModel, it requests profiles data from GetProfilesHelper which will later invoke OnGetProfilesDone. However, app menu is created on the UI thread and blocks the callback until it shows up. This makes the profiles mneu empty. The fix is to leverage an existing profile list in BrowserProcess. When "enable-udd-profiles" is on, BrowserInit will get the initial profile list and NewProfileDialog will refresh it if user creates new profile. And AppMenuModel just use the list to populate the profile menu. BUG=30417 TEST=Verify profiles menu exists when "enable-udd-profiles" is on command line for issue 30417. Review URL: http://codereview.chromium.org/503062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35166 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 35137 - Getting perf numbers. Will revert.viettrungluu@chromium.org2009-12-221-10/+0
| | | | | | | | | | | | | BUG=none TEST=none TBR=viettrungluu@chromium.org Review URL: http://codereview.chromium.org/502099 TBR=viettrungluu@chromium.org Review URL: http://codereview.chromium.org/504080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35138 0039d316-1c4b-4281-b951-d872f2087c98
* Getting perf numbers. Will revert.viettrungluu@chromium.org2009-12-221-0/+10
| | | | | | | | | | BUG=none TEST=none TBR=viettrungluu@chromium.org Review URL: http://codereview.chromium.org/502099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35137 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the cmdline "--new-window" that instructs the init sequenceestade@chromium.org2009-12-181-1/+2
| | | | | | | | | | | | | | to open a new window instead of reusing the most recent tab for opening cmdline URLs. BUG=2843 TEST=Run with --new-window switch and confirm that a new window pops up patch by <clemens [at] endorphin dot org> original review: <http://codereview.chromium.org/464060> Review URL: http://codereview.chromium.org/503023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34926 0039d316-1c4b-4281-b951-d872f2087c98
* Use GetSwitchValueASCII, so we don't use the deprecated versions.evan@chromium.org2009-12-171-3/+3
| | | | | | | | Patch from Thiago Farina <thiago.farina@gmail.com>. Review URL: http://codereview.chromium.org/498002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34811 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame uses the IPC automation channel to talk to Chrome. The IPC ↵ananta@chromium.org2009-12-101-2/+9
| | | | | | | | | | | | | | | | | messages sent by ChromeFrame are handled by the AutomationProvider class in Chrome, which also handles other IPC's not used by ChromeFrame. We now have a new class ChromeFrameAutomationProvider which derives from the AutomationProvider class and validates that incoming IPC messages are valid ChromeFrame messages. Bug=29931 Test=Covered by unit test Review URL: http://codereview.chromium.org/476008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34290 0039d316-1c4b-4281-b951-d872f2087c98
* Remove IsPrefRegistered function from PrefService API and fix the callers totony@chromium.org2009-12-071-1/+1
| | | | | | | | | | | | | | call FindPreference directly. BUG=None TEST=compiles and passes existing tests Original patch by Thiago Farina <thiago.farina@gmail.com> at http://codereview.chromium.org/460117/show Review URL: http://codereview.chromium.org/463044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34010 0039d316-1c4b-4281-b951-d872f2087c98
* Step 1 in getting rid of transient prefs. Move over --homepage totony@chromium.org2009-11-301-17/+0
| | | | | | | | | | not using a transient pref. BUG=28992 Review URL: http://codereview.chromium.org/457003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33337 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-301-1/+3
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33324 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 33301 and 33305 due to unit_tests breakage.maruel@chromium.org2009-11-301-3/+1
| | | | | | | | TBR=pawel Review URL: http://codereview.chromium.org/453007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33309 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-301-1/+3
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33301 0039d316-1c4b-4281-b951-d872f2087c98
* In-application Keystone ticket promotion.mark@chromium.org2009-11-281-4/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The concept of "ticket promotion" is added to the application when Keystone is in use. Ticket promotion is used to turn a user Keystone ticket, which Chrome normally establishes when it launches, into a system Keystone ticket, after successful user authentication and authorization. Having a system Keystone with a system ticket means that updates are applied with root privileges instead of user privileges, essentially eliminating the possibility that a user will fall off of the auto-update train because they can read and execute but not write the application. Two principles of promotion apply: - An application on a user ticket NEEDS promotion if it determines that it doesn't have permission to write to itself. Being on a user ticket, an update attempt would fail. - An application on a user ticket WANTS promotion if it already NEEDS promotion. Additionally, if it is installed in a system-wide location such as /Applications, it will WANT promotion, even if it does not NEED it. If promotion is needed, an info bar will show up on launch requesting it. This info bar works similarly to the default browser info bar: it has a "don't bother me again" button, it will only show up after the first launch, it won't disappear on navigation if the navigation happens very quickly, and it won't show itself if another info bar is up. This means that if both the default browser info bar and the promotion info bar have a shot at showing, only one will win. In my experience, each wins about half of the time. If promotion is needed, the update UI in the About window will be hidden. Checking for updates and offering to apply them doesn't make much sense when the update won't be able to install successfully. All of the auto-update machinery is still working in the background, but the About window UI is hidden. If promotion is wanted, the About window will contain a new button allowing the user to enter promotion. This gives access to the same promotion routine as the promotion info bar. It can be used even from an administrative account that is able to update the application without promotion. It's intended to be used by the system administrator of the family without requiring them to switch to one of the kids' accounts. BUG=16360 TEST=Exhaustively, please. Review URL: http://codereview.chromium.org/437053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33241 0039d316-1c4b-4281-b951-d872f2087c98
* Be more paranoid when checking the default browser in Windows and return ↵mdm@chromium.org2009-11-251-3/+1
| | | | | | | | | | | | | | | "not default" rather than "can't tell" in most cases. Also undo previous fixes that worked around an incorrect return value; one of them (the infobar change) regresses the Linux version to display the infobar in cases where we would not be able to set ourselves as the default anyway (which was the original reason for the change that broke things on Windows). BUG=28429, 27403 TEST=(windows) install chrome but don't set it as the default during install, then restart it and verify that the infobar shows and chrome can still be set as the default TEST=(linux) run chrome in an unsupported desktop environment and verify that it neither displays the infobar asking to be made the default browser nor claims that it is the default browser in options Review URL: http://codereview.chromium.org/434022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33147 0039d316-1c4b-4281-b951-d872f2087c98
* Disables default browser check and exit menu for toolkit_views onsky@chromium.org2009-11-241-1/+1
| | | | | | | | | | | chromeos. BUG=none TEST=none Review URL: http://codereview.chromium.org/431029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32942 0039d316-1c4b-4281-b951-d872f2087c98
* Default browser checking on start-up was broken.jcampan@chromium.org2009-11-231-1/+3
| | | | | | | | | | | | ShellIntegration::IsDefaultBrowser() had been changed to return an enum instead of a bool. But the code in browser_init.cc calling it has not been updated. BUG=28429 TEST=Test that the default browser infobar is shown when Chrome is started and not the default browser. Review URL: http://codereview.chromium.org/426009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32825 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/379007 for Dave:sky@chromium.org2009-11-111-0/+10
| | | | | | | | | | | | Fixes leak in BackingStore as shown by valgrind. XFree doesn't free the data of the image, where as XDestroyImage does. BUG=none TEST=none Review URL: http://codereview.chromium.org/391008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31633 0039d316-1c4b-4281-b951-d872f2087c98
* Kiosk Mode implementation.mhm@chromium.org2009-11-091-0/+6
| | | | | | | | | | | | Kiosk mode will just hide the status bar and initially set it as full screen. Added some tests to add --kiosk mode as a command switch that tests if its in fullscreen state and doesn't have a status bubble. BUG=23145 TEST=Kiosk Mode functions and Run the ./ui_tests --gtest_filter=KioskModeTest.* Review URL: http://codereview.chromium.org/244003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31412 0039d316-1c4b-4281-b951-d872f2087c98
* Use GetSwitchValueASCII.tony@chromium.org2009-11-061-25/+24
| | | | | | | | | | | | BUG=24672 TEST=None Original patch by Thiago Farina <thiago.farina@gmail.com> at http://codereview.chromium.org/296004 Review URL: http://codereview.chromium.org/373013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31269 0039d316-1c4b-4281-b951-d872f2087c98
* Fifth patch in getting rid of caching MessageLoop pointers.jam@chromium.org2009-11-031-8/+9
| | | | | | | BUG=25354 Review URL: http://codereview.chromium.org/345037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30790 0039d316-1c4b-4281-b951-d872f2087c98
* Move chromeos code to namespace chromeos.chocobo@google.com2009-10-301-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/341044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30541 0039d316-1c4b-4281-b951-d872f2087c98
* Change the use-flip command line flag from wchar_t to charbrettw@chromium.org2009-10-271-1/+1
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/338038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30196 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some #includes where possible.pkasting@chromium.org2009-10-231-20/+3
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/335002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29915 0039d316-1c4b-4281-b951-d872f2087c98
* Expand the options for how FLIP runs. The GFE team needsmbelshe@google.com2009-10-211-1/+3
| | | | | | | | | | | | the ability to run a client with ssl & compression turned off. Update the command line to accomodate. BUG=none TEST=none Review URL: http://codereview.chromium.org/315006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29741 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore invalid urls on command line.estade@chromium.org2009-10-201-2/+4
| | | | | | | | | BUG=none TEST=chrome doesn't dcheck if you launch with a command line such as "chrome %U" Review URL: http://codereview.chromium.org/293010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29529 0039d316-1c4b-4281-b951-d872f2087c98
* Disables session restore on chrome os when running tests. This causessky@chromium.org2009-10-201-0/+10
| | | | | | | | | | | | problems with some tests as the nested message loop run by session restore gets prematurely exited and Chrome is left in a weird state. BUG=none TEST=none Review URL: http://codereview.chromium.org/294009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29515 0039d316-1c4b-4281-b951-d872f2087c98
* Add a command line switch to enable flip sockets.mbelshe@google.com2009-10-131-0/+5
| | | | | | | | | | | | With this change, flip code is now compiled and the limited unit tests actually run. BUG=none TEST=none Review URL: http://codereview.chromium.org/259064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28793 0039d316-1c4b-4281-b951-d872f2087c98
* linux: fix build error on gcc-4.4 on Ubuntucraig.schlenter@chromium.org2009-10-081-1/+1
| | | | | | | | Patch by Joel Stanley <joel@jms.id.au> Review URL: http://codereview.chromium.org/261021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28388 0039d316-1c4b-4281-b951-d872f2087c98
* Reland: HTML Pack Extension Dialog / Linux & Mac Packaging Support.rafaelw@chromium.org2009-10-081-10/+17
| | | | | | | | | | | | | | | | | | original issue: http://codereview.chromium.org/207062 The issue had to do with a symbol collison with the nss libraries (which are currently out-of-date) on the build bots. HTML Pack Extension Dialog. This removes the views implementation of the ExtensionPackDialog, and implements the dialog in html in the extensions_ui DOMUI. Additionally, support is added for packaging extensions via ---pack-extension on linux and mac BUG=20668, 20669 TBR=aa,wtc Review URL: http://codereview.chromium.org/265032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28365 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Reland: HTML Pack Extension Dialog / Linux & Mac Packaging Support. ↵rafaelw@chromium.org2009-10-071-17/+10
| | | | | | | | | | | | Part 1." This reverts commit c18585b4bd75664122be8af6ff1170cc5c6efc66. TBR=tc Review URL: http://codereview.chromium.org/270015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28331 0039d316-1c4b-4281-b951-d872f2087c98
* Reland: HTML Pack Extension Dialog / Linux & Mac Packaging Support. Part 1.rafaelw@chromium.org2009-10-071-10/+17
| | | | | | | | | | | | | | original issue: http://codereview.chromium.org/207062 Attempting to land this patch earlier resulted in compile failures on linux valgrind and linux perf that I was unable to reproduce. I am splitting this into two pieces. This piece adds extension packing support via --pack-extension for mac & linux. BUG=20668,20669 Review URL: http://codereview.chromium.org/266007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28325 0039d316-1c4b-4281-b951-d872f2087c98
* This reverts: HTML Pack Extension Dialog / Linux & Mac Packaging Support.rafaelw@chromium.org2009-10-071-17/+10
| | | | | | | | | | original issue: http://codereview.chromium.org/207062/ TBR=sky Review URL: http://codereview.chromium.org/270001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28234 0039d316-1c4b-4281-b951-d872f2087c98
* HTML Pack Extension Dialog. This removes the views implementation of the ↵rafaelw@chromium.org2009-10-071-10/+17
| | | | | | | | | | ExtensionPackDialog, and implements the dialog in html in the extensions_ui DOMUI. Additionally, support is added for packaging extensions via ---pack-extension on linux and mac Review URL: http://codereview.chromium.org/207062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28229 0039d316-1c4b-4281-b951-d872f2087c98
* Reenables showing crashed info bar on chrome os.sky@chromium.org2009-10-011-2/+1
| | | | | | | | | BUG=23502 TEST=none Review URL: http://codereview.chromium.org/249050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27698 0039d316-1c4b-4281-b951-d872f2087c98
* Makes Chrome on Chrome OS not restore the last session if the lastsky@chromium.org2009-09-231-1/+0
| | | | | | | | | | | | | session crashed. BUG=22835 TEST=On Chrome OS bring up Chrome, wait a few seconds, go to a terminal and kill Chrome, when Chrome comes up again you should see the crashed info bar. Review URL: http://codereview.chromium.org/220018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26999 0039d316-1c4b-4281-b951-d872f2087c98
* Retry of r26698.estade@chromium.org2009-09-211-24/+0
| | | | | | | | R=stuartmorgan Review URL: http://codereview.chromium.org/208047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26704 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r26698. Somehow this broke scons?estade@chromium.org2009-09-211-0/+24
| | | | | | | | TBR=stuartmorgan Review URL: http://codereview.chromium.org/217004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26699 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Remove linux splash page and printing command line switch.estade@chromium.org2009-09-211-24/+0
| | | | | | | | | BUG=22295 BUG=19911 Review URL: http://codereview.chromium.org/211036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26698 0039d316-1c4b-4281-b951-d872f2087c98
* <html>aa@chromium.org2009-09-211-11/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | <style type="text/css"> <!-- body { font-family: arial,sans-serif; background-color: #fff; margin-top: 2; } .c { width: 4; height: 4; } a:link { color: #00c; } a:visited { color: #551a8b; } a:active { color: #f00; } .form-noindent { background-color: #fff; border: 1px solid #c3d9ff; } --> </style> <style type="text/css"><!-- .gaia.le.lbl { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.le.fpwd { font-family: Arial, Helvetica, sans-serif; font-size: 70%; } .gaia.le.chusr { font-family: Arial, Helvetica, sans-serif; font-size: 70%; } .gaia.le.val { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.le.button { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.le.rem { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.captchahtml.desc { font-family: arial, sans-serif; font-size: smaller; } .gaia.captchahtml.cmt { font-family: arial, sans-serif; font-size: smaller; font-style: italic; } --></style> <head> <title>Google Accounts</title> <style type="text/css"><!-- body { font-family: arial, sans-serif; margin: 0; padding: 13px 15px 15px; } .body { margin: 0; } div.errorbox-good {} div.errorbox-bad {} div.errormsg { color: red; font-size: smaller; font-family: arial,sans-serif;} font.errormsg { color: red; font-size: smaller; font-family: arial,sans-serif;} div.topbar { font-size:smaller; margin-right: -5px; text-align:right; white-space:nowrap; } div.header { margin-bottom: 9px; margin-left: -2px; position:relative; zoom: 1 } div.header img.logo { border: 0; float:left; } div.header div.headercontent { float:right; margin-top:17px; } div.header:after{ content:"."; display:block; height:0; clear:both; visibility:hidden; } div.pagetitle { font-weight:bold; } .footer { color: #666; font-size: smaller; margin-top: 40px; text-align: center; } table#signupform { left: -5px; top: -7px; position:relative; } table#signupform td{ padding: 7px 5px; } table#signupform td table td{ padding: 1px; } hr { border: 0; background-color:#DDDDDD; height: 1px; width: 100%; text-align: left; margin: 5px; } --></style> </head> <body dir="ltr" onLoad= "gaia_setFocus();" > <div id="main"> <?sc # for new logo transition ?> <div class=header> <a href='https://www.google.com/accounts/'> <img class=logo src='https://www.google.com/intl/en/images/logos/accounts_logo.gif' alt="Google" /> </img> </a> </div> <div id=maincontent> <table border="0" width="100%" cellpadding=0 cellspacing=0> <tr> <td width="75%" valign="top"> <h3> Chromium Code Reviews uses Google Accounts for Sign In. </h3> <p><font size=-1> Google is not affiliated with the contents of <b>Chromium Code Reviews</b> or its owners. If you sign in, Google will share your email address with <b>Chromium Code Reviews</b>, but not your password or any other personal information. </font></p> <p><font size=-1> <b>Chromium Code Reviews</b> may use your email address to personalize your experience on their website. </font></p> </td> <td style="padding-left: 10px;" valign="top" align="center"> <div id="rhs"> <div id="rhs_login_signup_box"> <script><!-- function gaia_onLoginSubmit() { if (window.gaiacb_onLoginSubmit) { return gaiacb_onLoginSubmit(); } else { return true; } } function gaia_setFocus() { var f = null; if (document.getElementById) { f = document.getElementById("gaia_loginform"); } else if (window.gaia_loginform) { f = window.gaia_loginform; } if (f) { if (f.Email && (f.Email.value == null || f.Email.value == "")) { f.Email.focus(); } else if (f.Passwd) { f.Passwd.focus(); } } } --></script> <style type="text/css"><!-- div.errormsg { color: red; font-size: smaller; font-family:arial,sans-serif; } font.errormsg { color: red; font-size: smaller; font-family:arial,sans-serif; } --></style> <style type="text/css"><!-- .gaia.le.lbl { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.le.fpwd { font-family: Arial, Helvetica, sans-serif; font-size: 70%; } .gaia.le.chusr { font-family: Arial, Helvetica, sans-serif; font-size: 70%; } .gaia.le.val { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.le.button { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.le.rem { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.captchahtml.desc { font-family: arial, sans-serif; font-size: smaller; } .gaia.captchahtml.cmt { font-family: arial, sans-serif; font-size: smaller; font-style: italic; } --></style> <form id="gaia_loginform" action="https://www.google.com/accounts/ServiceLoginAuth?service=ah&amp;sig=d71ef8b8d6150b23958ad03b3bf546b7" method="post" onsubmit= "return(gaia_onLoginSubmit());" > <div id="gaia_loginbox"> <table class="form-noindent" cellspacing="3" cellpadding="5" width="100%" border="0"> <tr> <td valign="top" style="text-align:center" nowrap="nowrap" bgcolor="#e8eefa"> <input type="hidden" name="ltmpl" value="gm"> <div class="loginBox"> <table id="gaia_table" align="center" border="0" cellpadding="1" cellspacing="0"> <tr> <td colspan="2" align="center"> <font size="-1"> Sign in with your </font> <table> <tr> <td valign="top"> <img src="google_transparent.gif" alt="Google"> </img> </td> <td valign="middle"> <font size="+0"><b>Account</b></font> </td> </tr> </table> </td> </tr> <script type="text/javascript"><!-- function onPreCreateAccount() { return true; } function onPreLogin() { if (window["onlogin"] != null) { return onlogin(); } else { return true; } } --></script> <tr> <td colspan="2" align="center"> </td> </tr> <tr> <td nowrap="nowrap"> <div align="right"> <span class="gaia le lbl"> Email: </span> </div> </td> <td> <input type="hidden" name="continue" id="continue" value="http://codereview.chromium.org/_ah/login?continue=http://codereview.chromium.org/210007/description" /> <input type="hidden" name="service" id="service" value="ah" /> <input type="hidden" name="ltmpl" id="ltmpl" value="gm" /> <input type="hidden" name="ltmpl" id="ltmpl" value="gm" /> <input type="hidden" name="ahname" id="ahname" value="Chromium Code Reviews" /> <input type="hidden" name="GALX" value="LfA4LnZj1gM" /> <input type="text" name="Email" id="Email" size="18" value="" class='gaia le val' /> </td> </tr> <tr> <td></td> <td align="left"> </td> </tr> <tr> <td align="right" nowrap="nowrap"> <span class="gaia le lbl"> Password: </span> </td> <td> <input type="password" name="Passwd" id="Passwd" size="18" class="gaia le val" /> </td> </tr> <tr> <td> </td> <td align="left"> </td> </tr> <tr> <td align="right" valign="top"> <input type="checkbox" name="PersistentCookie" id="PersistentCookie" value="yes" checked='checked' /> <input type="hidden" name='rmShown' value="1" /> </td> <td> <label for="PersistentCookie" class="gaia le rem"> Stay signed in </label> </td> </tr> <tr> <td> </td> <td align="left"> <input type="submit" class="gaia le button" name="signIn" value="Sign in" /> </td> </tr> <tr id="ga-fprow"> <td colspan="2" height="33.0" class="gaia le fpwd" align="center" valign="bottom"> <a href="http://www.google.com/support/accounts/bin/answer.py?answer=48598&amp;hl=en&amp;ctx=ch_ServiceLogin&amp;p=ah&amp;fpUrl=https%3A%2F%2Fwww.google.com%2Faccounts%2FForgotPasswd%3FfpOnly%3D1%26continue%3Dhttp%253A%252F%252Fcodereview.chromium.org%252F_ah%252Flogin%253Fcontinue%253Dhttp%253A%252F%252Fcodereview.chromium.org%252F210007%252Fdescription%26service%3Dah%26ltmpl%3Dgm" target=_top> Can&#39;t access your account? </a> </td> </tr> </table> </div> </td> </tr> </table> </div> <input type="hidden" name="asts" id="asts" value=""> </form> <form id="gaia_universallogin" action="https://www.google.com/accounts/ServiceLoginAuth?service=ah&amp;sig=d71ef8b8d6150b23958ad03b3bf546b7" method="post" onsubmit="return(gaia_onLoginSubmit());"> <input type="hidden" name="continue" id="continue" value="http://codereview.chromium.org/_ah/login?continue=http://codereview.chromium.org/210007/description" /> <input type="hidden" name="service" id="service" value="ah" /> <input type="hidden" name="ltmpl" id="ltmpl" value="gm" /> <input type="hidden" name="ltmpl" id="ltmpl" value="gm" /> <input type="hidden" name="ahname" id="ahname" value="Chromium Code Reviews" /> <input type="hidden" name="ltmpl" id="ltmpl" value="gm" /> </form> <br/> <table class="form-noindent" border="0" cellpadding="6" cellspacing="3" width="100%"> <tr> <td bgcolor="#e8eefa" align="center" style="font-size:83%"> <b>Don't have a Google Account? </b><br/> <a href='https://www.google.com/accounts/NewAccount?continue=http%3A%2F%2Fcodereview.chromium.org%2F_ah%2Flogin%3Fcontinue%3Dhttp%3A%2F%2Fcodereview.chromium.org%2F210007%2Fdescription&amp;service=ah&amp;ltmpl=gm&amp;sig=909f6cca8e55250406f8bfbd303ab4a9' > <b>Create an account now</b> </a> </td> </tr> </table> </div> <br/> </div> </td> </tr> </table> </div> <div class="footer"> &copy;2009 Google - <a href='http://www.google.com/'>Google Home</a> - <a href='https://www.google.com/accounts/TOS?hl=en'>Terms of Service</a> - <a href='http://www.google.com/intl/en/privacy.html'>Privacy Policy</a> - <a href='http://www.google.com/support/accounts?hl=en'>Help</a> </div> </div> </body> </html> Review URL: http://codereview.chromium.org/210007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26685 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore remote requests to open tabs that would open external protocol handlers.mdm@chromium.org2009-09-171-0/+7
| | | | | | | | | BUG=21934 TEST=none Review URL: http://codereview.chromium.org/213003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26490 0039d316-1c4b-4281-b951-d872f2087c98
* posix: NOTIMPLEMENTED in --pack-extensionevan@chromium.org2009-09-131-0/+2
| | | | | | Review URL: http://codereview.chromium.org/194097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26088 0039d316-1c4b-4281-b951-d872f2087c98
* Don't do a default browser check when new tabs are opened via the command line.mdm@chromium.org2009-09-091-1/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/203001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25777 0039d316-1c4b-4281-b951-d872f2087c98
* Check in patch for pierre.lafayette, http://codereview.chromium.org/178059/show.mirandac@chromium.org2009-09-091-3/+3
| | | | | | Review URL: http://codereview.chromium.org/194057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25738 0039d316-1c4b-4281-b951-d872f2087c98
* Intercept HTTP requests for documents that GView is capable of displaying (suchdavemoore@chromium.org2009-09-041-0/+8
| | | | | | | | | | | as pdf) and redirect the user to the appropriate URL for viewing. Original patch by skrulx@gmail.com http://codereview.chromium.org/174016 Review URL: http://codereview.chromium.org/199019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25496 0039d316-1c4b-4281-b951-d872f2087c98
* Adding command-line option to override bans on certain port numbers through ↵mirandac@chromium.org2009-08-311-0/+7
| | | | | | | | | | a comma-separated list of ports. BUG= http://crbug.com/18307 TEST= url_request_unittest, use commandline flag allowed_ports=1,600. Navigate to http://www.google.com:1 or http://www.google.com:600. You should not get an ERR_UNSAFE_PORT, it will attempt to load the page. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24883 0039d316-1c4b-4281-b951-d872f2087c98
* Enable welcome page for non-windows platforms.estade@chromium.org2009-08-271-9/+1
| | | | | | | | | | Later we may wish to customize the welcome page per platform (particularly for chrome os) but for now it looks helpful enough to be worth showing on the first run. BUG=20327 Review URL: http://codereview.chromium.org/174551 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24575 0039d316-1c4b-4281-b951-d872f2087c98
* coverity: Make sure we have a profile before potentially adding the Crashed ↵jhawkins@chromium.org2009-08-211-2/+5
| | | | | | | | | | | infobar. CID=5723 BUG=none TEST=none Review URL: http://codereview.chromium.org/165494 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23981 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure we have a valid profile when usingavi@chromium.org2009-08-111-0/+8
| | | | | | | | | | | | | | BrowserInit::LaunchWithProfile::OpenURLsInBrowser() directly and the browser passed in is a popup window. Original Review URL: http://codereview.chromium.org/160331 BUG=http://crbug.com/17520 TEST=see bug. Review URL: http://codereview.chromium.org/164341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23077 0039d316-1c4b-4281-b951-d872f2087c98
* Resurrect toolkit_views build.ben@chromium.org2009-07-211-1/+1
| | | | | | Review URL: http://codereview.chromium.org/155797 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21132 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Linux startup crash.brettw@chromium.org2009-07-211-10/+12
| | | | | | | | | | | | | When there is no existing browser, this code will crash. It only works because of the Linux splash screen. Original review=http://codereview.chromium.org/155795 R=agl TEST=none Review URL: http://codereview.chromium.org/155822 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21131 0039d316-1c4b-4281-b951-d872f2087c98
* Make testers happy.estade@chromium.org2009-07-171-1/+2
| | | | | | | | | | | | | Only show linux splash page for new windows. May this be the end of this sad saga. TEST=if chrome is already running, `./out/Debug/chrome test.html` doesn't open splash page BUG=http://crbug.com/16893 Review URL: http://codereview.chromium.org/149780 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20925 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 18:13:43 +0000