| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/551066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
There used to be freezes in browser_tests and ui_tests on the trybots and buildbots, but I've tried the trybots many times and haven't seen this repro, so I'm going to try committing again.
This change is mostly a revert of r35192.
Review URL: http://codereview.chromium.org/546035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke mac valgrind for test_shell_tests. Various errors. I also missed fixing a bug that eroman pointed out in review. Total brainfart.
Histograms for the 4.0.266.0 dev channel release indicate the following changes for late binding:
(a) Net.TCPSocketType shows a decrease (from 41.85% to 39.29%) in used of newly connected sockets. Part of this decrease is due to using previously used sockets more often (increase from 58.15% to 58.53%), but is primarily due to being able to use sockets that were connected, but not immediately handed over to a socket request (increased from 0 [not supported without late binding] to 2.18%).
(b) Net.SocketIdleTimeBeforeNextUse_ReusedSocket indicates that reused sockets are getting used more quickly than before, with a decrease of mean idle time from 11.65 seconds to 11.34 seconds.
(c) Net.Transaction_Connected_Under_10 indicates shows that the mean for time until the first byte of the transaction response decreased from 1585ms to 1481ms.
The code change deletes the old non socket late binding code paths, cleaning up the code significantly. It also deletes duplicated tests in ClientSocketPoolBase which covered both pathways. A TCPClientSocketPool test had to be updated as well.
BUG=http://crbug.com/30354.
Review URL: http://codereview.chromium.org/543051
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/549047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Histograms for the 4.0.266.0 dev channel release indicate the following changes for late binding:
(a) Net.TCPSocketType shows a decrease (from 41.85% to 39.29%) in used of newly connected sockets. Part of this decrease is due to using previously used sockets more often (increase from 58.15% to 58.53%), but is primarily due to being able to use sockets that were connected, but not immediately handed over to a socket request (increased from 0 [not supported without late binding] to 2.18%).
(b) Net.SocketIdleTimeBeforeNextUse_ReusedSocket indicates that reused sockets are getting used more quickly than before, with a decrease of mean idle time from 11.65 seconds to 11.34 seconds.
(c) Net.Transaction_Connected_Under_10 indicates shows that the mean for time until the first byte of the transaction response decreased from 1585ms to 1481ms.
The code change deletes the old non socket late binding code paths, cleaning up the code significantly. It also deletes duplicated tests in ClientSocketPoolBase which covered both pathways. A TCPClientSocketPool test had to be updated as well.
BUG=http://crbug.com/30354.
Review URL: http://codereview.chromium.org/543051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r35991 due to a perf regression to New Tab Cold
on Mac.
TBR=thakis
Review URL: http://codereview.chromium.org/545024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the file exists. Otherwise, just load like normal on the UI thread.
This failed before because the browser may have shutdown before the
posted task ran. When the posted task finally runs, it tried to
use the profile, but the profile was already deleted. Make a small
change to VisitedLinkMaster so GetDatabaseFileName no longer depends
on the profile.
BUG=24163
Review URL: http://codereview.chromium.org/507047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This avoids retaining navigation history relating to the incognito window.
I piggy-back off of the dns prefetcher's OffTheRecordObserver to do this. In the future I hope to have a separate host resolver for off the record mode, so this won't be necessary.
BUG=24629
Review URL: http://codereview.chromium.org/523076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This change allows the chrome-login code to talk back to a privileged process and ask it to emit upstart signals and such. Eventually, this IPC will be changed to use DBus, probably when cryptohomed lands.
Review URL: http://codereview.chromium.org/518086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
and nonexistent addresses to custom pages, and plumb it to the code that puts up infobars when users type in a search that appears to be an intranet address, so we don't show these for erroneous cases.
BUG=31556
TEST=none
Review URL: http://codereview.chromium.org/525079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This matches some adjustments already made in the current stable release.
r=mbelshe
Review URL: http://codereview.chromium.org/525047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=30508
r=ananta
Review URL: http://codereview.chromium.org/502019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Take 2: Reenable TCMalloc on Linux and make POSIX signal handling async signal safe.
Reinstates r34096 and r34036, which were reverted by r34632 due to hanging ui_tests and browser_tests on bots.
I've been unable to repro on the trybots despite hitting them with a ton of try jobs, so I'm trying on the buildbots again.
BUG=http://crbug.com/30501
Review URL: http://codereview.chromium.org/505068
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/517001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
signal safe.
Reinstates r34096 and r34036, which were reverted by r34632 due to hanging ui_tests and browser_tests on bots.
I've been unable to repro on the trybots despite hitting them with a ton of try jobs, so I'm trying on the buildbots again.
BUG=http://crbug.com/30501
Review URL: http://codereview.chromium.org/505068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/502099
TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/504080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/502099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST= run the toast experiment and cancel it. Then look at the dr key on
HKEY_CURRENT_USER\Software\Google\Update\ClientState\{8A69D345-D564-463C-AFF1-A69D9E530F96}
should be "0"
BUG=30799
Review URL: http://codereview.chromium.org/502077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are ui_test crashes with this change.
This reverts commit r34874.
TBR=mirandac
Review URL: http://codereview.chromium.org/502063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Otherwise, just load like normal on the UI thread.
BUG=24163
Review URL: http://codereview.chromium.org/502005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Patch from Thiago Farina <thiago.farina@gmail.com>.
Review URL: http://codereview.chromium.org/498002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
handler changes.
Reverts:
r34036 - "Make POSIX SIGTERM/SIGINT/SIGHUP handler async signal safe."
r34096 - "Re-enable TCMalloc on Linux." This change depended on the posix signal handler change.
BUG=http://crbug.com/30501
Review URL: http://codereview.chromium.org/502017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
flags.
Renames --testing-fixed-server to --testing-fixed-host. Adds --testing-fixed-http-port and --testing-fixed-https-port.
Review URL: http://codereview.chromium.org/501032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=30144
TEST=none
Review URL: http://codereview.chromium.org/491056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Based on the crash dump, the crash
occurs when the external tab container is being destroyed which in turn takes down the automation provider
and the channel, etc. All this occurs in the context of OleUninitialize, which executes after BrowserMain
returns, i.e. the message loop is now invalid, thus causing a crash while attempting to post a task to it.
Based on this call stack it looks like it happens due to the enable-renderer-accessisibility flag.
Fix is to move the OleInitialize/OleUnitialize calls to Platform::WillInitializeMainMessageLoop and
Platform::DidEndMainMessageLoop. The Platform::DidEndMainMessageLoop function now executes as a task which
is posted to the message loop prior to quitting it. This would ensure that the cleanup happens correctly.
Fixes http://code.google.com/p/chromium/issues/detail?id=30383
Bug=30383
Review URL: http://codereview.chromium.org/501011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Old CL: http://codereview.chromium.org/449023
Review URL: http://codereview.chromium.org/488007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
callers of l10n_util::GetApplicationLocale to use this instead.
In the browser process, it's wrong to call
l10n_util::GetApplicationLocale with an empty string because then
it won't consider the user pref value when resolving the locale.
On Linux, it's also wrong to call l10n_util::GetApplicationLocale
after startup because the call touches disk and on Linux, we assume
that all of the program files can be deleted after startup (so
updates in place can work).
Review URL: http://codereview.chromium.org/476002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
do anything
Review URL: http://codereview.chromium.org/449023
TBR=cmasone@google.com
Review URL: http://codereview.chromium.org/467060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/449023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
For some reason I thought that nonjoinable threads would always delete their delegates. I was wrong.
BUG=http://crbug.com/29675
Review URL: http://codereview.chromium.org/460144
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/460154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
For some reason I thought that non-joinable threads would always delete their delegates. I was wrong.
BUG=http://crbug.com/29675
Review URL: http://codereview.chromium.org/460144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
* Don't use LOG/CHECK. Replace with RAW_LOG/DCHECK (newly added to logging.h)
* Don't directly post a task to the UI loop. Write to a magic pipe. Read this from a separate thread which will post to a task to the UI loop.
BUG=http://crbug.com/29240
Review URL: http://codereview.chromium.org/460094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This prevents console spew when ctrl+c closing works gracefully.
Review URL: http://codereview.chromium.org/462013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/458010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a case where my extension used the network; but because extensions are
initialized earlier than WinSock init, the extension failed when
trying to do a dns lookup. This only fails because it was in conjunction
with the --single-process flag, so it is unlikely to effect others.
Nonetheless, there is really no harm in moving winsock initialization
to be very early.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/454021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
is only read from the options dialog, the windows installer (a separate
process) and a spot in safe browsing. The only one that matters is
the safe browsing case.
BUG=28992
Review URL: http://codereview.chromium.org/456004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/384062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SystemMonitor makes an assumption that through its lifetime a MessageLoop exists and stays the same. It is difficult and error-prone to satisfy that when it is a Singleton. It has caused problems in the past.
Additionally, extract HighResoltionTimerManager out of time_win.cc, eliminating yet another Singleton.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/431008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=ctrl+c in debug mode doesn't cause a DCHECK failure.
Review URL: http://codereview.chromium.org/442018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/437049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28746
TEST=Ctrl+C = clean shutdown.
Review URL: http://codereview.chromium.org/432019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
process: grep for TODO(port), find cruft, clean it up
Review URL: http://codereview.chromium.org/427004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=28501
Review URL: http://codereview.chromium.org/435001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
r32311 fixes the cause of the crash, so enable WebSocket experiment again.
BUG=28096,27856
TEST=none
Review URL: http://codereview.chromium.org/399065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This removes the two-state purge/reset code (no longer necessary), and the hooks to the power monitor (not ready to turn those on without more work and testing).
BUG=23400
TEST=Run Chrome with --purge-memory-button, use it for awhile, open the Task Manager, and click "Purge Memory". You should still be able to use the program normally, and hopefully we dumped some memory out too (varies by usage).
Review URL: http://codereview.chromium.org/399028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There was a race to destroy histograms held by an instance within
WebSocketExperimentRunner, and this was causing the crash when
histograms were being recorded at shutdown.
See bug 28096 for re-enabling this feature.
BUG=27856
r=wtc,ukai
Review URL: http://codereview.chromium.org/404017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=24672
TEST=unit_tests
Patch by Thiago Farina <thiago.farina@gmail.com>.
Review URL: http://codereview.chromium.org/375016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome periodically reads the content of a well-know file,
and parses it into name-value pairs, each representing a
Chrome OS metrics event. The events are then logged using
the normal UMA mechanism. The file is then truncated to
zero size. Chrome uses flock() to synchronize accesses
to the file.
BUG=none
TEST=compiled and run Linux and Chrome OS versions.
Verified that uploaded Chrome OS events appear in about:histograms.
Also external_metrics_unittest.cc tests the collection of metrics
messages from the well-known file.
patch written by semenzato_google.com
original code review: http://codereview.chromium.org/378013
(plus http://codereview.chromium.org/346041)
Review URL: http://codereview.chromium.org/394010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
--test-load-libcros on the command line. The browser will exit immediately and
the error code (and error messages) will indicate success or failure.
I also renamed loaded() static functions related to loading this library. These
are not simple getters since they will actually load the library if its not
loaded yet. I renamed it to EnsureLoaded.
TEST=This is a test
BUG=none
Review URL: http://codereview.chromium.org/387014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/369002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=26614
Review URL: http://codereview.chromium.org/360035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This gives us one less file to load on startup. This does mean
that some tests need to explicitly include theme_resources.rc.
BUG=24035
Review URL: http://codereview.chromium.org/348033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30755 0039d316-1c4b-4281-b951-d872f2087c98
|