| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently we are parsing master preferences file three time on startup. Since we only return an int bit mask flag after parsing preferences, it can not handle any preference other than boolean and we end up reading it again for first run tabs and ping delay. This change refactors all the preferences parsing logic to directly pass around DictionaryValue object around in Chrome as well as installer.
No functional change but this will make adding a new preference for new icon more logical since we will not read the preferences file once again.
BUG=12701
TEST=Make sure all the distribution preferences still work as before.
Review URL: http://codereview.chromium.org/159539
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The MessageLoop had to be modified to support Dispatchers on Linux.
BUG=None
TEST=On Windows and Linux, make sure the accelerators still work as expected. On Linux toolkit views, build and run the unit-tests.
Review URL: http://codereview.chromium.org/159046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
supposed to be commited. Seems like git took all the temporary commits from the
base branch and uploaded them to svn.
Review URL: http://codereview.chromium.org/159736
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
gtk_util/gtk_tree_util.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160417
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160371
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
CL cleans this up.BUG=NoneTEST=Accelerator should work in Chrome and in the first run window.
Review URL: http://codereview.chromium.org/160301
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159512
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to get a handle on a number of browser crashes, this patch
adds an options for Google internal folks to upload full core files
when the browser crashes. The core files are uploaded to an internal
IP address and will be available to other developers.
This is only enabled for Chrome branded builds and then, only if
--google-internal-crash-reporting is given on the command line.
http://codereview.chromium.org/160212
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
50% of dev channel).
Review URL: http://codereview.chromium.org/159038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update the UI to not say tips or recommendations.
BUG=None
TEST=Starting chrome should not show any tips byt default
Review URL: http://codereview.chromium.org/160138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since it's common start Chrome from the command line, we should print
something to indicate that it's intentionally quitting immediately.
This is the source of a lot of bug reports.
BUG=12918
Review URL: http://codereview.chromium.org/155740
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
optimized for the way we do internationalization with JST before
and is about 4 times faster (average 4.8ms vs 22.8ms) for the history
page.
The syntax for this is very similar to JsTemplates. It uses the
attributes i18n-values and i18n-content which worls like jsvalues and
jscontent except that it does not allow arbitrary expressions.
BUG=None
TEST=All UI pages should work as before
Review URL: http://codereview.chromium.org/149420
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16599
TEST=previous session should restore + linux splash page
Review URL: http://codereview.chromium.org/149555
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This metadata request just returns a dummy string for the "metadata" scheme.
This doesn't do anything yet.
Review URL: http://codereview.chromium.org/149490
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG= none.
TEST= New NTP should come up with a default title in Tips and Suggestions box, then be loaded with actual data from popgadget.
Review URL: http://codereview.chromium.org/149255
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to be "view linux splash page".
Thus users can still use the home button until we get rid of the splash page.
BUG=16308
TEST=none.
Review URL: http://codereview.chromium.org/149481
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=16358
Review URL: http://codereview.chromium.org/149398
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is an active A/B experiment to test the impact of SDCH support.
This change correctly toggles support by simulating the command line
flag, rather than incorrectly avoiding initialization of the module.
BUG=16274
r=huanr
Review URL: http://codereview.chromium.org/155277
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Run UI. Also enable it for Chromium builds.
Review URL: http://codereview.chromium.org/149348
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
return true then false when later invoked.This caused a bug where we would show the info-bar warning that Chromium is not the default browser after the first run.This patch resurrects that code and changes the first run UI, as it was relying on that behavior.BUG=http://crbug.com/15833TEST=Make IE or Firefox your default browser. Open Chromium so it shows the 1st run UI. Unselect the "make chromium my default browser" button, then press start. When Chromium shows up, there should be no info-bar warning you Chromium is not your default browser. Also test that the first run UI still works as expected.
Review URL: http://codereview.chromium.org/155168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
project. This simplifies further refactoring and eases understanding of the printing part of Chrome.
Also renamed win_printing_context to printing_context_win (correct naming convention) and added stub implementations for _linux and mac.
Now all but one file is compiling on all platforms.
TEST=none (no functional change).
BUG=none
Review URL: http://codereview.chromium.org/149212
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=1953127
Review URL: http://codereview.chromium.org/149135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed the PRINTED_DOCUMENT_UPDATED notification and move the debug output from PrintJobManager to PrintedDocument.
Also made the --debug-print startup parameter only active in non-official builds.
BUG=none
TEST=Should have no functional affect.
Review URL: http://codereview.chromium.org/149148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/150171
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- During first run (confusing the newbie)
- In other special situations when we show UI before the main chrome window is created
BUG=14192
TEST=see bug
Review URL: http://codereview.chromium.org/151061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To do this, I needed to add the feature that ALL FieldTrials that are
established in the browser process are forwarded and established in
the corresponding renderer processes. This then allows both DNS impact,
as well as SDCH inmpact (and any other field tests) to be studied
at the same time in a single binary.
This checkin also establishes a pattern that when we're doing A/B tests
via a histogram such as RequestToFinish, that we produce names for
all groups, rather than leaving one group as the "default" or "empty postfix"
group. This is critical for naming various sub-groups when a multitude
of tests are taking place at the same time.
BUG=15479
r=mbelshe
Review URL: http://codereview.chromium.org/150087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I added another option in the DNS experiment: user 2 seconds or 500ms
for the congestion limit (that causes pre-resolutions to be discarded
from the queue.
The code in browser_main.cc was getting toooo large, so I pulled all
the experiment code into dns_global.cc.
BUG=15479
r=eroman
Review URL: http://codereview.chromium.org/147215
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
pages and tab-hosted pages from extensions.
BUG=none
TEST=load an extension that has a background page and verify that the process is created (see chrome://extensions)
Review URL: http://codereview.chromium.org/149091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Crash reporting broke on Linux when we enabled the zygote model a
couple of weeks ago.
We can't just add "zygote" to the check for the process type because
the crash signal fd is set at the same time and that will change when
a renderer is forked from the zygote.
This fixes it for now, but it will need to be redone when we enable
sandboxing.
http://codereview.chromium.org/147004
BUG=14969
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Adds read-write to the client key of google_update
- Adds the logic to track experiment outcome
- Some new geric exitc codes (non error codes)
BUG= b/1484308
TEST= see the bug
Review URL: http://codereview.chromium.org/132058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
and stores it in user prefs, where it can be used by the new tab page.
BUG = http://crbug.com/13363
Review URL: http://codereview.chromium.org/125052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Although it compiles in all builds etc., someone left the enabling code
ifdef'ed in browser main. This should enable SDCH on mac/linux.
To test, visit a site that supports SDCH (twice... the first time
you'll get the dictionary in the background), and then do a
view-cache:
in front of the resulting URL, and check to see that you're getting
Content-Encoding: sdch,gzip
If it is not sdch encoded, then with some tiny (1%) probability,
you're in a control group of a current experiment... and you can
try starting your browser again... and doing another two visits.
To better track the issue if you think you are in the control group,
you can also visit
about:histograms
and you should see that a dictionary was downloaded, and then
either some content was decoded, with timings in Sdch3.Experiment_Decode
or was not run in SDCH and was timed in Sdch3.Experiment_Holdback.
BUG=14516
r=willchan,pinkerton
Review URL: http://codereview.chromium.org/131025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/126295
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=10825
Review URL: http://codereview.chromium.org/118528
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/125031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Bump up the default fd limit on the Mac; stopgap fix for page cyclers, but something we want long-term to improve performance once we handle fd exhaustion with delays.
BUG=none
TEST=Launching with --file-descriptor-limit=20 should crash the renderer almost immediately.
Review URL: http://codereview.chromium.org/125151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome processes by name.
Reverting:
commit b60e93b5ccb3bf0eefbc5b15b74b5a8be30aa589
Author: deanm@chromium.org <deanm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Mon Jun 15 09:59:38 2009 +0000
Set process name on Linux
This uses PR_SET_NAME to set the process name. It was useful in looking at
memory numbers with the zygote patches. PR_SET_NAME is only avalaible in
kernels >= 2.6.9 according to the man page:
> PR_SET_NAME (since Linux 2.6.9)
> Set the process name for the calling process, using the value in
> the location pointed to by (char *) arg2. The name can be up to
> 16 bytes long, and should be null terminated if it contains
> fewer bytes.
shenki@moya ~/src/chromium/src :process-name
$ ps --forest
PID TTY TIME CMD
5581 pts/2 00:00:00 bash
9559 pts/2 00:00:02 \_ Chromium_Browse
9573 pts/2 00:00:00 | \_ Chromium_Render
9581 pts/2 00:00:02 | \_ Chromium_Render
9584 pts/2 00:00:00 | \_ Chromium_Render
Patch by Joel Stanley.
Review URL: http://codereview.chromium.org/118060
git-svn-id: svn://chrome-svn/chrome/trunk/src@18376 0039d316-1c4b-4281-b951-d872f2087c98
Review URL: http://codereview.chromium.org/126119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This uses PR_SET_NAME to set the process name. It was useful in looking at
memory numbers with the zygote patches. PR_SET_NAME is only avalaible in
kernels >= 2.6.9 according to the man page:
> PR_SET_NAME (since Linux 2.6.9)
> Set the process name for the calling process, using the value in
> the location pointed to by (char *) arg2. The name can be up to
> 16 bytes long, and should be null terminated if it contains
> fewer bytes.
shenki@moya ~/src/chromium/src :process-name
$ ps --forest
PID TTY TIME CMD
5581 pts/2 00:00:00 bash
9559 pts/2 00:00:02 \_ Chromium_Browse
9573 pts/2 00:00:00 | \_ Chromium_Render
9581 pts/2 00:00:02 | \_ Chromium_Render
9584 pts/2 00:00:00 | \_ Chromium_Render
Patch by Joel Stanley.
Review URL: http://codereview.chromium.org/118060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- remove unneeded header includes
- move implementation bits out of headers
- more explicit header deps
In my scan of headers I got up to (including) dom_ui.
Review URL: http://codereview.chromium.org/126071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Wire it to the cmdline param --try-chrome-again
- Set window bounds so it looks nice on Vista
- Enable the link to help center
BUG=b/1484308
TEST=see the bug
Review URL: http://codereview.chromium.org/126029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/chromium/wiki/LinuxSandboxIPC
Without filesystem access from the renderers, we need another way of
dealing with fontconfig and font loading.
This add support for:
* An "SBX_D" environment variable in the renderers which is used to
signal the end of dynamic linking so that the chroot can be
enforced.
* A sandbox_host process, running outside the sandbox, to deal with
fontconfig requests from the renderers. See the wiki page for
the reasoning behind making it a separate process.
* A new, custom SkFontHost for Skia. Because this is Chrome
specific, it will live outside the upstream Skia tree. This
FontHost can be configured either to drive fontconfig directly
(for the browser process and for any unsandboxed renderers) or to
use an IPC system. Since the same SkFontHost has to be linked into
both the browser and renderer (they are the same binary), this
switch has to be made at run time.
Sandbox IPC calls are rare (a couple of dozen at page load time) and
add about 50us of overhead for each call.
http://codereview.chromium.org/112074
BUG=8081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=6532
r=wtc
Review URL: http://codereview.chromium.org/115990
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Linux first run dialog should be properly styled?
Review URL: http://codereview.chromium.org/115890
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This replaces the current time based approach (chrome is given N seconds
to upload all renederer histograms) with an asynch callback approach
that waits until all renderers have responded (with their updates). It
uses a fall-back timer to ensure that a hung renderer won't delay things
forever as well.
This causes faster (and complete) updates in about:histograms as well
as generally assuring complete updates during UMA gatherings.
This code was contributed by Raman Tenneti in CL 42496
http://codereview.chromium.org/42496
bug=12850
r=raman
Review URL: http://codereview.chromium.org/113473
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This involves implementing GoogleUpdateSettings::[GS]etCollectStatsConsent, and a whole lot of refactoring.
BUG=none
TEST=delete config dir, run official Linux build, don't enable crash reporting, crash browser -> no crash reporting.
Review URL: http://codereview.chromium.org/115808
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The observer requires that message loop stays up and same through
its lifetime. This is not true during testing.
TEST=none
http://crbug.com/12187
Review URL: http://codereview.chromium.org/113824
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11971
Review URL: http://codereview.chromium.org/115722
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=11971
TEST=fresh install of Chrome should still bring up the first run dialog
Review URL: http://codereview.chromium.org/115689
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16783 0039d316-1c4b-4281-b951-d872f2087c98
|