| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
user logout, and during system restart and shutdown.
MainMenu.xib changes (because you're not expected to parse nibs yourself):
- The quit menu item's action is changed from the AppController object's
-quit: method (which no longer exists) to the application object's
-terminate: method (the Cocoa standard).
- The application and owner object types are changed from NSApplication to
CrApplication.
- The application menu name is changed from Chromium to
^IDS_SHORT_PRODUCT_NAME. Cocoa doesn't use this anyway, it gets replaced
at runtime with the localized value of CFBundleName, but we shouldn't have
branding-specific strings in our nibs.
BUG=18078
TEST=Use Chrome for a while, quit it from the Dock icon menu, and relaunch.
You should NOT see the "Google Chrome didn't shut down correctly" info bar.
Review URL: http://codereview.chromium.org/201121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=21731
TEST=Metrics data should have the correct values for breakpadregistrationok,
breakpadregistrationfail, debuggerpresent, and debuggernotpresent in
log.profile.stability.
Review URL: http://codereview.chromium.org/203050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Localize the menu bar titles.
Have the browser platform delegate startup the resource bundle system so we can fetch localization data.
Make l10n_util::GetApplicationLocale return what cocoa says for the language so we match what the UI is using.
TEST=everything still works.
BUG=17380
Review URL: http://codereview.chromium.org/164413
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
is gone.
BUG=8044
TEST=Dock icon still works properly
Review URL: http://codereview.chromium.org/165384
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://codereview.chromium.org/112044
chrome.gyp caught in a different CL but here is the relevant part of
the diff:
--- chrome.gyp (revision 16158)
+++ chrome.gyp (working copy)
@@ -2679,6 +2682,11 @@
],
'sources': [
'app/breakpad_mac_stubs.mm',
+ # *NO* files in chrome/app have unit tests (except keystone_glue)!!!
+ # It seems a waste to have an app_unittests target, so for now
+ # I add keystone_glue.m explicitly to this target.
+ 'app/keystone_glue.m',
+ 'app/keystone_glue_unittest.mm',
# All unittests in browser, common, and renderer.
'browser/autocomplete/autocomplete_unittest.cc',
'browser/autocomplete/autocomplete_popup_view_mac_unittest.mm',
Review URL: http://codereview.chromium.org/113613
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28279
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Call it from the Browser. (no-op if not packaged for branding).
Add new build target "app_packaging" to package (if possible).
(app_packaging target intentionally left out of "All").
For convenience, here is the app_packaging script embedded in the xcodeproj:
PACKAGER="${PROJECT_DIR}/tools/mac/package_chrome.sh"
if [ -f "${PACKAGER}" ]; then
"${PACKAGER}"
fi
Mark, I know this is not in gyp... I am happy to have this klobbered
and redo it (in gyp) at the appropriate time.
Review URL: http://codereview.chromium.org/27293
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- eliminates one #ifdef
- Did I mention is cleaner?
Review URL: http://codereview.chromium.org/21331
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
initialization code.
Review URL: http://codereview.chromium.org/13295
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6627 0039d316-1c4b-4281-b951-d872f2087c98
|