summaryrefslogtreecommitdiffstats
path: root/chrome/browser/browser_main_win.cc
Commit message (Collapse)AuthorAgeFilesLines
* Add a histogram to record time elapsed before we start the browser message loop.siggi@chromium.org2011-04-151-0/+15
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6853023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81775 0039d316-1c4b-4281-b951-d872f2087c98
* first-run: Pull IsBrowserAlreadyRunning() out of upgrade_util_win.h.tfarina@chromium.org2011-04-151-2/+2
| | | | | | | | | | | | | | This concept is not specific to upgrade path and thus shouldn't belong there. Move it to a new header file called browser_util_win.h as it's more appropriate. BUG=79203 TEST=None R=jhawkins@chromium.org Review URL: http://codereview.chromium.org/6861001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81691 0039d316-1c4b-4281-b951-d872f2087c98
* first-run: Eliminate the ifdefs in upgrade_util.htfarina@chromium.org2011-04-141-1/+1
| | | | | | | | | | | BUG=79203 TEST=None R=jhawkins@chromium.org Review URL: http://codereview.chromium.org/6853022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81659 0039d316-1c4b-4281-b951-d872f2087c98
* Move crypto files out of base, to a top level directory.rvargas@google.com2011-04-141-2/+2
| | | | | | | | | | | | | src/crypto is now an independent project that contains our cryptographic primitives (except md5 and sha1). This removes the base dependency from nss, openssl and sqlite. BUG=76996 TEST=none Review URL: http://codereview.chromium.org/6805019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81611 0039d316-1c4b-4281-b951-d872f2087c98
* first-run: Reland refactor of Upgrade class into upgrade_util API.tfarina@chromium.org2011-04-131-2/+2
| | | | | | | | | | | | | This fix linux_chromeos build by adding an appropriate #ifdef on upgrade_util_linux.cc. BUG=79203 TEST=None TBR=jhawkins@chromium.org Review URL: http://codereview.chromium.org/6839021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81431 0039d316-1c4b-4281-b951-d872f2087c98
* Broke ARM compile.siggi@chromium.org2011-04-131-2/+2
| | | | | | | | Revert 81409 - first-run: Refactor Upgrade class into a common upgrade_util API.BUG=79203TEST=NoneR=jhawkins@chromium.orgReview URL: http://codereview.chromium.org/6840003 TBR=tfarina@chromium.org Review URL: http://codereview.chromium.org/6835022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81412 0039d316-1c4b-4281-b951-d872f2087c98
* first-run: Refactor Upgrade class into a common upgrade_util API.tfarina@chromium.org2011-04-131-2/+2
| | | | | | | | | | | BUG=79203 TEST=None R=jhawkins@chromium.org Review URL: http://codereview.chromium.org/6840003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81409 0039d316-1c4b-4281-b951-d872f2087c98
* first-run: Refactor Upgrade class.tfarina@chromium.org2011-04-121-0/+1
| | | | | | | | | | | | | | | - Split Upgrade class implementation per platform files outside of first_run implementations. - Move TryChromeDialog class into its own header file. - Rename TryChromeDialog to TryChromeDialogView. BUG=None TEST=None R=jhawkins@chromium.org Review URL: http://codereview.chromium.org/6824029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81313 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Update a bunch of files to the new location of browser_list.h. Part ↵tfarina@chromium.org2011-04-061-2/+2
| | | | | | | | | | | | | 1/3. BUG=None TEST=None R=avi@chromium.org Review URL: http://codereview.chromium.org/6689029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80632 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-281-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Move the remaining files in chrome\common to content\common.jam@chromium.org2011-03-171-1/+1
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6672070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78516 0039d316-1c4b-4281-b951-d872f2087c98
* Add an exception wrapper to the WindowProc functions sorvargas@google.com2011-03-171-0/+18
| | | | | | | | | | | that we receive crash reports when something goes wrong. BUG=63702 TEST=base_unittests Review URL: http://codereview.chromium.org/6697004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78475 0039d316-1c4b-4281-b951-d872f2087c98
* Move some chrome\common code to content in preparation for moving chrome\gpu.jam@chromium.org2011-03-111-1/+1
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6686002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77868 0039d316-1c4b-4281-b951-d872f2087c98
* Move call to c_str() on temporary object to inside the function calljoi@chromium.org2011-03-031-2/+2
| | | | | | | | | | | | | where it's needed. Prior to this, at least with the CHROME_ALLOCATOR=winheap environment variable set, the pointer passed to kernel32!RegisterApplicationRestart could be invalid. BUG=70824 TEST=run debug build under full page heap on Windows with CHROME_ALLOCATOR=winheap Review URL: http://codereview.chromium.org/6602092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76744 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the workaround for bug 43461. Use a g_use_system_sslwtc@chromium.org2011-02-231-7/+6
| | | | | | | | | | | | | | boolean flag in DefaultClientSocketFactory::CreateSSLClientSocket. Based on rch's code in http://codereview.chromium.org/6487012. R=rch BUG=43461 TEST=no ChromeFrame test program build failures. Review URL: http://codereview.chromium.org/6561003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75791 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DCHECK and remove moot DECLSPEC_IMPORT.msw@chromium.org2011-02-201-4/+4
| | | | | | | | | | | | Rename RAR to RegisterApplicationRestartProc. Remove a stray comment. BUG=70824 TEST=none Review URL: http://codereview.chromium.org/6541046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75517 0039d316-1c4b-4281-b951-d872f2087c98
* Register Application Restart with Windows Restart Manager on browser_main ↵msw@chromium.org2011-02-201-2/+37
| | | | | | | | | | | | | startup for Windows Vista / Server 2008 and beyond. This launches Chrome and restores tabs if the computer is restarted as the result of an update. Use GetFunctionPointer/GetProcAddress to avoid XP link and run errors. Make changes to support necessary CommandLine operations. Other minor cleanup and refactoring. BUG=70824 TEST=Reboot from update or ::ExitWindowsEx(EWX_RESTARTAPPS... Chrome should restart and restore tabs on login. Test launching Chrome with a variety of command-line switches and arguments. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75405 Review URL: http://codereview.chromium.org/6462024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75516 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 75405 - Register Application Restart with Windows Restart Manager on ↵msw@chromium.org2011-02-181-20/+2
| | | | | | | | | | | | | | browser_main startup for Windows Vista / Server 2008 and beyond. This launches Chrome and restores tabs if the computer is restarted as the result of an update. Make changes to support necessary CommandLine operations. Other minor cleanup and refactoring. BUG=70824 TEST=Reboot from update or ::ExitWindowsEx(EWX_RESTARTAPPS... Chrome should restart and restore tabs on login. Test launching Chrome with a variety of command-line switches and arguments. Review URL: http://codereview.chromium.org/6462024 TBR=msw@chromium.org Review URL: http://codereview.chromium.org/6538059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75410 0039d316-1c4b-4281-b951-d872f2087c98
* Register Application Restart with Windows Restart Manager on browser_main ↵msw@chromium.org2011-02-181-2/+20
| | | | | | | | | | | startup for Windows Vista / Server 2008 and beyond. This launches Chrome and restores tabs if the computer is restarted as the result of an update. Make changes to support necessary CommandLine operations. Other minor cleanup and refactoring. BUG=70824 TEST=Reboot from update or ::ExitWindowsEx(EWX_RESTARTAPPS... Chrome should restart and restore tabs on login. Test launching Chrome with a variety of command-line switches and arguments. Review URL: http://codereview.chromium.org/6462024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75405 0039d316-1c4b-4281-b951-d872f2087c98
* Fix user-to-system-level installation delegation. This looks to have been ↵robertshield@chromium.org2011-02-111-3/+3
| | | | | | | | | | | | broken since r66096. BUG=72620 TEST=Install user level Chrome then system level Chrome. Observer that user level Chrome removes itself and delegates to system level. Review URL: http://codereview.chromium.org/6490008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74609 0039d316-1c4b-4281-b951-d872f2087c98
* Cross-platform CL to remove app/win/win_util.h&cc and related work.msw@chromium.org2011-02-031-6/+5
| | | | | | | | | | | | | | | | | | | | See Issue 70141 for the full move details; see my inline review comments. Changes significantly different from or beyond those prescribed by the bug: *Consolidated a lot of GrabWindowSnapshot code. *Moved EnsureRectIsVisibleInRect to views::internal namespace for test access. *Moved app/win/win_util_unittest.cc to views/window/window_win_unittest.h *Named ui/base/message_box_win.h instead of ui/base/message_box.h *Made WindowWin::GetWindowTitleFont static; needed in static contexts. *Denoted WindowWin::FrameTypeChanged as a Window override, moved code. *Moved TestGrabWindowSnapshot into new file: chrome/browser/ui/window_snapshot/window_snapshot_mac_unittest.mm BUG=70141 TEST=none Review URL: http://codereview.chromium.org/6386009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73589 0039d316-1c4b-4281-b951-d872f2087c98
* Move l10n_util to ui/baseben@chromium.org2011-01-211-2/+2
| | | | | | | | | BUG=none TEST=none TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72227 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the stubbed out headers in chrome/browser/views.msw@chromium.org2011-01-101-2/+2
| | | | | | | | | | | | | | | | | Update references to use headers in chrome/browser/ui/views. Update copyright dates in affected files. /chrome/browser/ui/views/constrained_html_delegate_win.cc Add space before 'private' label (presubmit warning) /chrome/browser/ui/views/toolbar_view.cc Add space before 'cleanup' label (presubmit warning) BUG=69082 TEST=Compiling... Review URL: http://codereview.chromium.org/6204002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70965 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from l10n_util. Part 5.avi@chromium.org2011-01-051-12/+12
| | | | | | | | | BUG=9911 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6023012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70530 0039d316-1c4b-4281-b951-d872f2087c98
* Move app/win_util to app/win and fix the namespace usage.brettw@google.com2010-12-311-5/+5
| | | | | | | | | | | | | | Split out the two classes: ScopedComInitializer and ScopedCOMem (which I renamed) to separate files. I removed the win_util_path file which had one function in it and moved the function to win_util. Somehow, this was getting picked up by the nacl64 build and the call in sandbox_policy was then not being defined. I just implemented the function in-plcae since it's just a simple wrapper around a Windows API call. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6013009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70343 0039d316-1c4b-4281-b951-d872f2087c98
* Installer cleanupamit@chromium.org2010-12-161-2/+1
| | | | | | | | | | | | | 1] Remove installer::version and use base::version in installer 2] Use file_util::FileEnumerator instead of calling FindFirstFile directly BUG=none TEST=covered by existing tests Review URL: http://codereview.chromium.org/5687004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69433 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 69167, itself a revert of 69165 - Merge the installer, installer_util ↵robertshield@chromium.org2010-12-151-2/+2
| | | | | | | | | | | | and setup_util namespaces into a single installer namespace. BUG=61609 TEST=NONE Review URL: http://codereview.chromium.org/5738009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69256 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 69196 - Revert 69190 - Revert 68827 - Use SChannel for Windows.willchan@chromium.org2010-12-151-4/+0
| | | | | | | | | | | | | | | | | | | | Test to see if this stops memory corruption crashes, will revert after a canary release. BUG=65948 TEST=none Review URL: http://codereview.chromium.org/5733003 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/5805005 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/5835001 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/5828002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69217 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 69190 - Revert 68827 - Use SChannel for Windows.willchan@chromium.org2010-12-141-0/+4
| | | | | | | | | | | | | | | | | Test to see if this stops memory corruption crashes, will revert after a canary release. BUG=65948 TEST=none Review URL: http://codereview.chromium.org/5733003 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/5805005 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/5835001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69196 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 68827 - Use SChannel for Windows.willchan@chromium.org2010-12-141-4/+0
| | | | | | | | | | | | | | Test to see if this stops memory corruption crashes, will revert after a canary release. BUG=65948 TEST=none Review URL: http://codereview.chromium.org/5733003 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/5805005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69190 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 69165 - Merge the installer, installer_util and setup_util namespaces ↵robertshield@chromium.org2010-12-141-2/+2
| | | | | | | | | | | | | | into a single installer namespace. BUG=61609 TEST=NONE Review URL: http://codereview.chromium.org/5729004 TBR=robertshield@chromium.org Review URL: http://codereview.chromium.org/5756007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69167 0039d316-1c4b-4281-b951-d872f2087c98
* Merge the installer, installer_util and setup_util namespaces into a single ↵robertshield@chromium.org2010-12-141-2/+2
| | | | | | | | | | | installer namespace. BUG=61609 TEST=NONE Review URL: http://codereview.chromium.org/5729004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69165 0039d316-1c4b-4281-b951-d872f2087c98
* Use SChannel for Windows.willchan@chromium.org2010-12-101-0/+4
| | | | | | | | | | | Test to see if this stops memory corruption crashes, will revert after a canary release. BUG=65948 TEST=none Review URL: http://codereview.chromium.org/5733003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68827 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the installer to support multi-install.tommi@chromium.org2010-12-011-9/+14
| | | | | | | | | | | | | | | | | | The installer now does its work based on distributions and target installation paths. Each distribution has exactly one target installation path but each installation path can have more than one distribution. In the absense of the --multi-install switch, the installer should continue to work as before. The biggest difference here is that we don't rely on a single global distribution object that controls the entire installation flow and we have a few classes for the new abstractions instead of global functions. It's far from perfect, but it's a step towards separating the core file package required for all distributions from the distributions themselves. Additionally, there are tons of little changes here such as consistant usage of FilePath and CommandLine instead of mixing them with std::wstring. TEST=Install, uninstall, upgrade, etc. Everything install related. BUG=61609 Review URL: http://codereview.chromium.org/5172011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67818 0039d316-1c4b-4281-b951-d872f2087c98
* windows: remove PathService::Get() that uses wstringsevan@chromium.org2010-11-301-2/+3
| | | | | | | | | | This just required fixing the remaining callers. BUG=24672 Review URL: http://codereview.chromium.org/5356008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67783 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup AdjustStringForLocaleDirection() to modify input parameter in place.jeremy@chromium.org2010-11-241-1/+1
| | | | | | | | | | | As described in the bug, the current behavior is confusing and bug-prone. BUG=47194 TEST=Check that there are no visible regressions in RTL and LTR language UIs on Linux & Windows. Review URL: http://codereview.chromium.org/5154009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67237 0039d316-1c4b-4281-b951-d872f2087c98
* The UI language rather than the locale is now used to pick Chrome's language ↵grt@chromium.org2010-11-161-0/+9
| | | | | | | | | | | | | | | on Windows. (Also fixed some unrelated lint errors.) With this change, l10n_util::GetApplicationLocale first checks for an override of the "configured locale" (in base::i18n) containing the list of preferred Windows UI languages. The browser triggers an override early in startup before the ApplicationLocale is determined. In effect, the browser no longer uses ICU on Windows for language detection. (This locale override mechanism is borrowed from the OS X port.) Changes in Chrome Frame are largely a refactor, as some Win32 code in there has been moved into base/win. Also cleaned up language selection in installer_util so that the proper language is chosen for the EULA, installer messages, and shortcuts. In so doing, replaced hand-crafted lists of supported languages with either auto-generated lists (static consts) or logic so that the addition of translations in the future doesn't require code motion (that being said, there may be reason to update the alias and/or wildcard tables in language_selector.cc). In so doing, this change unlocks Amharic, Farsi, and Swahili translations for installer messages and shortcuts. BUG=39986,40496,26470 TEST=New MUI/Win32 calls are tested in base/win/i18n_unittest.cc. To test the overall functionality, uninstall Chrome, remove intl.app_locale user pref, switch to a supported display language (via the "Keyboards and Languages" tab of Win7's "Regional and Language" control panel, and install with { "distribution": { "require_eula": true } } in master_preferences (via -installerdata arg to setup.exe). If all goes well, both EULA and outer frame are in the same language as Windows. Also, from gwilson: "Install system-level Chrome in audit mode on a new machine, then go through the out-of-box-experience, select a language, and the in -product EULA (triggered by "require_eula" : true) and Chrome's UI should be in the language that the user selected." Review URL: http://codereview.chromium.org/4139010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66275 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to reland http://codereview.chromium.org/4928002/tommi@chromium.org2010-11-151-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | For some reason the Win bot failed to compile the sandbox unit test. Trybots and my machines don't have these build problems, so I'm going to try again, unchanged. Original description: Changing the installer switches from wchar_t[] to char[]. Because of this I'm also refactoring some code that before was using wstring to build command lines by hand instead of using the CommandLine class. Now we use CommandLine. To get this to work correctly, I also needed to fix CommandLine::AppendArguments so I added a little test for it. TEST=There should be no changes in functionality. Run all installer tests. BUG=61609 TBR=robertshield Review URL: http://codereview.chromium.org/4989001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66096 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 66088 - Changing the installer switches from wchar_t[] to char[].tommi@chromium.org2010-11-151-6/+6
| | | | | | | | | | | | | | | | | | Because of this I'm also refactoring some code that before was using wstring to build command lines by hand instead of using the CommandLine class. Now we use CommandLine. To get this to work correctly, I also needed to fix CommandLine::AppendArguments so I added a little test for it. TEST=There should be no changes in functionality. Run all installer tests. BUG=61609 Review URL: http://codereview.chromium.org/4928002 TBR=tommi@chromium.org Review URL: http://codereview.chromium.org/4988001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66089 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the installer switches from wchar_t[] to char[].tommi@chromium.org2010-11-141-6/+6
| | | | | | | | | | | | | | | Because of this I'm also refactoring some code that before was using wstring to build command lines by hand instead of using the CommandLine class. Now we use CommandLine. To get this to work correctly, I also needed to fix CommandLine::AppendArguments so I added a little test for it. TEST=There should be no changes in functionality. Run all installer tests. BUG=61609 Review URL: http://codereview.chromium.org/4928002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66088 0039d316-1c4b-4281-b951-d872f2087c98
* Convert LOG(INFO) to VLOG(1) - misc. chrome/browser/*.pkasting@chromium.org2010-10-211-4/+4
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4008001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63421 0039d316-1c4b-4281-b951-d872f2087c98
* Move windows version-related stuff out of base/win_util and into ↵brettw@chromium.org2010-10-151-5/+5
| | | | | | | | | | | | | | base/win/windows_version. Many files now only need to include this instead of all of win_util. Remove a bunch of unused code from base/win_util. There was a surprising amount. Replace the AppUserModel property key with the one from the SDK now that we use the Win7 SDK. Move GetLogonSessionOnlyDACL from win_util to ipc since it's only used in that one place. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62694 0039d316-1c4b-4281-b951-d872f2087c98
* Sigh... in fixing the crash message for RTL, I broke LTR, due to ↵pkasting@chromium.org2010-08-171-3/+3
| | | | | | | | | | AdjustStringForLocaleDirection() having stupid behavior. BUG=none TEST=Crashing in LTR mode produces a dialog box that isn't empty Review URL: http://codereview.chromium.org/3195002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56431 0039d316-1c4b-4281-b951-d872f2087c98
* Noticed when I crashed while running in RTL mode that the crash string had ↵pkasting@chromium.org2010-08-141-11/+11
| | | | | | | | | | its punctuation messed up. BUG=none TEST=Force a browser crash while running with --lang=he and look at the "Woah!" string in the popup Review URL: http://codereview.chromium.org/3187001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56115 0039d316-1c4b-4281-b951-d872f2087c98
* Use Environment::SetVar in more places.tfarina@chromium.org2010-08-131-6/+6
| | | | | | | | | | | | Make use of Environment::SetVar API to replace the calls to the Windows function SetEnvironmentVariable. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3076042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55993 0039d316-1c4b-4281-b951-d872f2087c98
* Add #include utf_string_conversions.h to all files that use ASCIIToWide andbrettw@chromium.org2010-08-031-0/+1
| | | | | | | | | | | | | | | ASCIIToUTF16. I removed string_util includes from a few places where it obviously wasn't needed. In a separate pass, I'm going to remove ASCIITo* from string_util, then I'm going to do an even later pass to find the unnecessary string_util.h includes and remove them. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3058027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54746 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded headers from app/ (part 2)thestig@chromium.org2010-07-311-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3066014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54437 0039d316-1c4b-4281-b951-d872f2087c98
* Move browser/first_run* into into a subdirectory.evan@chromium.org2010-07-291-1/+1
| | | | | | | | BUG=50548 Review URL: http://codereview.chromium.org/3043030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54226 0039d316-1c4b-4281-b951-d872f2087c98
* BrowserMain() refactoring, part 2.1.viettrungluu@chromium.org2010-07-291-0/+16
| | | | | | | | | | | | 1. Move InitializeSSL() into platform-specific files and eliminate #ifdef. 2. Add some instructions on how to add code to BrowserMain(). BUG=none TEST=everything still works Review URL: http://codereview.chromium.org/3073008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54098 0039d316-1c4b-4281-b951-d872f2087c98
* BrowserMain() refactoring, part 2.viettrungluu@chromium.org2010-07-271-5/+5
| | | | | | | | | | | | Add "MainMessageLoopStart()" and related platform methods to handle tasks directly tied to the start of the main message loop. BUG=none TEST=everything still works Review URL: http://codereview.chromium.org/2931007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53783 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-05-31 17:23:48 +0000