summaryrefslogtreecommitdiffstats
path: root/chrome/browser/browser_process_impl.h
Commit message (Collapse)AuthorAgeFilesLines
* Remove BrowserThread dependency from usb_service.reillyg2014-08-291-0/+5
| | | | | | | | | | | | | | | | | Instead of explicitly depending on specific browser threads the USB service can assume that it is instantiated on BrowserThread::FILE (or equivalent) and save a TaskRunner reference from this instantiation for later use when called from other threads. To reach BrowserThread::UI (required for DBus on Chrome OS) a reference to the appropriate TaskRunner must be provided when calling UsbService::GetInstance(). BUG= Review URL: https://codereview.chromium.org/507503002 Cr-Commit-Position: refs/heads/master@{#292546}
* Move more metrics classes to metrics namespace.asvitkine2014-08-261-2/+1
| | | | | | | | | BUG=374763 TBR=jam@chromium.org Review URL: https://codereview.chromium.org/502173002 Cr-Commit-Position: refs/heads/master@{#291994}
* Only build various flash/pnacl/ppapi code when they are enabled. (try 2)thestig2014-08-261-0/+3
| | | | | | Review URL: https://codereview.chromium.org/494993005 Cr-Commit-Position: refs/heads/master@{#291810}
* Revert of Only build various flash/pnacl/ppapi code when they are enabled. ↵rlarocque@chromium.org2014-08-211-3/+0
| | | | | | | | | | | | | | | | | | | | | (patchset #7 of https://codereview.chromium.org/471263003/) Reason for revert: Suspected of breaking the disable_nacl build. Original issue's description: > Only build various flash/pnacl/ppapi code when they are enabled. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291069 TBR=dyen@chromium.org,viettrungluu@chromium.org,thestig@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/492323002 Cr-Commit-Position: refs/heads/master@{#291112} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291112 0039d316-1c4b-4281-b951-d872f2087c98
* Only build various flash/pnacl/ppapi code when they are enabled.thestig@chromium.org2014-08-211-0/+3
| | | | | | | Review URL: https://codereview.chromium.org/471263003 Cr-Commit-Position: refs/heads/master@{#291069} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291069 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all the browser side extensions code from Android.thestig@chromium.org2014-08-081-1/+1
| | | | | | Review URL: https://codereview.chromium.org/434613003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288184 0039d316-1c4b-4281-b951-d872f2087c98
* ifdef extensions code in BrowserProcess, IOThread, and ChromeNetworkDelegate.thestig@chromium.org2014-07-191-4/+7
| | | | | | | | BUG=349436 Review URL: https://codereview.chromium.org/387003008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284312 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce plugin_metrics_provider_ usage in MetricsServiceblundell@chromium.org2014-06-061-2/+1
| | | | | | | | | | | | | | | | | | | This CL eliminates MetricsService's call to PluginMetricsProvider::RecordPluginChanges (replaced by a new API on MetricsProvider). It additionally adds a MetricsServicesManager::OnPluginLoadingError() API and has the plugin observer call that API rather than calling MetricsService directly. This change will enable easily moving MetricsService::LogPluginLoadingError() to ChromeMetricsServiceClient once the latter is the class that keeps a weak pointer to the plugin metrics provider. BUG=375776 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274403 Review URL: https://codereview.chromium.org/308433004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275404 0039d316-1c4b-4281-b951-d872f2087c98
* Add browser-global GCMDriverbartfab@chromium.org2014-06-051-0/+8
| | | | | | | | | | | | | | | | | | This CL adds a browser-global GCMDriver instance. This GCM connection can be used even if no session is in progress and no user is signed in. Since GCMDriverDesktop was originally meant to work for signed-in users only, it still depends on an IdentityProvider. The CL introduces a temporary DummyIdentityProvider to satisfy the dependency. This dummy class will be deleted when GCMDriver's dependency on IdentityProvider is removed. BUG=376746 TEST=Covered by GCMDriverTest.* unit tests Review URL: https://codereview.chromium.org/301973009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275134 0039d316-1c4b-4281-b951-d872f2087c98
* Componentize chrome/browser/network_timehashimoto@chromium.org2014-06-041-2/+2
| | | | | | | | | | | | Move chrome/browser/network_time to components/network_time network_time.h is removed as it's unused. BUG=371470 TEST=git cl try Review URL: https://codereview.chromium.org/296453005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274887 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Reduce plugin_metrics_provider_ usage in MetricsService ↵tzik@chromium.org2014-06-031-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/308433004/) Reason for revert: This CL seems to cause bot failure on CI: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/2745 Original issue's description: > Reduce plugin_metrics_provider_ usage in MetricsService > > This CL eliminates MetricsService's call to > PluginMetricsProvider::RecordPluginChanges (replaced by a new API on > MetricsProvider). It additionally adds a > MetricsServicesManager::OnPluginLoadingError() API and has the plugin observer > call that API rather than calling MetricsService directly. This change will > enable easily moving MetricsService::LogPluginLoadingError() to > ChromeMetricsServiceClient once the latter is the class that keeps a weak > pointer to the plugin metrics provider. > > BUG=375776 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274403 TBR=asvitkine@chromium.org,isherman@chromium.org,jochen@chromium.org,blundell@chromium.org NOTREECHECKS=true NOTRY=true BUG=375776 Review URL: https://codereview.chromium.org/314583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274418 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce plugin_metrics_provider_ usage in MetricsServiceblundell@chromium.org2014-06-031-2/+1
| | | | | | | | | | | | | | | | | This CL eliminates MetricsService's call to PluginMetricsProvider::RecordPluginChanges (replaced by a new API on MetricsProvider). It additionally adds a MetricsServicesManager::OnPluginLoadingError() API and has the plugin observer call that API rather than calling MetricsService directly. This change will enable easily moving MetricsService::LogPluginLoadingError() to ChromeMetricsServiceClient once the latter is the class that keeps a weak pointer to the plugin metrics provider. BUG=375776 Review URL: https://codereview.chromium.org/308433004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274403 0039d316-1c4b-4281-b951-d872f2087c98
* Merge NetworkTimeNotifier to NetworkTimeTrackerhashimoto@chromium.org2014-05-191-0/+3
| | | | | | | | | | | | | | | To remove dependencies to BrowserProcess and IOThread from NetworkTimeTracker. Remove NetworkTimeNotifier from IOThread, add NetworkTimeTracker to BrowserProcess instead. Change all users to use the NetworkTimeTracker instance owned by BrowserProcess. Since NetworkTimeTracker is living in the UI thread, there is no need to have multi-thread callback chain in NetowrkTimeTracker, the only exception is sync_backend_host_impl.cc who needs a callback which can be run on the IO thread. BUG=371470 TEST=git cl try Review URL: https://codereview.chromium.org/271853004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271389 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce a MetricsServicesManager class.asvitkine@chromium.org2014-05-091-7/+4
| | | | | | | | | | | | | | | This class now owns MetricsService, VariationsService and RapporService as well as MetricsStateManager. The motivation is to be able to pass MetricsStateManager to VariationsService (in a followup CL), so that it can be used for simulation. BUG=315807 Review URL: https://codereview.chromium.org/263093003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269144 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of bookmark prompt experimentyosin@chromium.org2014-05-021-4/+0
| | | | | | | | | | | | This patch removes code for bookmark prompt experiment introduced by https://codereview.chromium.org/11028114/ BUG=367923 TEST=n/a NOTRY=true Review URL: https://codereview.chromium.org/268633002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267811 0039d316-1c4b-4281-b951-d872f2087c98
* Remove automation code from browser process.jam@chromium.org2014-04-021-5/+0
| | | | | | | | | BUG=316203 R=avi@chromium.org Review URL: https://codereview.chromium.org/221453005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260995 0039d316-1c4b-4281-b951-d872f2087c98
* Move CommandLine to base namespace.brettw@chromium.org2014-03-171-2/+2
| | | | | | | | | | | | Fix all forward-declares and header files referencing CommandLine. This keeps a "using base::CommandLine" in the command line header file so that the rest of the source files can be changes in a follow-up. TBR=sky Review URL: https://codereview.chromium.org/196413016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257514 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: remove the --remote-debugging-frontend flag.pfeldman@chromium.org2014-03-121-2/+1
| | | | | | | | | R=jam@chromium.org, lushnikov@chromium.org, vsevik@chromium.org TBR=jam (a simple flag removal) Review URL: https://codereview.chromium.org/189233008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256433 0039d316-1c4b-4281-b951-d872f2087c98
* Implementation of Randomized Aggregatable Privacy-Preserving Ordinal ↵holte@chromium.org2014-02-211-0/+3
| | | | | | | | | | | | | Responses (RAPPORs). See the design doc at http://www.chromium.org/developers/design-documents/rappor BUG=328168 TBR=darin@chromium.org Review URL: https://codereview.chromium.org/49753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252492 0039d316-1c4b-4281-b951-d872f2087c98
* Make storage_monitor a componentthiago.santos@intel.com2014-02-171-4/+0
| | | | | | | | | | | | | | | | | Move storage_monitor to the components directory and: - Make the unit tests part of the components unit tests. - Update the include headers for both chrome and storage_monitor code. - Update the buildsystem dependencies and paths. - Update the DEPS files for both chrome and storage_monitor with the new restrictions. R=joi@chromium.org,thestig@chromium.org BUG= Review URL: https://codereview.chromium.org/152343005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251699 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Tabpose feature on mac, and supporting infrastructure (PaintAtSize)piman@chromium.org2014-02-141-5/+0
| | | | | | | | | | | | | | | | Tabpose has been behind a flag for 3 years, and UMA shows usage is very low. It is the unique user of the RenderWidgetSnapshotTaker, and the only user of RWH::PaintAtSize, which we want to remove. XIB changes: * Remove Tabpose menu entry "Show Tab Overview..." BUG=251960, 223336 R=cevans@chromium.org, jamesr@chromium.org, sky@chromium.org, viettrungluu@chromium.org Review URL: https://codereview.chromium.org/154083008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251439 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove some unused code, or make them platform specific.thestig@chromium.org2014-02-031-3/+0
| | | | | | | | Found by Scythe. Review URL: https://codereview.chromium.org/136113019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248465 0039d316-1c4b-4281-b951-d872f2087c98
* Split the BrowserPolicyConnector into platform parts.joaodasilva@chromium.org2014-01-211-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The BrowserPolicyConnector is the class that instantiates the rest of the policy code and wires it up to the rest of the browser (e.g. by overriding local state prefs at the BrowserProcessImpl). It also hosts some utilities and other central components. That class has grown over time and contains many platform-specific parts; it also had chrome-specific code that can't be used on iOS. This change breaks the class into 3 pieces: - the new BrowserPolicyConnector is the base class and lives in the component, so that an iOS subclass can be created in a subsequent CL. This is what g_browser_process holds now. - chrome/browser/policy contains ChromeBrowserPolicyConnector which overrides it and provides Chrome-specific initialization. - chrome/browser/chromeos/policy contains BrowserPolicyConnectorChromeOS which inherits from ChromeBrowserPolicyConnector and adds ChromeOS-specific components. ChromeBrowserPolicyConnector and the future BrowserPolicyConnectorIos only add configuration and no new methods, so the base class available from g_browser_process covers all current uses. BrowserPolicyConnectorChromeOS has methods that are needed on ChromeOS, and can now be obtained via g_browser_process->platform_parts()->browser_policy_connector_chromeos(). This CL doesn't make any functional changes; no behavior should be changed at all. BUG=275292 TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/141133003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246087 0039d316-1c4b-4281-b951-d872f2087c98
* Move component updater artifacts into component_updater namespace.sorin@chromium.org2014-01-171-4/+7
| | | | | | | | | | | | sky@ please look at the files in chrome/browser for owner approval. Long term, the idea is to unify several updaters in Chrome, so having a specific namespace could help avoiding name conflicts. Short term, the change reduces some naming verbosity in the implementation but makes the call site names longer, so it is a wash. Review URL: https://codereview.chromium.org/138553004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245596 0039d316-1c4b-4281-b951-d872f2087c98
* Make the "Consent To Send Stats" file follow the kMetricsReportingEnabled pref.joaodasilva@chromium.org2013-11-141-0/+1
| | | | | | | | | | | | | | | | | | The options UI updates the state of this file manually (besides setting the pref), but when the policy overrides the pref then the file should be updated to reflect the pref's value. On Windows a registry key is kept in sync with the pref instead of the consents file. After this fix it'll be possible to simply set the pref from the options UI, and to remove the ChromeOS-specific code (that reads from device settings). BUG=318761 Review URL: https://codereview.chromium.org/70233005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234979 0039d316-1c4b-4281-b951-d872f2087c98
* Move ExtensionsProcessManager to src/extensions, part 2jamescook@chromium.org2013-11-051-0/+5
| | | | | | | | | | | | | | * Move observation of NOTIFICATION_BROWSER_WINDOW_READY to Chrome * Remove remaining references to Profile * Tidy up ChromeTestSuiteInitializer BUG=313481 TEST=unit_tests and browser_tests ExtensionProcessManager* R=sky@chromium.org, yoz@chromium.org Review URL: https://codereview.chromium.org/56253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233011 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove chrome namespace for storage monitor and media galleries.thestig@chromium.org2013-09-131-6/+5
| | | | | | | | BUG=289619 Review URL: https://chromiumcodereview.appspot.com/23727009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222938 0039d316-1c4b-4281-b951-d872f2087c98
* Cmd+Q on an app window quits the app.jackhou@chromium.org2013-07-311-9/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | In applicationShouldTerminate, if the terminate was triggered by a keyboard event, and the currently focused window is a ShellWindow, then quit the app associated with that window and return NSTerminateCancel. An accessor for ExtensionAppShimHandler is added to BrowserProcessPlatFormPart to allow manipulating apps from anywhere. This will also be used for the Quit menu option for app menus. Cmd+Q behavior on a browser window remains mostly unchanged. The only difference is that Cmd+Q when there are no windows quits immediately, even if confirm-to-quit is enabled. Note that this does not affect termination due to OSX shutting down. Even if the shutdown is triggered by a keyboard shortcut (e.g. Ctrl+Cmd+Eject), the event type will be NSSystemDefined, so Chrome terminates as usual. BUG=168080,249059,227472 TEST=Start an app. Cmd+Q with one of the app's windows focused should quit the app. Quit Chrome and start an app using its shim. Cmd+Q on the app should quit the app and Chrome. TEST=Start an app. Ctrl+Cmd+Eject with the app window focused to shut down OSX. Chrome should terminate cleanly. Review URL: https://chromiumcodereview.appspot.com/17448007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214672 0039d316-1c4b-4281-b951-d872f2087c98
* [StorageMonitor] Move StorageMonitor ownership to BrowserProcessImplgbillock@chromium.org2013-07-191-0/+6
| | | | | | | | | | | This preserves all gross timings of setup and teardown of the storage monitor. BUG=None Review URL: https://chromiumcodereview.appspot.com/16703025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212487 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of time headers in chrome/browser/, part 1.avi@chromium.org2013-06-281-1/+1
| | | | | | | | | | BUG=254986 TEST=none TBR=ben@chromium.org Review URL: https://codereview.chromium.org/18083008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209145 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show a "new background extension" warning when reinstalling an ↵petewil@chromium.org2013-06-281-0/+2
| | | | | | | | | | | | | existing extension Currently, we show a notification bubble whenever we upgrade or reload an extension. This change checks to see if an extension is in the process of being reloaded or upgraded before showing the notice. BUG=157464 Review URL: https://chromiumcodereview.appspot.com/13587004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209075 0039d316-1c4b-4281-b951-d872f2087c98
* DisabledScheme policy existed before we had URLBlacklist. csorba@chromium.org2013-06-061-1/+0
| | | | | | | | | | | | Using URLBlacklist we can block complete schemes, so we translate the DisabledSchemes policy to URLBlacklist. URLBlacklist did not handle some schemes before (e.g.: chrome, file) which are now added to the URLBlacklistManager. BUG=111489, 128735 Review URL: https://chromiumcodereview.appspot.com/16305008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204630 0039d316-1c4b-4281-b951-d872f2087c98
* Implementing uploading of a WebRTC diagnostic log.grunell@chromium.org2013-06-031-0/+8
| | | | | | | | | | | | BUG=229829 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203700 R=agl@chromium.org, joi@chromium.org, sky@chromium.org, tommi@chromium.org, vabr@chromium.org, wtc@chromium.org Review URL: https://codereview.chromium.org/14329020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203711 0039d316-1c4b-4281-b951-d872f2087c98
* Revert http://crrev/203700 - "Implementing uploading of a WebRTC diagnostic ↵mnissler@chromium.org2013-06-031-8/+0
| | | | | | | | | | | | | | | | | | | log." This reverts commit 731c1368a3d9780b031894988ca68fd9a904c853. ../../chrome/browser/media/webrtc_logging_handler_host.cc: In member function 'void WebRtcLoggingHandlerHost::OpenLogIfAllowed()': ../../chrome/browser/media/webrtc_logging_handler_host.cc:73:error: 'chromeos::CrosSettings' has not been declared ../../chrome/browser/media/webrtc_logging_handler_host.cc:73:error: 'kStatsReportingPref' is not a member of 'chromeos' http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/54135/steps/compile/logs/stdio#error1 BUG=None TBR=grunell@chromium.org Review URL: https://codereview.chromium.org/15714007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203701 0039d316-1c4b-4281-b951-d872f2087c98
* Implementing uploading of a WebRTC diagnostic log.grunell@chromium.org2013-06-031-0/+8
| | | | | | | | BUG=229829 Review URL: https://chromiumcodereview.appspot.com/14329020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203700 0039d316-1c4b-4281-b951-d872f2087c98
* Remove reference to profile in devtools remote debugging initialization.tengs@chromium.org2013-05-251-1/+0
| | | | | | | | | | | | Use GetLastUsedProfile instead, so we can get the user profile after logging in on CrOS. BUG=242354 TEST=run_tests on CrOS Review URL: https://chromiumcodereview.appspot.com/15305014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202240 0039d316-1c4b-4281-b951-d872f2087c98
* Move winaura specific methods and members from ↵gab@chromium.org2013-05-171-17/+0
| | | | | | | | | | | | | | | | | | | chrome/browser/browser_process.h to chrome/browser/browser_process_platform_part_winaura.h Precursor CL to https://codereview.chromium.org/14576015/ BUG=235648, 232842, 179830 Originally Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200576 Reverted: http://crrev.com/200656 The cause of the issue is that the current paradigm is such that you can still include the header from the base class although the base class is ruled out in gyp... this resulted in a Heap Corruption debug check when deleting the TestingBrowserProcessPlatformPart on WinAura since it would take its definition from browser_process_platform_part.h at compile time, but use the impl from browser_process_platform_part_aurawin.h at runtime... This paradigm is being fixed in https://codereview.chromium.org/14951007/ and thus simply #ifdefing the right definition in testing_browser_process_platform_part.h for now is fine. Review URL: https://chromiumcodereview.appspot.com/14698027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200926 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 200576 "Move winaura specific methods and members from ch..."rouslan@chromium.org2013-05-161-0/+17
| | | | | | | | | | | | | | | | | | | This is a speculative revert to address all interactive_ui_tests and browser_tests timing out on win_aura. > Move winaura specific methods and members from chrome/browser/browser_process.h to chrome/browser/browser_process_platform_part_winaura.h > > Precursor CL to https://codereview.chromium.org/14576015/ > > BUG=235648, 232842, 179830 > > Review URL: https://chromiumcodereview.appspot.com/14698027 TBR=gab@chromium.org Review URL: https://codereview.chromium.org/14828010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200656 0039d316-1c4b-4281-b951-d872f2087c98
* Move winaura specific methods and members from ↵gab@chromium.org2013-05-161-17/+0
| | | | | | | | | | | | chrome/browser/browser_process.h to chrome/browser/browser_process_platform_part_winaura.h Precursor CL to https://codereview.chromium.org/14576015/ BUG=235648, 232842, 179830 Review URL: https://chromiumcodereview.appspot.com/14698027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200576 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ENABLE_MESSAGE_CENTERdimich@chromium.org2013-05-141-2/+0
| | | | | | | | | | | | | | | | | | Next step on re-factoring Notifications. This will bring the MessageCenter classes, most important message_center::Notification, into build on all systems, including those where the MessageCenter is not yet appearign in UI. This will allow to start using this Notification class in client code and remove the old Notification class defined in chrome/browser/notificaitons/notification.h That will allow the clients that already use Rich Notifications to use richer data type support, for example supply an image bits for a Notification (as in Snapshot notifications). This also removes a lot of compile-time @ifdefs and replaces them with checking a runtime flag which we already have anyways. On Android and iOS, the MessageCenter is not compiled in, for the size concerns and uncertain story for notifications in general - the existing ENABLE_NOTIFICATIONS define is used for that. BUG=174164 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199625 Review URL: https://chromiumcodereview.appspot.com/15025002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199920 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 199625 "Remove ENABLE_MESSAGE_CENTER"thakis@chromium.org2013-05-121-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Caused a static initializer on Linux: # message_center_constants.cc __i686.get_pc_thunk.cx (Not on Mac though. The SkGetColor() macro has a comment about it not adding a static initializer on release builds, so maybe it's the float-int-multiplication? I don't have a linux box around to check, sorry.) > Remove ENABLE_MESSAGE_CENTER > > Next step on re-factoring Notifications. This will bring the MessageCenter classes, most important message_center::Notification, into build on all systems, including those where the MessageCenter is not yet appearign in UI. This will allow to start using this Notification class in client code and remove the old Notification class defined in chrome/browser/notificaitons/notification.h > > That will allow the clients that already use Rich Notifications to use richer data type support, for example supply an image bits for a Notification (as in Snapshot notifications). > > This also removes a lot of compile-time @ifdefs and replaces them with checking a runtime flag which we already have anyways. > > On Android and iOS, the MessageCenter is not compiled in, for the size concerns and uncertain story for notifications in general - the existing ENABLE_NOTIFICATIONS define is used for that. > > BUG=174164 > > Review URL: https://chromiumcodereview.appspot.com/15025002 TBR=dimich@chromium.org Review URL: https://codereview.chromium.org/14631021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199639 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ENABLE_MESSAGE_CENTERdimich@chromium.org2013-05-111-2/+0
| | | | | | | | | | | | | | | | Next step on re-factoring Notifications. This will bring the MessageCenter classes, most important message_center::Notification, into build on all systems, including those where the MessageCenter is not yet appearign in UI. This will allow to start using this Notification class in client code and remove the old Notification class defined in chrome/browser/notificaitons/notification.h That will allow the clients that already use Rich Notifications to use richer data type support, for example supply an image bits for a Notification (as in Snapshot notifications). This also removes a lot of compile-time @ifdefs and replaces them with checking a runtime flag which we already have anyways. On Android and iOS, the MessageCenter is not compiled in, for the size concerns and uncertain story for notifications in general - the existing ENABLE_NOTIFICATIONS define is used for that. BUG=174164 Review URL: https://chromiumcodereview.appspot.com/15025002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199625 0039d316-1c4b-4281-b951-d872f2087c98
* Create instance of ProfileHelper that will track active user instance on ↵nkostylev@chromium.org2013-04-251-9/+3
| | | | | | | | | | | | | Chrome OS. Upcoming CL: ProfileHelper will provide mapping from user_id to Profile. BUG=180903 TEST=Signing in with multiple users work with --multi-profiles Review URL: https://codereview.chromium.org/14403013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196482 0039d316-1c4b-4281-b951-d872f2087c98
* Launching ASH on Windows 8 should activate an existing instance if one exits.ananta@chromium.org2013-04-241-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | The current behavior when there is an existing instance of ASH is that the launch fails taking down the existing instance of ASH. This is because metro app launches go through the delegate execute handler which first tries to launch the metro viewer process (browser). If we have an existing browser process which has an active MetroViewerProcessHost instance, we delete it first and recreate it. This takes down the existing ASH instance and attempts to launch the new one fail, because of a race condition in the metro startup code. Fix is to create a new instance of the MetroViewerProcessHost instance only if one does not exist in the BrowserProcessImpl::PerformInitForWindowsAura function which is invoked when a brower process processes a launch command line. We reset the MetroViewerProcessHost instance when we receive an OnChannelError notification in the MetroViewerProcessHost class. It in turn invokes the virtual function OnMetroViewerProcessTerminated added on the BrowserProcess interface with a windows aura specific implementation in the browser_process_impl_win.cc file. BUG=234429 R=cpu Review URL: https://codereview.chromium.org/13973023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196254 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude media galleries from android chrome.tommycli@chromium.org2013-04-241-1/+1
| | | | | | | | | | Android can no longer include media_galleries, as the MediaMountPointProvider and other fileapi mechanisms have now been moved to chrome/. android_webview cannot include anything from chrome/. BUG=175936 Review URL: https://chromiumcodereview.appspot.com/14305008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195994 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on component updater on chromeos, only for the pnacl component.jvoung@google.com2013-04-091-3/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make the pnacl component place files in a profile-specific directory for chromeos. We don't want to share data between users on chromeos because of questions about integrity of these files. This adds a notification watcher and will re-register pnacl with a different version whenever the user logs into a different account. Files are installed to a stateful partition, which should be okay. The stateful partition is mounted no-exec, but the pnacl files are not typical executables. This is a temporary solution to help with testing out PNaCl on chromeos. We will need to find a different solution later that does not involve multiple copies, one for each user. BUG=221381 TEST= manual with: 1) export GYP_DEFINES="chromeos=1" 2) build 3) out/Release/chrome --enable-pnacl --enable-nacl --user-data-dir=/tmp/temp_profile_chromeos --login-profile=user --login-manager 4) wait 20 seconds and see /tmp/temp_profile_chromeos/test-user/pnacl/0.0.0.5 show up Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192415 Review URL: https://codereview.chromium.org/13071002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192969 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 192415 "Turn on component updater on chromeos, only for t..."alexeypa@google.com2013-04-051-6/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This seemed to break Chromium OS (x86) ASAN: http://build.chromium.org/p/chromium.memory/builders/Chromium%20OS%20%28x86%29%20ASAN/builds/3552 ==26271== ERROR: AddressSanitizer: SEGV on unknown address 0x00000000 (pc 0x66dd8299 sp 0x7f8d7040 bp 0x7f8d7588 T0) AddressSanitizer can not provide additional info. #0 0x66dd8298 in (anonymous namespace)::FinishPnaclUpdateRegistration(ComponentUpdateService*, Version const&, PnaclComponentInstaller*) chrome/browser/component_updater/pnacl/pnacl_component_installer.cc:0 #1 0x66dd9a5b in base::internal::Invoker<3, base::internal::BindState<base::internal::RunnableAdapter<void (*)(ComponentUpdateService*, Version const&, PnaclComponentInstaller*)>, void ()(ComponentUpdateService*, Version const&, PnaclComponentInstaller*), void ()(ComponentUpdateService*, Version, PnaclComponentInstaller*)>, void ()(ComponentUpdateService*, Version const&, PnaclComponentInstaller*)>::Run(base::internal::BindStateBase*) ???:0 #2 0x673626c4 in base::MessageLoop::RunTask(base::PendingTask const&) ???:0 #3 0x67362ec1 in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask const&) ???:0 #4 0x67363df6 in base::MessageLoop::DoWork() ???:0 > Turn on component updater on chromeos, only for the pnacl component. > > Make the pnacl component place files in a profile-specific directory > for chromeos. We don't want to share data between users on > chromeos because of questions about integrity of these files. > This adds a notification watcher and will re-register pnacl with > a different version whenever the user logs into > a different account. > > Files are installed to a stateful partition, which should > be okay. The stateful partition is mounted no-exec, but > the pnacl files are not typical executables. > > This is a temporary solution to help with testing out PNaCl on chromeos. > We will need to find a different solution later that does > not involve multiple copies, one for each user. > > BUG=221381 > TEST= manual with: > > 1) export GYP_DEFINES="chromeos=1" > 2) build > 3) out/Release/chrome --enable-pnacl --enable-nacl --user-data-dir=/tmp/temp_profile_chromeos > 4) wait 20 seconds and see /tmp/temp_profile_chromeos/test-user/pnacl/0.0.0.5 show up > > Review URL: https://codereview.chromium.org/13071002 TBR=jvoung@google.com Review URL: https://codereview.chromium.org/13510006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192435 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on component updater on chromeos, only for the pnacl component.jvoung@google.com2013-04-041-3/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make the pnacl component place files in a profile-specific directory for chromeos. We don't want to share data between users on chromeos because of questions about integrity of these files. This adds a notification watcher and will re-register pnacl with a different version whenever the user logs into a different account. Files are installed to a stateful partition, which should be okay. The stateful partition is mounted no-exec, but the pnacl files are not typical executables. This is a temporary solution to help with testing out PNaCl on chromeos. We will need to find a different solution later that does not involve multiple copies, one for each user. BUG=221381 TEST= manual with: 1) export GYP_DEFINES="chromeos=1" 2) build 3) out/Release/chrome --enable-pnacl --enable-nacl --user-data-dir=/tmp/temp_profile_chromeos 4) wait 20 seconds and see /tmp/temp_profile_chromeos/test-user/pnacl/0.0.0.5 show up Review URL: https://codereview.chromium.org/13071002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192415 0039d316-1c4b-4281-b951-d872f2087c98
* Show user data dialog earlier on Windows.hshi@chromium.org2013-03-271-0/+1
| | | | | | | | | | | | | | | On Windows if the user data directory does not exist, we must show the user data dir picker dialog prior to creating the local state to avoid a CHECK failure. After obtaining the new dir we will restart chrome with the switch --user-data-dir appended to the command line. BUG=196301 TEST=CQ Review URL: https://chromiumcodereview.appspot.com/12662033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190833 0039d316-1c4b-4281-b951-d872f2087c98
* base/prefs: Remove the public/ directory and move the files to //base/prefs.tfarina@chromium.org2013-03-211-1/+1
| | | | | | | | | | BUG=155525 R=joi@chromium.org TBR=darin@chromium.org Review URL: https://codereview.chromium.org/12789006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189513 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-22 19:52:51 +0000