| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the initial landing of a component extension to handle file open, save-as, and file management user interfaces. This is just the basic plumbing, minus any useful functionality.
I've tested this by building with...
$ export GYP_DEFINES='file_manager_extension=1'
$ make chrome -j16
Then launch the result and visit chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/main.html, and verify that the <h1> tab is blue, and the document contains "Hello World".
BUG=chromium-os:11988
TEST=
Review URL: http://codereview.chromium.org/6588053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=73796
TEST=compile and start chrome and view about:gpu page fine
TBR=vangelis@chromium.org
Review URL: http://codereview.chromium.org/6581011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Creates a new internal page for listing recent reported crashes, to make it easier for users to report crashes, or get crash IDs when asked in bug reports.
Won't yet display any crashes on Windows, since the breakpad side is not yet done on Windows.
BUG=41106
TEST=Visit chrome://crashes; depending on the build type, platform, and metric pref state, it should display crashes or an informative message.
Review URL: http://codereview.chromium.org/6545001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Improved reconnection logic after OTASP - we still get number of transient activation failures there that got reported as 'connectivity' error (see http://crosbug.com/9361 for details)
* Added [Close] button to error page.
* Removed ':' from connection error message.
BUG=chromium-os:10335,chromium-os:9361,chromium-os:10282
TEST=make sure close button shows when there is a payment page below error div
Review URL: http://codereview.chromium.org/6250122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:11527
TEST=manual
Review URL: http://codereview.chromium.org/6312089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:11454
TEST=make sure marketing message shows up on chrome:mobilesetup page again
Review URL: http://codereview.chromium.org/6349041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://code.google.com/p/chromium-os/issues/detail?id=6923
TEST=manual
Review URL: http://codereview.chromium.org/5758002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72238
Review URL: http://codereview.chromium.org/6254007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Builder to fail.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6254007
TBR=chaitanyag@chromium.org
Review URL: http://codereview.chromium.org/6275015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
to view it with Adobe Reader if it's installed. If it's not, ask them if they want to launch the url to install it. If it's installed and out of date, show an interstitial.
BUG=65339
Review URL: http://codereview.chromium.org/6259008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6254007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
alongside the rest of the resources (and interstitials).
Review URL: http://codereview.chromium.org/6326007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Write chrome://sync-internals DOMUI page which is like about:sync but
automatically updates on sync events.
Make about:sync{,-internals} aliases for chrome://sync-internals.
More diagnostic capabilities will be added to chrome://sync-internals
in future CLs.
BUG=69500
TEST=Manual
Review URL: http://codereview.chromium.org/6299002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=67218
TEST=None
Review URL: http://codereview.chromium.org/6094013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
require a passphrase the first time.
BUG=63014,58935
TEST=test
Review URL: http://codereview.chromium.org/5563004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Add gaia_login.html and setup_flow_error.html resources.
2. Add SetupFlowErrorStepBase for errors.
3. More flexible message handling.
4. Support for multiple message handlers in ServiceProcessControl.
BUG=67218
TEST=Unittests.
Review URL: http://codereview.chromium.org/6064006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Generalize tabswitcherview slightly so it doesn't rely on div naming to
obtain its styling.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5228004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(os, device, driver) configuration is on the blacklist.
BUG=58182
TEST=unittest
Review URL: http://codereview.chromium.org/5612002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
into options.js.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5617006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the beginning of the implementation of the infrastructure to support a DOMui based login screen. The login page that is in this is not meant to be a final version. The authentication currently does not actually use libcros, but instead is stubbed. I have uploaded this to get some review before proceeded with the authentication and hooking this into the system.
The login page is reached in the browser from chrome://login.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4457003
Patch from Ryan Harrison <rharrison@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
New UI to setup the proxy in Chrome. This UI passed review. New features
include a friendlier layout, a Learn More link, and a Print Test Page button on
the success page. This does not yet bring the UI out from behind a flag; that
will be a separate CL.
BUG=60092
TEST=CloudPrintURLTest.CheckDefaultURLs
Review URL: http://codereview.chromium.org/5285001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use special text for Guest Session instead of using standard text for
Incognito mode. Also changes icon and link which are shown.
BUG=chromium-os:6907
TEST=Enter Guest mode, open new tab. Check opened page.
Review URL: http://codereview.chromium.org/4186009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Make sure invalid manual proxy changes can be changed to valid;
- Disable single proxy when manual proxy is not checked;
- Clearing manual settings take effect;
Kuan fixed the backend and I fixed the DOMUI.
BUG=chromium-os:8703, chromium-os:8683, chromium-os:8710
TEST=Verify per bug report.
Review URL: http://codereview.chromium.org/4580001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I originally added this in r60123 but over time it turned out that being a regular installed app will work out better.
BUG=none
TEST=chat manager should no longer be a component extension on Chrome OS builds
Review URL: http://codereview.chromium.org/4652002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
process.
BUG=http://crbug.com/51105, http://crbug.com/57239
TEST=Unit tests included.
Review URL: http://codereview.chromium.org/4524002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add path validation for SaveAs dialog in FileBrowse DOMUI;
- Add a UserCrosSettingsProvider instance to ExistingUserController.
This triggers cached settings refresh on login screen and protect us from
setting spoofing.
BUG=chromium-os:7738
TEST=Verify user could not save file outside default download dir andoverify that spoofed settings will be reverted on login screen show up.
Review URL: http://codereview.chromium.org/4181008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add a URL chrome://keyboardoverlay/ for keyboard overlay.
BUG=chromium-os:6268
TEST=manually on the net book
Review URL: http://codereview.chromium.org/4226001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of using standard text form Incognito mode.
BUG=chromium-os:6907
TEST=Enter Guest mode, open new tab. Check opened page.
Review URL: http://codereview.chromium.org/4010004
TBR=altimofeev@chromium.org
Review URL: http://codereview.chromium.org/4215005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Incognito mode.
BUG=chromium-os:6907
TEST=Enter Guest mode, open new tab. Check opened page.
Review URL: http://codereview.chromium.org/4010004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I first created (http://codereview.chromium.org/3582018). I deleted that issue accidentally :( So I will copy all the comments from that issue to here (I still have that browser window open fortunately)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3977001
Patch from Varun Jain <varunjain@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
login, with a different UI container that is built on the new tab-modal constrained html dialogs.
Hooked it up to the webstore extensions api with the desired behavior of turning on apps sync after a successful webstore login.
BUG=56383
TEST=manual only for now
Review URL: http://codereview.chromium.org/4033001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Added a css spinner for connecting status;
- Top align the network type icons;
- Fix a problem that the error logo is not loaded if theme source is not
setup.
- Change NetworkMenuItem that action area could be toggled and sendConnect
when the action area is hidden;
- Ignore clicks on controls inside NetworkMenuItem so that we don't
accidentally collapse and sendConnect;
BUG=none.
TEST=none.
Review URL: http://codereview.chromium.org/3816006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Update network UI to make it closer to mocks;
- Update menu.css to use default cursor;
- Allow derived menu UI pass localized strings;
BUG=chromium-os:7343
TEST=none.
Review URL: http://codereview.chromium.org/3771003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Rename labs.html to flags.html, use the new images.
BUG=59139
TEST=Go to about:flags. Notice new icons.
Review URL: http://codereview.chromium.org/3801005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:7301
TEST=manual
Review URL: http://codereview.chromium.org/3787001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Implement the network menu as a subclass of MenuUI (c++) and Menu (js).
BUG=chromium-os:7343
TEST=Test that the network menu is still functional. NOTE: With this CL, the menu won't look pretty, and it still has the old behavior. There will be a followup CL that will fix the UI.
Review URL: http://codereview.chromium.org/3675002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
-Tabbed version of configure page which offers both data type selection and passphrase selection
-New passphrase page which doubles for creation and entry.
-New common loading page which contains the spinny.
-Backend changes.
BUG=48706
Review URL: http://codereview.chromium.org/3655004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add WrenchMenu class that implements zoom/edit commands.
* changed toolkit_view to use domui menu.
* Add accelerator support.
* allow subclass to have its own css.
this also addresses comments on
* removed clearTimeout
* move init code to decorate as much as possible
* changed init:config to setter
* use 'hidden' rule to hide it, instead of not adding it.
* I didn't change addHandler as now target and menuitem does not necessary the same.
BUG=6497
TEST=
Review URL: http://codereview.chromium.org/3601021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the component extension system, simply install them as
normal apps the first time Chrome runs. Remove the old
style default apps.
This also removes support for --disable-apps, which doesn't
seem necessary since we already have --disable-extensions.
BUG=53972
TEST=Uninstall any installed apps. Remove the
"default_apps_installed" and "app_promo_counter" keys from
Preferences if they are present.
Start Chrome with the --enable-default-apps flag, navigate
to chrome://extensions/, and click "update now" in the
developer tools. This is to make the updater grab the
apps from the store quicker, so that you don't have to wait
while testing. Normally Chrome would do this by itself
after 5-40 mins.
Go to NTP. You should see gmail, calendar, and docs default
apps show up along with the promo (the text that says "New!
A world of ...").
Refresh the NTP 10 times. The promo should go away on the
10th time.
There are other details. To test each of these, remove all
installed apps and remove the keys from the preferences to
reset the state.
* If you close Chrome before getting the default apps. They
should still show up the next time Chrome is started (after
clicking 'Update now')
* Clicking "hide this message" should hide the promo and it
shouldn't come back on refresh.
* Installing or uninstalling any app should hide the promo,
and it shouldn't come back.
* If the keys from the preferences are removed, but apps
are left installed, the default apps should not be
installed when clicking 'update now'.
* The default apps should only be installed in locale
en-US.
Review URL: http://codereview.chromium.org/3522015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3569021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Changed the way to pass DataSource from subclass. CreateDataSource was called in the constructor, so virtual function does not work. Moved to constructor argument.
* extra JS source has to be embedded.
* removed unnecessary padding-left
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3595019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:6590
TEST=none
Review URL: http://codereview.chromium.org/3556012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A few key design points.
* Uses DOMView to render menu content.
* MenuUI (subclass of DOMUI) uses GtkWiget tree to access
WidgetGtk and MenuModel. Alternative way was to change
TabContents::GetDOMUIForCurrentState() public and pass them throught it, but this seems to work fine.
* Input/Focus is controlled by gtk_grab_add. Input is grabbed by the root widget, and then sent to each active menu widget via gtk_grab_add.
* Menu gets shown after the renderer rendered the content
(thus has some size) to avoid showing small/empty menu.
Mouse processing is blocked until the menu is shown (see Dispatcher).
A few issues that will be addressed in separate CL
* RTL (will be after beta)
* menu scroll. working on it now.
* menu sometimes show scroll bar. (I just need to disable it)
* unit test for native_menu_domui
BUG=chromiun-os:6497
TEST=manual for now. all menu2 based meus should work as before (web pages's context menu, system menu, forward/back menu and several chromeos specific one) except for following two:
* mnemonic should work now on context menus.
* menu larger than screen does not scroll. I'll implement this in separate CL
Review URL: http://codereview.chromium.org/3442018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=173
TEST=none
Review URL: http://codereview.chromium.org/3516010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:7091
TEST=verify on device
Review URL: http://codereview.chromium.org/3462019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:6868
TEST=none
Review URL: http://codereview.chromium.org/3448018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
to access a download that no longer exists.
Review URL: http://codereview.chromium.org/2844040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
setting.
BUG=56429
TEST=unit_tests --gtest_filter=ExtensionsServiceTest.*
Review URL: http://codereview.chromium.org/3120029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change does not add support for displaying the keyboard. That will be provided (along with a more useful keyboard) in follow-up changes.
BUG=none
TEST=added new override test
Review URL: http://codereview.chromium.org/3362019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
fix the bug where the wrench disappears on hover.
BUG=53248,52199
Review URL: http://codereview.chromium.org/3236001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57799 0039d316-1c4b-4281-b951-d872f2087c98
|