summaryrefslogtreecommitdiffstats
path: root/chrome/browser/browser_uitest.cc
Commit message (Collapse)AuthorAgeFilesLines
* Move:ben@chromium.org2010-12-021-385/+0
| | | | | | | | | | | | | | | | | | | | tab_menu_model->ui/tabs tab_contents_wrapper->ui/tab_contents view_ids.h->ui status_bubble.h->ui options*->ui/options show_options_url*->ui/options location_bar*->ui/omnibox input_window*->ui browser_uitests->ui/tests BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/5582002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68047 0039d316-1c4b-4281-b951-d872f2087c98
* Remove FLAKY from BrowserTest.PosixSessionEndcmasone@chromium.org2010-11-231-2/+1
| | | | | | | | | | | | | Pursuant to the discussion in the bug, this test fails under valgrind not because it is flaky, but because the valgrind helper makes it so that we cant SIGTERM the browser. BUG=39500 TEST=run browser tests; this test should run and pass. Run browser tests under valgrind; this test should not run. Review URL: http://codereview.chromium.org/5243004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67136 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Include browser.h -> ui/browser.h [Part 4].jhawkins@chromium.org2010-11-171-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5104002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66401 0039d316-1c4b-4281-b951-d872f2087c98
* Split out command IDs from chrome_dll_resource.h.evan@chromium.org2010-11-081-1/+1
| | | | | | | | | | | | The name of this file is a leftover from Windows. Split the command ids (which are used on all platforms) out, leaving just the Windows-specific resource IDs in the original file. TEST=compiles Review URL: http://codereview.chromium.org/4710001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65453 0039d316-1c4b-4281-b951-d872f2087c98
* Fix BrowserTest.OtherRedirectsDontForkProcess to not hard-code port 1337.skerner@chromium.org2010-10-261-5/+10
| | | | | | | | | BUG=None TEST=BrowserTest.OtherRedirectsDontForkProcess Review URL: http://codereview.chromium.org/4088001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63892 0039d316-1c4b-4281-b951-d872f2087c98
* Test server cleanup patch of death:phajdan.jr@chromium.org2010-08-171-7/+8
| | | | | | | | | | | | | | - reduce the number of different classes - clean up the internal code - modify the interface to expose less internal details (this will allow more flexibility with port numbers) TEST=many BUG=49680 Review URL: http://codereview.chromium.org/3080029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56405 0039d316-1c4b-4281-b951-d872f2087c98
* fixup for style nitsatwilson@chromium.org2010-08-111-2/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55668 0039d316-1c4b-4281-b951-d872f2087c98
* Added support for --no-startup-window flag to launch chrome with no startup ↵atwilson@chromium.org2010-08-111-0/+25
| | | | | | window git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55666 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated CommandLine API.evan@chromium.org2010-07-301-2/+1
| | | | | | | | | Cleaned up the final few callers, punting the remaining harder ones to TODOs. Review URL: http://codereview.chromium.org/3043033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54400 0039d316-1c4b-4281-b951-d872f2087c98
* CommandLine: add a CopySwitchesFrom() and AppendSwitchPath()evan@chromium.org2010-07-291-2/+1
| | | | | | | | | | | These are two common patterns in Chrome code: copying a subset of switches from one CommandLine to another, and appending a FilePath to a CommandLine. This sets me up to do a lot more deprecation in a follow-up change. Review URL: http://codereview.chromium.org/3012021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54218 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Move more test server code from net/url_request/url_request_unittest.hphajdan.jr@chromium.org2010-07-291-2/+5
| | | | | | | | | | | | | to net/test/test_server.h No code changes, just a move. TEST=none BUG=49680 Review URL: http://codereview.chromium.org/3034038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54201 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: test server cleanup:phajdan.jr@chromium.org2010-07-231-4/+2
| | | | | | | | | | | | | - simplify the public interface - remove unneeded methods - make it easier to understand TEST=none BUG=49680 Review URL: http://codereview.chromium.org/2881028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53509 0039d316-1c4b-4281-b951-d872f2087c98
* Moved code that generates APP_TERMINATING notification into BrowserList so ↵atwilson@chromium.org2010-07-201-0/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | it can be used on all platforms. Updated observers (ExtensionProcessManager, BackgroundContents) to listen for APP_TERMINATING instead of listening for BROWSER_CLOSED on some platforms. APP_TERMINATING is now sent just before the main message loop exits rather than just after, but no code depends on this timing. Updated Mac code to always call BrowserList::CloseAllBrowsers() even if there are no open browsers, to ensure that APP_TERMINATING is always fired. Changed BackgroundContentsService to keep the browser process alive when there are BackgroundContents running and updated the unit tests. Renamed BrowserList::IsInPersistentMode() => WillShutdownWhenLastBrowserCloses() and AllBrowsersClosed() => AllBrowsersClosedAndAppExiting() to more precisely indicate their true functions. Exposed BrowserProcess::ModuleRefCount() so BrowserList can determine when the application is going to exit so the right notifications/callbacks can be generated. Updated background-auto-update-restart code to use new BrowserList APIs to determine whether the application is running "in the background". Added code to cancel shutdown on all plaforms if the user selects cancel in an onbeforeunload dialog. BUG=45275 TEST=RunInBackgroundTest (ui_test) Review URL: http://codereview.chromium.org/2866034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53092 0039d316-1c4b-4281-b951-d872f2087c98
* Add a simple UI test for --app mode.scherkus@chromium.org2010-06-291-1/+28
| | | | | | | | | | | The --app browser launch code path was previously untested, which resulted in us shipping a release where it was broken. BUG=47544 TEST=ui_tests Review URL: http://codereview.chromium.org/2847032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51100 0039d316-1c4b-4281-b951-d872f2087c98
* Changing linux platform for chromeos. This involved moving platform_util ↵dhg@chromium.org2010-04-291-1/+1
| | | | | | | | | | and extension_error_reporter to browser, so that the UIs surrounding them can be in the browser. BUG=none TEST=none Review URL: http://codereview.chromium.org/1705009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45986 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Tests cleanup:phajdan.jr@chromium.org2010-04-081-3/+3
| | | | | | | | | | | | | | - use timeouts correctly - use more automation methods to make test code more clear - use more reliable ways of waiting - remove unnecessary automation calls TEST=none BUG=none Review URL: http://codereview.chromium.org/1553016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43932 0039d316-1c4b-4281-b951-d872f2087c98
* Mark OtherRedirectsDontForkProcess as FLAKY because it crashed at leastdmazzoni@chromium.org2010-04-021-1/+2
| | | | | | | | | | | | twice this morning - revisions 43472 and 43474. BUG=32799 TEST=greenify the tree TBR=rohitrao Review URL: http://codereview.chromium.org/1574011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43489 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Unify polling interval in some of the polling functionsphajdan.jr@chromium.org2010-03-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | in the UI test framework: - WaitUntilCookieValue - WaitUntilCookieNonEmpty - WaitUntilJavaScriptCondition This helps reduce number of arbitrary "magic timeouts" which are different in each test. We don't remove the test timeout parameter, because it varies depending on test case, and for now we don't have a better solution. Trying a "naive" way leads to hangs on flaky tests. TEST=UI-based tests BUG=none Review URL: http://codereview.chromium.org/1557001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43062 0039d316-1c4b-4281-b951-d872f2087c98
* Marking the PosixSessionEnd test as flaky..ananta@chromium.org2010-03-261-1/+2
| | | | | | | | | Bug=39500 TBR=phajdan.jr Review URL: http://codereview.chromium.org/1422003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42795 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Various ui tests cleanups:phajdan.jr@chromium.org2010-03-261-55/+4
| | | | | | | | | | | | | | | | - unify timeout handling - remove unneccessary assertions that clutter the code They were mostly there because earlier the automation framework was less reliable. Now the same checks (or equivalent) are always done in the framework itself. TEST=none BUG=none Review URL: http://codereview.chromium.org/1377001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42767 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more files to toplevel gfx dir.ben@chromium.org2010-03-171-3/+3
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41812 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Make automation framework more solid by making sure thatphajdan.jr@chromium.org2010-03-161-2/+3
| | | | | | | | | | | | | | | | | | | important return values are not ignored. The macro used here, WARN_UNUSED_RESULT, takes effect only for GCC, but that's enough since we have bots for all platforms. Adding these warnings already detected some cases where a return value was ignored. In some of them the test was trying to get the information about success "some other way", in some it could sometimes confuse test failure with test success. TEST=ui_tests BUG=none Review URL: http://codereview.chromium.org/948002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41696 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Add more NULL-checks to UI tests that were lacking them to avoid ↵phajdan.jr@chromium.org2010-03-111-0/+3
| | | | | | | | | | | crashiness. TEST=none BUG=none Review URL: http://codereview.chromium.org/841002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41273 0039d316-1c4b-4281-b951-d872f2087c98
* Attempting to reland this CL as this does not seem related to the ui test ↵ananta@chromium.org2010-03-091-0/+42
| | | | | | | | | | | | | | | | | | | | | failures. Will watch the build after I commit. Revert 40994 - Revert "Launching Chrome with a userdatadir command line switch containing a non ASCII ..." Speculative revert to try to fix win dbg MultipartResponseUITest.SingleVisit failures. This reverts commit r40981 TBR=tony Review URL: http://codereview.chromium.org/707001 TBR=mattm@chromium.org Review URL: http://codereview.chromium.org/712001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41003 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Launching Chrome with a user-data-dir command line switch containing ↵mattm@chromium.org2010-03-091-42/+0
| | | | | | | | | | | | | | a non ASCII ..." Speculative revert to try to fix win dbg MultipartResponseUITest.SingleVisit failures. This reverts commit r40981 TBR=tony Review URL: http://codereview.chromium.org/707001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40994 0039d316-1c4b-4281-b951-d872f2087c98
* Launching Chrome with a user-data-dir command line switch containing a non ↵ananta@chromium.org2010-03-091-0/+42
| | | | | | | | | | | | | | | | | | | | | | | | ASCII character in the path like "Test Chrome G�ldine" would cause a DCHECK to fire in the BrowserRenderProcessHost::AppendRendererCommandLine function while retrieving the user-data-dir switch value from the browser's command line and setting it back to the renderer's command line. This was because we would retrieve the value as ASCII which would not work because of the presence of a non ASCII character in the value. The end result is that a CHECK fires in the renderer when it tries to validate the existence of the user-data-dir path. Fix is to use the CommandLine::GetSwitchValuePath function instead which returns a FilePath which does the right thing. Test=Covered by a ui test. Fixes bug http://code.google.com/p/chromium/issues/detail?id=29245 Bug=29245 Review URL: http://codereview.chromium.org/671027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40981 0039d316-1c4b-4281-b951-d872f2087c98
* Make several tests more snappy, less sleepy.phajdan.jr@chromium.org2010-02-101-14/+3
| | | | | | | | | | | Some also say it's good for reducing flakiness. TEST=Changing ui_tests. BUG=none Review URL: http://codereview.chromium.org/593018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38605 0039d316-1c4b-4281-b951-d872f2087c98
* Disable a failing test on chrome os.estade@chromium.org2010-01-211-1/+9
| | | | | | | | | | | | This test was disabled except on linux until I enabled it in r36676. It passes on normal linux, but not chromeos. Further investigation is warranted, but it is not actually a regression. BUG=32799 TEST=none TBR=pkasting Review URL: http://codereview.chromium.org/552083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36763 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some obsolete ifdefs that excluded certain tests on linux + mac.estade@chromium.org2010-01-201-6/+0
| | | | | | | | | BUG=none TEST=trybots Review URL: http://codereview.chromium.org/549096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36676 0039d316-1c4b-4281-b951-d872f2087c98
* Kiosk Mode implementation.mhm@chromium.org2009-11-091-0/+26
| | | | | | | | | | | | Kiosk mode will just hide the status bar and initially set it as full screen. Added some tests to add --kiosk mode as a command switch that tests if its in fullscreen state and doesn't have a status bubble. BUG=23145 TEST=Kiosk Mode functions and Run the ./ui_tests --gtest_filter=KioskModeTest.* Review URL: http://codereview.chromium.org/244003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31412 0039d316-1c4b-4281-b951-d872f2087c98
* Mark ShowModalDialogTest.BasicTest as FLAKYrafaelw@chromium.org2009-11-031-1/+2
| | | | | | | | | TBR=phajdan.jr,jam BUG=17806 Review URL: http://codereview.chromium.org/346045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30886 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable PosixSessionEnd test.johnnyg@chromium.org2009-10-311-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30670 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable PosixSessionEnd test to make sure it's not masking other ↵johnnyg@chromium.org2009-10-311-1/+1
| | | | | | | | | | failures. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30658 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a whole bunch of style nits.erg@google.com2009-10-131-1/+0
| | | | | | | | (Long term intention is to add a subset of cpplint.py to the presubmit script.) Review URL: http://codereview.chromium.org/276008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28914 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r28745 which disabled nested message loops on Mac, after Mark's fixes.jam@chromium.org2009-10-131-4/+0
| | | | | | | BUG=24337 Review URL: http://codereview.chromium.org/269065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28881 0039d316-1c4b-4281-b951-d872f2087c98
* Disable nested message loops in Mac for now. There seems to be a problem ↵jam@chromium.org2009-10-121-0/+4
| | | | | | | | | with the message pumping or IPC channel where the sent reply from the browser doesn't make it to the renderer main thread. BUG=24337 Review URL: http://codereview.chromium.org/273023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28745 0039d316-1c4b-4281-b951-d872f2087c98
* Move native_widget_types and gtk_native_view_id_manager from base/gfx tobrettw@chromium.org2009-10-111-1/+1
| | | | | | | | | | | | app/gfx in preparation for removing the base_gfx project. This also moves base/window_impl.cc to app/win/window_impl because this file shouldn't be in base. TEST=none BUG=none Review URL: http://codereview.chromium.org/273017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28691 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a SIGTERM handler for OS_POSIX builds. This is needed so that Chrome ↵cmasone@google.com2009-10-071-3/+49
| | | | | | | | | | | | | can shut down gracefully when many posix-based system halt or reboot while Chrome is open. SIGTERM may come in on any thread, so the handler creates a Task object that wraps up a call to BrowserList::CloseAllBrowsers(true) and Posts it to the message loop of the UI thread. Thus, we both get out of the signal handler quickly and can deal with the signal on any thread. BUG=23551 TEST=covered by BrowserTest.PosixSessionEnd Review URL: http://codereview.chromium.org/255036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28225 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the need for cross process events in order to get plugin ↵jam@chromium.org2009-09-291-2/+0
| | | | | | | | | | processes to run nested message loops when a dialog is shown. Instead use an async message that's broadcast from the renderer to all plugin processes that are connected to it, and which is dispatched on the plugin IO thread to set a process-local waitable event. This fixes showModalDialog on Linux/Mac. BUG=15891 TEST=covered by UI tests, undef's them for POSIX Review URL: http://codereview.chromium.org/242043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27456 0039d316-1c4b-4281-b951-d872f2087c98
* Automated ui test porting + cleanup:estade@chromium.org2009-09-221-15/+2
| | | | | | | | | | | | | | | | - Change POINTs to gfx::Point - Get rid of 2 unused automation messages (the messages themselves are staying for now so we don't mess with the reference build) -- add new automation messages to replace GetWindowHWND, which is not portable - re-enable automated_ui_test_interactive_test (it seems to have been dropped when we converted to gyp) - compile additional tests on linux (they don't pass, so they are disabled) - stub out linux tab dragging automation implementation (browser side) - delete various cruft BUG=19758 Review URL: http://codereview.chromium.org/211033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26846 0039d316-1c4b-4281-b951-d872f2087c98
* Support running tests under LayoutTests/http/tests/local as local file, in ↵jianli@chromium.org2009-09-111-0/+21
| | | | | | | | | | | | | | | | order to mimic what run-webkit-tests does. Search "http/tests/local/" in http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/run-webkit-tests for what it does. This is needed by http/tests/local/resources/send-dragged-file.js. Turn on file URL universal access in the test_shell. Delete rebaseline results of those layout tests that pass due to this change. Also add a UI test to make sure it is not on for the browser. BUG=9275,12882 TEST=none Review URL: http://codereview.chromium.org/201048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25985 0039d316-1c4b-4281-b951-d872f2087c98
* Make ShowModalDialogTest.BasicTest not flaky and re-enable it.phajdan.jr@chromium.org2009-08-241-16/+12
| | | | | | | | | TEST=Covered by ui_tests. http://crbug.com/17806 Review URL: http://codereview.chromium.org/174245 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24101 0039d316-1c4b-4281-b951-d872f2087c98
* Disable flaky ShowModalDialogTest.BasicTestphajdan.jr@chromium.org2009-08-211-1/+3
| | | | | | | | | | TBR=jam http://crbug.com/17806 Review URL: http://codereview.chromium.org/173204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23974 0039d316-1c4b-4281-b951-d872f2087c98
* Renable ShowModalDialogTest test with a longer timeout. Until we have a way ↵jam@chromium.org2009-08-191-4/+5
| | | | | | | | of executing JS in the renderer from a ui test, we'll have to use hacks like this. Review URL: http://codereview.chromium.org/165090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23770 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ShowModalDialogTest.BasicTest. Currently #2 flaky test.phajdan.jr@chromium.org2009-07-281-1/+2
| | | | | | | | | TEST=none http://crbug.com/17806 Review URL: http://codereview.chromium.org/160210 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21875 0039d316-1c4b-4281-b951-d872f2087c98
* Make BrowserTest.ThirtyFourTabs not-flakyphajdan.jr@chromium.org2009-07-141-29/+0
| | | | | | | | | | | I converted it to browser_tests framework, so I can just query RenderProcessHost instead of counting "chrome" processes, which apparently induced the flakiness. TEST=Covered by browser_tests. http://crbug.com/16062 Review URL: http://codereview.chromium.org/149559 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20661 0039d316-1c4b-4281-b951-d872f2087c98
* Convert JavascriptAlertActivatesTab to browser_tests framework.phajdan.jr@chromium.org2009-07-101-19/+0
| | | | | | | | | | | | This should make it non-flaky, so I un-disabled the test. I also added necessary plumbing so we can wait for AppModalDialog to appear and close it. TEST=Covered by browser_tests. http://crbug.com/16062 Review URL: http://codereview.chromium.org/149460 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20400 0039d316-1c4b-4281-b951-d872f2087c98
* Fix window.close() not working for modal dialogs.jam@chromium.org2009-07-101-0/+7
| | | | | | | | BUG=16374 TEST=added regression test Review URL: http://codereview.chromium.org/149412 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20339 0039d316-1c4b-4281-b951-d872f2087c98
* Convert most flakiness-prone Browser UI tests to browser_tests framework.phajdan.jr@chromium.org2009-07-091-76/+0
| | | | | | | | | TEST=none BUG=http://crbug.com/16062 Review URL: http://codereview.chromium.org/149365 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20276 0039d316-1c4b-4281-b951-d872f2087c98
* Sprinkle some defensiveness into the UI tests so that they don't explode if ↵stuartmorgan@chromium.org2009-07-071-0/+4
| | | | | | | | | | the proxy doesn't respond (e.g., due to a timeout). BUG=none TEST=Hopefully the Mac valgrind bots will more reliably run all their tests (although there are likely more issues like this lurking). Review URL: http://codereview.chromium.org/149281 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20096 0039d316-1c4b-4281-b951-d872f2087c98