summaryrefslogtreecommitdiffstats
path: root/chrome/browser/browsing_data_remover.cc
Commit message (Collapse)AuthorAgeFilesLines
* Simplify threading in browser thread by making only ChromeThread deal with ↵jam@chromium.org2009-10-271-2/+1
| | | | | | | | different thread lifetimes.The rest of the code doesn't get MessageLoop pointers since they're not thread-safe and instead just call PostTask on ChromeThread. If the target thread is not alive, then the task is simply deleted.In a followup change, I'll remove any remaining MessageLoop* caching. With this change, there's little to be gained by caching since no locks are involved if the target MessageLoop is guaranteed to outlive the current thread (inferred automatically by the order of the chrome_threads_ array).BUG=25354 Review URL: http://codereview.chromium.org/306032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30163 0039d316-1c4b-4281-b951-d872f2087c98
* Move initialization of ChromeURLRequestContexts to the IO thread.eroman@chromium.org2009-10-231-6/+12
| | | | | | | | | | | | | | | | | | | | | | | Before, these URLRequestContexts were lazily created from the UI thread. Unfortunately that model made it easy for consumers on the UI thread to poke at stuff which was being used from the IO thread, and introduce races. So instead of providing a URLRequestContext*, the Profile now vends a URLRequestContextGetter*. The consequence of this is: * Consumers on the UI thread can no longer get access to a URLRequestContext. * Consumers on the IO thread need to call URLRequestContextGetter::GetURLRequestContext() to get at the context. This uses the same style lazy-creation of URLRequestContexts, albeit from the IO thread. OK, so now the smelly part: There were a couple of consumers of URLRequestContext on the UI thread that can't easily be moved to the IO thread -- these are the consumers of the cookie store. Before they could happily mess with the cookie store from the UI thread, and this was fine since CookieStore is threadsafe. However under the new model, they have no way to get at the URLRequestContext from the UI thread, hence can't get a pointer to the cookie store. To support that use-cases, I bastardized the API some by adding a URLRequestContextGetter::GetCookieStore() method that lets UI thread consumers get a pointer to the cookie store, since we know this particular cross-thread usage is safe. BUG=http://crbug.com/22294 Review URL: http://codereview.chromium.org/258008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29880 0039d316-1c4b-4281-b951-d872f2087c98
* Clear media cache when clearing browsing datahclam@chromium.org2009-10-141-2/+15
| | | | | | | | | | | | | | | BUG=24765 BUG=24813 TEST=run Chromium with --enable-byte-range-support, watch a movie, clear browsing data, Media Cache folder shouldn't have the cache files. Clear media cache when clearing browsing data. What's missing in this patch is that disk_cache in HttpCache is lazily initialized, so it has to be used at least once before we can clear it. Review URL: http://codereview.chromium.org/275013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28992 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a whole bunch of style nits.erg@google.com2009-10-131-2/+2
| | | | | | | | (Long term intention is to add a subset of cpplint.py to the presubmit script.) Review URL: http://codereview.chromium.org/276008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28914 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27389.darin@chromium.org2009-09-301-9/+6
| | | | | | Review URL: http://codereview.chromium.org/246027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27594 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27379, in hopes of fixing browser_tests.senorblanco@chromium.org2009-09-281-6/+9
| | | | | | | | TBR=darin Review URL: http://codereview.chromium.org/248021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27389 0039d316-1c4b-4281-b951-d872f2087c98
* Assert that thread-safe reference counting is used withdarin@chromium.org2009-09-281-9/+6
| | | | | | | | | | | | | | | | | | | | | | | | cross-thread NewRunnableMethod. This assertion caught such an error in VisitedLinkMaster! My approach, modify RunnableMethodTraits<T> to assert that when ReleaseCallee happens on a different thread from RetainCallee that the type supports thread-safe reference counting. I do this by adding a static method to both RefCounted<T> and RefCountedThreadSafe<T>. This results in a little ugliness in cases where people implement AddRef and Release by hand (to make the no-ops). There may be a nicer way to deal with those few cases. R=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/251012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27379 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Strict transport security: add checkbox to clear state."agl@chromium.org2009-09-181-9/+0
| | | | | | | This reverts commit r25955. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26528 0039d316-1c4b-4281-b951-d872f2087c98
* Strict transport security: add checkbox to clear state.agl@chromium.org2009-09-111-0/+9
| | | | | | | | | | | | | | | This patches add a checkbox to the "Clear Browsing Data" dialog which clears the STS state when checked. Since we don't timestamp our entries (for now at least, should we?), the duration selected has no effect: we always clear everything. Mac doesn't appear to have a dialog for this yet, so no Mac specific changes. http://codereview.chromium.org/196070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25955 0039d316-1c4b-4281-b951-d872f2087c98
* Navigation and cookies for Automationamit@chromium.org2009-07-281-2/+3
| | | | | | | | | | | | | Give Automation better visibility and control over navigations. Also, make it possible for automation to implement a dummy cookie store to go with dummy request serving over automation. BUG=none TEST=none Review URL: http://codereview.chromium.org/159189 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21836 0039d316-1c4b-4281-b951-d872f2087c98
* Add the rest of the password manager API to PasswordStore, and move clientsstuartmorgan@chromium.org2009-07-101-3/+4
| | | | | | | | | | | | off of WebDataService. The methods are unimplemented on the Mac for the moment, and do passthroughs to WDS on Windows as with the rest of the Windows PasswordStore interface. BUG=none TEST=Saving, viewing, and deleting password should still work on Windows. Review URL: http://codereview.chromium.org/155259 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20441 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build breakpkasting@chromium.org2009-05-221-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16705 0039d316-1c4b-4281-b951-d872f2087c98
* More NotificationRegistrar conversions.pkasting@chromium.org2009-05-221-13/+3
| | | | | | | BUG=2381 Review URL: http://codereview.chromium.org/115674 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16699 0039d316-1c4b-4281-b951-d872f2087c98
* Implement clear browsing data dialog in linuxevan@chromium.org2009-05-221-6/+41
| | | | | | | | | | | | As well, refactored code on the windows side to reuse some functionality for the deletion range specified by its time period. BUG=11192 (http://crbug.com/11192) TEST=Looks pretty Review URL: http://codereview.chromium.org/113558 Patch from Mohamed Mansour <m0.interactive@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16694 0039d316-1c4b-4281-b951-d872f2087c98
* Resolve crash when deleting history by preventing the deleter from being ↵glen@chromium.org2009-03-031-1/+3
| | | | | | | | called multiple times. We need to add UI to make what's happening clearer to the user, but this gets us over the hump for now. Also change the history page to queue deletions.Allow history search from the new tab page.Make history title inclusion safer (createTextNode changes).Show starred status on history page.BUG=8214,8163,8271,8284 Review URL: http://codereview.chromium.org/28308 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10773 0039d316-1c4b-4281-b951-d872f2087c98
* Bring download_file, download_manager into POSIX build.estade@chromium.org2009-02-221-11/+1
| | | | | | | | Also shuffle a bunch of headers. Review URL: http://codereview.chromium.org/27024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10155 0039d316-1c4b-4281-b951-d872f2087c98
* Porting in chrome/phajdan.jr@chromium.org2009-02-121-0/+1
| | | | | | | | | | | | | | - make following unit tests compile and pass on Linux: browser/history/expire_history_backend_unittest.cc browser/history/history_backend_unittest.cc browser/history/history_querying_unittest.cc browser/history/starred_url_database_unittest.cc - #include cleanup (less #ifdefs, more explicit deps) Review URL: http://codereview.chromium.org/21247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9671 0039d316-1c4b-4281-b951-d872f2087c98
* Make tab_restore_service.cc compile on Mac and Linux.jhawkins@chromium.org2009-02-121-1/+1
| | | | | | Review URL: http://codereview.chromium.org/23022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9632 0039d316-1c4b-4281-b951-d872f2087c98
* Make session_service.cc compile on Mac and Linux.jhawkins@chromium.org2009-02-111-1/+1
| | | | | | Review URL: http://codereview.chromium.org/23018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9608 0039d316-1c4b-4281-b951-d872f2087c98
* Make browsing_data_remover.cc compile on Mac and Linux.jhawkins@chromium.org2009-02-111-3/+15
| | | | | | Review URL: http://codereview.chromium.org/21232 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9533 0039d316-1c4b-4281-b951-d872f2087c98
* Remove most header file dependencies on the notification type list. It isbrettw@chromium.org2009-02-011-3/+4
| | | | | | | | | | | really painful to add more types, since lots of headers include the notification service to derive from the notification observer. This splits that out, so much less of the project should end up including notification_types.h ---Paths modified but not in any changelist: Review URL: http://codereview.chromium.org/19744 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9020 0039d316-1c4b-4281-b951-d872f2087c98
* Move metrics files into a subdirben@chromium.org2009-01-161-1/+1
| | | | | | Review URL: http://codereview.chromium.org/18302 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8156 0039d316-1c4b-4281-b951-d872f2087c98
* Move search code to a subdirben@chromium.org2009-01-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8148 0039d316-1c4b-4281-b951-d872f2087c98
* Fie.ben@chromium.org2009-01-151-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8111 0039d316-1c4b-4281-b951-d872f2087c98
* Move search engines files into subdirben@chromium.org2009-01-151-1/+1
| | | | | | Review URL: http://codereview.chromium.org/18263 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8108 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the tab restore service persist closed tabs/windows to disk andsky@google.com2008-12-061-4/+6
| | | | | | | | | | | | | | | | | reload them when asked. Sorry for largish looking change. It's made big by refactoring common code between TabRestoreService and SessionService into a common superclass. At the same time I removed some dead code and shuffled the session related classes into a single directory for easier perusal. BUG=384 TEST=close the browser, start the browser and make sure the new tab page shows closed windows/tabs from the previous session. Review URL: http://codereview.chromium.org/13152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6490 0039d316-1c4b-4281-b951-d872f2087c98
* Changes tab restore service to handle restoring closed windows as asky@google.com2008-11-251-1/+1
| | | | | | | | | | | | | | single unit. Sadly I've written another ui test. Lets hope it isn't flakey. Glen is going to change the NTP to deal with this appropriately. BUG=4686 TEST=Try closing a window (with more than one window open), hitting control-shift-t, and make sure the window and all it's tabs comes back. Review URL: http://codereview.chromium.org/11377 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6003 0039d316-1c4b-4281-b951-d872f2087c98
* Change by Alex Mendes da Costa <alexmdac@google.com>beng@google.com2008-11-191-0/+1
| | | | | | | | | | | | Use the most recently used download path when displaying a "save as" dialog. Reset the download path when the user clears the download history. BUG=293 (http://code.google.com/p/chromium/issues/detail?id=293) Review URL: http://codereview.chromium.org/10743 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5674 0039d316-1c4b-4281-b951-d872f2087c98
* New functions in WebDatabase and WebDataService for the removal of form ↵petersont@google.com2008-11-121-2/+6
| | | | | | | | | | entries made between two given times. BrowserDataRemover::Remove now clears autofill data. BUG=3870 Review URL: http://codereview.chromium.org/9775 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5312 0039d316-1c4b-4281-b951-d872f2087c98
* Fix hang in clearing browsing data from incognito mode.finnur@google.com2008-11-041-1/+1
| | | | | | | | When deleting Keywords, the BrowsingDataRemover class may need to load the TemplateURLModel if it isn't loaded and delete keywords asynchronously from the Observe function. The check to see if we were getting the model with the right profile wasn't taking into account that we might be doing this while incognito, which led to us failing to set the waiting_for_keywords_ flag, resulting in a hang (issue 2145). This fixes that. Review URL: http://codereview.chromium.org/9333 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4626 0039d316-1c4b-4281-b951-d872f2087c98
* Adding preferences and clear browsing data for form autofill.jcampan@chromium.org2008-10-311-0/+5
| | | | | | | | BUG=None TEST=Open the 'Clear browsing data' dialog, there should be a check box for from data. Open the options dialogue, 2nd tab, there should be an option for autofill. Review URL: http://codereview.chromium.org/8740 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4292 0039d316-1c4b-4281-b951-d872f2087c98
* Move Time, TimeDelta and TimeTicks into namespace base.dsh@google.com2008-10-271-1/+2
| | | | | | Review URL: http://codereview.chromium.org/7995 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4022 0039d316-1c4b-4281-b951-d872f2087c98
* Move the download code to new directories:paulg@google.com2008-09-131-1/+1
| | | | | | | | | browser/download/ browser/views/ Review URL: http://codereview.chromium.org/2826 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2166 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome changes corresponding to my message_loop_type CL.darin@google.com2008-08-261-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1363 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-241-28/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* Move more net classes into the net namespace. Also remove the net_util ↵darin@google.com2008-07-311-1/+1
| | | | | | | | namespace in favor of the net namespace. This is a purely mechanical change. There should be no logic changes. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome to the repository.initial.commit2008-07-261-0/+227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 07:04:06 +0000