| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=121862
TEST=existing unit_tests
TBR=eroman@chromium.org,sky@chromium.org,erg@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10805015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
For context see this thread:
https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II
TBR=thakis,pkasting,jam
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Finder on Mac OS has a habit of putting .DS_Store files into directories, which would (silently) prevent us from deleting them.
Also, don't treat trying to delete a directory that doesn't exist on disk anymore as an error.
Add URL to quota managed origin deletion callback.
BUG=134825
TEST=Clear Browsing Data does that.
Review URL: https://chromiumcodereview.appspot.com/10701094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
remove reliability suppression.
BUG=21054
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10598003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
location.
Note: This was a TODO for akalin@.
This patch was generated by:
$ find . -name '*.h' -o -name '*.cc' -o -name '*.mm' | xargs sed -i -e "s/base\/message_loop_helpers.h/base\/sequenced_task_runner_helpers.h/g"
R=akalin@chromium.org
TBR=willchan@chromium.org,ben@chromium.org,jam@chromium.org,tony@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10578026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG= http://code.google.com/p/nativeclient/issues/detail?id=2515
TEST= none
Review URL: https://chromiumcodereview.appspot.com/10440121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, installing a hosted application for `example.com` means that we
ignore that origin when removing browsing data. This CL extends the filtering
options available to extension authors using the BrowsingData API to include
removal of browsing data for these "protected" web origins.
BUG=113194
TEST=browser_tests
Review URL: https://chromiumcodereview.appspot.com/10522002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding a parameter to BrowsingDataRemover::Remove in order to support a
"Clear app data" flag in the "Clear Browsing Data UI". Additionally, this CL pulls the implementation of DomStorageContext::DeleteDataModifiedSince out of DomStorageContext, and into BrowsingDataRemover in order to manage the complexities of decision-making in the BDR, rather than exporting them out of chrome and into webkit.
This patch only addresses localStorage/sessionStorage and quota managed data. Cookies should already ignore the special storage policy, but we'll need to examine the remainder of the types that the BDR touches.
BUG=116372
TEST=unit_tests,test_shell_tests
Review URL: https://chromiumcodereview.appspot.com/10413072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A few notes about PepperFlashSettingsManager:
- It doesn't re-establish a channel for each request. It might seem unnecessary at this point. But that is needed for implementing content settings (camera/mic and peer networking), which requires more interactions with the broker process.
- Similarly, the support of multiple in-flight requests isn't very useful for deauthorizing content licenses, but that is useful for content settings, e.g., sending multiple GetPermissionSettings requests for different setting types.
BUG=112190
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10391173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds to the "Clear browsing data" dialog a checkbox, which will only show up when Pepper Flash is in use.
BUG=112190
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10387161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=115348
TEST=unit tests, manually checked 'Origin Bound Certs' contents after browsing
TBR=jam@chromium.org,willchan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9617039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
hide the threading details from the embedder.
Review URL: https://chromiumcodereview.appspot.com/9704048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
of directly to WEBKIT_DEPRECATED.
BUG=106763
Review URL: https://chromiumcodereview.appspot.com/9700007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9558012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
code so that it only calls profile-wide operations (i.e. saving session/purging memory/clearing local state on exit) on the BrowserContext. The content layer takes care of calling the necessary objects on the right thread.
WebKitContext now does almost nothing and I'll remove it completely in the next change.
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9462007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=114584
TEST=clear site data, sqlite .dump the Safe Browsing Cookies contents
Review URL: http://codereview.chromium.org/9419027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Half of them weren't used by chrome, so they can be hidden from chrome. The rest were accessed by chrome, but we don't need every embedder to store this data on their ResourceContext implementation. Instead have content associate the data itself to simplify the work for embedders.
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9425026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
instead of depending on the embedder. Apart from allowing us to hide more of content from embedders, it simplifies the work that every embedder has to do (see the change the shell_browser_context.cc as an example).
BUG=98716
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122521
Review URL: https://chromiumcodereview.appspot.com/9419033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=114787
Revert 122521 - Move creation of BrowserContext objects that live in content to content, instead of depending on the embedder. Apart from allowing us to hide more of content from embedders, it simplifies the work that every embedder has to do (see the change the shell_browser_context.cc as an example).
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9419033
TBR=jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9421023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
instead of depending on the embedder. Apart from allowing us to hide more of content from embedders, it simplifies the work that every embedder has to do (see the change the shell_browser_context.cc as an example).
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9419033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first of what will be many CLs to add origin-based deletion to
BrowsingDataRemover for all the variety of data types it supports. As a first
step, this CL hides origin-based functionality in the private
`BrowsingDataRemover::RemoveImpl()`. Once we're done with all the relevant data
types, we can add a `RemoveOrigin(int, GURL)` method next to `Remove(int)` to
expose a public API.
BUG=113965
TEST=unit_tests
Review URL: http://codereview.chromium.org/9379008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As discussed, we're renaming the `clear` namespace to `browsingData`, and
renaming the methods to `remove()` and `removeXXX()`. As a drive-by, this CL
also adds `removeOriginBoundCertificates()`, which was added in r119084, but
never made it into the JSON file or the documentation.
/**
* DO NOT COMMIT YET:
* This patch depends on http://codereview.chromium.org/7839029/ having landed.
* Make sure that lands first.
*/
BUG=108338
TEST=
Review URL: https://chromiumcodereview.appspot.com/9301002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
To enable a more fine-grained extension API that would allow removal of specific data types, this CL changes the QuotaClient::ID enum values to bitmasky flags, and adds a bitmask parameter to QuotaManager::DeleteOriginData and QuotaManager::DeleteHostData to filter the clients that are deleted for each origin.
BUG=94334
TEST=test_shell_tests,unit_tests
Review URL: http://codereview.chromium.org/7839029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=107056
TEST="Delete cookies and other site and plug-in data" option in Clear
Browsing Data dialog should clear origin bound certs.
Review URL: https://chromiumcodereview.appspot.com/9120001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=willchan,brettw,tony
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115997
Review URL: http://codereview.chromium.org/9004051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
uses base::Bind.
BUG=none
TEST=none
TBR=willchan,brettw,tony
Review URL: http://codereview.chromium.org/9004051
TBR=dcheng@chromium.org
Review URL: http://codereview.chromium.org/9034029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=willchan,brettw,tony
Review URL: http://codereview.chromium.org/9004051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jam@chromium.org
BUG=98716
Review URL: http://codereview.chromium.org/9021017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv
Review URL: http://codereview.chromium.org/8963030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/7717023 added more granular options to
BrowsingDataRemover. This CL exposes those options to the chrome.clear
extension API. Among other things, this means that chrome.clear.cookies()
will _only_ clear cookies, not cookies and site data.
At the moment, clearing any quota managed data type will clear them all.
That is being addressed in http://codereview.chromium.org/7839029/
but is independent from changing the public interface.
BUG=94334
TEST=browser_tests
Review URL: http://codereview.chromium.org/8952014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 114615 - chrome.clear: Increasing granularity of public API
http://codereview.chromium.org/7717023 added more granular options to
BrowsingDataRemover. This CL exposes those options to the chrome.clear
extension API. Among other things, this means that chrome.clear.cookies()
will _only_ clear cookies, not cookies and site data.
At the moment, clearing any quota managed data type will clear them all.
That is being addressed in http://codereview.chromium.org/7839029/
but is independent from changing the public interface.
BUG=94334
TEST=browser_tests
Review URL: http://codereview.chromium.org/8008012
TBR=mkwst@chromium.org
Review URL: http://codereview.chromium.org/8949014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/7717023 added more granular options to
BrowsingDataRemover. This CL exposes those options to the chrome.clear
extension API. Among other things, this means that chrome.clear.cookies()
will _only_ clear cookies, not cookies and site data.
At the moment, clearing any quota managed data type will clear them all.
That is being addressed in http://codereview.chromium.org/7839029/
but is independent from changing the public interface.
BUG=94334
TEST=browser_tests
Review URL: http://codereview.chromium.org/8008012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removing plugin data is different to removing only LSO data. Moreover, we call
out to content::PluginDataRemover to do the work: we should have an external
name here that's consistent.
This CL's tests depend on http://codereview.chromium.org/8907015/
landing. It shouldn't be landed until that patch is approved.
BUG=107355
TEST=
Review URL: http://codereview.chromium.org/8907018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After BrowsingDataRemover removes browsing data, it now triggers a
chrome::NOTIFICATION_BROWSING_DATA_REMOVED, which uses the profile
in which data was removed as it's |source|, and a struct containing the
beginning of the removal's timeframe, and the removal mask
(BrowsingDataRemover::NotificationDetail) as it's |details|.
BUG=107202
TEST=BrowsingDataRemover unit tests.
Review URL: http://codereview.chromium.org/8907015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The primary commit was 113249, the dependents were 113261, 113263.
This is a speculative revert, r113249 is by far the likeliest culprit in the blamelist of build http://build.chromium.org/p/chromium.memory/builders/ASAN%20Tests%20%282%29/builds/2325 which is where we started seeing the ASAN failures in question, will un-revert if it does not fix the problem.
TBR=jhawkins@chromium.org
BUG=none
Review URL: http://codereview.chromium.org/8832006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv
Review URL: http://codereview.chromium.org/8798001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/8794003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104314
TEST=no change
Review URL: http://codereview.chromium.org/8612007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
from it. This class really belongs in content because it's part of the web platform. I've also wrapped it with an interface that is used by chrome.
BUG=98716
Review URL: http://codereview.chromium.org/8590016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8566028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
content/public/browser.
This patch got way bigger than I wanted, but once I moved NotificationDetails, I figured I might as well mvoe the others since they're in the same files. In hindsight, I should have converted a subset of files at a time by leaving a using statement in the header.
BUG=98716
TBR=joi
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BrowsingDataRemover.
BUG=99505
TEST=browser_tests
Review URL: http://codereview.chromium.org/8223004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename CompletionCallback to OldCompletionCallback in preparation for introducing a new CompletionCallback based on base::Callback.
Also renames other CompletionCallback types like CancelableCompletionCallback and TestCompletionCallback and CompletionCallbackImpl. All using sed with s/CompletionCallback/OldCompletionCallback/g.
BUG=98719
TEST=none
Review URL: http://codereview.chromium.org/8070013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
REMOVE_LSO_DATA).
There's no case in the current codebase when we want to remove _only_ LSO data, and no case where we want to remove cookies, but _not_ LSO data. There are many instances of building removal masks that binary-OR REMOVE_LSO_DATA and REMOVE_COOKIES together; this CL formalizes that by dropping the extra enum value.
Moreover, we talk about "cookies" differently when targeting users on the one hand, and developers on the other. REMOVE_COOKIES is a developer-facing name with a user-facing value, which is confusing. Renaming the current functionality to REMOVE_SITE_DATA is much more explicit, and will enable us to _just_ remove cookies at some point in the future via a REMOVE_COOKIES that actually means cookies.
REMOVE_SITE_DATA has exactly the same semantics that REMOVE_COOKIES used to, with one exception: REMOVE_COOKIES included deleting cached strict transport security values. This functionality has been moved to REMOVE_CACHE.
As a drive-by, this CL also moves a check against the kClearPluginLSODataEnabled pref out of webui (ClearBrowsingDataHandler) and into the BrowsingDataRemover itself, where it seems more likely to be effective.
BUG=92628, 94334
TEST=Nothing but removal cached transport-security values should change.
Review URL: http://codereview.chromium.org/7717023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were accesing a flag from multiple threads, which cloud lead to BrowsingDataRemover::NotifyAndDeleteIfDone() to be called multiple times, which in turn would cause a DCHECK().
BUG=None
TEST=No DCHECK on cancelling enterprise enrollment on CrOS.
Review URL: http://codereview.chromium.org/7834023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to flaky test. Turns out there was a race condition: the cookie store api for deleting cookies is exclusive of the end time, and in the test, on Windows, we often got around to deleting the cookie we had created the same millisecond (hence, it was excluded from deletion).
This change updates the Browsing Data Remover to use the new asynchronous Cookie Store API.
BUG=68657
TEST=unit_tests / BrowsingDataRemoverTest.RemoveCookieForever
TBR=jochen
Review URL: http://codereview.chromium.org/7740084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Opens up the `BrowsingDataRemover::Remove()` functionality to extensions: initial implementation, so it's sitting behind the experimental flag to work out kinks in the API/code.
BUG=83530,54853
TEST=browser_tests
Review URL: http://codereview.chromium.org/7551008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CookieMonster API.
BUG=XXXX
TEST=XXXX
Review URL: http://codereview.chromium.org/7210034
TBR=ycxiao@chromium.org
Review URL: http://codereview.chromium.org/7605007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=XXXX
TEST=XXXX
Review URL: http://codereview.chromium.org/7210034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=90996
TEST=test_shell_tests
Review URL: http://codereview.chromium.org/7533013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95591 0039d316-1c4b-4281-b951-d872f2087c98
|