summaryrefslogtreecommitdiffstats
path: root/chrome/browser/bug_report_util.cc
Commit message (Collapse)AuthorAgeFilesLines
* Refactor and fix feedbackrkc@chromium.org2012-01-061-405/+0
| | | | | | | | | | | | | | | | | | | | | This CL does the following things, .) Removes user-facing categories from the UI completely. .) Changes categories that are still used (Autofill for example) use category tags instead of the category enum (which has been deprecated) .) Updates the protocol buffers .) Refactors the code to change bug report to feedback and re-organizes the file naming/layout .) Cleans up the unused feedback strings, files and code .) Cleans up the code at a few places .) Makes a few UI changes to get closer to the mock given in chromium:98738 This seems like a really huge CL but in reality it just just a couple of hundred lines of 'code' changes; a lot of this is just code being deleted BUG=chromium:98738 TEST=Tested sending reports. Review URL: http://codereview.chromium.org/9006003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116598 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the remaining trivial tab_contents.h includes in chrome to use ↵jam@chromium.org2012-01-051-3/+5
| | | | | | | | | web_contents.h BUG=98716 Review URL: http://codereview.chromium.org/9113020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116548 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 115346. The change didn't break anything, the test was faulty. Will ↵jam@chromium.org2011-12-211-1/+1
| | | | | | | | | | | | | | | | | | | | disable in a followup. - Revert r115276, it broke PanelDownloadTest.Download in interactive_ui_tests on win,linux,mac. Original change: Rename TabContents::controller() to GetController and put it into the WebContents namespace. BUG=98716 TBR=dpranke Review URL: http://codereview.chromium.org/8956050 TBR=jam Review URL: http://codereview.chromium.org/9018016 TBR=thakis@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115428 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r115276, it broke PanelDownloadTest.Download in interactive_ui_teststhakis@chromium.org2011-12-211-1/+1
| | | | | | | | | | | | | | | | on win,linux,mac. Original change: Rename TabContents::controller() to GetController and put it into the WebContents namespace. BUG=98716 TBR=dpranke Review URL: http://codereview.chromium.org/8956050 TBR=jam Review URL: http://codereview.chromium.org/9018016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115346 0039d316-1c4b-4281-b951-d872f2087c98
* Rename TabContents::controller() to GetController and put it into the ↵jam@chromium.org2011-12-211-1/+1
| | | | | | | | | | WebContents namespace. BUG=98716 TBR=dpranke Review URL: http://codereview.chromium.org/8956050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115276 0039d316-1c4b-4281-b951-d872f2087c98
* Change NavigationController::LoadURL to take a Referrer class instead of a ↵jochen@chromium.org2011-12-051-1/+1
| | | | | | | | | | | GURL as referrer BUG=105028 TEST=no functional change Review URL: http://codereview.chromium.org/8785004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112968 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate NewRunnableFunction() to base::Bind() in bug_report_util.ccisherman@chromium.org2011-11-051-1/+2
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/8475018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108779 0039d316-1c4b-4281-b951-d872f2087c98
* Handle additional feedback from http://codereview.chromium.org/8395038/.jam@chromium.org2011-10-281-1/+1
| | | | | | | | | | | -rename URLFetcherFactory to URLFetcherImplFactory -rename GetUrl to GetURL and GetOriginalUrl to GetOriginalURL -get rid of request_type in TestURLFetcher's constructor BUG=98716 Review URL: http://codereview.chromium.org/8416020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107665 0039d316-1c4b-4281-b951-d872f2087c98
* Convert chrome callers of UrlFetcher to use the interface. I'll switch tests ↵jam@chromium.org2011-10-261-5/+4
| | | | | | | | | to use composition instead of inheritence in a future change. BUG=98716 Review URL: http://codereview.chromium.org/8395023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107268 0039d316-1c4b-4281-b951-d872f2087c98
* Create a content::UrlFetcher interface that lives in content/public/common ↵jam@chromium.org2011-10-251-8/+8
| | | | | | | | | and convert users to it. I have added a static create function, but will switch instantiations to use it in another change since this has grown a lot. Basically this change converts function names away from unix_hacker style, which they shouldn't have been using anyways since some are virtual, and made all of the other functions virtual. BUG=98716 Review URL: http://codereview.chromium.org/8375039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107151 0039d316-1c4b-4281-b951-d872f2087c98
* Convert URLFetcher::Delegates to use an interface in content/public/common. ↵jam@chromium.org2011-10-241-17/+8
| | | | | | | | Also remove the old URLFetcher delegate callback while I'm touching all of them.BUG=98716,83592 Review URL: http://codereview.chromium.org/8373021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106949 0039d316-1c4b-4281-b951-d872f2087c98
* Move PageTransition into content namespace. While I'm touching all these ↵jam@chromium.org2011-10-131-1/+1
| | | | | | | | | files, I've also updated it to use the enum naming convention in the Content API. BUG=98716 Review URL: http://codereview.chromium.org/8253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105254 0039d316-1c4b-4281-b951-d872f2087c98
* Move URLFetcher from content/common to content/common/net.willchan@chromium.org2011-09-131-1/+1
| | | | | | | | | | | | | Add a OWNERS for content/common/net BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100828 Review URL: http://codereview.chromium.org/7875006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100857 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Linux Views build breakage.willchan@chromium.org2011-09-131-1/+1
| | | | | | | | | | | | | | | | Revert 100828 - Move URLFetcher from content/common to content/common/net. Add a OWNERS for content/common/net BUG=none TEST=none Review URL: http://codereview.chromium.org/7875006 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/7884003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100829 0039d316-1c4b-4281-b951-d872f2087c98
* Move URLFetcher from content/common to content/common/net.willchan@chromium.org2011-09-131-1/+1
| | | | | | | | | | | Add a OWNERS for content/common/net BUG=none TEST=none Review URL: http://codereview.chromium.org/7875006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100828 0039d316-1c4b-4281-b951-d872f2087c98
* Remove redundant LoadURLWithHeaders method.rogerta@chromium.org2011-09-101-1/+2
| | | | | | | | | BUG=None TEST=No user visible or functional change. Review URL: http://codereview.chromium.org/7847023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100573 0039d316-1c4b-4281-b951-d872f2087c98
* browser: Get rid of static initializer in BugReportUtil.tfarina@chromium.org2011-09-011-8/+0
| | | | | | | | | | | BUG=94925 TEST=None R=rkc@chromium.org Review URL: http://codereview.chromium.org/7831013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99228 0039d316-1c4b-4281-b951-d872f2087c98
* Fix saved screenshots for feedback.rkc@chromium.org2011-08-311-4/+6
| | | | | | | | | | | | Fixed the location where the saved screenshots are picked from. Also fixed the issue with saved screenshots blocking the UI. R=zelidrag@chromium.org,derat@chromium.org BUG=chromium-os:18227,chromium:73180 TEST=Tested with sending feedback using a saved screenshot. Review URL: http://codereview.chromium.org/7635017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98934 0039d316-1c4b-4281-b951-d872f2087c98
* base: Fix the TODO in string_util.htfarina@chromium.org2011-08-171-3/+6
| | | | | | | | | | | | | This removes the include of stringprintf.h from string_util.h and fix the clients. BUG=None TEST=None R=evan@chromium.org Review URL: http://codereview.chromium.org/7633055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97067 0039d316-1c4b-4281-b951-d872f2087c98
* Add memory usage info to SyslogsProvider, and clean up bug report screenshot ↵stevenjb@google.com2011-08-031-20/+47
| | | | | | | | | | | data. BUG=chromium-os:18418 TEST=Ensure bug reporting and screenshots work, system info is only provided when option is checked, and system info includes "mem_usage" entry. Review URL: http://codereview.chromium.org/7562001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95327 0039d316-1c4b-4281-b951-d872f2087c98
* Make safe browsing optional at compile time.torne@chromium.org2011-07-111-0/+2
| | | | | | | | | Introduce a gyp variable "safe_browsing" which can be set to 0 to remove safe browsing code at compile time. Review URL: http://codereview.chromium.org/7227013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92000 0039d316-1c4b-4281-b951-d872f2087c98
* Split SystemAccess into TimezoneSettings, StatisticsProvider, and ↵satorux@chromium.org2011-07-101-3/+3
| | | | | | | | | | | | | | | | | | SyslogsProvider. SystemAccess contained three separate things: timezone settings, statistics provider, and syslogs provider. We should have them in separate classes. This patch touches many files but changes are mechanical. No logic changes introduced. BUG=none TEST=chrome builds and try bots pass Review URL: http://codereview.chromium.org/7324017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91971 0039d316-1c4b-4281-b951-d872f2087c98
* Improve and unify Mac OS X run-time version checks.mark@chromium.org2011-06-141-5/+1
| | | | | | | | | | | | Don't use base::SysInfo::OperatingSystemVersionNumbers, because it calls Gestalt, which has a few bad properties. Introduce new functions that perform specific version checks. BUG=85972 TEST=base_unittests MacUtilTest.IsOSEllipsis Review URL: http://codereview.chromium.org/7144007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89028 0039d316-1c4b-4281-b951-d872f2087c98
* Move UrlFetcher to content. I originally thought that it's only used by ↵jam@chromium.org2011-06-011-1/+1
| | | | | | | | | chrome code, but turns out there are legitimate content uses for HTML5 features like speech/geolocation which need to go to the web. BUG=76697 Review URL: http://codereview.chromium.org/7006005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87406 0039d316-1c4b-4281-b951-d872f2087c98
* Use a different tpl= parameter when reporting an error from client-side ↵bryner@chromium.org2011-05-261-1/+2
| | | | | | | | | | | | | phishing detection. This extends SafeBrowsingService::UrlCheckResult to add a new type for client-side phishing urls. BUG=83436 TEST=ClientSideDetectionHostTest Review URL: http://codereview.chromium.org/7076009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86915 0039d316-1c4b-4281-b951-d872f2087c98
* net: Move ResponseCookies into the net namespace.tfarina@chromium.org2011-05-061-2/+2
| | | | | | | | | | | BUG=81612 TEST=None R=wtc@chromium.org,willchan@chromium.org Review URL: http://codereview.chromium.org/6932025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84375 0039d316-1c4b-4281-b951-d872f2087c98
* Make the windows_version.h functions threadsafe by using a singleton. Add ↵pkasting@chromium.org2011-04-071-21/+16
| | | | | | | | | | | | accessors to the singleton for more values that various code wants, then convert almost everyone using OSVERSIONINFO or SYSTEM_INFO structs to calling these accessors. Declare an AtExitManager in the out-of-process test runner since it didn't have one and that breaks singleton-using code in the test executable (as opposed to in chrome.dll). A few other minor cleanups along the way (binding of "*", shorter code, etc.). Because I ran into problems with it while modifying gcapi.cc, I cleaned up our usage of strsafe.h a bit, so that files that don't need it don't include it and files that do use STRSAFE_NO_DEPRECATE instead of a modified #include order. BUG=none TEST=none Review URL: http://codereview.chromium.org/6816027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80851 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 80819 due to failed testsmmenke@chromium.org2011-04-071-16/+21
| | | | | | | TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/6816024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80824 0039d316-1c4b-4281-b951-d872f2087c98
* Make the windows_version.h functions threadsafe by using a singleton. Add ↵pkasting@chromium.org2011-04-071-21/+16
| | | | | | | | | | | | accessors to the singleton for more values that various code wants, then convert almost everyone using OSVERSIONINFO or SYSTEM_INFO structs to calling these accessors. Declare an AtExitManager in the out-of-process test runner since it didn't have one and that breaks singleton-using code in the test executable (as opposed to in chrome.dll). A few other minor cleanups along the way (binding of "*", shorter code, etc.). Because I ran into problems with it while modifying gcapi.cc, I cleaned up our usage of strsafe.h a bit, so that files that don't need it don't include it and files that do use STRSAFE_NO_DEPRECATE instead of a modified #include order. BUG=none TEST=none Review URL: http://codereview.chromium.org/6713107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80819 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Update a bunch of files to the new location of browser_list.h. Part ↵tfarina@chromium.org2011-04-061-3/+3
| | | | | | | | | | | | | 1/3. BUG=None TEST=None R=avi@chromium.org Review URL: http://codereview.chromium.org/6689029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80632 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Update the includes to the old tab_contents.hjam@chromium.org2011-03-021-1/+1
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6596103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76552 0039d316-1c4b-4281-b951-d872f2087c98
* Disable sending of page title in Chrome reports.rkc@chromium.org2011-01-251-5/+0
| | | | | | | | | | | Page title can leak privacy information hence we don't really want it. BUG=66716 TEST=Sent a report to confirm page title is no longer being sent. Review URL: http://codereview.chromium.org/6366007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72441 0039d316-1c4b-4281-b951-d872f2087c98
* Move l10n_util to ui/baseben@chromium.org2011-01-211-1/+1
| | | | | | | | | BUG=none TEST=none TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72227 0039d316-1c4b-4281-b951-d872f2087c98
* net: Remove typedef net::URLRequestStatus URLRequestStatus;tfarina@chromium.org2011-01-131-3/+3
| | | | | | | | | BUG=64263 TEST=compiled locally, trybots Review URL: http://codereview.chromium.org/6166010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71285 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 69592 - file_version_info was not finding Mac values correctly.dmaclach@chromium.org2010-12-181-5/+7
| | | | | | | | | | | | | | Changed file_version_info to find Mac values, and changed version_info to fail if values can't be found. BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/5815001 TBR=dmaclach@chromium.org Review URL: http://codereview.chromium.org/6017003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69601 0039d316-1c4b-4281-b951-d872f2087c98
* file_version_info was not finding Mac values correctly.dmaclach@chromium.org2010-12-181-7/+5
| | | | | | | | | | | Changed file_version_info to find Mac values, and changed version_info to fail if values can't be found. BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/5815001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69592 0039d316-1c4b-4281-b951-d872f2087c98
* Move:ben@chromium.org2010-12-021-1/+1
| | | | | | | | | | | | | | | file_path_watcher into subdir profile* into profiles/ subdir login* into ui/login visitedlink* into subdir BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/5606002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68069 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to enable retry of failed sends on feedback reports.rkc@chromium.org2010-10-291-103/+96
| | | | | | | | | | | | | | | | | | If the initial send fails, the first retry will be in 15 minutes after the attempt. The next attempt will be in 30 minutes and the time will double till we hit a 4 hour delay - the send will be then retried every 4 hours till the Chrome instance is up. BUG=cros:6331 TEST=Tested with up to 25 reports at a time, with varying network connectivity (via pulling out the network cable); report data verified on the feedback server. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64321 Review URL: http://codereview.chromium.org/4027005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64347 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64321 (broke mac compile; please use tryservers) - Changes to enable ↵thakis@chromium.org2010-10-281-96/+103
| | | | | | | | | | | | | | | | | | | | | retry of failed sends on feedback reports. If the initial send fails, the first retry will be in 15 minutes after the attempt. The next attempt will be in 30 minutes and the time will double till we hit a 4 hour delay - the send will be then retried every 4 hours till the Chrome instance is up. BUG=cros:6331 TEST=Tested with up to 25 reports at a time, with varying network connectivity (via pulling out the network cable); report data verified on the feedback server. Review URL: http://codereview.chromium.org/4027005 TBR=rkc@chromium.org Review URL: http://codereview.chromium.org/4096007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64323 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to enable retry of failed sends on feedback reports.rkc@chromium.org2010-10-281-103/+96
| | | | | | | | | | | | | | | | If the initial send fails, the first retry will be in 15 minutes after the attempt. The next attempt will be in 30 minutes and the time will double till we hit a 4 hour delay - the send will be then retried every 4 hours till the Chrome instance is up. BUG=cros:6331 TEST=Tested with up to 25 reports at a time, with varying network connectivity (via pulling out the network cable); report data verified on the feedback server. Review URL: http://codereview.chromium.org/4027005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64321 0039d316-1c4b-4281-b951-d872f2087c98
* Convert LOG(INFO) to VLOG(1) - misc. chrome/browser/*.pkasting@chromium.org2010-10-211-6/+6
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4008001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63421 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to enable pushing large log data to the feedback server as a bz2rkc@chromium.org2010-10-201-6/+3
| | | | | | | | | | BUG=7344 TEST=Manually verified that the bz2 data is getting to the feedback server dev instance; UI changes will only be active after the next push to prod Review URL: http://codereview.chromium.org/3814010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63293 0039d316-1c4b-4281-b951-d872f2087c98
* Do not call SystemNotification::Hide() in SystemNotification dtor. The bug ↵achuith@google.com2010-10-141-2/+4
| | | | | | | | | | | report feedback notification is a Singleton. When it gets destroyed in atExit(), it calls Hide() which touches a non-existant global balloon collection object. We avoid this by requiring that Hide() be explicitly called (which it is everywhere except in bug_report_util.cc). BUG=6895 TEST=none Review URL: http://codereview.chromium.org/3803005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62666 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize member variables.jhawkins@chromium.org2010-10-131-1/+1
| | | | | | | | | | CID=7636,8292,8295,8766,8788,9312,9444,10754,12632,12689 BUG=none TEST=none Review URL: http://codereview.chromium.org/3764001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62439 0039d316-1c4b-4281-b951-d872f2087c98
* Prepared code for system logs split in ChromeOS feedback reports. We are ↵zelidrag@chromium.org2010-10-091-1/+50
| | | | | | | | | | | | | still missing sever-side changes, so part of this code is commented out until we get at least proto buffers defined. BUG=chromium-os:7344 TEST=none Review URL: http://codereview.chromium.org/3563011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62046 0039d316-1c4b-4281-b951-d872f2087c98
* Make feedback failure notification non stickyoshima@chromium.org2010-09-271-1/+1
| | | | | | | | | BUG=chromium-os:6368 TEST=none Review URL: http://codereview.chromium.org/3412033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60696 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor version-getting info into a chrome::VersionInfo object.evan@chromium.org2010-08-271-9/+6
| | | | | | | | | | | | | | | I was trying to replace wstring usage in base::FileVersionInfo, but that class is rather Windows-specific with strange fields like "private_build()" where the value and encoding aren't clear. 95% of the users of FileVersionInfo actually just care about the current Chrome version, so we can provide a much simpler interface for them. We still use FileVersionInfo for retrieving information from e.g. plugin DLLs, but in those cases the usage is clearer. Review URL: http://codereview.chromium.org/3135028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57725 0039d316-1c4b-4281-b951-d872f2087c98
* Build fixes to the CLrkc@google.com2010-08-221-27/+143
| | | | | | Review URL: http://codereview.chromium.org/3061044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57019 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Checkin for CL: http://codereview.chromium.org/3061044/show"phajdan.jr@chromium.org2010-08-191-142/+27
| | | | | | | | | | Broke compile. TBR=rkc Review URL: http://codereview.chromium.org/3199006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56717 0039d316-1c4b-4281-b951-d872f2087c98