summaryrefslogtreecommitdiffstats
path: root/chrome/browser/cancelable_request.cc
Commit message (Collapse)AuthorAgeFilesLines
* Move cancelable_request.cc/h to chrome/browser/common.kaiwang@chromium.org2012-09-221-140/+0
| | | | | | | | | | It is a commonly shared utility. Also move "!chrome/browser/browser_process.h" to test section in bookmarks/DEPS BUG=144783 Review URL: https://codereview.chromium.org/10958031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158151 0039d316-1c4b-4281-b951-d872f2087c98
* RefCounted types should not have public destructors, delegate cleanuprsleevi@chromium.org2012-06-261-12/+12
| | | | | | | | | | | | | | | | | | | | | | | | For Delegate/Observer-type classes that specify an interface but do not have any particular lifetime requirements, make their destructors protected. This is to allow their interfaces to be implemented safely by RefCounted types. With public destructors, it's possible to do "scoped_ptr<Delegate> foo", and then assign a RefCountedDelegateImpl, which would lead to a double free. As none of these Delegates actually need public destructors (ownership of the Delegate* is not transferred during a function call / class constructor), mark the destructors protected so that it becomes a compile warning to try to delete them via the Delegate*. BUG=123295 TEST=it compiles Review URL: https://chromiumcodereview.appspot.com/10383262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144086 0039d316-1c4b-4281-b951-d872f2087c98
* Move CancelableRequest to chrome/browser.joi@chromium.org2011-12-211-0/+140
| | | | | | | | | | | | | This does not update the include paths used in existing code. I will later TBR a trivial change that removes the redirect header (content/browser/cancelable_request.h) and updates all includes of cancelable_request.h (and sorts headers correctly). BUG=98716 Review URL: http://codereview.chromium.org/8974012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115326 0039d316-1c4b-4281-b951-d872f2087c98
* Move core pieces of chrome\browser. I've only gone up to "g", will do the ↵jam@chromium.org2011-02-221-106/+0
| | | | | | | | | rest in another cl. TBR=avi Review URL: http://codereview.chromium.org/6538100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75652 0039d316-1c4b-4281-b951-d872f2087c98
* Move CancellationFlag and WaitableEvent to the synchronization subdirectory.brettw@chromium.org2011-01-021-5/+5
| | | | | | | | TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/5977010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70369 0039d316-1c4b-4281-b951-d872f2087c98
* Mark common instantions of CancelableRequestConsumerTSimple as extern templates.erg@google.com2010-09-291-0/+28
| | | | | | | | | | | | | | | This means that these template instantiations will be built once in cancelable_request.cc instead of in each of the 20 files that use it. The definitions have been moved to make them not inline (as explicit template instantiation only works with non-inline members). This cuts more than 4 megabytes off libbrowser.a in Debug mode. This patch does nothing when compiled with MSVC, due to compiler problems. BUG=none TEST=compiles smaller Review URL: http://codereview.chromium.org/3520001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60974 0039d316-1c4b-4281-b951-d872f2087c98
* Improve example code for cancelable request -- pass consumer base class ↵joth@chromium.org2010-02-231-8/+9
| | | | | | | | | | | | | pointer in StartRequest as it is more general Make a small optimization: passing an iterator in CancelRequestLocked rather than Handle can avoid a call to map::find() BUG=none TEST=none Review URL: http://codereview.chromium.org/650143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39708 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix uninit warnings when building -Os.agl@chromium.org2009-11-161-1/+1
| | | | | | http://codereview.chromium.org/401002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32105 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGEdeanm@chromium.org2009-03-101-1/+0
| | | | | | | | | Normalize end of file newlines in chrome/. All files end in a single newline. Review URL: http://codereview.chromium.org/42015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11331 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-241-28/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a few places that wind up using Lock recursively.erikkay@google.com2008-08-121-1/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@725 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome to the repository.initial.commit2008-07-261-0/+99
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 16:49:57 +0000