| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
TBR=jam@chromium.org
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9600036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This also finishes breaking the Chrome dependency on RenderWidgetHostImpl and RenderViewHostImpl.
TBR=jam@chromium.org
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9599011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=98716
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/9421030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
trivial changes to use WebContents instead of TabContents.
BUG=98716
Review URL: http://codereview.chromium.org/9030032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the WebContents interface.
BUG=98716
Review URL: http://codereview.chromium.org/9007026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=105872
TEST=no functional change
Review URL: http://codereview.chromium.org/8892011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pull the CrAppProtocol autorelease-pool handling down into
MessagePumpCrApplication, which is selected at Create() if NSApp
implements the right protocol. UsingCrApp() allows clients to
confirm the correct setup (unfortunately, synchronizing NSApp
initialization and MessagePump::Create() would be intrusive).
Also push CrAppProtocol and CrAppControlProtocol implementation into
BrowserCrApplication, and reparent that class from NSApplication.
Reparent ServiceCrApplication on NSApplication and rename.
Remove CrApplication registration from gpu, plugin, and renderer
mains.
Remove MockCrApp dependency from remoting sample code.
BUG=102224
Review URL: http://codereview.chromium.org/8771028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also merge content/ MockCrControlApp into base/ MockCrApp.
Also use MockCrApp in test_shell_tests, and slight tweak to autorelease pool in test_shell's initialization.
BUG=102224
Review URL: http://codereview.chromium.org/8724004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
base/mac.
Also merge content/ MockCrControlApp into base/ MockCrApp.
BUG=102224
Review URL: http://codereview.chromium.org/8724004
TBR=shess@chromium.org
Review URL: http://codereview.chromium.org/8762020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also merge content/ MockCrControlApp into base/ MockCrApp.
BUG=102224
Review URL: http://codereview.chromium.org/8724004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Removing dependencies from content/.
BUG=102224
Review URL: http://codereview.chromium.org/8498034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Breakpad support currently resides in chrome/app/breakpad_mac.* this makes it inaccessible to lower level code that would also like to set crash keys e.g. The sandboxing infrastructure.
This CL refactors the crash key reporting code to reside in base/mac.
Logging is also added to the Sandbox code to try to track down the cause of crbug.com/94758.
BUG=95272, 94758
TEST=On official builds crash logs should contain crash keys e.g. OS version.
Review URL: http://codereview.chromium.org/7849011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
For the browser process, this will be overridden by
-[BrowserCrApplication init] (which raises it).
BUG=94551
TEST=Developers don't complain about zombie objects in other processes.
Review URL: http://codereview.chromium.org/7826016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Prefixes:
~/Library
/Library
/Network/Library
Suffixes:
Application Support/SIMBL/Plugins
Contextual Menu Items
InputManagers
ScriptingAdditions
Hosting parasitic third-party code in our application is the cause of
instability which has only increased since the release of Mac OS X 10.7
("Lion").
This replaces an earlier version of the change that only blocked NSBundle
loads. This version blocks CFBundle loads. NSBundle uses CFBundle to load
modules internally, so the NSBundle code is removed. The earlier version was
only operative in the browser process. This version is active in all process
types.
Some blocked modules may result in messages being logged to the system
console, such as:
Google Chrome: OpenScripting.framework - can't find entry point
(EntryPointName) in scripting addition /Library/ScriptingAdditions/...
Google Chrome[12345:678] Cannot find function pointer (EntryPointName) for
factory (UUID) in CFBundle/CFPlugin (address) </Library/Contextual Menu
Items/...> (not loaded)
BUG=90193
TEST=Crash less? Watch the stats.
Make sure that things in /Library/Contextual Menu Items,
/Library/InputManagers, and /Library/ScriptingAdditions aren't loaded
into the process. Any functionality they provide should be absent from
Chrome. Any crashes they provide should be absent as well.
Review URL: http://codereview.chromium.org/7694008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should really disable all thrid-party code from loading in our process.
BUG=90193,93262
TEST=Crash stats.
Review URL: http://codereview.chromium.org/7669032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Prefixes:
~/Library
/Library
/Network/Library
Suffixes:
Application Support/SIMBL/Plugins
Contextual Menu Items
Input Managers
ScriptingAdditions
Hosting parasitic third-party code in our application is the cause of
instability which has only increased since the release of Mac OS X 10.7
("Lion").
BUG=90193, 90920, 90716
TEST=Crash less? Watch the stats.
Review URL: http://codereview.chromium.org/7661007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=90075
TEST=Install that thing on Lion (good luck) and gesticulate. No crash.
Review URL: http://codereview.chromium.org/7481015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=85932
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90435
Review URL: http://codereview.chromium.org/7233022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This caused a legitimate check deps failure
er/accessibility/browser_accessibility_cocoa.mm depending on ui/base/l10n
BUG=85932
TEST=none
Review URL: http://codereview.chromium.org/7233022
TBR=dmazzoni@chromium.org
Review URL: http://codereview.chromium.org/7235008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=85932
TEST=none
Review URL: http://codereview.chromium.org/7233022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=85932
TEST=none
Review URL: http://codereview.chromium.org/7233022
TBR=dmazzoni@chromium.org
Review URL: http://codereview.chromium.org/7247022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=85932
TEST=none
Review URL: http://codereview.chromium.org/7233022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=85463
TEST=Crash server stops seeing crashes (see bug).
Review URL: http://codereview.chromium.org/7145006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
10.6 added object_destructInstance() as a wrapper around
object_cxxDestruct() and also releasing associated objects. As a
bonus, it's available via dlsym() rather than nlist().
BUG=82937
TEST=none
Review URL: http://codereview.chromium.org/7084017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NSZombie support is elbow-deep in the Objective-C runtime, so it
should only be enabled for runtimes which are known to support the
necessary assumptions.
BUG=82937
TEST=See bug.
Review URL: http://codereview.chromium.org/7083012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Thirdy-party print drivers seem to be a source of NSExceptions which
Chromium will never be able to fix. ScopedNSExceptionEnabler causes
the code which makes throwing an NSException fatal to allow throws.
The flag will be reset in -reportException: in most cases.
For now, allow exceptions to be thrown for -selectPDE: (bug 80686) and
PrintingContextMac::AskUserForSettings() (bug 82589).
BUG=80686, 82589
TEST=Monitor crash server.
Review URL: http://codereview.chromium.org/7038010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
set on AXApplication when VoiceOver's turned on. This gives us the ability to turn on ax even after a render widget host has started.
BUG=none
TEST=manually with VoiceOver. Launch Chrome, VoiceOver, windows, tabs (permuted order) and verify that ax is on. This sometimes required navigation to a different page or efreshing the current page.
Review URL: http://codereview.chromium.org/6909013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NSExceptions can cause the flag to get latched to YES, which messes
with window closing. A number of suspected exceptions shouldn't cause
too much other damage, so this patches over the problem for the short
term.
TBR=jam@chromium.org
BUG=45928
TEST=see bug
Review URL: http://codereview.chromium.org/6873081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=78782
TEST=Monitor crashes.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81855
Review URL: http://codereview.chromium.org/6861004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unfortunately, clang complained.
Original CL http://codereview.chromium.org/6861004/
http://src.chromium.org/viewvc/chrome?view=rev&revision=81855
BUG=78782
TBR=rsesek@chromium.org
TEST=waterfall
Review URL: http://codereview.chromium.org/6870024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=78782
TEST=Monitor crashes.
Review URL: http://codereview.chromium.org/6861004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
raw_scoped_refptr_mismatch_checker.h
ref_counted.cc
ref_counted.h
ref_counted_memory.cc
ref_counted_memory.h
ref_counted_unittest.cc
scoped_callback_factory.h
scoped_comptr_win.h
scoped_handle.h
scoped_native_library.cc
scoped_native_library.h
scoped_native_library_unittest.cc
scoped_nsobject.h
scoped_open_process.h
scoped_ptr.h
scoped_ptr_unittest.cc
scoped_temp_dir.cc
scoped_temp_dir.h
scoped_temp_dir_unittest.cc
scoped_vector.h
singleton.h
singleton_objc.h
singleton_unittest.cc
linked_ptr.h
linked_ptr_unittest.cc
weak_ptr.cc
weak_ptr.h
weak_ptr_unittest.cc
BUG=None
TEST=Compile
Review URL: http://codereview.chromium.org/6714032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On the crash server, almost all NSInvalidArgumentException cases are
due to sending a bad selector to an object. Most likely cause is a
stale pointer which has been reallocated to another object, or memory
stompers.
Also start tracking uncaught NSInternalInconsistencyException, which
is the most popular exception on the crash servers.
BUG=24462
TEST=none
Review URL: http://codereview.chromium.org/6698002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
An exception named |NSInternalInconsistencyException| with the reason
"View is not in any window" seems to be correlated with a particular
shutdown crash on the crash server. Crash at the point where the
exception is raised to get a better stack backtrace.
BUG=62597
TEST=none
Review URL: http://codereview.chromium.org/6529004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a @protocol CrAppProtocol that clients of base must implement in their NSApplication subclass, and let base depend only on this protocol.
Let MessagePumpNSApplication::DoRun() no longer initialize NSApplication (fixes a TODO).
Add a MockCrApplication that the simple unittests in base and app can use, move chrome_application to chrome/common.
Test shell might run nested run loops, so I gave it a real but simplified CrAppProtocol implementation.
BUG=62968,46929
TEST=Everything still works. The PDF plugin prints one fewer warning when loaded.
Review URL: http://codereview.chromium.org/5950003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24255
TEST=none
Review URL: http://codereview.chromium.org/5695006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
const NSString* -> NSString* const.
TBR=thakis@chromium.org
BUG=24462, 62597, 62763
TEST=none
Review URL: http://codereview.chromium.org/4979002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Exception name |NSInternalInconsistencyException| reason "Invalid
parameter not satisfying: (index >= 0) && (index < [_Itemarray
count])" is seen in many crashes, and has become more prevalent in
9.0. It appears corrlated with bug 62597. This change causes that
exception to CHECK() and generate a crash dump immediately.
BUG=24462, 62597, 62763
TEST=none
Review URL: http://codereview.chromium.org/4752007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
put them in the base namespace.
TEST=it compiles
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/2835007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/2813012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
As discussed on irc, we're getting rid of const NSObjects, and we're making all properties nonatomic.
const: All of cocoa takes nonconst NSObjects, and passing a const NSString to a function that takes NSString is a const violation. gcc doesn't complain about this, but clang intentionally does. constness is usually done via immutable base classes and mutable subclasses in cocoa anyway, so getting rid of const isn't that bad. Also, we don't really have a choice.
nonatomic: Some of our classes have custom setters that are not @synchronized. If the @property for that is not non-atomic, then the interface claims that the method is synchronized but the implementation actually isn't. That's a bug. gcc happens not to complain about this, but clang does. Since we shouldn't need atomic properties anywhere, the simple rule is now to just make all properties nonatomic.
Review URL: http://codereview.chromium.org/2769014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Attempt to flush out more use-after-free cases in the wild. Right now messages to freed ObjC objects are binned by the object's address, with this change they should aggregate into a bigger bin. Additionally, the treadmill should slightly increase the number of cases caught.
[Was reverted earlier due to Mac Perf(2). A fix to the zombie code should improve things.]
BUG=35590,24987,45676
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48838
Review URL: http://codereview.chromium.org/2478004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reverts r48933, which broke the Mac Perf(2) bot. The original CL's
review URL: http://codereview.chromium.org/2627001
TBR=avi
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2629003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Attempt to flush out more use-after-free cases in the wild. Right now
messages to freed ObjC objects are binned by the object's address,
with this change they should aggregate into a bigger bin.
BUG=35590, 24987, 45676
TEST=none
Review URL: http://codereview.chromium.org/2627001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Is causing Perf(2) redness.
TBR=pink,avi
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2588002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Attempt to flush out more use-after-free cases in the wild. Right now messages to freed ObjC objects are binned by the object's address, with this change they should aggregate into a bigger bin. Additionally, the treadmill should slightly increase the number of cases caught.
BUG=35590,24987,45676
TEST=none
Review URL: http://codereview.chromium.org/2478004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48838 0039d316-1c4b-4281-b951-d872f2087c98
|