summaryrefslogtreecommitdiffstats
path: root/chrome/browser/chrome_browser_main.cc
Commit message (Collapse)AuthorAgeFilesLines
* Revise user-data-dir switch handling; avoid crashes.msw@chromium.org2014-02-131-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | Chrome needs a pre-existing or creatable user-data-dir to run. ChromeMainDelegate::PreSandboxStartup was CHECK'ing for this. (crashing on startup with --user-data-dir="M:\invalid") (crashing on startup with --user-data-dir="C:\windows") Supposedly, we had a dialog to let users choose another dir. (I've never gotten this to work on M28-M32 stable versions) Revise the user-data-dir code to warn on invalid paths. (see crbug.com/318999#c18 for the warning screenshot) Then attempt to use the default directory as a backup. (no alternate dir selection UI, users can try again) This should avoid many of the numerous related crashes. BUG=318999 TEST=Supplying an invalid --user-data-dir=<path> will warn users and attempt to use the default directory instead of silently crashing. R=sky@chromium.org Review URL: https://codereview.chromium.org/123693003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251126 0039d316-1c4b-4281-b951-d872f2087c98
* Make some field trials unforceable via command-line in the official build.gab@chromium.org2014-02-131-1/+9
| | | | | | | | | | | | | BUG=342585 TEST=Remove the OFFICIAL_BUILD ifdefs and: 1) Confirm that running with --force-fieldtrials with an unforceable experiment and a forceable one only forces the forceable one. 2) Confirm that the value which couldn't be forced in the browser also makes it unforced in the renderer. Put the OFFICIAL_BUILD ifdefs back and confirm that unforceable experiments are still forceable in non-official builds. Review URL: https://codereview.chromium.org/153913009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250988 0039d316-1c4b-4281-b951-d872f2087c98
* [Variations] Read the policy from profile prefs if on Androidmathp@chromium.org2014-02-131-1/+3
| | | | | | | | | BUG=342839 TEST=Manually tested with a User Policy file running on an Android build. Review URL: https://codereview.chromium.org/136003008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250859 0039d316-1c4b-4281-b951-d872f2087c98
* views: Remove AcceleratorHandlersadrul@chromium.org2014-02-061-4/+0
| | | | | | | | | | | | The windows implementation in accelerator_handler_win.cc is not longer used, and the aura implementation in accelerator_handler_aura.cc is equivalent to the default message-pump. So remove AcceleratorHandler altogether. R=sky@chromium.org Review URL: https://codereview.chromium.org/156223002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249376 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor pref code out of ProfileImpl.gab@chromium.org2014-02-051-2/+1
| | | | | | | | | | | | | | | | | Moved into the chrome_pref_service_factory.cc ProfileImpl no longer has any notion of the Preferences file. This knowledge lives strictly in chrome_pref_service_factory.cc which now implements everything that needs to know about that file's path. As per noms@'s request on https://codereview.chromium.org/145053004/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249095 Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=249100 R=bauerb@chromium.org, erikwright@chromium.org, jochen@chromium.org, noms@chromium.org Review URL: https://codereview.chromium.org/154593002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249123 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary uses of aura::Env::GetDispatchersadrul@chromium.org2014-02-051-5/+0
| | | | | | | | | | | | | Avoid using aura::Env::GetDispatcher() as the dispatcher for new instances of base::RunLoop()s, since for both Windows and X11, it's the same as the message-pump. This patch also removes some non-aura views code, and some unnecessary USE_AURA ifdefs. R=darin@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/154203002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249105 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 249095 "Refactor pref code out of ProfileImpl."gab@chromium.org2014-02-051-1/+2
| | | | | | | | | | | | | | | | | | | | > Refactor pref code out of ProfileImpl. > > Moved into the chrome_pref_service_factory.cc > > ProfileImpl no longer has any notion of the Preferences file. This knowledge lives strictly in chrome_pref_service_factory.cc which now implements everything that needs to know about that file's path. > > As per noms@'s request on https://codereview.chromium.org/145053004/ > > TBR=jochen (chrome/browser/chrome_browser_main.cc) > > Review URL: https://codereview.chromium.org/154593002 TBR=gab@chromium.org Review URL: https://codereview.chromium.org/156013003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249100 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor pref code out of ProfileImpl.gab@chromium.org2014-02-051-2/+1
| | | | | | | | | | | | | | Moved into the chrome_pref_service_factory.cc ProfileImpl no longer has any notion of the Preferences file. This knowledge lives strictly in chrome_pref_service_factory.cc which now implements everything that needs to know about that file's path. As per noms@'s request on https://codereview.chromium.org/145053004/ TBR=jochen (chrome/browser/chrome_browser_main.cc) Review URL: https://codereview.chromium.org/154593002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249095 0039d316-1c4b-4281-b951-d872f2087c98
* Move TranslateLanguageList to the Translate componentdroger@chromium.org2014-02-051-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | A lot of static methods from TranslateManager are moved to TranslateDownloadManager, as they are related to the management of the TranslateLanguageList. The observer interface for translate events has been moved from TranslateManager to TranslateLanguageList. It also has been changed into a callback list rather than an observer list, since observers with a single method are generally discouraged. The SetSupportedLanguages() method in TranslateLanguageList has been moved from the anonymous namespace as it needs to invoke the callbacks for translate events. Finally, this CL fixes a bug where the TranslateList was not listening to ResourceRequestNotifications. BUG=335077, 335085, 339508 R=blundell@chromium.org, jochen@chromium.org, joi@chromium.org, mad@chromium.org TBR=jochen, joi, sky Review URL: https://codereview.chromium.org/143003020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248975 0039d316-1c4b-4281-b951-d872f2087c98
* Cache feedback reports to disk in case of send failure.rkc@chromium.org2014-02-041-0/+5
| | | | | | | | | | | | | R=zork@chromium.org BUG=249853 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246992 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247772 Review URL: https://codereview.chromium.org/141433011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248648 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove some unused code, or make them platform specific.thestig@chromium.org2014-02-031-0/+8
| | | | | | | | Found by Scythe. Review URL: https://codereview.chromium.org/136113019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248465 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 247772 "Cache feedback reports to disk in case of send fa..."benwells@chromium.org2014-01-301-5/+0
| | | | | | | | | | | | | | | | | | | | > Cache feedback reports to disk in case of send failure. > > R=zork@chromium.org > BUG=249853 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246992 > > Review URL: https://codereview.chromium.org/141433011 This introduced a race condition picked up by the TSAN bots. BUG=339326 TBR=rkc@chromium.org Review URL: https://codereview.chromium.org/149993002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247816 0039d316-1c4b-4281-b951-d872f2087c98
* Split ExtensionSystem interface from ExtensionSystemImpl implementation, part 1.yoz@chromium.org2014-01-301-1/+1
| | | | | | | | | | | | | This moves ExtensionSystem to extensions/browser. It also moves setting the channel for Features to ChromeExtensionsBrowserClient. It also removes the duplicate ExtensionSystem::GetForBrowserContext. BUG=337707 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/147923005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247788 0039d316-1c4b-4281-b951-d872f2087c98
* Cache feedback reports to disk in case of send failure.rkc@chromium.org2014-01-291-0/+5
| | | | | | | | | | | R=zork@chromium.org BUG=249853 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246992 Review URL: https://codereview.chromium.org/141433011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247772 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce TranslateService and TranslateDownloadManagerdroger@chromium.org2014-01-291-10/+5
| | | | | | | | | | | | | | | This CL removes the TranslateDelegate interface and introduces TranslateService and TranslateDownloadManager. This will enable (in a future CL) to move TranslateScript and TranslateLanguageList in the Translate component, and TranslateDownloadManager will own them. BUG=332736 Review URL: https://codereview.chromium.org/145023015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247724 0039d316-1c4b-4281-b951-d872f2087c98
* TrackedPreferences are initialized when a profile is created or loaded. But ↵erikwright@chromium.org2014-01-281-0/+15
| | | | | | | | | | | | | | profiles that have not been loaded are not being tracked. At startup, identify profiles whose PrefHashStores have not been initialized and initialize them. BUG=336478 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247250 Review URL: https://codereview.chromium.org/117593002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247349 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 247250 "TrackedPreferences are initialized when a profile..."mad@chromium.org2014-01-271-15/+0
| | | | | | | | | | | | | | | | | | It was causing crashes in some Android tests. > TrackedPreferences are initialized when a profile is created or loaded. But profiles that have not been loaded are not being tracked. > > At startup, identify profiles whose PrefHashStores have not been initialized and initialize them. > > BUG=336478 > > Review URL: https://codereview.chromium.org/117593002 TBR=erikwright@chromium.org Review URL: https://codereview.chromium.org/139263012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247284 0039d316-1c4b-4281-b951-d872f2087c98
* TrackedPreferences are initialized when a profile is created or loaded. But ↵erikwright@chromium.org2014-01-271-0/+15
| | | | | | | | | | | | profiles that have not been loaded are not being tracked. At startup, identify profiles whose PrefHashStores have not been initialized and initialize them. BUG=336478 Review URL: https://codereview.chromium.org/117593002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247250 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Cache feedback reports to disk in case of send failure. ↵hclam@chromium.org2014-01-251-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/141433011/) Reason for revert: This change is causing memory error on this bot: http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%29/builds/15509 Original issue's description: > Cache feedback reports to disk in case of send failure. > > R=zork@chromium.org > BUG=249853 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246992 TBR=zork@chromium.org,thestig@chromium.org,rkc@chromium.org NOTREECHECKS=true NOTRY=true BUG=249853 Review URL: https://codereview.chromium.org/133193004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247061 0039d316-1c4b-4281-b951-d872f2087c98
* Cache feedback reports to disk in case of send failure.rkc@chromium.org2014-01-241-0/+5
| | | | | | | | | R=zork@chromium.org BUG=249853 Review URL: https://codereview.chromium.org/141433011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246992 0039d316-1c4b-4281-b951-d872f2087c98
* Add plumbing for persisting a signature for the variations seed.asvitkine@chromium.org2014-01-231-0/+4
| | | | | | | | | | | In a later CL, I will add logic to actually use this signature for validating the integrity of the seed. BUG=336536 Review URL: https://codereview.chromium.org/143803008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246702 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 243623 "Revert profile cleanup temporarily to verify regr..."pastarmovj@google.com2014-01-211-0/+26
| | | | | | | | | | | | | | | | | | The perf results didn't change after reverting this CL so I am going to bring it back in. > Revert profile cleanup temporarily to verify regression is really caused by it. > > BUG=310934 > TEST=Let's see what the chrome-rel-mac6 bot has to say about this. > > Review URL: https://codereview.chromium.org/128413003 TBR=pastarmovj@chromium.org Review URL: https://codereview.chromium.org/134733006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246019 0039d316-1c4b-4281-b951-d872f2087c98
* Removes MessageLoop::Type checks in favor of IsCurrent on MessageLoops.sky@chromium.org2014-01-201-1/+1
| | | | | | | | | | | | This is part of removing the MessageLoop::Type enum. BUG=none TEST=none R=darin@chromium.org Review URL: https://codereview.chromium.org/141683005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245882 0039d316-1c4b-4281-b951-d872f2087c98
* Move component updater artifacts into component_updater namespace.sorin@chromium.org2014-01-171-1/+2
| | | | | | | | | | | | sky@ please look at the files in chrome/browser for owner approval. Long term, the idea is to unify several updaters in Chrome, so having a specific namespace could help avoiding name conflicts. Short term, the change reduces some naming verbosity in the implementation but makes the call site names longer, so it is a wash. Review URL: https://codereview.chromium.org/138553004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245596 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid loading the last used browser profile in app_controller_mac when it's ↵tapted@chromium.org2014-01-161-23/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | not needed. Currently -[AppController applicationDidFinishLaunching:] and -[AppController windowLayeringDidChange:] can trigger a synchronous load of the last used _browser_ profile, even when no browsers are being opened, and that profile is not required. This causes delays when the app launcher or app shims are launched for a profile that doesn't match the last used browser profile, because both profiles must be loaded and initialized. This change moves ChromeBrowserMain's GetStartupProfilePath() from an anonymous namespace to startup_browser_creator.h so that AppController can share the logic that determines the profile loaded when the browser process starts up. The shim process is tweaked slightly to ensure it passes `--show-app-list` for the app launcher shim, similar to the Windows app launcher. This allows a newly created browser process to determine that the first thing it will be doing is showing a launcher. BUG=178260, 262848 Review URL: https://codereview.chromium.org/127343004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245199 0039d316-1c4b-4281-b951-d872f2087c98
* Enable SDCH support over HTTPS if --enable-sdch=2 switch is present.mef@chromium.org2014-01-101-6/+13
| | | | | | | | | | BUG=313716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243957 Review URL: https://codereview.chromium.org/123383002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244217 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 243957 "Enable SDCH support over HTTPS if --enable-sdch=2..."noamsml@google.com2014-01-101-13/+6
| | | | | | | | | | | | | | > Enable SDCH support over HTTPS if --enable-sdch=2 switch is present. > > BUG=313716 > > Review URL: https://codereview.chromium.org/123383002 TBR=mef@chromium.org Review URL: https://codereview.chromium.org/130893005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244038 0039d316-1c4b-4281-b951-d872f2087c98
* Enable SDCH support over HTTPS if --enable-sdch=2 switch is present.mef@chromium.org2014-01-091-6/+13
| | | | | | | | BUG=313716 Review URL: https://codereview.chromium.org/123383002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243957 0039d316-1c4b-4281-b951-d872f2087c98
* Move LanguageUsageMetrics and TranslateBrowserMetrics to componentsdroger@chromium.org2014-01-091-3/+3
| | | | | | | | | | | | | | LanguageUsageMetrics is moved to its own component because it is used both in the translate component and directly in the browser. TranslateBrowserMetrics is moved to the translate component. BUG=331509 TBR=jochen Review URL: https://codereview.chromium.org/131203002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243946 0039d316-1c4b-4281-b951-d872f2087c98
* Removing GetDefaultProfileOrOffTheRecord and GetDefaultProfile(<path>) from ↵skuhne@chromium.org2014-01-091-9/+14
| | | | | | | | | | | ProfileManager's (public) functions. BUG=322682 TEST=covered by existing unit tests Review URL: https://codereview.chromium.org/129293002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243939 0039d316-1c4b-4281-b951-d872f2087c98
* Revert profile cleanup temporarily to verify regression is really caused by it.pastarmovj@chromium.org2014-01-081-26/+0
| | | | | | | | | BUG=310934 TEST=Let's see what the chrome-rel-mac6 bot has to say about this. Review URL: https://codereview.chromium.org/128413003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243623 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 242262 "Revert of https://codereview.chromium.org/119913003/"aurimas@google.com2014-01-071-6/+10
| | | | | | | | | | | | | | | | | | | | reland r242237 that got reverted in r242262. > Revert of https://codereview.chromium.org/119913003/ > Reason for revert: Broke ComponentUpdaterTest on Android. Need to update expectations. > > TBR=cpu@chromium.org,thakis@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=116838 > > Review URL: https://codereview.chromium.org/120433002 TBR=aurimas@chromium.org Review URL: https://codereview.chromium.org/112673008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243217 0039d316-1c4b-4281-b951-d872f2087c98
* Remove kChromeFrame checks in the browser process.jam@chromium.org2014-01-021-9/+3
| | | | | | | | R=grt@chromium.org Review URL: https://codereview.chromium.org/122383003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242804 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 242455 "Revert 242449 "Update some uses of UTF conversion..."avi@chromium.org2013-12-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | > Revert 242449 "Update some uses of UTF conversions in chrome/bro..." > > > Update some uses of UTF conversions in chrome/browser to use the base:: namespace. > > > > BUG=330556 > > TEST=no change > > TBR=ben@chromium.org > > > > Review URL: https://codereview.chromium.org/120943002 > > TBR=avi@chromium.org > > Review URL: https://codereview.chromium.org/103853007 TBR=avi@chromium.org Review URL: https://codereview.chromium.org/120993002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242463 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 242449 "Update some uses of UTF conversions in chrome/bro..."avi@chromium.org2013-12-241-1/+1
| | | | | | | | | | | | | | | | > Update some uses of UTF conversions in chrome/browser to use the base:: namespace. > > BUG=330556 > TEST=no change > TBR=ben@chromium.org > > Review URL: https://codereview.chromium.org/120943002 TBR=avi@chromium.org Review URL: https://codereview.chromium.org/103853007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242455 0039d316-1c4b-4281-b951-d872f2087c98
* Update some uses of UTF conversions in chrome/browser to use the base:: ↵avi@chromium.org2013-12-241-1/+1
| | | | | | | | | | | | namespace. BUG=330556 TEST=no change TBR=ben@chromium.org Review URL: https://codereview.chromium.org/120943002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242449 0039d316-1c4b-4281-b951-d872f2087c98
* Update some uses of Value in chrome/browser to use the base:: namespace.avi@chromium.org2013-12-231-1/+1
| | | | | | | | | | | BUG=88666 TEST=no change R=brettw@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/106433007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242387 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of https://codereview.chromium.org/119913003/aurimas@chromium.org2013-12-211-10/+6
| | | | | | | | | | | | | Reason for revert: Broke ComponentUpdaterTest on Android. Need to update expectations. TBR=cpu@chromium.org,thakis@chromium.org NOTREECHECKS=true NOTRY=true BUG=116838 Review URL: https://codereview.chromium.org/120433002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242262 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Component Updater on Androidaurimas@chromium.org2013-12-211-6/+10
| | | | | | | | | | | Enable CRL set fetching Enable WebUI for chrome://components BUG=116838 Review URL: https://codereview.chromium.org/119913003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242237 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize high dpi early in the chrome process on Windows by calling the ↵ananta@chromium.org2013-12-201-4/+0
| | | | | | | | | | | | | | | | SetProcessDpiAware API in chrome.exe instead of chrome.dll This API needs to be invoked as early as possible in the process. Not doing this causes the OS to assume that the process needs dpi scaling which leads to bad things. We also need to initialize high dpi in the gpu process as it is involved in win32 operations like painting, etc. BUG=330093 R=cpu@chromium.org TBR=sky Review URL: https://codereview.chromium.org/100923011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242182 0039d316-1c4b-4281-b951-d872f2087c98
* Getting rid of temporary IsGetDefaultProfileAllowed instrumentationskuhne@chromium.org2013-12-201-4/+0
| | | | | | | | | | | Getting closer to get rid of GetDefaultProfile. This is now removing the temporary instrumentation from stevenjb which was adding a check to see that GetDefaultProfile does not get called before a Profile was created. I discussed with dpolukhin and nkostylev and instead of renaming this to something like "WasProfileCreated" (or similar) the instrumentation should get removed (since it was temporary to begin with). BUG=322682 TEST=covered by existing unit tests Review URL: https://codereview.chromium.org/119593002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242169 0039d316-1c4b-4281-b951-d872f2087c98
* Run all flag-checks for new-profile-managment et al through common functions ↵bcwhite@chromium.org2013-12-181-1/+2
| | | | | | | | | | | | | | | | | | | for future Finch integration. In order to do tests and a safe, controlled roll-out of Chrome's new profile management, we're going to enable it using a Finch experiment. The current tests of the existing command-line flags all need to be routed through common functions in order to override these settings if a Finch experiment is set. Affected flags are: --new-profile-management --enable-inline-signin --google-profile-info Note that there existed a function to test for NewProfileManagement but it was not in a good place for general testing and definitely not for other flags so it has been extracted as well. BUG=324046 Review URL: https://codereview.chromium.org/108803007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241698 0039d316-1c4b-4281-b951-d872f2087c98
* Removes some dead codesky@chromium.org2013-12-171-14/+0
| | | | | | | | | | | | This isn't going to be used, so nuking. BUG=none TEST=none R=brettw@chromium.org Review URL: https://codereview.chromium.org/99133026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241345 0039d316-1c4b-4281-b951-d872f2087c98
* Send UMA stability stats in a separate UMA log on startup. asvitkine@chromium.org2013-12-161-3/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This is implemented behind a field trial, so that we can roll-out this functionality while monitoring crash stats, to ensure there's no problem with the stats being misreported. This change splits the initial UMA upload into two separate logs when the previous session didn't end cleanly. The first will contain the system profile from the previous session (which has been saved to local state), as well as the Chrome stability stats. The second log will have the regular startup metrics (histograms and profiler data). With the new (behind a field-trial) behavior, the code also reads unsent logs from prefs (that are already in memory) earlier, so that it can persist the initial stability log, in case a crash happens before it's sent. I've added some UMA histograms to track how long reading/saving unsent logs takes and will evaluate this when ramping up the field trial to ensure the time taken is acceptable. BUG=312733 TEST=Manual by running with command-line --enable-metrics-reporting- for-testing --force-fieldtrials=UMAStability/SeparateLog/ and running my own modified UMA server and logging requests. Also, new unit tests. Review URL: https://codereview.chromium.org/81603002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240919 0039d316-1c4b-4281-b951-d872f2087c98
* cros: Remove default pinned apps trial.xiyuan@chromium.org2013-12-131-6/+0
| | | | | | | | | | | | - Remove the trial code; - Clean up trial local state value; - Deprecate UMA; BUG=234415 Review URL: https://codereview.chromium.org/99763005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240770 0039d316-1c4b-4281-b951-d872f2087c98
* Do not call SetDefaultBrowser() twice on first run.gab@chromium.org2013-12-111-1/+2
| | | | | | | | | | | ... and other minor cleanups regarding unattended default browser setup. TBR=thakis BUG=320650 Review URL: https://codereview.chromium.org/108193004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239966 0039d316-1c4b-4281-b951-d872f2087c98
* Rename the X-Chrome-Variations header to X-Client-Data.dcblack@chromium.org2013-12-051-1/+1
| | | | | | | | BUG=325472 Review URL: https://codereview.chromium.org/103063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239054 0039d316-1c4b-4281-b951-d872f2087c98
* Fix race / DCHECK in MetricsService. asvitkine@chromium.org2013-12-041-7/+0
| | | | | | | | | | | | | | | | | | | Without this CL, there's a race where the init task races against the "final log collection" step for the first UMA log. If the "final log collection" step would win, a DCHECK would be hit and I think the initial log would not be be sent up. This fixes the race by handling that case in the MetricsReportingScheduler. Also adds a histogram to track how many times this happens as well as some unit tests for MetricsReportingScheduler. Also, re-enables MetricsService recording/reporting under debug builds. BUG=156979 TEST=New unit tests. Review URL: https://codereview.chromium.org/96913005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238589 0039d316-1c4b-4281-b951-d872f2087c98
* linux_aura: Port the root error dialog.erg@chromium.org2013-11-251-3/+3
| | | | | | | | | BUG=284562 R=pastarmovj@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/83293005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237139 0039d316-1c4b-4281-b951-d872f2087c98
* Android: Disable about:flags impl-side-painting overridesievers@chromium.org2013-11-221-2/+1
| | | | | | | | | | | | | | | | | | We don't support running with impl-side painting disabled on Android anymore. (It's hardcoded to enabled for Android in cc/base/switches.cc) Removing it from the supported experiments should also cause it to be ignored at startup when loading the profile (see ConvertFlagsToSwitches called from ChromeBrowserMainParts::PreCreateThreadsImpl), so that users that turned this off some time in the past will be forced to enabled again. BUG=321545 TBR=thakis@chromium.org NOTRY=True Review URL: https://codereview.chromium.org/82553012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236869 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-30 04:19:01 +0000