summaryrefslogtreecommitdiffstats
path: root/chrome/browser/chromeos/audio_handler.cc
Commit message (Collapse)AuthorAgeFilesLines
* Improved thread safetydavej@chromium.org2010-08-111-0/+1
| | | | | | | | | | | Before these fixes, if PulseAudio was installed, but had no devices, one of the callbacks could hang indefinitely. If told to shut down before initialization had completed, weird things may have happened. Now the mixer can be shut down at any time, and can handle requests safely from different threads. BUG=5141 TEST=Make sure the "E: mutex-posic.c" assertion is no longer appearing in build-bot logs Review URL: http://codereview.chromium.org/3069025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55751 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 53992 - An earlier check-in (r51786, Issue 2769008) caused a memory ↵brettw@chromium.org2010-07-291-5/+8
| | | | | | | | | | | | | | leak on the build bots when PulseAudio was initialized on a separate worker thread. This change calls PulseAudioMixer::InitSync() so the init happens on the calling thread. For some reason, the init finishes cleanly on one thread, but not the other. BUG=48553 (and http://code.google.com/p/chromium-os/issues/detail?id=5141) TEST=Valgrind should not have PulseAudio related memory leaks, suppression 48553, or assertion failures. Review URL: http://codereview.chromium.org/3026028 TBR=davej@chromium.org Review URL: http://codereview.chromium.org/3013042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54170 0039d316-1c4b-4281-b951-d872f2087c98
* An earlier check-in (r51786, Issue 2769008) caused a memory leak on the ↵davej@chromium.org2010-07-281-8/+5
| | | | | | | | | | | build bots when PulseAudio was initialized on a separate worker thread. This change calls PulseAudioMixer::InitSync() so the init happens on the calling thread. For some reason, the init finishes cleanly on one thread, but not the other. BUG=48553 (and http://code.google.com/p/chromium-os/issues/detail?id=5141) TEST=Valgrind should not have PulseAudio related memory leaks, suppression 48553, or assertion failures. Review URL: http://codereview.chromium.org/3026028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53992 0039d316-1c4b-4281-b951-d872f2087c98
* Sometimes pulseaudio is restarted if system goes into hibernation or sleep ↵davej@chromium.org2010-07-221-21/+38
| | | | | | | | | | | | | and resumes. When this happens, we were not reconnecting to pulse, and so could not adjust volume from that point on. BUG=4017 TEST=In shell, kill the pulseaudio process. It will auto-restart and volume keys should still work Review URL: http://codereview.chromium.org/2959015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53367 0039d316-1c4b-4281-b951-d872f2087c98
* Asynchronous threaded volume get/set/initscherkus@chromium.org2010-07-071-32/+19
| | | | | | | | | | | | | | | | | | | | Non-blocking version of init is now being called, and asynchronous set/get of mute and volume is implmenented at PulseAudioMixer level. The logic has been updated in SystemKeyEventListener so that the audio key behavior follows the latest doc 'Chrome OS Audio Scenarios': Increase volume key: unmutes aduio if muted, otherwise increases volume. Decrease volume key: do nothing if muted, otherwise decrease volume. Mute volume key: always mutes volume. UI is displayed after any volume key press. Currently only the init is being called asynchronously, but the next step will be to add a call allowing asynchronous operation of the volume adjust/unmute sequence from SystemKeyEventListener, and move the ShowVolumeBubble() calls into AudioHandler so that the volume bubble will update once the calls complete on their own thread. Patch by davej@chromium.org: http://codereview.chromium.org/2769008/show BUG=2910 Test=Play video or audio in ChromeOS, and press the system volume up, down, and mute keys to see they follow the above behavior. Alternating Mute and Increment Volume presses should always bring the volume back to the same level and not creep it upwards. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51786 0039d316-1c4b-4281-b951-d872f2087c98
* Tiny cleanup in Volume code.glotov@chromium.org2010-06-281-2/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2842026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50970 0039d316-1c4b-4281-b951-d872f2087c98
* Using PulseAudio for volume and mute key handling.scherkus@chromium.org2010-06-071-0/+167
Patch by davej@chromium.org: http://codereview.chromium.org/2285004/show BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49099 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-06 08:13:27 +0000