summaryrefslogtreecommitdiffstats
path: root/chrome/browser/chromeos/cros
Commit message (Collapse)AuthorAgeFilesLines
* chromeos: Replace copy-and-pasted code with macros.derat@chromium.org2010-12-232-179/+46
| | | | | | | | | | | | This replaces a bunch of duplicated-per-library cros function definitions and comments. BUG=none TEST=built it Review URL: http://codereview.chromium.org/6086007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70070 0039d316-1c4b-4281-b951-d872f2087c98
* Extend the TTS extension API to allow an extension to register itself asdmazzoni@chromium.org2010-12-233-0/+29
| | | | | | | | | | | a TTS provider. BUG=none TEST=Adds new test. Review URL: http://codereview.chromium.org/4161007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70062 0039d316-1c4b-4281-b951-d872f2087c98
* Update CrOS time formatting APIs too.avi@chromium.org2010-12-221-5/+3
| | | | | | | | | BUG=23581 TEST=everything still works Review URL: http://codereview.chromium.org/6037009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69949 0039d316-1c4b-4281-b951-d872f2087c98
* Remove CrOS hack from ppapi.gyp that made the include directories work. Thisbrettw@chromium.org2010-12-1719-21/+19
| | | | | | | | | | fixes the includes for cros to use "third_party" so that everything works. TEST=none BUG=none Review URL: http://codereview.chromium.org/5854003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69493 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash when disabling 3g.chocobo@chromium.org2010-12-151-9/+15
| | | | | | | | BUG=chromium-os:9790 TEST=Manual. Followed steps in bug to make sure crash no longer happens. Review URL: http://codereview.chromium.org/5722008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69283 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for http://crosbug.com/8870 + remembered network code cleanup.stevenjb@google.com2010-12-152-46/+55
| | | | | | | | | BUG=chromium-os:8870 TEST=Requires extensive testing of remembered network behavior. Test plan to be added soon. Review URL: http://codereview.chromium.org/5586010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69270 0039d316-1c4b-4281-b951-d872f2087c98
* Make members of Singleton<T> private and only visible to the singleton type. ↵satish@chromium.org2010-12-142-3/+11
| | | | | | | | | | | | | | | This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness. As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file. There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5682008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69107 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded browser_thread.h usage.thestig@chromium.org2010-12-131-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5676004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69037 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Show onscreen bubble when brightness changes.derat@chromium.org2010-12-104-0/+142
| | | | | | | | | | | | | | | | | | | | This adds a BrightnessLibrary class that registers to receive notification of brightness changes from the libcros code that I added in http://codereview.chromium.org/5640003/, a BrightnessBubble class to control an onscreen indicator of the current brightness level, and a BrightnessObserver class that wires up the two. This change depends on http://codereview.chromium.org/5603012/, which pulls the updated version of libcros into Chrome. BUG=chromium-os:8473,chromium-os:4816 TEST=built and tried it Review URL: http://codereview.chromium.org/5620004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68879 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded browser_process.h includes.thestig@chromium.org2010-12-051-2/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5512009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68323 0039d316-1c4b-4281-b951-d872f2087c98
* Remove check of service->favorite for remembered networks.stevenjb@google.com2010-12-031-14/+11
| | | | | | | | | BUG=chromium-os:9930 TEST=Log in as owner and connect/disconnect to/from several networks. Confirm the correct ones show up in the remembered networks list. Review URL: http://codereview.chromium.org/5635001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68180 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 67369 - Forget newly connected networks when not owner.stevenjb@google.com2010-12-022-36/+3
| | | | | | | | | | | | BUG=chromium-os:8552 TEST=See issue, but note: networks should only be remembered if the owner is logged in, i.e. 'guest' apples to any non owner login. Review URL: http://codereview.chromium.org/5278011 TBR=stevenjb@google.com Review URL: http://codereview.chromium.org/5548005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68073 0039d316-1c4b-4281-b951-d872f2087c98
* Implement wifi scanning state properlystevenjb@google.com2010-12-021-9/+5
| | | | | | | | | | | | This addresses the edge case where the UI gets stuck in a 'scanning' state. This is possible now that chromium-os:9326 is fixed. BUG=chromium-os:9448 TEST=See issue Review URL: http://codereview.chromium.org/5497001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68044 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify netowork library mock expectationsstevenjb@google.com2010-12-024-59/+55
| | | | | | | | | | | | | | | BUG=chromium-os:9707 TEST=Run browser_tests From chromium-os:9707: Currently CrosMock::SetNetworkLibraryStatusAreaExpectations() sets up a host of very specific expectations. These are fragile and difficult to maintain, and they break pretty much every browser test when they become stale. TODO: Replace these with a minimal set of specific expectations (e.g. just set expectations for *_connected() and *_connecting() calls). Review URL: http://codereview.chromium.org/5402001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68038 0039d316-1c4b-4281-b951-d872f2087c98
* Move ScopedStubCrosEnabler to cros_library.h and use it in Chrome OS tests.satorux@chromium.org2010-12-021-0/+16
| | | | | | | | | BUG=chromium-os:9872 TEST=run all chrome os tests with try Review URL: http://codereview.chromium.org/5529002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67983 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce CPU usage for input method switching.yusukes@google.com2010-12-022-10/+39
| | | | | | | | | | | | | - Move GetNumActiveInputMethods call from input_method_menu_button.cc to input_method_library.cc so that the IBus function is called only once even when multiple Chrome windows are available. - Improved InputMethodMenu::InputMethodChanged so that only the first input method button would update Preferences. - Remove ImePropertiesChanged callback. It's obsolete. BUG=chromium-os:8553 TEST=manually. Review URL: http://codereview.chromium.org/4162002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67973 0039d316-1c4b-4281-b951-d872f2087c98
* Notify the CrOS Enterprise Daemon if an Enterprise Extension has been installedgfeher@chromium.org2010-12-013-0/+9
| | | | | | | | | | | Listen for extension install events and restart the Enterprise Daemon if an extension was installed, that is from a policy and it contains the policy marker file. BUG=chromeos:9702 TEST=manual Review URL: http://codereview.chromium.org/5311007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67847 0039d316-1c4b-4281-b951-d872f2087c98
* Land for jackc@codeaurora.com:chocobo@chromium.org2010-11-301-3/+12
| | | | | | | | | | | | | | | | | | | | | | | This is a fix for when multiple ethernet services exist (etho0, dummy0, etc). The code loops through all available services, and if it is of TYPE_ETHERNET, will assign it as the default service to use. If there are multiple services of TYPE_ETHERNET, later services in the array will overwrite earlier ones. If the last service is something without a real connection (such as dummy0), you will not be able to access the internet. Also, earlier services are never deleted and will be leaked. This change will stop reassigning services once a service is created and has a working connection. It will also delete previous connections to fix the memory leak. This fix was originally implemented http://codereview.chromium.org/3027015/ but was removed in http://codereview.chromium.org/4169001/ BUG=chromium-os:9766 TEST=Manual. Check to make sure connecting/disconnecting ethernet works as normal. Review URL: http://codereview.chromium.org/5289007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67779 0039d316-1c4b-4281-b951-d872f2087c98
* Disable auto shutdown of ibus-daemon on the screenlockerzork@chromium.org2010-11-293-1/+15
| | | | | | | | | BUG=chromium-os:9207 TEST=Enable mozc and us layout. Enable the screen locker. Close the lid. Open the lid. Check that ibus-daemon is still running. Review URL: http://codereview.chromium.org/5389002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67512 0039d316-1c4b-4281-b951-d872f2087c98
* Make cellular icons show red badge when we need new plan.chocobo@chromium.org2010-11-261-0/+3
| | | | | | | | BUG=chromium-os:9504 TEST=none Review URL: http://codereview.chromium.org/5366002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67438 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where data plan info gets wiped out after a network refresh.chocobo@chromium.org2010-11-251-4/+19
| | | | | | | | BUG=chromium-os:9643 TEST=after getting a plan, click on the menu a few times and make sure it always shows how much data left. Review URL: http://codereview.chromium.org/5337005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67420 0039d316-1c4b-4281-b951-d872f2087c98
* Update default timezone name to match CL3432015 (r65850)oshima@chromium.org2010-11-251-1/+1
| | | | | | | | | BUG=chromium-os:9623 TEST=see the bug for repro step. Review URL: http://codereview.chromium.org/5347004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67370 0039d316-1c4b-4281-b951-d872f2087c98
* Forget newly connected networks when not owner.stevenjb@google.com2010-11-252-3/+36
| | | | | | | | | BUG=chromium-os:8552 TEST=See issue, but note: networks should only be remembered if the owner is nogged in, i.e. 'guest' apples to any non owner login. Review URL: http://codereview.chromium.org/5278011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67369 0039d316-1c4b-4281-b951-d872f2087c98
* Add error message for immediate failure on short passwords.stevenjb@google.com2010-11-243-5/+11
| | | | | | | | | BUG=chromium-os:9100 TEST=See issue. Test repeatedly connecting to a variety of secure and 'other' wifi networks. Review URL: http://codereview.chromium.org/5303006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67346 0039d316-1c4b-4281-b951-d872f2087c98
* Use TimeFormat::TimeRemaining for CellularDataPlan::GetUsageInfo.xiyuan@chromium.org2010-11-231-31/+14
| | | | | | | | | | | | CellularDataPlan::GetUsageInfo is used for network menu's expiration label and TimeFormat::TimeRemaining is prefered per chromium-os:9331. BUG=chromium-os:9331 TEST=Verify fix for chromium-os:9331 Review URL: http://codereview.chromium.org/5221004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67176 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tests.chocobo@chromium.org2010-11-231-8/+4
| | | | | | | TBR=stevenjb@chromium.org Review URL: http://codereview.chromium.org/5310002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67053 0039d316-1c4b-4281-b951-d872f2087c98
* Build break for compile warning.zelidrag@chromium.org2010-11-221-3/+3
| | | | | | | | | | TBR=satorux BUG=none TEST=bbots are happy place again Review URL: http://codereview.chromium.org/5126006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66928 0039d316-1c4b-4281-b951-d872f2087c98
* Submitting on behalf of ers@chromium.org, the original CL at ↵zelidrag@chromium.org2010-11-222-17/+59
| | | | | | | | | | | | | | | | | http://codereview.chromium.org/5217004/: Switch to using network connectivity_state, which replaces restricted_pool. BUG=chromium-os:9228 TEST=starting from a partially activated state, tried to activate, and saw that the browser navigated to the payment portal. Also monitored the chrome log and verified that chrome was seeing the connectivity state change to "restricted". Review URL: http://codereview.chromium.org/5112009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66926 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 3g data plan notification and menu color.chocobo@chromium.org2010-11-192-30/+78
| | | | | | | | | Fix 3g data expiration crash. BUG=chromium-os:9388 TEST=manual Review URL: http://codereview.chromium.org/5197002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66826 0039d316-1c4b-4281-b951-d872f2087c98
* Clear passphrase when canceling a failed connection attempt.stevenjb@chromium.org2010-11-181-8/+34
| | | | | | | | | | | Also, keep the connect dialog up after an immediate conenction failure (e.g. due to an invalid password format) BUG=chromium-os:8566 TEST=See issue. Also, test conencting to network with a combination of good / bad passwords in general. Note: the only way currently to re-enter the passphrase for a successfully remembered network is to forget it, log out, and log back in. Review URL: http://codereview.chromium.org/5160004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66698 0039d316-1c4b-4281-b951-d872f2087c98
* Add wifi 'searching' to netowkr menu for chromium-os:4982stevenjb@chromium.org2010-11-183-48/+72
| | | | | | | | | BUG=chromium-os:4982 TEST=Network menu should say 'scanning' above the 'disable wi-fi' option while networks are scanned after opening the menu. Review URL: http://codereview.chromium.org/5230002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66689 0039d316-1c4b-4281-b951-d872f2087c98
* Fix testschocobo@chromium.org2010-11-181-1/+1
| | | | | | | | | BUG=None TEST=None TBR=stevenjb@chromium.org Review URL: http://codereview.chromium.org/5209002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66565 0039d316-1c4b-4281-b951-d872f2087c98
* Workaround bug in flimflam to fix active_network not being reported ↵chocobo@chromium.org2010-11-182-33/+74
| | | | | | | | | | propertly causing ethernet icon to get stuck. BUG=chromium-os:8785 TEST=manual. connect to both ethernet and wifi. unplug ethernet usb dongle. verify that the network icon when from wired to wireless. Review URL: http://codereview.chromium.org/5194002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66558 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Google-A certificate getting accidently cleared.chocobo@chromium.org2010-11-171-1/+2
| | | | | | | | BUG=chromium-os:8618 TEST=Manual Review URL: http://codereview.chromium.org/5142002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66475 0039d316-1c4b-4281-b951-d872f2087c98
* Fix favorite and auto_connect property usage (again)kochi@chromium.org2010-11-172-4/+10
| | | | | | | | | | | | | | | | | | The original CL was: http://codereview.chromium.org/4818002 which missed a unittest fix, and the commit(r66253) was reverted (r66258). Changed chrome/browser/chromeos/options/wifi_config_view_browsertest.cc and network_library.h. BUG=chromium-os:8193 TEST=manually open chrome://settings/internet and see if remembered networks are listed properly. For DOMUI network menu, pass --enable-domui-menu for chrome to enable and check. Also check browser_test --gtest_filter="WifiConfigViewTest.ChangeAutoConnectSaveTest" Review URL: http://codereview.chromium.org/5094002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66411 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Include browser.h -> ui/browser.h [Part 4].jhawkins@chromium.org2010-11-171-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5104002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66401 0039d316-1c4b-4281-b951-d872f2087c98
* Don't allow connection to networks that are not connected.chocobo@chromium.org2010-11-172-4/+20
| | | | | | | | | For example, if Google-A is not configure, it will be disabled in the network menu and not selectable in the options pages. And from oobe/login, Google-A will always be disabled b/c the certificates will not be there until the user logs in. BUG=chromium-os:8293 TEST=Manual. From oobe, make sure google-a is disabled. Before setting up google-a, make sure google-a is disabled in network menu and options pages. Then set up google-a and see that it's now enabled in both network menu and options page. Log out and check that google-a is disabled. Review URL: http://codereview.chromium.org/4976007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66356 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix favorite and auto_connect property usage."thakis@chromium.org2010-11-162-6/+4
| | | | | | | | | | | | | | This reverts commit 2a5da02ef3fec8da1f223dd1990fb0b56d617188 / r66253: Fix favorite and auto_connect property usage. BUG=chromium-os:8913 TEST=manually open chrome://settings/internet and see if remembered networks are listed properly. For DOMUI network menu, pass --enable-domui-menu for chrome to enable and check. Review URL: http://codereview.chromium.org/4818002 It broke the ChromeOS and arm compiles with: chrome/browser/chromeos/options/wifi_config_view_browsertest.cc:44: error: ‘class chromeos::WifiNetwork’ has no member named ‘set_favorite’ TBR=kochi git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66258 0039d316-1c4b-4281-b951-d872f2087c98
* Fix favorite and auto_connect property usage.kochi@chromium.org2010-11-162-4/+6
| | | | | | | | | BUG=chromium-os:8913 TEST=manually open chrome://settings/internet and see if remembered networks are listed properly. For DOMUI network menu, pass --enable-domui-menu for chrome to enable and check. Review URL: http://codereview.chromium.org/4818002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66253 0039d316-1c4b-4281-b951-d872f2087c98
* Notification fix for case when there is no mobile plan. Fixed network menu ↵zelidrag@chromium.org2010-11-132-3/+143
| | | | | | | | | | | | | | to properly redirect to partner payment portal when we run out of plan. Changed usage notification to display "More info..." instead of "Buy plan". BUG=chromium-os:8745, chromium-os:8724, chromium-os:8853, chromium-os:8685 TEST=see listed bugs for details Review URL: http://codereview.chromium.org/4699004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66039 0039d316-1c4b-4281-b951-d872f2087c98
* Disables full sync option for the owner when password is changed.altimofeev@chromium.org2010-11-111-0/+10
| | | | | | | | | | | | | | | Currently, full sync for the owner leads to ownership loss. This CL disables full sync radio button in the view, that appears when password was changed. BUG=chromium-os:8630 TEST=Login to device. Log out. Change user password in Guest Session. Try to login again. In the showed window notice, that full sync options is grayed out. Review URL: http://codereview.chromium.org/4699001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65823 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed issues with network menu list:chocobo@chromium.org2010-11-101-0/+12
| | | | | | | | | | | | | | - Don't show separator at begining of network list - Don't show join other network when wifi is disabled - Don't show IP address in OOBE network dropdown list - Don't show unactivated cellular networks in OOBE/login - Various fixes to make network menus more robust BUG=chromium-os:8672,chromium-os:8792,chromium-os:8980 TEST=manually ran through all iterations to make sure that the network menu list looks right. Review URL: http://codereview.chromium.org/4677003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65692 0039d316-1c4b-4281-b951-d872f2087c98
* Do not send many requests to flimflam when network chagned.oshima@chromium.org2010-11-093-15/+32
| | | | | | | | | | | | | | | Send sync request to flimflam only if new request didn't come in 50ms. Network menu was updating menu twice when opening. BUG=chromium-os:8435 TEST=manual: enable vlog (--vlog=1) and observe that chrome log reports one "UpdateNetworkStatus" when network changes (disable, enable ethernet etc) There may be two when wifi is enabled as different wifi source may be recognized at different timing. Review URL: http://codereview.chromium.org/4229005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65478 0039d316-1c4b-4281-b951-d872f2087c98
* Better support for failed network connection attempts (chromiumos:8594).stevenjb@chromium.org2010-11-083-19/+46
| | | | | | | | | | | This includes some NetworkMenu refactoring to reduce code duplication. BUG=http://code.google.com/p/chromium-os/issues/detail?id=8594 TEST=Test network menu, particularly failed connection attempts. Review URL: http://codereview.chromium.org/4598002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65428 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed crash related to cellular network payment plan retreival.zelidrag@chromium.org2010-11-081-5/+2
| | | | | | | | | BUG=chromium-os:8864 TEST=none Review URL: http://codereview.chromium.org/4690002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65405 0039d316-1c4b-4281-b951-d872f2087c98
* Re-insert IP address in Network Menu.stevenjb@chromium.org2010-11-082-1/+5
| | | | | | | | | BUG=chromium-os:8476 TEST=Open the network menu on ChromeOS; the IP address should be at the bottom of the menu. Review URL: http://codereview.chromium.org/4544001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65398 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for crash (chromium-os:8733)stevenjb@chromium.org2010-11-041-1/+4
| | | | | | | | | BUG=chromium-os:8733 TEST=Quit from a ChromeOS device with a cellular network enabled; confirm that Chrome does not crash. Review URL: http://codereview.chromium.org/4507001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65144 0039d316-1c4b-4281-b951-d872f2087c98
* Landing change for ers@chromium.org: http://codereview.chromium.org/4134012/showchocobo@chromium.org2010-11-044-172/+464
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added handling of network ("service" in flimflam parlance) property changes. NetworkLibrary updates its Network objects in response to property changes, then calls any NetworkObservers that have registered for the given network. Use the is_active member of Network in various places to ensure that we are dealing with the correct network. Created separate observer classes for NetworkManager, Network, and CellularDataPlan, so that monitors can be established independently for each of them. Changed the callback method names to prepend "On", i.e., OnNetworkManagerChanged, OnNetworkChanged, OnCellularDataPlanChanged. Wired up signal strength update and network technology update in the status bar, network dropdown menu, and internet settings page. Added new icon badges for 1xRTT radio technology. These are used when EVDO coverage switches to 1xRTT. Just as is the case for the 3G icons, there are three 1x icons: normal, warn, and error. Please consider these icons to be placeholders if the UI folks think they need to be redesigned. Centralized choosing of the network technology badge in NetworkMenu::BadgeForNetworkTechnology. BUG=chromium-os:5612:chromium-os:7619,chromium-os:5917,chromium-os:4674 TEST=Extensive manual testing with different combinations of wi-fi and cellular networks connected and disconnected. Used a modified version of flimflam that randomly changes reported signal strength, network technology, and roaming state, and verified that the UI correctly reflected current values for the active network (roaming is not handled in the UI at this time). Review URL: http://codereview.chromium.org/4482003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65106 0039d316-1c4b-4281-b951-d872f2087c98
* Submitting http://codereview.chromium.org/4116010 on behalf of ↵zelidrag@chromium.org2010-11-042-32/+51
| | | | | | | | | | | | | | jglasgow@chromium.org: Change the libcros API for cellular data plans keep all memory allocation and deletion within libcros. BUG=chromium-os:8297 TEST=ad hoc Review URL: http://codereview.chromium.org/4270004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65073 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64888 - Push for ers:chocobo@chromium.org2010-11-034-450/+161
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added handling of network ("service" in flimflam parlance) property changes. NetworkLibrary updates its Network objects in response to property changes, then calls any NetworkObservers that have registered for the given network. Use the is_active member of Network in various places to ensure that we are dealing with the correct network. Created separate observer classes for NetworkManager, Network, and CellularDataPlan, so that monitors can be established independently for each of them. Changed the callback method names to prepend "On", i.e., OnNetworkManagerChanged, OnNetworkChanged, OnCellularDataPlanChanged. Wired up signal strength update and network technology update in the status bar, network dropdown menu, and internet settings page. Added new icon badges for 1xRTT radio technology. These are used when EVDO coverage switches to 1xRTT. Just as is the case for the 3G icons, there are three 1x icons: normal, warn, and error. Please consider these icons to be placeholders if the UI folks think they need to be redesigned. Centralized choosing of the network technology badge in NetworkMenu::BadgeForNetworkTechnology. BUG=chromium-os:5612:chromium-os:7619,chromium-os:5917,chromium-os:4674 TEST=Extensive manual testing with different combinations of wi-fi and cellular networks connected and disconnected. Used a modified version of flimflam that randomly changes reported signal strength, network technology, and roaming state, and verified that the UI correctly reflected current values for the active network (roaming is not handled in the UI at this time). Review URL: http://codereview.chromium.org/4235005 TBR=chocobo@chromium.org Review URL: http://codereview.chromium.org/4229006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64889 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 09:05:52 +0000