summaryrefslogtreecommitdiffstats
path: root/chrome/browser/chromeos/cros
Commit message (Collapse)AuthorAgeFilesLines
* Eliminate NetworkLibrary!stevenjb@chromium.org2013-09-1125-11241/+0
| | | | | | | | | | | | | There should be no functionality changes with this CL, it should only eliminate unused code. It also removes cros_network_functions and all Shill blocking dbus calls (now unused). BUG=245494 Review URL: https://chromiumcodereview.appspot.com/23477058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222615 0039d316-1c4b-4281-b951-d872f2087c98
* Switch ObserverList::size() to ObserverList::might_have_observers() Pt.1caitkp@chromium.org2013-08-261-2/+2
| | | | | | | | | | | | This is in preparation for making ObserverList::size() protected (see bug for details). BUG=278526 TEST=no change TBR=darin@chromium.org Review URL: https://chromiumcodereview.appspot.com/23190045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219580 0039d316-1c4b-4281-b951-d872f2087c98
* Remove NetworkLibrary references from unit_tests and browser_testsstevenjb@chromium.org2013-08-172-223/+0
| | | | | | | | | | | | | Also removes some files that are no longer referenced and some includes from files that do not actually use NetworkLibrary. BUG=273102 For activity_database_unittest.cc, in_process_browser_test.h: TBR=pneubeck@chromium.org Review URL: https://codereview.chromium.org/23183004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218145 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate NetworkLoginObserverstevenjb@chromium.org2013-08-122-8/+0
| | | | | | | | | | | This is no longer necessary with the new network connect code. BUG=249532 R=gauravsh@chromium.org Review URL: https://codereview.chromium.org/22761002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217012 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the client certificate code in chromeos/network/.pneubeck@chromium.org2013-08-121-3/+3
| | | | | | | | | | | | | This prepares for the next commit, which adds automatic resolution of client certificates which doesn't require a manual trigger by the user anymore. The only functional is that flimflam::kOpenVPNClientCertSlotProperty is not set anymore, because it was never supported by Shill and leads to errors with Service::SetProperties. BUG=234983, 126870 R=stevenjb@chromium.org Review URL: https://codereview.chromium.org/22588002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216997 0039d316-1c4b-4281-b951-d872f2087c98
* Show notifications for Network Config errorsstevenjb@chromium.org2013-08-101-5/+0
| | | | | | | | | | | | | Follow up to https://codereview.chromium.org/21046008/ to: * Treat invalid 'share' parameter as a configuration failure * Show error notifications for configuration failures * Eliminate NetworkStateNotifier::NetworkConnectionStateChanged which watched for connect failures triggered by NetworkLibrary connection attempts. This is now redundant and could result in duplicate notifications (one would replace the other). BUG=270936 Review URL: https://chromiumcodereview.appspot.com/22340006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216824 0039d316-1c4b-4281-b951-d872f2087c98
* Convert all connect code to use NetworkHandler instead of NetworkLibrarystevenjb@chromium.org2013-08-093-24/+11
| | | | | | | | | | | | | | * Eliminates kUseNewNetworkConnectionHandler * Converts *_config_view to NetworkStateHandler + network_connect * Migrates non Chrome/Browser dependent network_connect code to ash::network_connect. BUG=263978 R=gauravsh@chromium.org, pneubeck@chromium.org Review URL: https://codereview.chromium.org/21046008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216568 0039d316-1c4b-4281-b951-d872f2087c98
* Fix parsing of CaCertPEM properties in NetworkLibrary.pneubeck@chromium.org2013-07-291-4/+12
| | | | | | | | | BUG=208986 R=stevenjb@chromium.org Review URL: https://codereview.chromium.org/20755005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214161 0039d316-1c4b-4281-b951-d872f2087c98
* Call crypto::InitializeTPMToken on the IO thread (Take 2)stevenjb@chromium.org2013-07-263-9/+8
| | | | | | | | | | | | | | This is identical to https://chromiumcodereview.appspot.com/15649018 with the following addition: Call DeviceSettingsService::EnsureReload once certs are loaded BUG=244455 R=mnissler@chromium.org, nkostylev@chromium.org, rsleevi@chromium.org, xiyuan@chromium.org Review URL: https://codereview.chromium.org/20130002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213951 0039d316-1c4b-4281-b951-d872f2087c98
* Make CertificateHandler a proper interface of CertificateImporter.pneubeck@chromium.org2013-07-261-7/+7
| | | | | | | | | | | | | | | - Change CertificateHandler into a pure interface onc::CertificateImporter. - Make the old onc::CertificateImporter an implementation of that interface. - Replace the unnecessary CertificateImporter::ParseResult by a simple bool. This also frees the name CertificateHandler for other purposes. BUG=NONE TBR=stevenjb@chromium.org (gyp change), eroman@chromium.org (net-internals: API usage) Review URL: https://chromiumcodereview.appspot.com/20041002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213860 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeOS: Add a per user and a local state network preference.pneubeck@chromium.org2013-07-221-14/+0
| | | | | | | | | | | | | | | - Adds a network preference kOpenNetworkProperties to user prefs. - Adds a network preference kDeviceOpenNetworkProperties to local state. - Both are lists of NetworkConfigurations according to the ONC spec. - For now, only policies are written to these prefs. - User settings continue to be stored in Shill for now. A follow up commit will change that too. BUG=258835 TBR=mpcomplete@chromium.org (trivial change in chrome_direct_setting_api.h) Review URL: https://chromiumcodereview.appspot.com/18348012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212872 0039d316-1c4b-4281-b951-d872f2087c98
* Add ONC string expansion to NetworkConfigurationUpdaterImpl.pneubeck@chromium.org2013-07-191-1/+1
| | | | | | | | | | | | | String expansion is currently done in NetworkLibrary::LoadOncNetworks. That code will be replaced by ManagedNetworkConfigurationHandler, which resides in chromeos/ and cannot access User. Thus, with this commit, strings are expanded before pushing ONC to ManagedNetworkConfigurationHandler, namely in NetworkConfigurationUpdaterImpl. BUG=261152 TBR=joaodasilva@chromium.org Review URL: https://codereview.chromium.org/19564002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212580 0039d316-1c4b-4281-b951-d872f2087c98
* Replace third_party/icu/public with third_party/icu/source in the include ↵jshin@chromium.org2013-07-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | directives. This is to move back icu headers in third_party/icu/public/{i18n,common}/unicode back to their upstream locations in third_party/icu/source/{i18n,common}/unicode. http://codereview.chromium.org/18836004 has is a CL to move ICU header files. Roll ICU to the version with the above ICU CL (http://crrev.com/211851 ). In addition to the global replacement of third_party/icu/public with third_party/icu/source, the top-level DEPS, DEPS in printing and chrome/ are tightened up. (the latter two were too permissive (it used to allow any header from third_party/icu). Besides, sync '-foo' list in ios/public/DEPS with '+foo' in the top-level DEPS and build/linux/unbundled/icu.gyp is updated. BUG=251433 TEST=Compile succeeds on all bots. checkdeps.py does not find any error. TBR=brettw,sky,wtc Review URL: https://chromiumcodereview.appspot.com/18252003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212324 0039d316-1c4b-4281-b951-d872f2087c98
* cros_library: Remove CrosLibrarysatorux@chromium.org2013-07-177-135/+69
| | | | | | | | | | | | | | | | | | | CrosLibray was just wrapping NetworkLibrary. This patch is essentially a global replace of the following: CrosLibrary::Get()->GetNetworkLibrary() -> NetworkLibrary::Get() CrosLibrary::Initialize/Shutdown/etc are replaced with NetworkLibrary::Initialize/Shutdown/etc. BUG=126719 TEST=networking works as before on the chromebook TBR=hashimoto@chromium.org # for some non-chromeos files under chrome/browser Review URL: https://codereview.chromium.org/19340002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211912 0039d316-1c4b-4281-b951-d872f2087c98
* cros_library: Remove unnecessary includes of cros_library.hsatorux@chromium.org2013-07-171-1/+0
| | | | | | | | | | | BUG=126719 TEST=none TBR=hashimoto@chromium.org # for some non-chromeos files under chrome/browser Review URL: https://codereview.chromium.org/19329003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211894 0039d316-1c4b-4281-b951-d872f2087c98
* cros: Remove CrosLibrary::libcros_loaded()satorux@chromium.org2013-07-121-9/+0
| | | | | | | | | | | | This method is no longer in use. BUG=126719 TEST=none R=hashimoto@chromium.org Review URL: https://codereview.chromium.org/18435015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211351 0039d316-1c4b-4281-b951-d872f2087c98
* cros: Remove TestApi and Library from CrosLibrarysatorux@chromium.org2013-07-103-77/+18
| | | | | | | | | | | | These indirections no longer make sense as CrosLibrary is now just a wrapper around NetworkLibrary. BUG=126719 TEST=none Review URL: https://chromiumcodereview.appspot.com/18981003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210832 0039d316-1c4b-4281-b951-d872f2087c98
* cros: Remove use of libcros_loaded() in network_library.ccsatorux@chromium.org2013-07-101-7/+8
| | | | | | | | | | | | | | Here, what matters is if the code is running on Chrome OS (hence the D-Bus calls would work) or not, which can be checked with base::chromeos::IsRunningOnChromeOS() BUG=126719 TEST=none R=hashimoto@chromium.org Review URL: https://codereview.chromium.org/18980002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210783 0039d316-1c4b-4281-b951-d872f2087c98
* cros: Remove assertions of libcros_loaded() from NetworkLibraryImplCrossatorux@chromium.org2013-07-101-5/+0
| | | | | | | | | | | | | | Checking libcros_loaded() in NetworkLibraryImplCros is meaningless as libcros_loaded() just returns if CrosLibrary is not a stub, which is guranteeded in NetworkLibraryImplCros (non stub implementation). BUG=126719 TEST=none R=hashimoto@chromium.org Review URL: https://codereview.chromium.org/18767004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210778 0039d316-1c4b-4281-b951-d872f2087c98
* cros_library: Merge CrosMock into CrosInProcessBrowserTestsatorux@chromium.org2013-07-104-279/+181
| | | | | | | | | | | | | CrosMock was just wrapping MockNetworkLibrary. It's simpler to get rid of this indirection. BUG=126719 TEST=none R=hashimoto@chromium.org Review URL: https://codereview.chromium.org/18801016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210735 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused code from NetworkLibrary.pneubeck@chromium.org2013-07-0914-351/+14
| | | | | | | | BUG=NONE Review URL: https://chromiumcodereview.appspot.com/18635002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210594 0039d316-1c4b-4281-b951-d872f2087c98
* Resolve certificate references in ONC by PEM.pneubeck@chromium.org2013-07-039-86/+101
| | | | | | | | | | | | | | | | | | | | | | | | | In ONC, Server and CA certificates are referenced by GUID. Before, the GUID was stored in the nickname of each certificate and used to identify each certificate. After this change, the GUID is resolved and replaced by the PEM encoding of the certificate during import. The nickname is not used. This commit only affects Server and CA certificates (including IssuerCARef in CertificatePatterns). Client certificates are still identified by GUID. This CL also - uses the new *CaCertPEMProperty fields of Shill. - prepares for a list of CaCerts (for EAP, IPsec and OpenVPN) Side-effect of this CL: IssuerCARef is stored in the UIData service-property in Shill. Because this CL replaces IssuerCARef by IssuerCAPEMs, IssuerCARef entries of old UIData properties are ignored. This may break network configurations which were configured via chrome://net-internals. Reimporting such a configuration will fix the problem. BUG=208986 TBR=eroman@chromium.org (for net_internals_ui.cc) Review URL: https://chromiumcodereview.appspot.com/16946002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210019 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused NetworkLibrary::GetIPConfigsAndBlock.pneubeck@chromium.org2013-07-036-58/+0
| | | | | | | | | | This also removes code that was solely used by NetworkLibrary::GetIPConfigsAndBlock. BUG=NONE Review URL: https://chromiumcodereview.appspot.com/18541004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209975 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of time headers in chrome/browser/, part 2.avi@chromium.org2013-06-283-3/+3
| | | | | | | | | | BUG=254986 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/18050009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209046 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused includes of base/chromeos/chromeos_version.htfarina@chromium.org2013-06-171-1/+0
| | | | | | | | | | | BUG=244089 R=thestig@chromium.org TBR=ben@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/17200002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206748 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite scoped_ptr<T>(NULL) to use the default ctor in chrome/.dcheng@chromium.org2013-06-141-4/+1
| | | | | | | | | | | This is the result of running the rewrite_scoped_ptr_ctor_null tool across all files built on CrOS in the chrome/ directory. BUG=173286 Review URL: https://chromiumcodereview.appspot.com/16871010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206234 0039d316-1c4b-4281-b951-d872f2087c98
* Configure networks requiring a certificate.stevenjb@chromium.org2013-06-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | Original CL: https://chromiumcodereview.appspot.com/16512003/ The current flow does not guarantee that a configured network will have its tpm / pkcs11 credentials configured. We need to set these properties in order to reliably connect to networks requiring certificates. The patch also includes some minor changes to improve error reporting and configuration triggering for failure cases. This patch does not introduce NetworkHandler::InitializeForTest and instead allows NetworkConnectionHandler to Initialize correctly when LoginState is not initialized. BUG=247104 TBR=gspencer@chromium.org,pneubeck@chromium.org For /wifi_data_provider_chromeos_unittest.cc: TBR=joth@chromium.org Review URL: https://chromiumcodereview.appspot.com/16045010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205653 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in chrome/browser/chromeos/.avi@chromium.org2013-06-115-6/+6
| | | | | | | | | | BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/15798019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205469 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 204994 "Configure networks requiring a certificate."oshima@chromium.org2013-06-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | > Configure networks requiring a certificate. > > The current flow does not guarantee that a configured network will have > its tpm / pkcs11 credentials configured. We need to set these > properties in order to reliably connect to networks requiring > certificates. The patch also includes some minor changes to improve > error reporting and configuration triggering for failure cases. > > BUG=247104 > For /wifi_data_provider_chromeos_unittest.cc: > TBR=joth@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/16512003 TBR=stevenjb@chromium.org Review URL: https://codereview.chromium.org/16109015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205307 0039d316-1c4b-4281-b951-d872f2087c98
* Remove code related to proxy configuration from NetworkLibrary.pneubeck@chromium.org2013-06-105-82/+0
| | | | | | | | | | | Had to migrate the testing_automation_provider_chromeos to NetworkStateHandler + chromeos::proxy_config. BUG=234982 R=phajdan.jr@chromium.org, stevenjb@chromium.org Review URL: https://codereview.chromium.org/16181012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205230 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of utf_string_conversions.h in chrome/browser/, part 1.avi@chromium.org2013-06-091-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/15789014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205122 0039d316-1c4b-4281-b951-d872f2087c98
* Configure networks requiring a certificate.stevenjb@chromium.org2013-06-081-1/+1
| | | | | | | | | | | | | | | | The current flow does not guarantee that a configured network will have its tpm / pkcs11 credentials configured. We need to set these properties in order to reliably connect to networks requiring certificates. The patch also includes some minor changes to improve error reporting and configuration triggering for failure cases. BUG=247104 For /wifi_data_provider_chromeos_unittest.cc: TBR=joth@chromium.org Review URL: https://chromiumcodereview.appspot.com/16512003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204994 0039d316-1c4b-4281-b951-d872f2087c98
* Move common default expectations for network library to CrosMockgauravsh@chromium.org2013-06-041-0/+4
| | | | | | | | | | | | Removes mock expectations that are no longer needed. This also results in removal of all direct {Mock}NetworkLibrary dependencies in chromeos/login/*. BUG=189035 Review URL: https://chromiumcodereview.appspot.com/16196006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203979 0039d316-1c4b-4281-b951-d872f2087c98
* Trigger NetworkConnectionHandler callbacks on success or failurestevenjb@chromium.org2013-05-312-7/+26
| | | | | | | | | | | | | | | | | | | This CL triggers waits for the network state to change before triggering success or failure callbacks in NetworkConnectionHandler. Notifications are triggered on success or failure without requiring the NetworkStateHandler connecting_network() hack. It also separates the enable flag from NetworkConfigurationHandler since enabling that has different artifacts. BUG=243899 For ash.gyp: TBR=gspencer@chromium.org Review URL: https://codereview.chromium.org/16123011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203501 0039d316-1c4b-4281-b951-d872f2087c98
* Convert NetworkMenu to use NetworkStateHandlerstevenjb@chromium.org2013-05-315-81/+0
| | | | | | | | | | | | | | This cleans up the separators and moves Searching/Initializing messages to match the status area. Additionally it removes Lock/IsLocked and related code from NetworkLibrary. This code was designed to prevent enabling / disabling a device during activation, but was only used in NetworkMenu which is only used in the Login UI which does not include activation. BUG=167231 R=gspencer@chromium.org, pneubeck@chromium.org Review URL: https://codereview.chromium.org/15486008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203451 0039d316-1c4b-4281-b951-d872f2087c98
* Add CheckPortalList manager property to NetworkStateHandlergauravsh@chromium.org2013-05-318-63/+0
| | | | | | | | | | | Also, gets rid of the code for handling this in NetworkLibrary and moves WizardController to use NetworkStateHandler instead. BUG=189035 Review URL: https://chromiumcodereview.appspot.com/15899015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203296 0039d316-1c4b-4281-b951-d872f2087c98
* Add NetworkHandler to own network handlers in src/chromeos/networkstevenjb@chromium.org2013-05-284-17/+28
| | | | | | | | | | | | | This is just some code cleanup and should have no behavior changes. BUG=239073 For webui/chromeos, browser/geolocation: TBR=nkostylev@chromium.org,joth@chromium.org Review URL: https://chromiumcodereview.appspot.com/14729017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202609 0039d316-1c4b-4281-b951-d872f2087c98
* Add NetworkStateHandler::RequestUpdateForNetworkstevenjb@chromium.org2013-05-223-0/+15
| | | | | | | | | | | | | This also changes the code to signal observers after update requests, even if nothing changed so that NetworkPropertiesUpdated() will get signaled after a request. BUG=240728 R=pneubeck@chromium.org Review URL: https://codereview.chromium.org/15233002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201614 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup NetworkPropertyUIData.pneubeck@chromium.org2013-05-213-108/+65
| | | | | | | | | | This removes the dependency on NetworkUIData. BUG=NONE Review URL: https://chromiumcodereview.appspot.com/15297002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201298 0039d316-1c4b-4281-b951-d872f2087c98
* Don't open mobile setup when activating Sprint network from network menutbarzic@chromium.org2013-05-204-0/+13
| | | | | | | | | | | it should be activated directly BUG=chrome-os-partner:16215 TEST=tbd Review URL: https://chromiumcodereview.appspot.com/14753003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201159 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded base/file_util.h includes in chrome.thestig@chromium.org2013-05-151-2/+1
| | | | | | Review URL: https://chromiumcodereview.appspot.com/15030005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200118 0039d316-1c4b-4281-b951-d872f2087c98
* Add NetworkConnectionHandler classstevenjb@chromium.org2013-05-144-222/+4
| | | | | | | | | | | | | | | | This moves NetworkConfigurationHandler::Connect -> NetworkConnectionHandler::ConnectToNetwork and adds error handling and certificate checking. Depends on https://codereview.chromium.org/14522013/ Test with --use-new-network-configuration-handlers BUG=235243 Review URL: https://chromiumcodereview.appspot.com/14566009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199893 0039d316-1c4b-4281-b951-d872f2087c98
* In NetworkLibrary::LoadOncNetworks, configure only networks, for which the ↵pneubeck@chromium.org2013-05-081-5/+8
| | | | | | | | | | | policy changed. BUG=231456 R=gspencer@chromium.org Review URL: https://codereview.chromium.org/14348023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198888 0039d316-1c4b-4281-b951-d872f2087c98
* Separate cert loading code from CertLibrary and move to src/chromeos.stevenjb@chromium.org2013-05-066-557/+210
| | | | | | | | | | | | | The intention of this CL is to move certificate loading code without chrome/i18n dependencies into src/chromeos. This is so that networking code that needs access to certificates can also be moved to src/chromeos. This also extracts CertLibrary from CrosLibrary. BUG=133752 R=gspencer@chromium.org, pneubeck@chromium.org Review URL: https://codereview.chromium.org/14522013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198511 0039d316-1c4b-4281-b951-d872f2087c98
* Enable L2TP-IPSec group name in VPN config dialog.pneubeck@google.com2013-05-022-3/+3
| | | | | | | | | | | Also replaces usages of kL2tpIpsecGroupNameProperty by kL2tpIpsecTunnelGroupProperty, which is the correct constant for this setting. The former is ignored by Shill. BUG=224834 R=stevenjb@chromium.org Review URL: https://codereview.chromium.org/14629009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197983 0039d316-1c4b-4281-b951-d872f2087c98
* Warn on missing OVERRIDE/virtual everywhere, not just in header files.rsleevi@chromium.org2013-05-021-11/+11
| | | | | | | | | | This is only enabled for Linux (so far). BUG=115047 Review URL: https://chromiumcodereview.appspot.com/14696007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197788 0039d316-1c4b-4281-b951-d872f2087c98
* chrome: Remove the remaining use of ALLOW_THIS_IN_INITIALIZER_LIST.tfarina@chromium.org2013-05-014-10/+10
| | | | | | | | | | | | It's no longer providing value as the MSVC warning is disabled during compilation. Refer to bug for details. BUG=234765 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/14712004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197552 0039d316-1c4b-4281-b951-d872f2087c98
* Extract certificate policy application from NetworkLibrary.pneubeck@google.com2013-04-265-269/+113
| | | | | | | | | | | | | | This is mostly a refactoring: - Import of certificates is handled by a new CertifcateHandler, which will get more functionality like resolving CertificatePatterns in upcoming commits. - Policy validation moved into NetworkConfigurationUpdater and net_internals, because it covers both certificates and networks. The only functional change is that certificate policies should now also work if ManagedNetworkConfigurationHandler is used instead of NetworkLibrary. BUG=223869 Review URL: https://codereview.chromium.org/14192017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196735 0039d316-1c4b-4281-b951-d872f2087c98
* Move cryptohome_library to src/chromeosstevenjb@chromium.org2013-04-2411-554/+1
| | | | | | | | | | | | | | | This CL does the following: 1. Move [De|En]cryptWithSystemSalt to CryptohomeLibrary 2. Remove CryptohomeLibrary from CrosLibrary 3. Move CryptohomeLibrary to src/chromeos BUG=233724 For chrome_browser_chromeos.gypi TBR=sky@chromium.org Review URL: https://codereview.chromium.org/14179007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196159 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring: Moved the function CompareString16WithCollator from ↵hajimehoshi@chromium.org2013-04-231-1/+2
| | | | | | | | | | | ui/base/l10n to base/i18n. The function LocalAwareCompareFilenames at base/i18n/file_util_icu.cc needed a function to sort string with consideration of a locale, but it couldn't refer ui/base. BUG=55883 (Indirectly) TEST=Unit tests Review URL: https://chromiumcodereview.appspot.com/14044002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195711 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-16 03:52:28 +0000