summaryrefslogtreecommitdiffstats
path: root/chrome/browser/chromeos/external_metrics_unittest.cc
Commit message (Collapse)AuthorAgeFilesLines
* Lands http://codereview.chromium.org/1610030/show from Luigi:sky@chromium.org2010-04-211-34/+29
| | | | | | | | | | | | | | | | | | This changes makes histograms dynamically defined by external metrics clients, instead of hardcoding them in Chrome source. This is important because making even simple changes to Chrome is laborious and takes a fair amount of learning. Unfortunately user actions still require code in Chrome, because of a pre-processing script that extracts them from the source. BUG=NONE TEST=the included unit test Review URL: http://codereview.chromium.org/1718003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45189 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build errors that occur on Ubuntu 9.10satorux@chromium.org2010-04-011-3/+4
| | | | | | | | | | | | | | | With g++ 4.4.1, ignoring return values from write() results in compilation errors: error: ignoring return value of ‘ssize_t write(int, const void*, size_t)’, declared with attribute warn_unused_result BUG=none TEST=built and ran the tests out/Release/unit_tests --gtest_filter='PipeReaderTest*' out/Release/unit_tests --gtest_filter='ExternalMetricsTest*' Review URL: http://codereview.chromium.org/1564005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43320 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile error : " error: open with O_CREAT in second argument needs 3 ↵nsylvain@chromium.org2010-02-271-2/+2
| | | | | | | | arguments" Review URL: http://codereview.chromium.org/660191 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40194 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Add some network metrics to the external metrics transport.derat@chromium.org2009-12-161-7/+27
| | | | | | | | | | | | | Also test all metrics names in the unit test. (change is by semenzato@chromium.org and was already reviewed by rvargas at http://codereview.chromium.org/489008) TBR=semenzato Review URL: http://codereview.chromium.org/500041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34636 0039d316-1c4b-4281-b951-d872f2087c98
* fix for memory leak and illegal access, 2nd attempt.oshima@chromium.org2009-12-091-8/+9
| | | | | | | | | | | | | | * ExternalMetrics class requires scoped_refptr. original CL : http://codereview.chromium.org/470006 BUG=None TEST=Run unit_test with valgrind. patch from issue 470006 Review URL: http://codereview.chromium.org/465140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34176 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 34099 - fix for memory leak and illegal access. (found in valgrind test)asargent@chromium.org2009-12-091-10/+8
| | | | | | | | | | | | | | | | * name, values for callback seems to be on stack. i changed const char* to string so that it can copy, and also expect_eq can print string when failed. BUG=None TEST=Run unit_tests on valgrind. Review URL: http://codereview.chromium.org/470006 TBR=oshima@chromium.org Review URL: http://codereview.chromium.org/466083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34114 0039d316-1c4b-4281-b951-d872f2087c98
* fix for memory leak and illegal access. (found in valgrind test)oshima@chromium.org2009-12-081-8/+10
| | | | | | | | | | | | | * name, values for callback seems to be on stack. i changed const char* to string so that it can copy, and also expect_eq can print string when failed. BUG=None TEST=Run unit_tests on valgrind. Review URL: http://codereview.chromium.org/470006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34099 0039d316-1c4b-4281-b951-d872f2087c98
* Use Chrome to transport Chrome OS metrics. rvargas@google.com2009-11-131-0/+111
Chrome periodically reads the content of a well-know file, and parses it into name-value pairs, each representing a Chrome OS metrics event. The events are then logged using the normal UMA mechanism. The file is then truncated to zero size. Chrome uses flock() to synchronize accesses to the file. BUG=none TEST=compiled and run Linux and Chrome OS versions. Verified that uploaded Chrome OS events appear in about:histograms. Also external_metrics_unittest.cc tests the collection of metrics messages from the well-known file. patch written by semenzato_google.com original code review: http://codereview.chromium.org/378013 (plus http://codereview.chromium.org/346041) Review URL: http://codereview.chromium.org/394010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31952 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-29 15:18:44 +0000