summaryrefslogtreecommitdiffstats
path: root/chrome/browser/chromeos/file_manager/app_installer.cc
Commit message (Collapse)AuthorAgeFilesLines
* We have a problem in the process on destroying WebContentsImpl becausezverre@yandex-team.ru2014-05-091-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | each WebContentsObserver first NULLs its web_contents_ pointer and performs cleanup code after that. This could work if we guaranteed that every WebContentsObserver doesn't directly or indirectly affect any other WebContentsObserver. But actually WebContentsObservers can do anything and also affect each other. And if one WebContentsObserver already NULLed its web_contents_ pointer (e.g. ZoomController) other WebContentsObserver (e.g. InterstitialPageImpl) calls it (indirectly in this case) we have problems and result depends on ordering of WebContentsObservers in the list of observers. The solution splits that process into two phases. First we let each WebContentsObserver to perform their cleanup code and at that point they can freely call each other, we completely don't care about the ordering. We can call this phase as untrusted phase because we deal with some cleanup code that can do anything. After that we make second pass and NULL each web_contents_ pointer and this phase is trusted because we call only private implementation of WebContentsObserver that we definitely can trust. BUG=363564 Review URL: https://codereview.chromium.org/257153003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269264 0039d316-1c4b-4281-b951-d872f2087c98
* Make sideloaded (externally installed) extensions display webstore infordevlin.cronin@chromium.org2014-01-291-4/+4
| | | | | | | | | | | | | | | | Have sideloaded extensions pull data from the webstore (a la inline install) in order to give the users a better idea of what extension they are installing. Images worth 1000 words: http://imgur.com/zlexZeb,VljPXLz,WzT2ZOc#0 XIB changes: * rename 'app/nibs/ExtensionInstallPromptInline.xib' to 'app/nibs/ExtensionInstallPromptWebstoreData', since the same prompt is now used for inline prompts and for sideloaded extensions when webstore data is available. BUG=323063 Review URL: https://codereview.chromium.org/145153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247604 0039d316-1c4b-4281-b951-d872f2087c98
* Reland: Misc cleanup in Drive/Files.app C++ code.kinaba@chromium.org2013-12-181-2/+2
| | | | | | | | | | | BUG=none Prev Commit: https://src.chromium.org/viewvc/chrome?view=rev&revision=240957 Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=240967 Review URL: https://codereview.chromium.org/116983003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241526 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of https://codereview.chromium.org/114963002/yoz@chromium.org2013-12-161-2/+2
| | | | | | | | | | | | Reason for revert: Broken build on ChromeOS: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder/builds/62298/steps/compile/logs/stdio TBR=hashimoto@chromium.org,kinaba@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/116523003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240967 0039d316-1c4b-4281-b951-d872f2087c98
* Misc cleanup in Drive/Files.app C++ code.kinaba@chromium.org2013-12-161-2/+2
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/114963002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240957 0039d316-1c4b-4281-b951-d872f2087c98
* file_manager: Rename file_manager::FileManagerInstaller to ↵satorux@chromium.org2013-11-061-0/+113
file_manager::AppInstaller Revise the class comment along the way. BUG=284984 TEST=none R=yoshiki@chromium.org Review URL: https://codereview.chromium.org/61463003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233234 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-22 07:36:52 +0000