| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Added extra debug logging for update screen.
BUG= http://crosbug.com/4208
TEST=Manually: run OOBE, press Esc on update screen, you should stay at login screen.
Review URL: http://codereview.chromium.org/2842024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Single url is enough. If needed it could be easily changed to multiple ones.
Hopefully merging login_screen & existing_user_controller will remove some of duplication.
BUG= http://crosbug.com/4214
TEST=Manual. "Can't access your account" should open BWSI with help link in it.
Review URL: http://codereview.chromium.org/2802021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
LanguageMenuButton will use the interface to implement crosbug.com/2619 (Implement input language selector on the log in page)
BUG=none
TEST=ran try bot
Review URL: http://codereview.chromium.org/2846031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
is clicked so wm knows which one to select.
BUG=cros:2318
TEST=With new wm tooltips should appear above user image and label on
unselected user pod.
Review URL: http://codereview.chromium.org/2856014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added initial_timezone=Asia/Tokyo attribute to the test manifest.
BUG=http://crosbug.com/1761
TEST=Run out/Debug/chrome --login-manager --startup-manifest=chrome/browser/chromeos/testdata/startup_manifest.json. Press Ctrl+Alt+U to switch to update screen. Clock in status area should display Tokyo time.
Review URL: http://codereview.chromium.org/2834018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MesssageBubble was propagating event to the parent,
which caused problem in screen locker. This change is
harmless in login screen.
Fix a cut&paste error in CHECK in grab broke handler.
BUG=chromium-os:4213
TEST=see bug for intstruction to reproduce the crash. This should fix the crash.
Review URL: http://codereview.chromium.org/2811022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes crash introduced in http://codereview.chromium.org/2867012
BUG=chromium-os:3056
TEST=Login to CrOS. Chrome should not crash after login.
Review URL: http://codereview.chromium.org/2833027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix Sign In button focus order.
BUG= http://crosbug.com/4104
TEST=manual
Review URL: http://codereview.chromium.org/2813022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=crosbug.com/2321
TEST=On user image in top right corner there is a menu button to remove user. Need changes in WM to work properly.
Review URL: http://codereview.chromium.org/2832012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Not well-tested; feel free to use this as a starting point, though.
BUG=chromium-os:3056
TEST=None
Review URL: http://codereview.chromium.org/2867012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=crosbug.com/2279
TEST=See bug description.
Review URL: http://codereview.chromium.org/2815015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
always transparent. Removed shadow stroke from screens.
BUG=none
TEST=Verify that there's no black border around screens in OOBE mode. Also verify that there's no light blue stroke at the edge of the screens.
Review URL: http://codereview.chromium.org/2873008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=crosbug.com/4116
TEST=See bug description.
Review URL: http://codereview.chromium.org/2823014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=trybots; make -j8 chrome unit_tests browser_tests
BUG=chromium-os:4063
Review URL: http://codereview.chromium.org/2875001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Verify that background has radial gradient from dark blue in the center to black at the edges. Screens should have linear gradient of light greyfrom top to bottom.
Review URL: http://codereview.chromium.org/2839011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
behavior when clearning native focus.
This is necessary in ScreenLocker as the focus has to be set to the widget that is grabbing all input focus.
* PasswordField that will set focus it itself when mouse is clicked. This is necessary again when the input is grabbed by
other widget because the gtk textfield will never receive mouse event.
* fix minor bug : locating the grab widget in wrong place.
Review URL: http://codereview.chromium.org/2811015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
screen is unlocked.
BUG=none
TEST=(with new screen locker on L13) Login from new user login. Notice that camera light is on. Lock the screen with Ctrl-Alt-L. Notice that camera light is off. Unlock the screen. Notice that camera light is on and video is shown.
Review URL: http://codereview.chromium.org/2847019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was caused by X drawing white background on resume.
Chagned to not to draw any background.
Two small changes:
Made signout button focusable.
Fix a bug that TryGrabAllInput was not checking mouse grab.
BUG=chromium-os:4132
TEST=none
Review URL: http://codereview.chromium.org/2841011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Don't ask twice for secure network credentials if connection is not yet in "connecting" state by the time "Continue" is pressed
BUG= http://crosbug.com/3999
TEST=Manually. Select secure network, enter credentials and hit "Continue" immediately.
Review URL: http://codereview.chromium.org/2871012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=cros:2318
TEST=Get to image login screen. Verify that over user's image there's a
tooltip that shows user's email address.
Review URL: http://codereview.chromium.org/2871010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
accelerator was not removed when it's closed by escape accelerator. This was causing crash in screen locker.
Use "Resume" text for unlock button.
Removed unnecessary TextButton dependency in screen_lock_view.h
BUG=none
TEST=lock screen using ctrl-alt-l, type wrong password and enter then hit escape twice.
It will not crash.
Review URL: http://codereview.chromium.org/2872004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crosbug.com/4033
TEST=When WiFi was disabled through network status area button it's possible to enable it back.
Review URL: http://codereview.chromium.org/2850012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2809016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tab key doesn't get here since it's handled by focus manager.
BUG=none
TEST=Enter a name without domain in username field on login screen. Remove
focus from the field (i.e. by hitting Tab). @gmail.com should be appended.
Review URL: http://codereview.chromium.org/2829005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LanguageLibrary is a misnomer. This is actually an input method library.
Will change the file name in the next change list.
Methodology of refactoring:
1. perl -i -pe 's/LanguageLibrary/InputMethodLibrary/g' **/*.cc **/*.h
2. manually fix the lines that became longer than 80 chars.
3. grep 'language_lib' **/*.{cc,h} |grep -v '#include'
4. manually fix the variable names.
BUG=chromium-os:4063
TEST=manually
Review URL: http://codereview.chromium.org/2868009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Created new UserView that shows the user's photo.
* Moved common constants to helper.h with login namespace to avoid
conflict.
BUG=none
TEST=none. CL does not change the behavior. All tests should still pass.
Review URL: http://codereview.chromium.org/2831007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor ImageDownloader/ImageDecoder into a separate classes.
Resources submitted in http://codereview.chromium.org/2856003
BUG= http://crosbug.com/3486
TEST=Select "New User" screen, enter new account for this device. Enter incorrect password 3 times. After captcha is presented and entered login should succeed.
Review URL: http://codereview.chromium.org/2729020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Run browser_tests --gtest_filter=WizardControllerFlowTest\.Accelerators
Review URL: http://codereview.chromium.org/2862006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
startup customization manifest.
BUG=http://crosbug.com/3176
TEST=Run out/Debug/chrome --login-manager --startup-manifest=chrome/browser/chromeos/testdata/startup_manifest.json. Welcome message should be in Italian.
Review URL: http://codereview.chromium.org/2853006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Follow up CL to http://codereview.chromium.org/2820006
BUG=chromium-os:323
TEST=unit tests, and loading up a chromium os device and logging in
Review URL: http://codereview.chromium.org/2851006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We used to read the system salt from a file on disk, which meant that
we had to do a bunch of dancing to do some work during login on the
FILE thread instead of the UI thread. Now, we no longer have to,
because there is an API to request the system's salt value from
cryptohomed over dbus. This CL is a precursor to some of the other
login/cryptohome changes that are coming.
BUG=chromium-os:323
TEST=unit tests, and loading up a chromium os device and logging in
Review URL: http://codereview.chromium.org/2820006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2804003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Call SetKeyboardLayoutPerWindow(false) in LanguageMenuButton::LanguageMenuButton().
- Mock Keyboard APIs so LanguageMenuButton::LanguageMenuButton() can call the function even in browser_tests.
In browser_tests, code like "if (CrosLibrary::Get()->EnsureLoaded()) SetKeyboardLayoutPerWindow(false);" does not work since the EnsureLoaded() function is replaced so it always returns true without loading libcros.so (i.e. the function pointer |SetKeyboardLayoutPerWindow| is NULL). We could fix this by either of the following:
1) Add NULL check: if (CrosLibrary::Get()->EnsureLoaded() && (SetKeyboardLayoutPerWindow != NULL)) SetKeyboardLayoutPerWindow(false);
2) Mock keyboard APIs and just call: CrosLibrary::Get()->GetKeyboardLibrary()->SetKeyboardLayoutPerWindow(false);
I'd choose 2), since 1) looks a bit error-prone and inconsistent with other libcros libraries (e.g. power, language, ...)
FYI, we can use the new cros/keyboard_library.h interface to implement the "swap ctrl/caps" feature in a clean way.
BUG=chromium-os:2433
TEST=manually
Review URL: http://codereview.chromium.org/2781006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2722011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allow chrome logging to pivot inside the users encrypted home dir on
chrome os, post-login. We also set the inital logs up to be
timestamped, so that we don't lose them when crashes happen.
BUG=None
TEST=Enable chrome logging on chrome os, log in, and check for chrome logs in /home/chronos/user
Review URL: http://codereview.chromium.org/2723007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
if more than one keyboard are active.
BUG=chromium-os:3936
TEST=manual
Review URL: http://codereview.chromium.org/2787008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:4021
TEST=manual + browser_tests
Review URL: http://codereview.chromium.org/2717009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Timeout increased to 30s.
- Correctly handle when network was previously in a failed state
- Also handle if identity/cert was cleared out and waits for the fields to be set by the enterprise daemon.
BUG=chromium-os:3262
TEST=manual testing
Review URL: http://codereview.chromium.org/2746009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Send Notification when screen lock state is changed.
BUG=chromium-os:3950, chromium-os:3675
TEST=manual: login to bwsi mode and hit ctrl-alt-l. unlock by moving mouse or type any key.
Review URL: http://codereview.chromium.org/2735008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
XKB keyboard layout.
For instance, if English USA keyboard layout is the only input method enabled,
we don't show the input language menu on the right upper corner.
On the other hand, if Japanese input method is the only input method enabled,
we still show the input language menu so users can change the intra input method
modes, like Hiragana and Katakana modes.
Note that this is a retry of r49375 that was reverted in r49393
http://src.chromium.org/viewvc/chrome?view=rev&revision=49375
http://src.chromium.org/viewvc/chrome?view=rev&revision=49393
The new fix is in chrome/browser/chromeos/login/login_browsertest.cc
- .WillRepeatedly(Return(CreateFallbackInputMethodDescriptors()));
+ .WillRepeatedly(
+ InvokeWithoutArgs(CreateFallbackInputMethodDescriptors));
BUG=chromium-os:2275
TEST=manually on the netbook; try bots
Review URL: http://codereview.chromium.org/2787007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jcivelli
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2754010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=46274
TEST=CrOS linux bot greener
TBR=jcivelli
Review URL: http://codereview.chromium.org/2771012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=gmerged on netbook, logged in/out, rebooted, inspected about:histograms
Review URL: http://codereview.chromium.org/2711009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reactivates them when screen is unlocked.
Note that if two or more keyboard layouts are active, you can switch layout by pressing the language hot-key (Shift+Alt), though the language indicator ("EN") is not clickable yet.
BUG=chromium-os:3936
BUG=chromium-os:2714
TEST=manual
Review URL: http://codereview.chromium.org/2771005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of adding window_contents_ as grab widget.
Explicitly adding grab widget was confusing gtk and the event has been handled by grab widget rather than by the window the event is forwarded to.
This CL fixes it by removing all grab widget and let gtk propagage event in target window.
BUG=none
TEST=open screen locker, type wrong password to show message bubble,
then close it by clicking close (x) button.
Review URL: http://codereview.chromium.org/2788001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=All controls are disabled on "New User" screen with login is in progress
Review URL: http://codereview.chromium.org/2774004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use it for "Can't access your account" link.
BUG= http://crosbug.com/3179
TEST=Open "Can't access your account" link from "New User" view.
Review URL: http://codereview.chromium.org/2675007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* When closing and opening the lid, chrome window is briefly visible because
the computer is suspended before window is fully mapped and covers the
screen.
BUG=none
TEST=manual: close and open the lid shoudl not expose the content of chrome window.
Review URL: http://codereview.chromium.org/2762001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add "sign out" button
* Let chrome crash when grab is borken.
* send ScreenIsLocked signal after all inputs are grabbed.
BUG=chromium-os:2914,chromium-os:2614
TEST=manual:
set the content of /var/lib/power_manager/use_xscreensaver to 1,
reboot the machine and login
hit ctr-alt-l to enter screenlock mode
1) typing in wrong password should show message bubble with error message
2) pressing "Sign out" will terminate the session and move to login screen
Review URL: http://codereview.chromium.org/2685006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on mouse press event.
* Added new constructor to InfoBubble for chromeos which takes WidgetGtk::Type parameter
* Made DoGrab/HandleGrabBroke so that subclass can customize its behavior.
* Added MessageBubble::ShowNoGrab that shows a child MessageBubble which does not grab input on mouse press event.
* Explicitly remove accelerator when closed. This is necessary for child, but doing for all case as it's harmless to do so.
* Moved HandleGrabBroke to protected and made virtual so that sub class
can trap the event. ScreenLocker will use this event to detect this.
This will be used for screen locker.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2682004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49068 0039d316-1c4b-4281-b951-d872f2087c98
|