| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:7216
TEST=Verify all windows/dialogs use new bubble design, e.g. JS dialog, page info window, certificate view, extension install confirmation, save as dialog etc.
Review URL: http://codereview.chromium.org/3538012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:7174
TEST=see bug
Review URL: http://codereview.chromium.org/3529011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
string_split.h
BUG=None
TEST=trybos
Review URL: http://codereview.chromium.org/3447008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Another attempt (previous one was incorrect).
BUG=http://crosbug.com/6620
TEST=Manual
Review URL: http://codereview.chromium.org/3386013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Verify celluar config view shows not-yet-implemented info instead of fake data.
Review URL: http://codereview.chromium.org/3397006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Do it fast with following shell script:
export LC_ALL=C
find chrome/browser/chromeos/ -name '*.h' -o -name '*.cc' \
| xargs grep -C1 '^#include' \
| awk -F: '$2 !~ "include" { prev=""; next } ($2 <= prev) { print $1 } { prev=$2 }' \
| uniq \
| xargs -n1 sh -c 'cat "$1" \
| awk "{ tag=((/^#include/) \"_\" (/</) \"_\" (/third.party/)); print tag \"\t\" \$0 }" \
| awk -vi=0 -F\\t "{ if (!/^1_0_/ || \$1 != prev) { ++i } } { printf \"%09d\t%s\n\",i,\$0; prev=\$1 }" \
| sort \
| sed "s/^[0-9]*\t[0-9]_[0-9]_[0-9]\t//" > "$1".fixed; mv -f "$1".fixed "$1"' xxx
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/3402010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crosbug.com/6620
TEST=Manual
Review URL: http://codereview.chromium.org/3429007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:4023, chromium-os:4117, chromium-os:4117
TEST=Manual test first OOBE screen
Review URL: http://codereview.chromium.org/3166028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:4727,chromium-os:2863
TEST=Confirm that the UI only shows 2 settings (tap-to-click and sensitivity)
Confirm that the settings work on both x86-generic and x86-dogfood builds.
Review URL: http://codereview.chromium.org/3315016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add 'favorite' state to WirelessNetwork and use it to determine whether to show autoconnect checkbox.
BUG=chromium-os:5214
TEST=Test connecting to new and remembered secure netowrks. See issue.
Given that this dialog is going to be phased out, hiding the autoconnect checkbox for new networks is the most consistent with how the new UI will behave.
Review URL: http://codereview.chromium.org/3350007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This finish the work in the chromeos/ directory.
(Note: This is a TODO in base/stringprintf.h).
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3336003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
default values instead.
BUG=chromium-os:5933
TEST=manually
Review URL: http://codereview.chromium.org/3181035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:5609
TEST=none. Hold until flipflam supports are implemented.
Review URL: http://codereview.chromium.org/3112035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename includes, resort header include order in places where the rename
changed the order.
BUG=50548
TEST=compiles
Review URL: http://codereview.chromium.org/3203008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- This changes RecentlyUsedFoldersComboModel::GetItemAt() to return a string16
instead of a wstring.
- This entailed changing the base class, ComboboxModel, and shaving a herd of
yaks.
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3159031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
language_preferences.h exports lots of constants hence polutes chromeos
namespace.
TEST=compiles. try bots.
BUG=chromium-os:5848
Review URL: http://codereview.chromium.org/3132023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix a bunch of #includes. Folks, scoped_refptr<> is defined in
base/ref_counted.h, not in base/scoped_ptr.h.
BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/3132024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Get rid of includes from language_preferences.h.
Move definitions of variables from .h to .cc file.
Change affected files accordingly.
Note that some files were depending on includes in
language_preferences.h. For these files, add required
includes so these files compile.
BUG=chromium-os:5848
TEST=compiles. try bots.
Review URL: http://codereview.chromium.org/3164027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3093013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/3179017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gfx::Font is a platform-neutral API shim that exists as a wrapper object to allow for the creation and lifetime of gfx::Font objects to remain consistent with past usage.
gfx::PlatformFont is an interface implemented by the platform-specific inner classes (gfx::PlatformFontWin,Mac,Gtk).
BUG=none
TEST=existing unittests
Review URL: http://codereview.chromium.org/3083022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mazda: In your DOMUI html, please set the integers defined in chromeos_keyboard.h:
enum ModifierKey {
kSearchKey = 0,
kLeftControlKey,
kLeftAltKey,
kVoidKey,
kCapsLockKey,
kNumModifierKeys,
};
to the following integer prefs:
prefs::kLanguageXkbRemapSearchKeyTo
prefs::kLanguageXkbRemapControlKeyTo
prefs::kLanguageXkbRemapAltKeyTo
BUG=chromium-os:5152
TEST=manually
Review URL: http://codereview.chromium.org/3141011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a follow-up CL of
http://codereview.chromium.org/3041054
which removed m17n:t:* (latin-pre/post) from input method ID whitelist.
We had some special cases here and there for these IDs and I removed them.
Patch from kochi@chromium.org.
BUG=chromium-os:5439
TEST=run unittest (LanguageMenuButtonTest, InputMethodUtilTest)
Review URL: http://codereview.chromium.org/3122005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As we now sort language codes in assets/input_method/whitelist.txt
manually and use the order in the list, we don't need a hack to move
the default language first.
Patch from kochi@chromium.org.
BUG=chromium-os:4576
TEST=Run unit_tests --gtest_filter='Input*', manually install chromium and check if the order appears in the expected order.
Review URL: http://codereview.chromium.org/3161001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:4102
TEST=ran unit_tests
Review URL: http://codereview.chromium.org/3023044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Much remains to be converted.
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3076037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
We are no longer using the code. If we decide that we need it later, we will likely do something different.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3084027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
again with an error message.
BUG=chromium-os:2556
TEST=manual
Review URL: http://codereview.chromium.org/2808108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Handles the new wrench menu.
2. Uses NotifyAccessibilityEvent to find out when focus changes, rather
than installing focus change listeners that need to be cleaned up.
BUG=none
TEST=Updated AccessibilityEventRouterViewsTest.TestFocusNotification
Review URL: http://codereview.chromium.org/3056045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ASCIIToUTF16. I removed string_util includes from a few places where it
obviously wasn't needed.
In a separate pass, I'm going to remove ASCIITo* from string_util, then I'm
going to do an even later pass to find the unnecessary string_util.h includes
and remove them.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3058027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3012017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=CrOS bot goes green?
TBR=vtl
Review URL: http://codereview.chromium.org/3084006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3054029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to net/test/test_server.h
No code changes, just a move.
TEST=none
BUG=49680
Review URL: http://codereview.chromium.org/3034038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
work will be in another changelist.
BUG=chromium-os:4744
BUG=49030
TEST=manual
Review URL: http://codereview.chromium.org/3036020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
swap Alt/Ctrl keys and Search/Ctrl keys.
BUG=chromium-os:2636
TEST=manually on eeepc
Review URL: http://codereview.chromium.org/3038025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50273
TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux
TBR: erg
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome: create an option for using libcros provided by the system; fix all
includes referring to libcros to not include third_party/
* Headers fix is needed to support using system libcros (installed to /usr/include)
* All includes are "", and therefore a local variant in third_party/cros/ is
always preferred, but system will also get picked up as a secondary target
* Fixed chrome/browser/chromeos/cros/synaptics_library.h comments to better
reflect the header placement
* Added a variable system_libcros defaulting to 0
* Gotten rid of duplicate cros_api.gyp
* Changed both places to either link against cros_api or libcrosapi
TEST=build in the following scenarios:
1) libcros not installed, libcros sources in third_party/, !defined system_libcros
- sucess
2) installed libcros, put #error into /usr/include/cros/chromeos_cros_api.h, repeat 1)
- success
3) BUILD_DEFINES+=system_libcros=1, removed libcros from third_party, repeat 2)
- fail (on #error in chromeos_cros_api.h)
4) Installed clean libcros, repeat 3)
- success
Review URL: http://codereview.chromium.org/3043010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make NetworkLibrary::UpdateSystemInfo() externally usable, and invoke
it before retrieving/displaying network information, so that we
successfully display data that the user has just changed via another
mechanism.
BUG=chromium-os:3972
TEST=Configure certificates via entd and log out. Log back in and select the
network menu, then (immediately) the relevant SSID. Check for the proper
certificate information, rather than unset fields.
Review URL: http://codereview.chromium.org/3019015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Input dialog.
Before this change, we used to get the list of preferred languages based on
the active input methods. This is tricky. Having a preference for the value
is simpler, and makes it easier for us to implement the DOM UI version.
BUG=none
TEST=manually
Review URL: http://codereview.chromium.org/3012012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
button, rather than using the cert button ID directly, which produces
garbage.
BUG=http://crosbug.com/4490
TEST=Click network dropdown and select a 802.1x network that has not
been configured by the system (google-A when logged in to a non-corp
account, for example). Check that the button to the right of the
"Certificate:" label contains text ("Select certificate file"), rather
than the not-a-character glyph.
Review URL: http://codereview.chromium.org/2952006
Patch from Nathan Williams <njw@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:4312
TEST=none
Review URL: http://codereview.chromium.org/2805079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
function.
BUG=chromium-os:4575
TEST=see the bug
Review URL: http://codereview.chromium.org/2884017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Get rid of Init() method from LanguageConfigModel,
and add a call to NotifyPrefChanged() in the constructor.
Along the way, fix a sytle issue in LanguageConfigView.
Per the style guide, model should look like model_, as it's a member variable.
TEST=manually on the netbook.
BUG=none
Review URL: http://codereview.chromium.org/2872031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=manually on netbook
BUG=chromium-os:2625
Review URL: http://codereview.chromium.org/2815049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Note that this change works even if 51628 is reverted.
BUG=chromium-os:4555
TEST=manually
Review URL: http://codereview.chromium.org/2822045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Auto-size the views version of the options dialog.
This adds support for auto-sizing tab controls, adjusts the options dialog to
use it and takes care of any fallout due to the new layout handling. Also fixes
a couple of small bugs in the views Layout() machinery and sanitizes layouting
of options pages.
BUG=36497
TEST=unit tests in tabbed_pane_unittest.cc and grid_layout_unittest.cc, as well as checking the options dialog in any supported language.
original issuse: http://codereview.chromium.org/2812026/show
Review URL: http://codereview.chromium.org/2883022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:4183
TEST=manual
Review URL: http://codereview.chromium.org/2799052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Unexpected unit_tests crash on chromeos.
TBR: mnissler
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds support for auto-sizing tab controls, adjusts the options dialog to
use it and takes care of any fallout due to the new layout handling. Also fixes
a couple of small bugs in the views Layout() machinery and sanitizes layouting
of options pages.
BUG=36497
TEST=unit tests in tabbed_pane_unittest.cc and grid_layout_unittest.cc, as well as checking the options dialog in any supported language.
Review URL: http://codereview.chromium.org/2812026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51526 0039d316-1c4b-4281-b951-d872f2087c98
|