summaryrefslogtreecommitdiffstats
path: root/chrome/browser/chromeos/proxy_cros_settings_parser.cc
Commit message (Collapse)AuthorAgeFilesLines
* Update some uses of Value in chrome/browser to use the base:: namespace.avi@chromium.org2013-12-231-3/+4
| | | | | | | | | | | BUG=88666 TEST=no change R=brettw@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/106433007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242387 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeOS: Add a per user and a local state network preference.pneubeck@chromium.org2013-07-221-1/+2
| | | | | | | | | | | | | | | - Adds a network preference kOpenNetworkProperties to user prefs. - Adds a network preference kDeviceOpenNetworkProperties to local state. - Both are lists of NetworkConfigurations according to the ONC spec. - For now, only policies are written to these prefs. - User settings continue to be stored in Shill for now. A follow up commit will change that too. BUG=258835 TBR=mpcomplete@chromium.org (trivial change in chrome_direct_setting_api.h) Review URL: https://chromiumcodereview.appspot.com/18348012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212872 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in chrome/browser/chromeos/.avi@chromium.org2013-06-111-1/+1
| | | | | | | | | | BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/15798019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205469 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ownership of proxy UI related state.pneubeck@chromium.org2013-06-071-10/+4
| | | | | | | | | | | | - stores proxy UI related state in the CoreChromeOSOptionsHandler, i.e. per open settings page. - removes any dependency of ProxyConfigServiceImpl on proxy UI. BUG=142370, 234982 Review URL: https://chromiumcodereview.appspot.com/15847003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204853 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate ProxyConfigServiceImpl to NetworkStateHandler and NetworkProfileHandler.pneubeck@chromium.org2013-06-041-87/+77
| | | | | | | | | | | | | - UI part of ProxyConfigServiceImpl is moved to UIProxyConfig and UIProxyConfigService. - ProxyConfigServiceImpl uses NetworkStateHandler instead of NetworkLibrary except for the legacy migration of device proxy settings. - UI code continues to use NetworkLibrary for now. BUG=234982 TBR=willchan@chromium.org (for trivial but reviewed change in net/proxy/proxy_config.*) Review URL: https://chromiumcodereview.appspot.com/14846004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204016 0039d316-1c4b-4281-b951-d872f2087c98
* Added "Use an autoconfiguration URL" checkbox in proxy tabsathish.kuppuswamy@intel.com2013-04-231-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | Adding this checkbox makes user to be aware of auto detecting proxy option and also meets the new design suggested to solve the same. Providing this checkbox also ease the user to select between auto configuring proxy(PAC) and auto detecting proxy(WPAD). This checkbox functions similar to the one already provided to select single proxy mode. Contributed by sathish.kuppuswamy@intel.com BUG=chromium:222576 TEST=Built the changes along with Chromium OS, verified the behaviour of the checkbox and proxy connection. Selected "Automatic proxy configuration" option 1, Verified internet access after checking "use a autoconfiguration URL" checkbox and entering a valid PAC URL in the URL field(Auto configuring proxy). 2, Verified internet access, leaving "use a autoconfiguration URL" unchecked(Auto Detecting proxy). Same is been verified by checking "use a autoconfiguration URL" checkbox, but leaving the URL field blank. Review URL: https://chromiumcodereview.appspot.com/13334007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195690 0039d316-1c4b-4281-b951-d872f2087c98
* Fix proxy settings so that a port number in the host field gets applied to ↵gspencer@chromium.org2013-01-041-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the port field. chrome/browser/chromeos/proxy_cros_settings_parser.cc:85 The port number's final value comes from either the one specified in the Host field or the one specified in the Port field. Which one it would be depends on which field is the last updated field, so the overriding-it-whatever logic will be no longer necessary, and we removed it. chrome/browser/resources/options/chromeos/internet_detail.js:524 Add a new function called "updateProxySetting", it is used to update the proxy setting dialog's UI. Whenever the internal data storing the proxy information is changed, this function is called to update the UI instantly. chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc:167 When the proxy data settings changed, make sure the view is updated properly by calling JS function - updateProxySettings. This patch was contributed by keenepan@linpus.com, and originally reviewed in CL TBR=pastarmovj@chromium.org BUG=chromium-os:26554 TEST=Setting manual proxy with "http://" prefix AND ":<port>" suffix, the proxy settings dialog UI will update and values will in right TEXTVIEW Review URL: https://chromiumcodereview.appspot.com/11737038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175213 0039d316-1c4b-4281-b951-d872f2087c98
* Add copy and assignment to FundamentalValue and StringValue.estade@chromium.org2012-11-201-5/+4
| | | | | | | | | | | | | Also get rid of use of CreateStringValue in chromeos/ directory. This is a retry of r167808, but adding the copy and assign constructors fixes a clang compile error. BUG=160586 Review URL: https://chromiumcodereview.appspot.com/11418048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168868 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 167808 - Get rid of use of CreateStringValue in chromeos/ directory.kinaba@chromium.org2012-11-151-4/+5
| | | | | | | | | | | | | | | | | | | Reverting because the patch makes clang build failing: > chrome/browser/chromeos/cros/network_library.cc:380:26:error: C++98 requires an > accessible copy constructor for class 'base::StringValue' when binding a > reference to a temporary; was private [-Werror,-Wbind-to-temporary-copy] > SetValueProperty(prop, base::StringValue(str)); etc. BUG=160586 Review URL: https://chromiumcodereview.appspot.com/11363203 TBR=estade@chromium.org Review URL: https://codereview.chromium.org/11369258 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167826 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of use of CreateStringValue in chromeos/ directory.estade@chromium.org2012-11-151-5/+4
| | | | | | | | | BUG=160586 Review URL: https://chromiumcodereview.appspot.com/11363203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167808 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the managed banner from the Chrome settings UIbartfab@chromium.org2012-10-251-13/+13
| | | | | | | | | | | This banner has been obsoleted by the controlled setting indicators. BUG=104955 Review URL: https://chromiumcodereview.appspot.com/11272026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164195 0039d316-1c4b-4281-b951-d872f2087c98
* Consistently decorate pref values sent to the settings UI codebartfab@chromium.org2012-08-081-31/+16
| | | | | | | | | | | | | | | Pref values are provided to the settings UI code by three different classes. Each decorates the values slightly differently, adding different metadata fields or none at all. This CL makes the classes use a consistent decoration with identically named metadata fields, simplifying the handling of pref values on the JS side. BUG=104955 Review URL: https://chromiumcodereview.appspot.com/10834109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150527 0039d316-1c4b-4281-b951-d872f2087c98
* cros proxy: fix bug to accept http:// prefix and :<port> suffix for host inkuan@chromium.org2011-12-201-4/+16
| | | | | | | | | | | manual configuration BUG=chromium-os:22777 TEST=verify per bug report. Review URL: http://codereview.chromium.org/8974021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115217 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor proxy handling for ChromeOS to not go through the CrosSettings ↵pastarmovj@chromium.org2011-11-141-0/+388
interface. The ProxyCrosSettingsProvider was not a real SignedSettings handler since the network manager was introduced and was only used to parse the data for the UI. However this does not go well with the unification of the SignedSettings handling and belongs to the presentation layer. Therefore we extract the parsing functionality in a helper class and move some of the logic up the UI handling layer. BUG=chromium-os:14054 TEST=Proxy UI should still be working (automation tests). Review URL: http://codereview.chromium.org/8467012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109886 0039d316-1c4b-4281-b951-d872f2087c98