summaryrefslogtreecommitdiffstats
path: root/chrome/browser/chromeos/text_input
Commit message (Collapse)AuthorAgeFilesLines
* Tweak the horizontal mode UI in candidate_window to make it look nicerzork@chromium.org2010-06-021-7/+23
| | | | | | | | | BUG=chromium-os:2760 TEST=Use any IME, and examine the candidate window. Review URL: http://codereview.chromium.org/2450001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48690 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable the offset computation logic for the vertical candidate window.satorux@chromium.org2010-06-011-14/+10
| | | | | | | | | | | | | | | | | | | | | | The problem with the original change was that it didn't call in GetHorizontalOffset() in OnSetLocationCursor(). Outside web contetns in Chrome, UpdateLookupTable signal is followed by SetLocationCursor signal. This caused: 1. OnUpdateLookupTable() to move the candidate window with the offset computed 2. Then OnSetLocationCursor() to move the candidate window without the offset. This resulted in a flicker of the candidate window. BUG=chromium-os:2720 TEST=manually on the netbook Review URL: http://codereview.chromium.org/2423001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48612 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug that caused some Chinese characters be shown at lower positions.satorux@chromium.org2010-05-261-3/+3
| | | | | | | | | | | | | | | | | | | For some reason, Chinese characters like 时 \u65F6 are shown at wrong positions lower than it should be (see the screenshot in crosbug.com/2303). The root cause seemed be that pango_layout_get_pixel_size() returned larger height values for certain characters, but hopefully, I found that we can fix the rendering weirdness by changing the grid layout alighment. Along the way, change the logging behavior from APPEND_TO_OLD_LOG_FILE to DELETE_OLD_LOG_FILE, as appending causes more confusion than it helps. BUG=chromium-os:2303 TEST=manually on the netbook Review URL: http://codereview.chromium.org/2254001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48242 0039d316-1c4b-4281-b951-d872f2087c98
* Add --logtofile option to candidate_window.satorux@chromium.org2010-05-251-0/+18
| | | | | | | | | | | | | | | This will be used for debugging. To enable logging, we can modify /usr/share/ibus/component/candidate_window.xml as follows. - <exec>/opt/google/chrome/candidate_window</exec> + <exec>/opt/google/chrome/candidate_window --logtofile=/tmp/log.cw</exec> BUG=chromium-os:3395 TEST=manually Review URL: http://codereview.chromium.org/2101020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48135 0039d316-1c4b-4281-b951-d872f2087c98
* Do not #include obsolete header files.yusukes@google.com2010-05-251-1/+1
| | | | | | | | | BUG=none TEST=checked the patched code can compile with libcros v35. Review URL: http://codereview.chromium.org/2101018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48116 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the hack for ibus-pinyin.satorux@chromium.org2010-05-211-56/+40
| | | | | | | | | | | | | | | | Before this change, the code assumed that the orientation is vertical, if the number of candidates is 5, which is an ugly hack. After this change, we'll use orientation information in InputMethodLookupTable. To be compatible with IBus's standard candidate window, the default orientation is set to horizontal. BUG=chromium-os:2724 TEST=manually Review URL: http://codereview.chromium.org/2120010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47887 0039d316-1c4b-4281-b951-d872f2087c98
* Make the font size in the candidate window bigger again.satorux@chromium.org2010-05-181-1/+1
| | | | | | | | | | | Even with r47236, the Chinese characters look still small on the netbook. BUG=chromium-os:2904 TEST=manually Review URL: http://codereview.chromium.org/2136006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47493 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug that caused two status areas are shown when ibus-mozc is used.satorux@chromium.org2010-05-181-47/+31
| | | | | | | | | | | | | | | The root cause of the problem was a hack for ibus-anthy, that is no longer necessary. Get rid of the hack. Change the code to show the auxiliary text in the footer area when the orientation is vertical. BUG=chromium-os:3301 TEST=manually Review URL: http://codereview.chromium.org/2087008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47489 0039d316-1c4b-4281-b951-d872f2087c98
* Make the font size in the candidate window bigger.satorux@chromium.org2010-05-141-4/+10
| | | | | | | | | | | This is to make Chinese characters more readable. BUG=chromium-os:2904 TEST=manually Review URL: http://codereview.chromium.org/2070002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47236 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disabled the window position adjustment since it does not work ↵yusukes@google.com2010-05-111-3/+6
| | | | | | | | | | | fine with ibus-mozc. BUG=none TEST=manual. checked that the window does not flicker. Review URL: http://codereview.chromium.org/1987011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46896 0039d316-1c4b-4281-b951-d872f2087c98
* Compute the horizontal offset at run time in the candidate window.satorux@chromium.org2010-04-221-43/+109
| | | | | | | | | | | | | We used to use a magic number 30 to do the aligning but with this change, we'll compute the horizontal offset at run time. This is much cleaner, and more precise. TEST=manually BUG=crosbug.com/2720 Review URL: http://codereview.chromium.org/1711007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45297 0039d316-1c4b-4281-b951-d872f2087c98
* Use new APIs in candidate_window.ccsatorux@chromium.org2010-04-211-41/+45
| | | | | | | | BUG=crosbug.com/2717 Review URL: http://codereview.chromium.org/1551040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45144 0039d316-1c4b-4281-b951-d872f2087c98
* Convert Label::GetFont() to unix_hacker style. Original patch by Thiago ↵pkasting@chromium.org2010-03-301-1/+1
| | | | | | | | | | Farina (see http://codereview.chromium.org/1580002 ), r=me. BUG=none TEST=none Review URL: http://codereview.chromium.org/1528009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43136 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug that caused candidate_window to crash at startup time.satorux@chromium.org2010-03-251-0/+1
| | | | | | | | | | | | | | | | | | | | | | The problem was that CommandLine::ForCurrentProcess() was called despite candidate_window did not parse the command line flags. StackTrace::StackTrace() [0x45a312] logging::LogMessage::~LogMessage() [0x40abb7] CommandLine::ForCurrentProcess() [0x40b3b5] l10n_util::GetApplicationLocale() [0x4cd3f7] ResourceBundle::LoadResources() [0x4c935d] ResourceBundle::InitSharedInstance() [0x4c5ed7] main [0x402a5f] 0x7ffff2aa6abd 0x4002a9 BUG=crosbug.com/2254 TEST=manually Review URL: http://codereview.chromium.org/1238008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42596 0039d316-1c4b-4281-b951-d872f2087c98
* Mocks for all libcros elements. Added library registry object that provides ↵zelidrag@chromium.org2010-03-232-4/+6
| | | | | | | | | | | access to all *Libray classes that used to be singletons. This registry adds an indirection layer that will let is replace the actual objects with mocks during test runs. BUG=chromium-os:2026 TEST=none Review URL: http://codereview.chromium.org/1142005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42405 0039d316-1c4b-4281-b951-d872f2087c98
* Move app/gfx/canvas and app/gfx/font to gfx/.ben@chromium.org2010-03-231-2/+2
| | | | | | | | | | TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/1132006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42312 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: string_util.h -> utf_string_conversions.h fix.jhawkins@chromium.org2010-03-141-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/851010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41539 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug that where the horizontal candidate window was not rendered properly.satorux@chromium.org2010-02-151-6/+9
| | | | | | | | | | | | | | | | | | | | | This is a non-deterministic issue. After some investigation, we learned that the following callback functions are called before the horizontal candidate window is rendered. OnUpdateLookupTable() OnUpdateAuxiliaryText() OnSetCursorLocation() As shown, OnSetCursorLocation() is the last function to be called. We should request a resize and a paint in OnSetCursorLocation() to to ensure that the candidate window is always rendered properly. TEST=manually BUG=crosbug.com/1560 Review URL: http://codereview.chromium.org/594046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39046 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of use of deprecated members in ImeLookupTable.satorux@chromium.org2010-02-151-10/+25
| | | | | | | | | | | | | | | | | | Namely: - current_page_index - cursor_row_index - num_candidates_in_current_page - num_pages (not used in candidate_window.cc, but this will also be deleted in libcros) These members will be deleted from libcros in a separate CL. TEST=manually BUG=none Review URL: http://codereview.chromium.org/606012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39044 0039d316-1c4b-4281-b951-d872f2087c98
* Move candidate_window from third_party/chromeos_text_input to ↵satorux@chromium.org2010-02-082-0/+977
chrome/browser/chromeos/text_input. Turned out there is no benefit of having this in a separate git repository. No code change in candidate_window.cc, but modified the copyright notice from Chromium OS Authors to Chromium Authors. Slightly modified text_input.gyp to make it compile. We'll also change cros_deps/DEPS in a separate CL. BUG=none TEST=confirmed candidate_window compiles as before. Review URL: http://codereview.chromium.org/579026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38345 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-10 21:37:36 +0000