summaryrefslogtreecommitdiffstats
path: root/chrome/browser/chromeos/views
Commit message (Collapse)AuthorAgeFilesLines
* fixes for misc visual issues of domui menuoshima@chromium.org2010-10-141-3/+14
| | | | | | | | | | | | | | | | * use minimum width when set the bound of menu. This fixes problem where menu was shown in incorrect place for short period of time on OOBE. * clears the content when menu is hidden. This fixes the problem where bigger menu window is showne when opening a menu. * Update zoom controls only if the menu is root. * use plain property for scrollEnabled. BUG=none TEST=none Review URL: http://codereview.chromium.org/3775003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62636 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chromeos test failures.oshima@chromium.org2010-10-141-2/+3
| | | | | | | | | | | | Call OnMenuOpened when the menu is showen on visible area. TBR=isherman@chromium.org BUG=none TEST=TestMenuKeyboardAccess/TestAltMenuKeyboardAccess should pass Review URL: http://codereview.chromium.org/3780006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62525 0039d316-1c4b-4281-b951-d872f2087c98
* Warmup DOMView so that the 1st time menu open is fast.oshima@chromium.org2010-10-131-3/+134
| | | | | | | | | | | | DOMViewCache caches one instance for current profile. It delets and creates new one if profile is switched. BUG=chromium-os:6497 TEST=none Review URL: http://codereview.chromium.org/3778001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62479 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Resize/Scroll for dropdown as well. RTL support (location only)oshima@chromium.org2010-10-132-59/+59
| | | | | | | | | | | | | | | | | * RTL support is menu positioning only. Menu content will be done after beta. * Fix the location of menu when it has to be placed at the left edge. * Temporarily disable rounded corner for beta. I'm pretty sure there was a bug filed for RTL, but I couldn't find it today. BUG=chromium-os:7722 TEST=select rtl language (hebrew) and make sure menu's position is correctly adjusted. Language menu on info bar should have scroll button with this change. Review URL: http://codereview.chromium.org/3803002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62474 0039d316-1c4b-4281-b951-d872f2087c98
* Wait calling OnMenuOpened until the domui menu is ready to accept input.oshima@chromium.org2010-10-123-2/+18
| | | | | | | | | | | | | * Call OnMenuOpened when the window is mapped. This is necessary as DOMUI menu doesn't show the popup window until page is renderred. * Moved listners to Menu2 as Menu2 manages MenuListeners. BUG=chromium-os:7642 TEST=TestMenuKeyboardAccess,TestAltMenuKeyboardAccess passes with this fix. Review URL: http://codereview.chromium.org/3678005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62355 0039d316-1c4b-4281-b951-d872f2087c98
* Exit DOMUI menu when browser window is destroyed.oshima@chromium.org2010-10-121-0/+38
| | | | | | | | | | | | This correctly exits the loop, then destroy menu2 instance when the browser is closed while the menu is open. BUG=chromium-os:7642 TEST=CloseWithAppMenuOpen browser test should pass. Review URL: http://codereview.chromium.org/3643004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62328 0039d316-1c4b-4281-b951-d872f2087c98
* * Let MenuLocator tell if menu needs to scroll or not so thatoshima@chromium.org2010-10-124-45/+85
| | | | | | | | | | | | we only show scroll buttons when there is no space left. * If there not enough space left to make a turn, place the menu on the original direction but make it fit to the screen. BUG=chromium-os:5760, chromium-os:4762 TEST=manual: network list should no longer show scroll bar and language menu should be shown on right side of button. Review URL: http://codereview.chromium.org/3669006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62243 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor domui menu to make extending easieroshima@chromium.org2010-10-083-110/+33
| | | | | | | | | | | | | | | | * Moved the code to build JS model to MenuUI. * Added ModelUpdated/CreateMenuItem/AddCustomConfigValues for subclass to extends behavior. * Uses the actual icon size to compute left padding * Adjusted css padding parameters to match the mock (http://www.corp.google.com/~roma/design/chrome/native-widgets/menus/menus-spec.png) wrech_menu.{cc,h} not used yet, but added for Steven to look at it. BUG=none TEST=none Review URL: http://codereview.chromium.org/3613015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61981 0039d316-1c4b-4281-b951-d872f2087c98
* * Made Menu/MenuItem subclass of HTMLDivElementoshima@chromium.org2010-10-082-6/+17
| | | | | | | | | | | | | | | I looked at shared/css/menu.css, but it uses menu class and will take a bit more time to consolidate. I'll revisit again after finishign wrench menu. * Don't adjust size when window is not yet shown, which was causing flashing. * Support command activation w/o closing menu. This is necessary to support wrench menu. class BUG=none TEST=none Review URL: http://codereview.chromium.org/3579016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61896 0039d316-1c4b-4281-b951-d872f2087c98
* Let menu scroll when the menu content exceeds screen height.oshima@chromium.org2010-10-072-19/+21
| | | | | | | | | | | | | | Menu locator limits the size of window, and scrolling is handled in DOMUI. This does not implement mouse wheel yet as the current implementation doesn't support it. I also haven't enable this yet for dropdown as I need to figure out how this should work for OOBE. I'll address it in separate CL. Added command line parameter to specify DOMUI html page for testing. BUG=none TEST=none Review URL: http://codereview.chromium.org/3608006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61800 0039d316-1c4b-4281-b951-d872f2087c98
* Fix assertion failure which happens when opening submenu using keyboard ↵oshima@chromium.org2010-10-061-7/+10
| | | | | | | | | | | navigation quickly. BUG=none TEST=none Review URL: http://codereview.chromium.org/3564014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61659 0039d316-1c4b-4281-b951-d872f2087c98
* * Allow a user to select the last selected item when moving back to submenu.oshima@chromium.org2010-10-051-1/+1
| | | | | | | | | | | * Ignore false mouseover when switching to submenu, which was closing submenu. * Fixed a bug that was setting selection when moving a mouse. (in native_menu_domui.cc) BUG=none TEST=none Review URL: http://codereview.chromium.org/3615010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61575 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI implementation of Menu2.oshima@chromium.org2010-10-046-0/+1299
A few key design points. * Uses DOMView to render menu content. * MenuUI (subclass of DOMUI) uses GtkWiget tree to access WidgetGtk and MenuModel. Alternative way was to change TabContents::GetDOMUIForCurrentState() public and pass them throught it, but this seems to work fine. * Input/Focus is controlled by gtk_grab_add. Input is grabbed by the root widget, and then sent to each active menu widget via gtk_grab_add. * Menu gets shown after the renderer rendered the content (thus has some size) to avoid showing small/empty menu. Mouse processing is blocked until the menu is shown (see Dispatcher). A few issues that will be addressed in separate CL * RTL (will be after beta) * menu scroll. working on it now. * menu sometimes show scroll bar. (I just need to disable it) * unit test for native_menu_domui BUG=chromiun-os:6497 TEST=manual for now. all menu2 based meus should work as before (web pages's context menu, system menu, forward/back menu and several chromeos specific one) except for following two: * mnemonic should work now on context menus. * menu larger than screen does not scroll. I'll implement this in separate CL Review URL: http://codereview.chromium.org/3442018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61445 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-03 14:01:06 +0000