| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- This changes RecentlyUsedFoldersComboModel::GetItemAt() to return a string16
instead of a wstring.
- This entailed changing the base class, ComboboxModel, and shaving a herd of
yaks.
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3159031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
changes have already been removed.
Review URL: http://codereview.chromium.org/3149029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:5168
TEST=Manual - use devserver to install update and verify notification
appears to restart after update is installed with no other notifications.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56616
Review URL: http://codereview.chromium.org/3157018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
src/chrome.
BUG=23581
TEST=builds
Review URL: http://codereview.chromium.org/3181028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
used for recovery screen.
BUG=chromium-os:5877
TEST=Run Chrome with --login-manager --login-screen=html file://filename
Review URL: http://codereview.chromium.org/3158023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/3167031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=CrOS builds
TBR=jhawkins
Review URL: http://codereview.chromium.org/3171021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
switch and display the new DOM UI when it's used.
BUG=chromium-os:5522
TEST=make sure the new DOM UI option tab opens from status bar drop down menues (language, internet and system settings)
Review URL: http://codereview.chromium.org/3142020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
language_preferences.h exports lots of constants hence polutes chromeos
namespace.
TEST=compiles. try bots.
BUG=chromium-os:5848
Review URL: http://codereview.chromium.org/3132023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=phajdan.jr@chromium.org,
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3149026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to (but not limited to) allow system update notification to have "restart" button.
* BalloonHost::EnableDOMUI() to enable DOMUI in notification page.
* chromeos::BalloonCollectionImpl::AddDOMUIMessageCallback to add
a callback for given DOMUI message.
* Added two tests cases (see below)
BUG=chromium-os:5810
TEST=TestAddDOMUIMessageCallback and TestDOMUIMessagCallback are added to notification_browsertest
Review URL: http://codereview.chromium.org/3186016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The parameter describes a list of Values that act as parameters to the callback. It is always a ListValue. It should be typed as such.
BUG=none
TEST=compile; manual testing
Review URL: http://codereview.chromium.org/3146019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the browser chrome. This doesn't fix problems with the NTP background image offsets (see bug 51853).
This also makes sure the OTR avatar is reversed in RTL mode, and clipped as usefully as possible when there isn't enough room for the full image.
BUG=44157
TEST=Frame, toolbar, bookmark bar, and find bar all look lined up with default and custom themes, restored and maximized, LTR and RTL, side tabs and normal tabs, and in popup and app windows
Review URL: http://codereview.chromium.org/3137019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove CAPTCHA code from existing user controller and plumb into google
authenticator2.
TEST=Install ChromeOS build. Hit Captcha. Enter captcha.
BUG=50408
Review URL: http://codereview.chromium.org/3134009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3153023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix a bunch of #includes. Folks, scoped_refptr<> is defined in
base/ref_counted.h, not in base/scoped_ptr.h.
BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/3132024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
includes to other files
Review URL: http://codereview.chromium.org/3142019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GetHardwareKeyboardLayoutName method in libcros.
(In addition to http://codereview.chromium.org/3188003/show)
BUG=chromium-os:5579
TEST=None
Review URL: http://codereview.chromium.org/3115018
Patch from Hitoshi Yoshida <peria@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3183018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Get rid of includes from language_preferences.h.
Move definitions of variables from .h to .cc file.
Change affected files accordingly.
Note that some files were depending on includes in
language_preferences.h. For these files, add required
includes so these files compile.
BUG=chromium-os:5848
TEST=compiles. try bots.
Review URL: http://codereview.chromium.org/3164027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This (re-)inspects files under src/chrome for unneeded #includes of <map>, <string>, <vector>, etc.
BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/3152033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
fix to 5168.
BUG=chromium-os:5168
TEST=Manual - use devserver to install update and verify notification
appears to restart after update is installed with no other notifications.
Review URL: http://codereview.chromium.org/3157018
TBR=seanparent@google.com
Review URL: http://codereview.chromium.org/3162022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compile test
Review URL: http://codereview.chromium.org/3199005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3093013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
method in DOMUI.
BUG=chromium-os:5546, chromium-os:5547
TEST=manual
Review URL: http://codereview.chromium.org/3143013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:5168
TEST=Manual - use devserver to install update and verify notification
appears to restart after update is installed with no other notifications.
Review URL: http://codereview.chromium.org/3157018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:5600
TEST=On Chrome OS login screen enter wrong password.
Review URL: http://codereview.chromium.org/3111009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Remove "display candidates in Traditonal Chinese" config as it's no longer
present in the upstream.
2. Rephrase an incorrect description "Use Shift key to select a candidate"
per suggestion from penghuang.
BUG=chromium-os:4856,chromium-os:4685
TEST=manually
Review URL: http://codereview.chromium.org/3145023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We were showing 1 or 2 instead of meaningful labels.
TEST=manually
BUG=chromium-os:5690
Review URL: http://codereview.chromium.org/3165034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:5796
TEST=login, enable Japanese IME, click Omnibox, type aaa, make sure a preedit string like あああ is shown, click the language menu botton on the top-right corner of Chrome, make sure the language menu pops up, click the button again to close the menu, verify that the preedit string あああ still exists.
Review URL: http://codereview.chromium.org/3185009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=eroman
BUG=49680
Review URL: http://codereview.chromium.org/3175019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=28294
Review URL: http://codereview.chromium.org/3145014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TabStrip::SetBackgroundOffset() into a single call in a different place.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3107012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(http://code.google.com/p/chromium-os/issues/detail?id=4448)
Moved PopupNonClientFrameView to its own file and moved FrameView initialization logic to BrowserFrameChromeos::Init.
TEST=See issue. Additionally, ensure that non-chromeos Chrome popup window behavior is unaffected, and that the address bar is still visible for popup windows not generated by apps (e.g popped out google chat windows), on chromeos and non-chromeos.
Review URL: http://codereview.chromium.org/3133001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Apply 10% white to selected menu button;
- Remove the menu offset so that the menu is top aligned with toolbar;
- Make all status area buttons derive from StatusAreaButton;
- Move ClockMenuButton's text size logic into StatusAreaButton to share the
logic with LanguageMenuButton;
- Strip unused space from LanguageMenuButton so that it looks good with 10%
white highlight;
- Make LanguageMenuButton and ClockMenuButton center aligned;
- Add 1-pixel padding at top when the vertical space is odd number so that text
looks properly aligned with the icons;
BUG=chromium-os:5517
TEST=Verify fix for chromium-os:5517.
Review URL: http://codereview.chromium.org/3141019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3109025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crosbug.com/5376
TEST=Manual
Review URL: http://codereview.chromium.org/3114011/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Get{Boolean,Integer,Real,Binary,Dictionary,List}().
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3187004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:5646
TEST=option chrome:options on chromeos build, go to system page and make timezone is back there
Review URL: http://codereview.chromium.org/3143009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the language menu, we show language names only if there are no
ambiguity. However, showing "Japanese" is confusing, when only
Japanese keyboard layout is enabled. Users would expect they can
enter Japanese with an input method, rather than just using
"Japanese keyboard".
BUG=chromium-os:5675
TEST=unit tests; manually on the netbook
Review URL: http://codereview.chromium.org/3122019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chromium OS.
Users shoulnd't be able to remove such a language.
In the C++ version, we disabled the "Remove" button to prevent the action, but
in the DOMUI version, we'll show a warning instead, per suggestions from UX
designers.
BUG=chromium-os:5702
TEST=manually
Review URL: http://codereview.chromium.org/3122018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove unused variable kDefaultKeyboardLayout.
- Fix bad indent.
- Add comment to SetImeConfig().
BUG=none
TEST=manually
Review URL: http://codereview.chromium.org/3148014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I wasn't freeing some memory I caused to be allocated down in NSS. It turns
out I didn't even need the data structures I was allocating anymore :-)
BUG=52181
TEST=Valgrind the unit_tests
Review URL: http://codereview.chromium.org/3106013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/3179017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3121017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
DictionaryValue::Get...WithoutPathExpansion()s.
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3116013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Instead use AppendArg variants which accept a FilePath or an ASCII string.
Review URL: http://codereview.chromium.org/3134008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
background
so it doesn't get deleted more than once
BUG=chromium-os:5156
TEST=none
Review URL: http://codereview.chromium.org/3104010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56062 0039d316-1c4b-4281-b951-d872f2087c98
|