| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and is restarted.
BUG=112109
TEST=Crash the browser and verify that screenlocker observers have been registered (i.e. short power press works).
Review URL: https://chromiumcodereview.appspot.com/9310002
TBR=flackr@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9317057
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@120228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is check-in for mattias.
Original review: http://codereview.chromium.org/9315011/
Note that this hard-wires policy OAuth fetching in login_utils.cc to the
authentication profile. I'm not entirely sure this is a good idea, but
required since the user profile isn't in a state to allow successful
requests at this point (the use-shared-proxies flag is off). Other stuff
in login_utils.cc might need the hack too (sync?).
BUG=chromium-os:25703
TEST=Verify fix for chromium-os:25703
TBR=mnissler@chromium.org,zelidrag@chromium.org,sumit@chromium.org,pastarmovj@chromium.org,kuan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9309024
TBR=xiyuan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9309053
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@120203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
populate the use_shared_proxies pref.
This is necessary to enforce proper operation if the browser crashes too
early in the login sequence and the preferences file has not been stored
yet.
BUG=chromium-os:25703
TEST=Manually tested by putting a DCHECK just after setting the pref in LoginUtilsImpl::OnProfileCreated.
Review URL: https://chromiumcodereview.appspot.com/9314031
TBR=pastarmovj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9317050
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@120202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
chromeos/power looks more suitable place for the code than chromeos/system
BUG=None
TEST=Turn on spoken feedback and ensure audio feedbacks are made when resuming from suspend or unlocking screen.
Review URL: http://codereview.chromium.org/9234060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=chrome://imageburner works
Review URL: http://codereview.chromium.org/9225054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:23673
TEST=OncNetworkParserTest
Review URL: https://chromiumcodereview.appspot.com/9297061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The lock screen container needs a layout manager to respond to resolution changes caused by an external monitor being attached or detached. Marking the login screen widget as fullscreen makes it reshape to track the size change.
BUG=110942
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/9121063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, the UI would make decision based on the enabled() state of
controls, indicating that the control is not relevant for the currently
chosen configuration. This doesn't work for policy-configured networks,
since the control might just be locked down, in which case it is
relevant, but disabled.
BUG=chromium-os:23124
TEST=Configure ONC networks through policy, observe that the connection dialogs show the configured values even though disabled.
Review URL: https://chromiumcodereview.appspot.com/9296009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=108740
TEST=Manul: see bug description.
Review URL: https://chromiumcodereview.appspot.com/9113080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
burn_controller.cc
BUG=chromium-os:16553
TEST=chrome://imageburner works
Review URL: https://chromiumcodereview.appspot.com/9235028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 119620 - Revert r119614 "Make auto-enrollment client retry after auto-update if the modulus limit was in..."
I initially thought r119615 was the culprit but I was wrong. Only r119614 could
now possibly make ExtensionApiTest.ProcessesVsTaskManager time out reliably on
windows.
TBR=joaodasilva@chromium.org
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/9295039
TBR=maruel@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9296037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
modulus limit was in..."
I initially thought r119615 was the culprit but I was wrong. Only r119614 could
now possibly make ExtensionApiTest.ProcessesVsTaskManager time out reliably on
windows.
TBR=joaodasilva@chromium.org
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/9295039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
increased.
Also moved the local state handling code to auto_enrollment_client.cc.
BUG=chromium-os:23063
TEST=AutoEnrollmentClientTest.*
Review URL: http://codereview.chromium.org/9296007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
prevents the browser window from receiving focus.
Removed current fade out animation in favor of ash's hide animation. Ash hide animation will be added once ben's hide animation refactoring is done.
BUG=101119
TEST=manual: see bug for repro step
Review URL: http://codereview.chromium.org/9290019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
For example, if the current tab is navigated to a JPEG and the user chooses "Save Page As" from the wrench menu, the data will be retrieved from cache without validation even if Cache-Control: no-cache is specified.
BUG=32246,55551,94574
TEST=DownloadTest.SavePageNonHTMLViaGet
Review URL: http://codereview.chromium.org/9178029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change-Id: Ide0e496c6919282ee707847c4d11db8a182eeac2
BUG=24403
TEST=Add a certificate. Ensure that it shows up when adding Wifi or VPN networks. Remove the certificate. Make sure it is no longer available when adding Wifi or VPN networks. Also, see issue.
Review URL: http://codereview.chromium.org/9280014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[part 2 of 2].
Add caps_lock_handler.cc which implements ash::CapsLockDelegate.
Part 1 of 2: http://codereview.chromium.org/9242003
Original review for Part 2 of 2: http://codereview.chromium.org/9225004/ (LGTM'ed by ben@chromium.org and derat@chromium.org)
BUG=110129
TEST=ran browser_tests
TBR=ben@chromium.org,derat@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9297027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=110765
TEST=Lock the screen, open network menu, select proxy settings. Observe proxy settings dialog.
Review URL: https://chromiumcodereview.appspot.com/9296013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is mostly everything except code under /sync or sync_internals (those require a little more time
as they have unit test implications). The ones here are quite simple but need several owner-approvals, and given the upcoming 18 branch I'd like
to get this landed without a cross-team monday crunch :)
TBR=jhawkins@chromium.org
TBR=mirandac@chromium.org
TBR=isherman@chromium.org
TBR=nkostylev@chromium.org
TBR=estade@chromium.org
BUG=93922
Review URL: http://codereview.chromium.org/9169096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chrome for cros on linux repeatedly attempts to connect to alsa. The most visible effect is continual error log spew as the connect fails and chrome retries.
BUG=NONE
TEST=should no longer see audio connection log spew with chrome for cros on Linux.
Review URL: http://codereview.chromium.org/9288050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:24308
TEST=Modified DeviceStatusCollectorTest in unit_tests to check that
portions of the status are only included when the appropriate pref is
enabled.
Review URL: http://codereview.chromium.org/9289017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also reintroduced the missing counters for token and policy fetching.
BUG=chromium-os:23063
TEST=about:histograms shows collected metrics for Enterprise.Enrollment with values from 9 to 13 after enrolling a device
Review URL: http://codereview.chromium.org/9160027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=109314
TEST=Manual: see bug description comment #5
Review URL: http://codereview.chromium.org/9289049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We can't allow the lock screen to be shown before the login flow is complete. The lock screen uses the same layer which can lead to all sorts of problems.
BUG=110933
TEST=Login as a new user, before completing the new user wizard short press the power button and the device will turn off.
Review URL: http://codereview.chromium.org/9271065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Currently we need to be careful not to delete the start and the end marker lines so that gen_keyboard_overlay_data.py work properly. This change move the generated part of xkeyboard.cc to a different file in order to make it easy to update the data and xkeyboard.cc.
BUG=None
TEST=unit_tests --gtest_filter="XKeyboardTest.*" passes
Review URL: http://codereview.chromium.org/9289044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Time from EULA acceptance to Sign-In screen;
- Time from Sign-In screen display to login completion;
- Time for auto-enrollment protocol to complete;
- Extra time for auto-enrollment protocol to complete, after login completion.
BUG=chromium-os:23063
TEST=Do auto-enrollment. about:histograms collected these metrics.
Review URL: http://codereview.chromium.org/9289015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Confiure a WPA-EAP wireless network and check that the ServerCARef settings is parsed correctly.
Review URL: http://codereview.chromium.org/9113062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:18550
TEST=Manual: see bug description
Review URL: http://codereview.chromium.org/9234027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
for long time.
BUG=chromium-os:25316
TEST=chrome://imageburner works
Review URL: http://codereview.chromium.org/9270040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and hide LeakyLazyInstanceTraits in base::internal to discourage cargo-culting
new users.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9117038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is implemented by the SiteInstanceImpl class which lives
in content\browser\site_instance.cc/.h.
Changes as part of creating a content API.
BUG=98716
TEST=No change in functionality. Hopefully it all compiles and works.
Review URL: http://codereview.chromium.org/8515027
Review URL: https://chromiumcodereview.appspot.com/9146028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also changes the order the variants are suggested.
BUG=chromium-os:23360
TEST=manual
Review URL: http://codereview.chromium.org/9234026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ensure BurnManager is initialized/destroyed at the correct timing.
BUG=chromium-os:16553
TEST=Open chrome://imageburner and try to burn recovery image.
Review URL: http://codereview.chromium.org/9251007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:20007
TEST=None
Review URL: http://codereview.chromium.org/9193005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
systemPrivate
BUG=chromium-os:24954
TEST=Build success
Review URL: http://codereview.chromium.org/9130002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In that case, sending the event to the daemon is unnecessary since 1) xkb IME always returns 'not consume the key' and 2) Chrome itself can perform dead key composition.
BUG=chromium-os:25273
TEST=ran ui_unittest
Review URL: http://codereview.chromium.org/9235006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(broke in r108543).
Refactor test DB code so that nss_util owns the test DB dir.
Keeping the test DB dir until exit prevents later tests that would use the test DB from failing. The dir will still be deleted by the LazyInstance atexit handler.
BUG=108748
TEST=see bug
Review URL: http://codereview.chromium.org/9255034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
crosh process.
Some applications we run in crosh expect their stdin/stdout to be terminal, and
malfunction if we use pipes.
One of results of this change is we stopped distinguishing between stdout and
stderr (both streams are detected through same file descriptor). I still have to
update extension API to reflect this.
Also, added support for detecting when crosh process exits.
This depends on https://chromiumcodereview.appspot.com/9150051/ and
https://chromiumcodereview.appspot.com/9176013/ (and I tested it with those two in place).
TEST=ExtensionTerminalPrivateApiTest.*, ProcessProxy.*, git try
BUG=chromium-os:23273
Review URL: https://chromiumcodereview.appspot.com/9195039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:25224
TEST=Lock the screen, press ctrl+alt+z and the accessibility bubble is no longer shown.
Review URL: https://chromiumcodereview.appspot.com/9235011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change reverts r118627 and r118640.
BUG=hromium-os:24612
TEST=Login/sync works and policy fetched as before the gaia url change.
TBR=zelidrag@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9117048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
resumes from sleep.
BUG=106245
TEST=manual
Review URL: http://codereview.chromium.org/9284003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Run chrome on linux; connect to a stub network with incryption: a passphrase starting wiht "bad" should trigger a "bad passphrase" error notification; a passphrase starting with "error" should trigger an error notification.
Review URL: http://codereview.chromium.org/9155021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, every time the location of the input cursor in Chrome changes, ui::InputMethodIBus sends an IPC message to ibus-daemon by calling ibus_input_context_set_cursor_location API so that the IME candidate window could be shown in a proper position. However, the IPC is actually unnecessary since the candidate window is shown by the Chrome browser process itself. Instead of the IPC, we should update member variables in chromeos::input_method::IBusUiControllerImpl.
BUG=chromium-os:25332
TEST=try
Review URL: http://codereview.chromium.org/9241033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This allows us to create a mock object for the interface, which is necessary for http://codereview.chromium.org/9225004/. Actual function implementations are not changed.
BUG=110129
TEST=ran try
Review URL: https://chromiumcodereview.appspot.com/9264004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change renames some identifiers to distinguish the visual style of being drawn **** **** from the logical property of being a password. It is split off from issue 8748001 and issue 8747001. See http://codereview.chromium.org/8748001/#msg12 and http://codereview.chromium.org/8748001/#msg14 for discussion of the name.
TEXT_INPUT_TYPE_PASSWORD is unchanged; it should perhaps be renamed, but not to OBSCURED since it affects input, not display.
BUG=none
TEST=It compiles. Ship it.
Review URL: http://codereview.chromium.org/9117012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
cros/burn_library is still there.
BUG=chromium-os:16553
TEST=chrome://imageburner works
Review URL: https://chromiumcodereview.appspot.com/9176016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a regression introduced in http://codereview.chromium.org/8961009
(http://codereview.chromium.org/8961009/diff/18001/chrome/browser/chromeos/login/login_performer.cc?context=&column_width=80)
TEST=If only username@gmail.com is whitelisted, signing in as user.name@gmail.com should also be allowed
Review URL: https://chromiumcodereview.appspot.com/9265005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
cros/burn_library is still there.
BUG=chromium-os:16553
TEST=chrome://imageburner works
TBR=hashimoto@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9193006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=hashimoto@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9200010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118659 0039d316-1c4b-4281-b951-d872f2087c98
|