summaryrefslogtreecommitdiffstats
path: root/chrome/browser/chromeos
Commit message (Collapse)AuthorAgeFilesLines
* Refactor the keyboard events handling code related to ↵suzhe@chromium.org2009-12-101-4/+3
| | | | | | | | | | | | | | | | | | | | | | | | | RenderViewHostDelegate::View and TabContentsDelegate interfaces. Significant changes made by this CL: 1. The keyboard event handling code has been moved from TabContentsView implementation classes into BrowserWindow implementation classes. Please refer to this discussion thread: http://groups.google.com/group/chromium-dev/browse_thread/thread/e6e0b5cc105659b7/9953c4308bb0000c This change makes the keyboard event flow comply with the relationship between TabContents/TabContentsView and TabContentsDelegate/BrowserWindow. Besides it, the code is also simplified a lot, for example, the keyboard event handling code in chrome/browser/views/tab_contents/tab_contents_view_{gtk,win}.cc are now merged into one copy and moved into chrome/browser/views/frame/browser_view.cc. 2. A pre-handle phrase has been added into the keyboard event handling flow. A keyboard event will be first sent to the browser for pre-handling before being sent to the renderer. Then if the event was not handled by the renderer, it'll be sent to the browser again for post-handling. 3. The keyboard accelerator handling code of Windows and Linux ports have been optimized to get rid off extra command lookup. 4. The keyboard event message flow between the browser and the renderer is changed back to full async mode, all complex logics introduced by revision 29857 are removed. BUG=24479, 26054, 26131, 28839 TEST=See bug reports. Review URL: http://codereview.chromium.org/400012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34234 0039d316-1c4b-4281-b951-d872f2087c98
* rollback r34183estade@chromium.org2009-12-091-2/+2
| | | | | | | | tbr=asargent Review URL: http://codereview.chromium.org/482002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34187 0039d316-1c4b-4281-b951-d872f2087c98
* linux: theme scrollbars from GTK theme estade@chromium.org2009-12-091-2/+2
| | | | | | | | | | | | | | | | Pick the color of the slider's thumbpart and rail from the GTK theme. We cannot match the exact visual appearance of the GTK theme, as rendering engines can make arbitrary changes to the actual visual appearance. But by sampling a representative set of pixels, we ensure that we will at least match the general color scheme. BUG=10949 patch by <markus [at] chromium> original review: http://codereview.chromium.org/400027/show Review URL: http://codereview.chromium.org/466080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34183 0039d316-1c4b-4281-b951-d872f2087c98
* fix for memory leak and illegal access, 2nd attempt.oshima@chromium.org2009-12-091-8/+9
| | | | | | | | | | | | | | * ExternalMetrics class requires scoped_refptr. original CL : http://codereview.chromium.org/470006 BUG=None TEST=Run unit_test with valgrind. patch from issue 470006 Review URL: http://codereview.chromium.org/465140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34176 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bugs with panels. We weren't setting the type at the right timesky@chromium.org2009-12-091-0/+2
| | | | | | | | | | | | and needed to set a size_request so that the title gets the right size. BUG=none TEST=none Review URL: http://codereview.chromium.org/466081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34141 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 34134 - Viewsbased login window for Chrome OS. Doesn't yet actually ↵jrg@chromium.org2009-12-096-364/+16
| | | | | | | | | | | do anything Review URL: http://codereview.chromium.org/449023 TBR=cmasone@google.com Review URL: http://codereview.chromium.org/467060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34135 0039d316-1c4b-4281-b951-d872f2087c98
* Views-based login window for Chrome OS. Doesn't yet actually do anythingcmasone@google.com2009-12-096-16/+364
| | | | | | Review URL: http://codereview.chromium.org/449023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34134 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 34099 - fix for memory leak and illegal access. (found in valgrind test)asargent@chromium.org2009-12-092-12/+8
| | | | | | | | | | | | | | | | * name, values for callback seems to be on stack. i changed const char* to string so that it can copy, and also expect_eq can print string when failed. BUG=None TEST=Run unit_tests on valgrind. Review URL: http://codereview.chromium.org/470006 TBR=oshima@chromium.org Review URL: http://codereview.chromium.org/466083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34114 0039d316-1c4b-4281-b951-d872f2087c98
* fix for memory leak and illegal access. (found in valgrind test)oshima@chromium.org2009-12-082-8/+12
| | | | | | | | | | | | | * name, values for callback seems to be on stack. i changed const char* to string so that it can copy, and also expect_eq can print string when failed. BUG=None TEST=Run unit_tests on valgrind. Review URL: http://codereview.chromium.org/470006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34099 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where we wouldn't force a maximized window on Chrome OSsky@chromium.org2009-12-071-2/+6
| | | | | | | | | | | | | | | | during login. This happens because on Chrome OS we start the WM and Chrome at the same time, which means it's possiblef for us not to be able to get the name of the window manager. I've changed the code to assume that if we can't get the name of the window manager we're on Chrome OS. This isn't perfect. Hopefully once the WM tells us we're maximized before we're shown we can do away with this code. BUG=ChromeOS bug 929 TEST=none Review URL: http://codereview.chromium.org/463042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33985 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustage.pinkerton@chromium.org2009-12-041-4/+1
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33829 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the menu model to live outside views/ so it can be sharedpinkerton@chromium.org2009-12-049-51/+57
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/465005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33827 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chromium os build.estade@chromium.org2009-12-042-0/+7
| | | | | | Review URL: http://codereview.chromium.org/468016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33777 0039d316-1c4b-4281-b951-d872f2087c98
* Still fixing ChromiumOS build.phajdan.jr@chromium.org2009-12-021-0/+1
| | | | | | | | TBR=thestig Review URL: http://codereview.chromium.org/459013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33564 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromeOS build by #including needed header.phajdan.jr@chromium.org2009-12-021-0/+1
| | | | | | | | TBR=sky Review URL: http://codereview.chromium.org/459012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33562 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-301-0/+1
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33324 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 33301 and 33305 due to unit_tests breakage.maruel@chromium.org2009-11-301-1/+0
| | | | | | | | TBR=pawel Review URL: http://codereview.chromium.org/453007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33309 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile for ChromeOS by #including needed headers.phajdan.jr@chromium.org2009-11-301-0/+1
| | | | | | | | | | TBR=maruel BUG=none TEST=none Review URL: http://codereview.chromium.org/457004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33305 0039d316-1c4b-4281-b951-d872f2087c98
* Draw the normal window's frame in maximized mode. See BUG for more detail. ↵oshima@chromium.org2009-11-301-5/+27
| | | | | | | | | | | Dan will investigate further when he has time. BUG=28580, 727 (chromeos) TEST=None Review URL: http://codereview.chromium.org/436039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33302 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Network section from options pages for now.chocobo@chromium.org2009-11-191-3/+4
| | | | | | | | BUG=541 TEST=None Review URL: http://codereview.chromium.org/399094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32443 0039d316-1c4b-4281-b951-d872f2087c98
* Remove new tabstrip code. Going to try doing this a different way.ben@chromium.org2009-11-171-3/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/400005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32197 0039d316-1c4b-4281-b951-d872f2087c98
* Use plain strings instead of wstrings for UMA actionsevan@chromium.org2009-11-172-8/+8
| | | | | | | | | | | | git grep 'RecordAction(L' | xargs sed -i -e s/RecordAction(L/RecordAction(/ This cuts more than 10k off my binary. Which is nothing compared to the size of the binary, but that's a whole lot of zero bytes! This is less code this way anyway. Review URL: http://codereview.chromium.org/399026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32194 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crashing bug due to browser being NULL.chocobo@chromium.org2009-11-171-3/+3
| | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/400015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32187 0039d316-1c4b-4281-b951-d872f2087c98
* amit, please review everything, jam please review the changes to the ↵ananta@chromium.org2009-11-171-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | tab_contents and the renderer_host sources. Remove the AutomationProfileImpl class which wraps the Chrome profile for an external tab container, which hosts ChromeFrame. This object was used to carry a custom URL request context which was used to intercept HTTP requests and cookie requests issued by external tabs. However as the life time of the automation profile class depended on the lifetime of the external tab container object this caused a number of crashes in objects which held on to the automation profile pointer retrieved from the associated tab contents. This does not happen in a regualar Chrome browser instance as the profile is deleted at the very end. We can associate the automation URL request context with the underlying tab_contents which would eventually percolate down to the resource message filter. Doing this would avoid the need for the AutomationProfile class. This CL achieves that. Bug=27695,27662 Review URL: http://codereview.chromium.org/385117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32127 0039d316-1c4b-4281-b951-d872f2087c98
* Use Chrome to transport Chrome OS metrics. rvargas@google.com2009-11-133-0/+461
| | | | | | | | | | | | | | | | | | | | | | | Chrome periodically reads the content of a well-know file, and parses it into name-value pairs, each representing a Chrome OS metrics event. The events are then logged using the normal UMA mechanism. The file is then truncated to zero size. Chrome uses flock() to synchronize accesses to the file. BUG=none TEST=compiled and run Linux and Chrome OS versions. Verified that uploaded Chrome OS events appear in about:histograms. Also external_metrics_unittest.cc tests the collection of metrics messages from the well-known file. patch written by semenzato_google.com original code review: http://codereview.chromium.org/378013 (plus http://codereview.chromium.org/346041) Review URL: http://codereview.chromium.org/394010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31952 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes almost all of the rest of lint errors in the chrome/ directory (minus ↵erg@google.com2009-11-131-1/+1
| | | | | | | | the really hard ones which will need actual review instead of rubber-stamping.) Review URL: http://codereview.chromium.org/386026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
* Rename loaded() to EnsureLoaded() to match my previous change.brettw@chromium.org2009-11-132-5/+5
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/391053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31913 0039d316-1c4b-4281-b951-d872f2087c98
* Write a test for loading libcros.so on startup of Chrome. You just pass thebrettw@chromium.org2009-11-1310-26/+28
| | | | | | | | | | | | | | | --test-load-libcros on the command line. The browser will exit immediately and the error code (and error messages) will indicate success or failure. I also renamed loaded() static functions related to loading this library. These are not simple getters since they will actually load the library if its not loaded yet. I renamed it to EnsureLoaded. TEST=This is a test BUG=none Review URL: http://codereview.chromium.org/387014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31911 0039d316-1c4b-4281-b951-d872f2087c98
* Focus fix for compact navigation bar.oshima@chromium.org2009-11-124-1/+28
| | | | | | | | | | | | * Make focusable so that focus can be moved to compact navigation bar by tab. * Ctrl-L should focus the compact navigation bar (and select all texts) BUG=51 (chrome-os) TEST=switch to compact navigation bar mode, hit tab or ctrl-L to move focus to compact navigation bar. Review URL: http://codereview.chromium.org/384079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31808 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for issue 27210, show bookmarks bar menu is out of sync with the ↵oshima@chromium.org2009-11-111-3/+5
| | | | | | | | | | | | | | | | | browser's status. * Update the states of menu before showing menu like Window's menu does. * Don't fire activate signal when the state is chagned via API. * Eliminated UpdateStateData and replace it with the NativeMenuGtk and the position stored in the gtk widget. * Fixed StateAreaView to check bookmark bar status. BUG=27210 TEST=Run linux builds (gtk/views/chromeos) check if the bookmark bar menu's status is in sync with the bookmark bar. Review URL: http://codereview.chromium.org/383012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31654 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/379007 for Dave:sky@chromium.org2009-11-114-0/+341
| | | | | | | | | | | | Fixes leak in BackingStore as shown by valgrind. XFree doesn't free the data of the image, where as XDestroyImage does. BUG=none TEST=none Review URL: http://codereview.chromium.org/391008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31633 0039d316-1c4b-4281-b951-d872f2087c98
* Unrevert 31478 Add UI for turning on/off network devices.mpcomplete@chromium.org2009-11-104-84/+336
| | | | | | | | | | | BUG=26636 TEST=run skbitmap_operations_unittest Review URL: http://codereview.chromium.org/353028 TBR=chocobo@google.com Review URL: http://codereview.chromium.org/384017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31598 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 31478 - Add UI for turning on/off network devices.mpcomplete@chromium.org2009-11-104-336/+84
| | | | | | | | | | | BUG=26636 TEST=run skbitmap_operations_unittest Review URL: http://codereview.chromium.org/353028 TBR=chocobo@google.com Review URL: http://codereview.chromium.org/384014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31589 0039d316-1c4b-4281-b951-d872f2087c98
* * Add History menu to back/forward buttons in compact navigation bar.oshima@chromium.org2009-11-092-39/+105
| | | | | | | | | | | * Enable/Dislable back/forward button to reflect the state of command. BUG=26498, 26264 TEST=None Review URL: http://codereview.chromium.org/366033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31504 0039d316-1c4b-4281-b951-d872f2087c98
* Refactored FindBarHost/View to create DropdownBarHostView, which I'm plannig ↵oshima@chromium.org2009-11-091-1/+2
| | | | | | | | | | | | | to use this for CompactLocationBar. BUG=None TEST=enabled find_bar_host_browsertest.cc for linux view build. Review URL: http://codereview.chromium.org/360044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31486 0039d316-1c4b-4281-b951-d872f2087c98
* Add UI for turning on/off network devices.chocobo@google.com2009-11-094-84/+336
| | | | | | | | BUG=26636 TEST=run skbitmap_operations_unittest Review URL: http://codereview.chromium.org/353028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31478 0039d316-1c4b-4281-b951-d872f2087c98
* Use GetSwitchValueASCII.tony@chromium.org2009-11-061-1/+1
| | | | | | | | | | | | BUG=24672 TEST=None Original patch by Thiago Farina <thiago.farina@gmail.com> at http://codereview.chromium.org/296004 Review URL: http://codereview.chromium.org/373013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31269 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert r31175 r31176 r31187"hclam@chromium.org2009-11-061-0/+4
| | | | | | | | | | | | The bustage seems to be a WebKit change upstream. It is not reverted in WebKit and merger. So bring the innocent change back in. TBR=jam TEST=green tree Review URL: http://codereview.chromium.org/375009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31214 0039d316-1c4b-4281-b951-d872f2087c98
* Rever r31175 r31176 r31187hclam@chromium.org2009-11-061-4/+0
| | | | | | | | | | | XP tests are failing, the guess is r31175 and r31176. TBR=beng TEST=XP tests go green Review URL: http://codereview.chromium.org/376008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31201 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chromeos build breakjam@chromium.org2009-11-061-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31187 0039d316-1c4b-4281-b951-d872f2087c98
* Fifth patch in making destructors of refcounted objects private.jam@chromium.org2009-11-061-0/+4
| | | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/361025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31175 0039d316-1c4b-4281-b951-d872f2087c98
* Fourth patch in making destructors of refcounted objects private.jam@chromium.org2009-11-051-0/+3
| | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/360043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31167 0039d316-1c4b-4281-b951-d872f2087c98
* Show only one app menu. Cole pointed out that ChromeOS currently has two ↵oshima@chromium.org2009-11-053-15/+40
| | | | | | | | | | | | | almost identical app menu. This CL will toggle app menu depending on the status of toolbar. - This is only for toolkit views build as gtk version does not toggle toolbar. - The menu contnets are not fully sync'ed. We need some refactoring, when we fully migrate to views. Review URL: http://codereview.chromium.org/366010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31061 0039d316-1c4b-4281-b951-d872f2087c98
* Enable ExternalProtocolDialog for Chromeos.oshima@chromium.org2009-10-302-0/+156
| | | | | | | | | | | | * It simply says it's not supported as ChromeOS wont launch external program. Fixed resource files to use chromeos. Apparently I misunderstood how this works when I added 'toolkit_views' to grd files. It was never defined, and wasn't necessary. BUG=23853 TEST=type in "apple.cm" in the omnibox and it should popup the external protocol dialog. Review URL: http://codereview.chromium.org/342040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30593 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux view build breakage.chocobo@google.com2009-10-301-10/+10
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30544 0039d316-1c4b-4281-b951-d872f2087c98
* Move chromeos code to namespace chromeos.chocobo@google.com2009-10-3043-162/+324
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/341044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30541 0039d316-1c4b-4281-b951-d872f2087c98
* CompactLocationBar 1st step:oshima@chromium.org2009-10-283-1/+425
| | | | | | | | | | | | | | | | | | | | | * Added OnMouseXXXTab methods to BrowserExtender to handle on tabs. * Changed tab to call above methods. * Added GetSelectedTab to TabStrip Minor changes along with the major changes above * Removed unnecessary file entries in chrome.gyp * Fixed a few method's const. * Removed unnecessary class declarations and includes. Know issue: keyboard focus is not working. In 2nd step, I'm going to eliminate popup and use whatever that FindBar is using to show compact location bar. I'll fix the issue above after this migration. (if it still persists) BUG=None Test=None Review URL: http://codereview.chromium.org/341008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30386 0039d316-1c4b-4281-b951-d872f2087c98
* New wifi icons animation.chocobo@google.com2009-10-287-51/+315
| | | | | | | | BUG=none TEST=25538 Review URL: http://codereview.chromium.org/315008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30318 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile failures in Chrome OS and Views builds.jam@chromium.org2009-10-271-5/+3
| | | | | | | | TBR=darin BUG=25354 Review URL: http://codereview.chromium.org/329033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30164 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify threading in browser thread by making only ChromeThread deal with ↵jam@chromium.org2009-10-272-9/+8
| | | | | | | | different thread lifetimes.The rest of the code doesn't get MessageLoop pointers since they're not thread-safe and instead just call PostTask on ChromeThread. If the target thread is not alive, then the task is simply deleted.In a followup change, I'll remove any remaining MessageLoop* caching. With this change, there's little to be gained by caching since no locks are involved if the target MessageLoop is guaranteed to outlive the current thread (inferred automatically by the order of the chrome_threads_ array).BUG=25354 Review URL: http://codereview.chromium.org/306032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30163 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 11:47:32 +0000