| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
screen is unlocked.
BUG=none
TEST=(with new screen locker on L13) Login from new user login. Notice that camera light is on. Lock the screen with Ctrl-Alt-L. Notice that camera light is off. Unlock the screen. Notice that camera light is on and video is shown.
Review URL: http://codereview.chromium.org/2847019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was caused by X drawing white background on resume.
Chagned to not to draw any background.
Two small changes:
Made signout button focusable.
Fix a bug that TryGrabAllInput was not checking mouse grab.
BUG=chromium-os:4132
TEST=none
Review URL: http://codereview.chromium.org/2841011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=46666
TEST=none
Review URL: http://codereview.chromium.org/2830012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Don't ask twice for secure network credentials if connection is not yet in "connecting" state by the time "Continue" is pressed
BUG= http://crosbug.com/3999
TEST=Manually. Select secure network, enter credentials and hit "Continue" immediately.
Review URL: http://codereview.chromium.org/2871012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Design doc: https://docs.google.com/a/google.com/Doc?docid=0ATICCjR-gNReY2djdjkyNnNfNzl4ZnpiODQ2Mg&hl=en
BUG=40745
BUG=36728
BUG=36222
TEST=New test added to focus_manager_unittest.cc
Review URL: http://codereview.chromium.org/2737010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=cros:2318
TEST=Get to image login screen. Verify that over user's image there's a
tooltip that shows user's email address.
Review URL: http://codereview.chromium.org/2871010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Moved all functions in language_menu_l10n_util.h to the new file.
- Moved static methods in language_library.h and language_config_model.h to the file.
BUG=none
TEST=try bot passed
Review URL: http://codereview.chromium.org/2810008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crosbug.com/4136
TEST=none
Review URL: http://codereview.chromium.org/2820013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Part 1: Convert RegisterStringPref.
BUG=none
TEST=compile
Review URL: http://codereview.chromium.org/2809022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Also fix Google-A wifi auto-reconnect to also try Google if Google-A is not available or not setup to auto-connect.
BUG=chromium-os:3054
TEST=manual test. when you change auto-connect setting, make sure that it's set properly when you immediately open the network options dialog again.
Review URL: http://codereview.chromium.org/2853001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
accelerator was not removed when it's closed by escape accelerator. This was causing crash in screen locker.
Use "Resume" text for unlock button.
Removed unnecessary TextButton dependency in screen_lock_view.h
BUG=none
TEST=lock screen using ctrl-alt-l, type wrong password and enter then hit escape twice.
It will not crash.
Review URL: http://codereview.chromium.org/2872004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove menu, accelerator and tests.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2812007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the initial implementation of System page in ChromeOS options.
BUG=chromium-os:
TEST=none yet, work in progress
Review URL: http://codereview.chromium.org/2781005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crosbug.com/4033
TEST=When WiFi was disabled through network status area button it's possible to enable it back.
Review URL: http://codereview.chromium.org/2850012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2809016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tab key doesn't get here since it's handled by focus manager.
BUG=none
TEST=Enter a name without domain in username field on login screen. Remove
focus from the field (i.e. by hitting Tab). @gmail.com should be appended.
Review URL: http://codereview.chromium.org/2829005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LanguageLibrary is a misnomer. This is actually an input method library.
Will change the file name in the next change list.
Methodology of refactoring:
1. perl -i -pe 's/LanguageLibrary/InputMethodLibrary/g' **/*.cc **/*.h
2. manually fix the lines that became longer than 80 chars.
3. grep 'language_lib' **/*.{cc,h} |grep -v '#include'
4. manually fix the variable names.
BUG=chromium-os:4063
TEST=manually
Review URL: http://codereview.chromium.org/2868009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
No change in the logic. Just move the code around.
- Add language_config_model.cc, .h, _test.cc
- Sort function definitions and declarations so the order match in .cc and .h files.
Search for OCD in http://www.chromium.org/developers/coding-style
TEST=manually
BUG=chromium-os:4063
Review URL: http://codereview.chromium.org/2856005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Created new UserView that shows the user's photo.
* Moved common constants to helper.h with login namespace to avoid
conflict.
BUG=none
TEST=none. CL does not change the behavior. All tests should still pass.
Review URL: http://codereview.chromium.org/2831007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=crosbug.com/525
TEST=none
Review URL: http://codereview.chromium.org/2790012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor ImageDownloader/ImageDecoder into a separate classes.
Resources submitted in http://codereview.chromium.org/2856003
BUG= http://crosbug.com/3486
TEST=Select "New User" screen, enter new account for this device. Enter incorrect password 3 times. After captcha is presented and entered login should succeed.
Review URL: http://codereview.chromium.org/2729020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Run browser_tests --gtest_filter=WizardControllerFlowTest\.Accelerators
Review URL: http://codereview.chromium.org/2862006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
startup customization manifest.
BUG=http://crosbug.com/3176
TEST=Run out/Debug/chrome --login-manager --startup-manifest=chrome/browser/chromeos/testdata/startup_manifest.json. Welcome message should be in Italian.
Review URL: http://codereview.chromium.org/2853006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Follow up CL to http://codereview.chromium.org/2820006
BUG=chromium-os:323
TEST=unit tests, and loading up a chromium os device and logging in
Review URL: http://codereview.chromium.org/2851006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move non-View portions of code into LanguageConfigModel.
The patch just moves code around (i.e. no change in the logic)
To minimize the amount of diffs, functions are not moved.
We'll do more cleanup in the upcoming changes.
TEST=manually
BUG=chromium-os:4063
Review URL: http://codereview.chromium.org/2868001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
RunnableMethods easier.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2830006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=built chrome locally, ran with chromeos-wm.
BUG=none
Review URL: http://codereview.chromium.org/2716011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We used to read the system salt from a file on disk, which meant that
we had to do a bunch of dancing to do some work during login on the
FILE thread instead of the UI thread. Now, we no longer have to,
because there is an API to request the system's salt value from
cryptohomed over dbus. This CL is a precursor to some of the other
login/cryptohome changes that are coming.
BUG=chromium-os:323
TEST=unit tests, and loading up a chromium os device and logging in
Review URL: http://codereview.chromium.org/2820006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(and the valgrind errors below.)
BUG=chromium-os:46560
BUG=chromium-os:46558
TEST=manually
Review URL: http://codereview.chromium.org/2869001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2804003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Call SetKeyboardLayoutPerWindow(false) in LanguageMenuButton::LanguageMenuButton().
- Mock Keyboard APIs so LanguageMenuButton::LanguageMenuButton() can call the function even in browser_tests.
In browser_tests, code like "if (CrosLibrary::Get()->EnsureLoaded()) SetKeyboardLayoutPerWindow(false);" does not work since the EnsureLoaded() function is replaced so it always returns true without loading libcros.so (i.e. the function pointer |SetKeyboardLayoutPerWindow| is NULL). We could fix this by either of the following:
1) Add NULL check: if (CrosLibrary::Get()->EnsureLoaded() && (SetKeyboardLayoutPerWindow != NULL)) SetKeyboardLayoutPerWindow(false);
2) Mock keyboard APIs and just call: CrosLibrary::Get()->GetKeyboardLibrary()->SetKeyboardLayoutPerWindow(false);
I'd choose 2), since 1) looks a bit error-prone and inconsistent with other libcros libraries (e.g. power, language, ...)
FYI, we can use the new cros/keyboard_library.h interface to implement the "swap ctrl/caps" feature in a clean way.
BUG=chromium-os:2433
TEST=manually
Review URL: http://codereview.chromium.org/2781006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2825002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
directionality of the content is specified already inside the HTML.
BUG=46170
TEST=create a notification while using an RTL language for Chrome UI.
Review URL: http://codereview.chromium.org/2794001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2722011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allow chrome logging to pivot inside the users encrypted home dir on
chrome os, post-login. We also set the inital logs up to be
timestamped, so that we don't lose them when crashes happen.
BUG=None
TEST=Enable chrome logging on chrome os, log in, and check for chrome logs in /home/chronos/user
Review URL: http://codereview.chromium.org/2723007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
m17n:t:latn-pre, and m17n:t:latn-post.
BUG=chromium-os:4001
TEST=manually
Review URL: http://codereview.chromium.org/2771013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
if more than one keyboard are active.
BUG=chromium-os:3936
TEST=manual
Review URL: http://codereview.chromium.org/2787008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:4021
TEST=manual + browser_tests
Review URL: http://codereview.chromium.org/2717009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- LanguageConfigView_Open (the "Languages and input dialog" is opened)
- LanguageMenuButton_Open (input language menu is opened)
- LanguageMenuButton_InputMethodChanged (input method is changed)
These are very basic actions. We'll add more.
TEST=manually
BUG=chromium-os:2637
Review URL: http://codereview.chromium.org/2730013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem was caused by the candidate window became being too wide.
Limit the width fixes the problem.
TEST=manually
BUG=chromium-os:4018
Review URL: http://codereview.chromium.org/2716008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2737008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Timeout increased to 30s.
- Correctly handle when network was previously in a failed state
- Also handle if identity/cert was cleared out and waits for the fields to be set by the enterprise daemon.
BUG=chromium-os:3262
TEST=manual testing
Review URL: http://codereview.chromium.org/2746009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Improve gtk_util::ShowDialog to respect dialog size and resizable trait;
- Make TaskManagerGtk remember correct geometry info;
- Use gtk_util::PresentWindow instead of gek_window_present;
BUG=chromium-os:3967
TEST=Verify fix for chromium-os:3967
Review URL: http://codereview.chromium.org/2776005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Send Notification when screen lock state is changed.
BUG=chromium-os:3950, chromium-os:3675
TEST=manual: login to bwsi mode and hit ctrl-alt-l. unlock by moving mouse or type any key.
Review URL: http://codereview.chromium.org/2735008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
XKB keyboard layout.
For instance, if English USA keyboard layout is the only input method enabled,
we don't show the input language menu on the right upper corner.
On the other hand, if Japanese input method is the only input method enabled,
we still show the input language menu so users can change the intra input method
modes, like Hiragana and Katakana modes.
Note that this is a retry of r49375 that was reverted in r49393
http://src.chromium.org/viewvc/chrome?view=rev&revision=49375
http://src.chromium.org/viewvc/chrome?view=rev&revision=49393
The new fix is in chrome/browser/chromeos/login/login_browsertest.cc
- .WillRepeatedly(Return(CreateFallbackInputMethodDescriptors()));
+ .WillRepeatedly(
+ InvokeWithoutArgs(CreateFallbackInputMethodDescriptors));
BUG=chromium-os:2275
TEST=manually on the netbook; try bots
Review URL: http://codereview.chromium.org/2787007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This does the basic surgery on all three OSes without trying to fix up the visual appearance. As a result, things look pretty ugly. My intent is to at least put endcaps on the omnibox in a subsequent patch.
BUG=45745,45762,45763
TEST=Reload and stop should be combined; go should be gone.
Review URL: http://codereview.chromium.org/2677003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jcivelli
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2754010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=46274
TEST=CrOS linux bot greener
TBR=jcivelli
Review URL: http://codereview.chromium.org/2771012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
which broke build because of a missing deps
Original Issue:
http://codereview.chromium.org/2510001/show
Review URL: http://codereview.chromium.org/2769005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=gmerged on netbook, logged in/out, rebooted, inspected about:histograms
Review URL: http://codereview.chromium.org/2711009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49397 0039d316-1c4b-4281-b951-d872f2087c98
|