| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:1883
TEST=Unit tests
Review URL: http://codereview.chromium.org/1911001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a NativeDialogWindow as container for native dialog contents;
- Host native option dialogs in NativeDialogWindow;
BUG=<http://crosbug.com/1885>
TEST=Verify sub dialogs from options dialog have a frame and no longer full screen.
Review URL: http://codereview.chromium.org/1702018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:2793, chromium-os:2980
TEST=None
When we went to login images we lost the version on the main screen.
This change moves it to the background so all wizard panels will show it.
Also we currently show the time it took to boot the system. We may change
this later but it's useful for now to keep us aware of regressions.
In addition, any issues with loading libcros are displayed here as well.
Review URL: http://codereview.chromium.org/1827001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
connection is not ready yet.
This trick is necessary since chrome for the login screen calls SetImeConfig() before ibus-daemon starts. This is the first step to fix crosbug.com/2670.
BUG=crosbug.com/2670
TEST=manual
Review URL: http://codereview.chromium.org/1758014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Use translated English strings rather than transliterated Korean strings.
* Drop "3-set 2-set" keyboard support since it's not widely used.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/1718018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crosbug.com/2940
TEST=new test NotificationTest.TestActivateDeactivate is added to cover this.
Review URL: http://codereview.chromium.org/1824001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromiumos:2981
TEST=manually tested both functionality in the UI.
Review URL: http://codereview.chromium.org/1723022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is because the gtk-based options page is based on NativeViewHost
which does not provide CanClose function. The fix bypasses the check of
CanClose for gtk-base options pages since this seems not supported.
The crash does not happen now because OptionsWindowView does not set
accept_ flag and thus CanClose is not called. However, we might want to
patch this just in case.
BUG=none
TEST=Verify Chrome does not crash on ChromeOs when user presses "ESC" on gtk-based options page.
Review URL: http://codereview.chromium.org/1825001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Fixed crashing bug and ethernet not updating bug.
BUG=chromiumos:2896,2939,2996
TEST=manual, in network options dialog, the new auto-connect checkbox should now control whether or not we automatically connect to this network.
Review URL: http://codereview.chromium.org/1755013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Code is untested. From gChat:
me: do you have a good test I can use to make sure mac impl of
ui_controls for sending events works OK? Or would you prefer I send
you CLs to play with and we iterate by hand?
Joe: I would like the CL to play with to see if I can get it to work
with the code I wrote
Warning to Joe: mouse moved events currently use the Mac coordinate
frame (0,0 is bottom-left not top-left). That's easy to switch; I'd
like to do whatever is easiest to get WebDriver working.
BUG=26102
Review URL: http://codereview.chromium.org/1701006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We currently have two copies of these enums, one in Chrome
and one in Chrome OS. I'm switching us to have a single
copy in the libcros repo.
This reverts r45955, which reverted r45952. I've added
third_party/cros to the browser directory's DEPS file to fix
the checkdeps.py failure.
http://codereview.chromium.org/1811002/show contains the
review of the original change.
BUG=none
TEST=built it and ran checkdeps.py manually
Review URL: http://codereview.chromium.org/1705017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1692017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1730001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We currently have two copies of these enums, one in Chrome
and one in Chrome OS. I'm switching us to have a single
copy in the libcros repo.
BUG=none
TEST=built it
Review URL: http://codereview.chromium.org/1811002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crosbug.com/2743
TEST=none
Review URL: http://codereview.chromium.org/1711017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We're releasing panel controller but never deleted.
Handle edge case where a renderer requests resize after the panel is closed.
BUG=none
TEST=added new test case TestCloseOpen to verify it.
Review URL: http://codereview.chromium.org/1687011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The patch contributed by chaitanya@chromium.org
Original review URL: http://codereview.chromium.org/1775006
Review URL: http://codereview.chromium.org/1774013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
signin
The test for whether the login form reappeared on the next page load now ignores invisible forms.
BUG=28911
TEST=none (manual testing with reduced web pages)
Review URL: http://codereview.chromium.org/1656005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
of all currently open tabs in all browsers.
This is needed for overview mode on ChromeOS.
BUG=http://code.google.com/p/chromium-os/issues/detail?id=1170
TEST=Ran Chrome under ChromeOS with updated window manager.
Review URL: http://codereview.chromium.org/661237
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Native gtk options pages rely on host to call gtk_widget_show_all. Doing
this after options dialog's size allocated. This is because the
WrapLabelAtAllocationHack trick in ContentPageGtk needs container's size
allocated when the label is being shown.
BUG=<http://crosbug.com/2859>
TEST=Verify fix for ChromeOS issue 2859 and in sync status message in "Peronal Stuff" tab is wrapped correctly.
Review URL: http://codereview.chromium.org/1773006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=crosbug.com/491
BUG=crosbug.com/2623
TEST=manual
Review URL: http://codereview.chromium.org/1694017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
screen.
Block buttons/keyboard on login window when sign in is in process.
BUG= http://crosbug.com/2573, http://crosbug.com/2528
TEST=Run through OOBE screens and observe spinner when network response is more than 0.5 seconds.
Review URL: http://codereview.chromium.org/1755006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1723014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37068
TEST=Boot so that any wizard is shown. Verify that Ctrl-Alt-{n, u, l, a} switch to network, update, login and account screens correspondingly.
Review URL: http://codereview.chromium.org/1696011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
own accessibile name. (In other words, I forgot to do this in r43558.)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1751018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Omnibox, toolbar, tab animations, and other UI changes for purposes of
testing and merging into mstone-5.
Additionally reverts these CLs to fix the earlier revert:
r45271: [Mac] Image references missing from Omnibox revert.
r45268: GTK fix merge failure in uber-revert.
Additional revert which fixed a bug for the branch:
r45381: [Mac] Omnibox popup icons and text lined up under toolbar.
Slight merge conflict which should be good:
r45322: GTK: Implement OnDragCanceled() for autocomplete...
Also ++kThemePackVersion and regenerate the cached theme pak.
Re-instated changes:
r45213: GTK: Override cursor colors in chrome-theme mode.
r45103: Support drawing nano tabs in the tabstrip.
r45084: GTK: Position the EV certificate stuff inside a green bubble.
r44979: Subclassing the InfoBubble to handle anchoring bubbles basedon...
r44957: GTK: Tint the geolocation icons in gtk mode.
r44943: Changes FormatURL to not strip http if the host starts with ft...
r44930: Remove an icon that is no longer used.
r44929: SSL UI changes, Windows, code side (images are separate).
r44859: SSL UI changes (icons). TBRed since trybots hate binary patches.
r44822: GTK: Select better greens in the native omnibox popup.
r44814: GTK: navigate to URL on PRIMARY when middle-clicking the locat...
r44789: [Mac] Bookmark star missing on NTP and BMM.
r44775: [Mac] Centralize hack to make tests work with AutocompleteClas...
r44678: Display the SECURITY_WARNING status in the location bar for the
r44648: [Mac] Add an arrow cursor rect for the location image.
r44615: Revert r44611 because it may have broken "unit_tests" on "Vist...
r44611: Display the SECURITY_WARNING status in the location bar for the
r44577: Revert 44572 - [Mac] Update locationbar icon as user types.
r44572: [Mac] Update location-bar icon as user types.
r44555: GTK: Use correct button mask on reload button.
r44545: [Mac] Omnibox text drag drag URL when select-all.
r44523: GTK: Prevent inappropriate drag of location bar location icon.
r44519: GTK: make the primary selection include the url's scheme when ...
r44492: [Mac] Fix search icon in keyword search to be right-side-up.
r44415: GTK: Update top padding on icons in the autocomplete popup.
r44401: GTK: Tint omnibox icons in GTK mode differently.
r44380: GTK: Move reload in gtk mode and fix omnibox popup location.
r44282: Fixes crash in autocomplete when typing some URLs. The problem
r44273: [Mac] PDF icons for omnibox nits.
r44269: Fix build break due to bad merge resolve
r44268: Shift omnibox dropdown in and up on Windows, and square off th...
r44178: GTK: fix TTS padding.
r44177: Round the top left and right edges of the toolbar.
r44171: Images only checkin for try server goodness.
r44163: GTK: fix padding of autocomplete popup.
r44152: [Mac] PDF icons for omnibox.
r44145: GTK: Theme the icons in the location bar and use GTK colors fo...
r44140: Strips http from the omnibox
r44131: Fixes bugs in new tab strip animations where they weren't doin...
r44116: Change the default theme colors.
r44117: Add newline to EOF to fix CrOS builder.
r44115: Make the bottom edges of the opaque frame rounded.
r44091: [Mac] No star icon or page actions in omnibox on popups.
r44087: Don't allow drag or click on location icon when editing in omn...
r44021: [GTK] Add TTS lens graphic to linux TTS box.
r44008: [Mac] Tweak location icon spacing in omnibox.
r43977: GTK: don't show the star or page actions in ShouldOnlyShowLoca...
r43972: Make the firstrun bubble point at a better spot now that the l...
r43971: [Mac] Location icon in omnibox as drag source.
r43970: Make the star and page action icons not appear on popup windows.
r43954: Fixes bug in TabStrip where dragging tab out then back in rapidly
r43864: Tweaks to BoundsAnimator/SlideAnimation and TabStrip:
r43787: Allow location icon to be dragged & dropped. This also fixes ...
r43759: Changes end cap of tab-to-search images.
r43740: Change bookmark bar toggle to ctrl-shift-b.
r43723: Show Page Info dialog on mouse up, not mouse down.
r43677: Fix Mac build failure.
r43676: Replace omnibox icons with new set that are all the same size ...
r43596: Fix browser test TestStarButtonAccObj.
r43593: Disables TestStarButtonAccObj.
r43582: Changes tab strip to use BoundsAnimator for tab strip animatio...
r43563: GTK: don't show reload button for popup/app windows.
r43562: Star/reload shuffle, Windows version.
r43540: [Mac] Magnifying glass in keyword-search bubble.
r43482: Adds images needed for new tab animation. I'm separating this ...
r43422: Add reload mask resource.
r43392: GTK: make the location icon a drag source.
r43376: [Mac] Move star button into page-actions area of omnibox.
r43357: [Mac] Line up omnibox popup under field.
r43290: gtk: fix display of icons in omnibox popup
r43269: GTK: fix reload button.
r43249: [Mac] Rearrange SSL status icon/label in omnibox.
r43248: BrowserThemePack: Adds persistant ids for the reload endcaps.
r43241: GTK: more location bar updates.
r43191: Fix memory leak in BrowserThemePack.
r43154: GTK: set the new star button's ID
r43151: Fix bad conflict resolution for r43146.
r43146: GTK: toolbar reload/star shuffle.
r43025: Show the location bar icon (almost) all the time, and have its...
r43023: Add new images for new reload button. No code change.
r42782: Remove this icon, now that it's no longer used (due to my secu...
r42502: Omnibox M5 work, part 1: Security changes
r42245: Check in new icons for omnibox security changes alone, so that...
BUG=none
TEST=People go back to complaining about missing http://.
R=pkasting@chromium.org,beng@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adjust margin and fixed horizontal alignment.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1687009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
/etc/gtk-2.0/gtkrc. This CL fixes explicitly set fonts to use predefined
fonts from ResourceBundle.
BUG=crosbug.com/2795
TEST=See font size of login and welcome screens.
Review URL: http://codereview.chromium.org/1748008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Users could already be typing in the omnibox before the load commits (e.g. due to a slow renderer process startup) and this typing would then be selected and overwritten.
BUG=41466
TEST=On a very slow machine, typing before a new tab finishes loading should not be selected or cleared once the tab finishes loading.
Review URL: http://codereview.chromium.org/1738004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed the layout of buttons on notification.
This fits nicer because a notification can be shorter and menu requires more hight.
Enable double buffer where necessary to avoid flicker.
Fixed a condition to close ControlViewHost.
It should be closed when renderer is deleted.
Fixed notification_browsertest so that it passes on chromeos device.
Note: changes to native_view_host_gtk and widget_gtk are being done separately in
http://codereview.chromium.org/1725005
so you do not need to review them. I won't check this in unless that one is approved.
BUG=23445,33306
TEST=no functional change. all tests must still pass.
Review URL: http://codereview.chromium.org/1754003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1700006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromiumos:2212
TEST=LoginProfileTest.UserPassed
Review URL: http://codereview.chromium.org/1714005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I had to do two changes to existing tests to get these to work:
. Wizard tests wait until all the wizard related classes have been destroyed. At the time the tests want to quit the wizard classes haven't been shut down, so I needed to add an event to know when this happens. See comment as to why this is the case.
. PanelBrowserTests were flakey because they were waiting for page to load, which can happen before javascript finishes completing.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1735001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We don't have to update input method descriptors since they are not related to locales.
BUG=none
TEST=ran browser_tests.
Review URL: http://codereview.chromium.org/1723008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We used to use a magic number 30 to do the aligning but
with this change, we'll compute the horizontal offset at run time.
This is much cleaner, and more precise.
TEST=manually
BUG=crosbug.com/2720
Review URL: http://codereview.chromium.org/1711007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Moving all input method related constants from preferences.cc to language_preferences.h.
This change is necessary to implement a configuration dialog for Pinyin input method.
BUG=crosbug.com/488
TEST=ran browser_tests
Review URL: http://codereview.chromium.org/1631030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
UI changes for purposes of testing and merging into mstone-5.
Also ++kThemePackVersion and regenerate the cached theme pak.
Reverted changes:
r45213: GTK: Override cursor colors in chrome-theme mode.
r45103: Support drawing nano tabs in the tabstrip.
r45084: GTK: Position the EV certificate stuff inside a green bubble.
r44979: Subclassing the InfoBubble to handle anchoring bubbles basedon...
r44957: GTK: Tint the geolocation icons in gtk mode.
r44943: Changes FormatURL to not strip http if the host starts with ft...
r44930: Remove an icon that is no longer used.
r44929: SSL UI changes, Windows, code side (images are separate).
r44859: SSL UI changes (icons). TBRed since trybots hate binary patches.
r44822: GTK: Select better greens in the native omnibox popup.
r44814: GTK: navigate to URL on PRIMARY when middle-clicking the locat...
r44789: [Mac] Bookmark star missing on NTP and BMM.
r44775: [Mac] Centralize hack to make tests work with AutocompleteClas...
r44678: Display the SECURITY_WARNING status in the location bar for the
r44648: [Mac] Add an arrow cursor rect for the location image.
r44615: Revert r44611 because it may have broken "unit_tests" on "Vist...
r44611: Display the SECURITY_WARNING status in the location bar for the
r44577: Revert 44572 - [Mac] Update locationbar icon as user types.
r44572: [Mac] Update location-bar icon as user types.
r44555: GTK: Use correct button mask on reload button.
r44545: [Mac] Omnibox text drag drag URL when select-all.
r44523: GTK: Prevent inappropriate drag of location bar location icon.
r44519: GTK: make the primary selection include the url's scheme when ...
r44492: [Mac] Fix search icon in keyword search to be right-side-up.
r44415: GTK: Update top padding on icons in the autocomplete popup.
r44401: GTK: Tint omnibox icons in GTK mode differently.
r44380: GTK: Move reload in gtk mode and fix omnibox popup location.
r44282: Fixes crash in autocomplete when typing some URLs. The problem
r44273: [Mac] PDF icons for omnibox nits.
r44269: Fix build break due to bad merge resolve
r44268: Shift omnibox dropdown in and up on Windows, and square off th...
r44178: GTK: fix TTS padding.
r44177: Round the top left and right edges of the toolbar.
r44171: Images only checkin for try server goodness.
r44163: GTK: fix padding of autocomplete popup.
r44152: [Mac] PDF icons for omnibox.
r44145: GTK: Theme the icons in the location bar and use GTK colors fo...
r44140: Strips http from the omnibox
r44131: Fixes bugs in new tab strip animations where they weren't doin...
r44116: Change the default theme colors.
r44117: Add newline to EOF to fix CrOS builder.
r44115: Make the bottom edges of the opaque frame rounded.
r44091: [Mac] No star icon or page actions in omnibox on popups.
r44087: Don't allow drag or click on location icon when editing in omn...
r44021: [GTK] Add TTS lens graphic to linux TTS box.
r44008: [Mac] Tweak location icon spacing in omnibox.
r43977: GTK: don't show the star or page actions in ShouldOnlyShowLoca...
r43972: Make the firstrun bubble point at a better spot now that the l...
r43971: [Mac] Location icon in omnibox as drag source.
r43970: Make the star and page action icons not appear on popup windows.
r43954: Fixes bug in TabStrip where dragging tab out then back in rapidly
r43864: Tweaks to BoundsAnimator/SlideAnimation and TabStrip:
r43787: Allow location icon to be dragged & dropped. This also fixes ...
r43759: Changes end cap of tab-to-search images.
r43740: Change bookmark bar toggle to ctrl-shift-b.
r43723: Show Page Info dialog on mouse up, not mouse down.
r43677: Fix Mac build failure.
r43676: Replace omnibox icons with new set that are all the same size ...
r43596: Fix browser test TestStarButtonAccObj.
r43593: Disables TestStarButtonAccObj.
r43582: Changes tab strip to use BoundsAnimator for tab strip animatio...
r43563: GTK: don't show reload button for popup/app windows.
r43562: Star/reload shuffle, Windows version.
r43540: [Mac] Magnifying glass in keyword-search bubble.
r43482: Adds images needed for new tab animation. I'm separating this ...
r43422: Add reload mask resource.
r43392: GTK: make the location icon a drag source.
r43376: [Mac] Move star button into page-actions area of omnibox.
r43357: [Mac] Line up omnibox popup under field.
r43290: gtk: fix display of icons in omnibox popup
r43269: GTK: fix reload button.
r43249: [Mac] Rearrange SSL status icon/label in omnibox.
r43248: BrowserThemePack: Adds persistant ids for the reload endcaps.
r43241: GTK: more location bar updates.
r43191: Fix memory leak in BrowserThemePack.
r43154: GTK: set the new star button's ID
r43151: Fix bad conflict resolution for r43146.
r43146: GTK: toolbar reload/star shuffle.
r43025: Show the location bar icon (almost) all the time, and have its...
r43023: Add new images for new reload button. No code change.
r42782: Remove this icon, now that it's no longer used (due to my secu...
r42502: Omnibox M5 work, part 1: Security changes
r42245: Check in new icons for omnibox security changes alone, so that...
BUG=none
TEST=Eyjafjallajokull
R=pkasting@chromium.org,beng@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
When canonicalizing email addresses for login on chromium OS, we want to make sure that we're using a user's canonical gmail addres, so we ignore interstitial '.' characters already. This adds ignoring +-suffixes, ensuring that cmasone@gmail.com == cmasone+cc@gmail.com
Review URL: http://codereview.chromium.org/1765001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=<http://crosbug.com/1885>
TEST=Verify ChromeOS options dialog background if white as in mock http://www.chromium.org/chromium-os/user-experience/settings
Review URL: http://codereview.chromium.org/1725004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed histogram creation and retrieval for dynamic histogram samples.
TEST=none
BUG=none
TBR=semenzato
Review URL: http://codereview.chromium.org/1710006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use last active browser window as options dialogs parent because
window manager only repsect top-level window as parent for now. That is,
we could not use options dialog as its sub dialoags' parent.
BUG=none
TEST=Verify all sub dialogs from options are not treated as toplevel window (ie they do not occupy the fulll screen).
Review URL: http://codereview.chromium.org/1751003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WifiConfigView - support networks with 802.1x authentication by prompting the user to enter an ID, select a certificate/private key file, and enter a password for the key file, if any.
Pass these values down the stack into ConnectToWifiNetwork().
TEST=Compiles and login dialog shows new fields when security is 802.1x.
BUG=none
TBR=njw
Review URL: http://codereview.chromium.org/1692005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
tbr:njw
TEST=Compiles and login dialog shows new fields when security is 802.1x
BUG=none
Review URL: http://codereview.chromium.org/1712003
TBR=chocobo@chromium.org
Review URL: http://codereview.chromium.org/1743002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=chocobo@chromium.org
Review URL: http://codereview.chromium.org/1697005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a chromeos OptionsWindowView that hosts options pages in a ChromeWindow
so that it has a frame; This piece of code is based on Chrome's
OptionsWindowView. Ideally, we should use Chrome's options view but
we still missing underlying controls such as Tree and Table.
- Use last active browser window as options dialog's parent;
This makes optiosn dialog transient for the browser window and window
manager will no longer treat it as top-level window and will not move
and resize it;
- If user switches to a new browser window and invokes options dialog again,
close the existing one and re-opens it for the current browser window.
This is currently supported by window manager;
- Update CustomerFrameView and WindowDelegate to make client edge optionaly;
Options dialog has no client area padding and does not have a client
edge per UI mock;
- Make NativeViewHost respects its background. This solves the problem that
tab pane background is not properly cleared when hosting a native GtkVBox
pane in TabbedPane;
BUG=<http://crosbug.com/1885>
TEST=Verify ChromeOS settings dialog looks like the mocks in http://www.chromium.org/chromium-os/user-experience/settings
Review URL: http://codereview.chromium.org/1672003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
tbr:njw
TEST=Compiles and login dialog shows new fields when security is 802.1x
BUG=none
Review URL: http://codereview.chromium.org/1712003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
pointed to by the filebrowser.
BUG=chromium-os:2547
TEST=NONE
Review URL: http://codereview.chromium.org/1690001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes makes histograms dynamically defined by external metrics
clients,
instead of hardcoding them in Chrome source. This is important because
making even simple changes to Chrome is laborious and takes a fair
amount of
learning. Unfortunately user actions still require code in Chrome,
because
of a pre-processing script that extracts them from the source.
BUG=NONE
TEST=the included unit test
Review URL: http://codereview.chromium.org/1718003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DEPENDS_ON=1648004 (http://codereview.chromium.org/1648004/show)
DEPENDS_ON=1596023 (http://codereview.chromium.org/1596023/show)
DEPENDS_ON=1568033 (http://codereview.chromium.org/1568033/show)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1551029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45172 0039d316-1c4b-4281-b951-d872f2087c98
|