| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
add keyboard acclerators to login wizard
This is to make it possible to put the login wizard into a known state for testing purposes.
Ctrl-Alt-L navigates to the login screen, from there
Atl-U focuses the username field
Alt-P focuses the password field
BUG=none
TEST=none
TBR=zelidrag@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Farina (see http://codereview.chromium.org/1580002 ), r=me.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1528009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- test server to serve account creation page
- deferred creation of login windows to tune account screen for testing
- refactored InProcessBrowserTest to shutdown test reliably.
BUG=39310
TEST=Run browser_tests with --gtest_filter=AccountScreenTest.*
Review URL: http://codereview.chromium.org/1452001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
language is removed.
BUG=crosbug.com/2297
TEST=manually
Review URL: http://codereview.chromium.org/1585002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Along the way, refactor the code by adding SetLanguageActivated(),
This is simpler than having ActivateLanguage() and DeactivateLanguage().
The idea comes from View::SetEnabled(bool enabled).
BUG=crosbug.com/2001
TEST=manually
Review URL: http://codereview.chromium.org/1546002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
changes changed how things get focus, so it's not clear to me what the desired behavior here is. I'll get this worked out tomorrow.
TBR=sky
BUG=none
TEST=Unittests don't fail
Review URL: http://codereview.chromium.org/1587001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1543001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
protocol launch message.
BUG=35168
TEST=None
Review URL: http://codereview.chromium.org/1518003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pressing ESCAPE key.
Accelerator and label are active only in non-official builds.
BUG=39279
TEST=Build Chrome with macro OFFICIAL_BUILD undefined. Run out/Debug/chrome --login-manager --login-screen=update. Label "Press ESCAPE..." should be visible, and pressing escape should cancel the update and proceed to the login screen. Build Chrome with OFFICIAL_BUILD macro defined. Run previous command, label should not be visible and pressing ESCAPE should have no effect.
Review URL: http://codereview.chromium.org/1222007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Refactor CrosInProcessBrowserTest - granular mocks and expectations.
Fix PowerMenuButtonTest.
Review URL: http://codereview.chromium.org/1405001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Found and fixed the following bug in this test. (yay!)
minimize if no sticky / new notification exists after Remove
* Replaced RunAllPending with InProcessBrowserTest::RunAllPendingEvents
BUG=http://crosbug/2027
TEST=two new browser tests and one updated browser test.
Review URL: http://codereview.chromium.org/1357005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Changed to use ui_controls::SendKeyPress instead of its own.
BUG=http://crosbug.com/2028
TEST=two new browser tests for CompactLocationBarHost.
Review URL: http://codereview.chromium.org/1463002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1349005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromiumos:2036
TEST=Run out/Debug/browser_tests --gtest_filter=LoginManagerViewTest.TestBasic
Review URL: http://codereview.chromium.org/1256004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=39404
TEST=none
TBR=avayvod
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
reload the correct tab, not the full browser.
BUG=chromium-os:2057
Review URL: http://codereview.chromium.org/1238006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=power_menu_button_browsertest
Review URL: http://codereview.chromium.org/1338003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=38992
Review URL: http://codereview.chromium.org/1310001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=2039
TEST=out/Debug/browser_tests --gtest_filter=WizardControllerTest.SwitchLanguage
Review URL: http://codereview.chromium.org/1239005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move model and controller logic to NetworkScreen class.
Move Refresh() method out of view to controller.
Make network selection obligatory on OOBE even if Ethernet is connected.
BUG=37070
TEST=Running with --login-manager --login-screen=oobe should initiate normal out of box flow. After selecting network from combobox update is initiated.
Review URL: http://codereview.chromium.org/1058004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=avayvod
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=On Chrome OS login screen edge is sharp and blue.
Review URL: http://codereview.chromium.org/1278002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem was that CommandLine::ForCurrentProcess() was called
despite candidate_window did not parse the command line flags.
StackTrace::StackTrace() [0x45a312]
logging::LogMessage::~LogMessage() [0x40abb7]
CommandLine::ForCurrentProcess() [0x40b3b5]
l10n_util::GetApplicationLocale() [0x4cd3f7]
ResourceBundle::LoadResources() [0x4c935d]
ResourceBundle::InitSharedInstance() [0x4c5ed7]
main [0x402a5f]
0x7ffff2aa6abd
0x4002a9
BUG=crosbug.com/2254
TEST=manually
Review URL: http://codereview.chromium.org/1238008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Run browser_tests with --gtest_filter=AccountScreenTest.*
Review URL: http://codereview.chromium.org/1123008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:1685
TEST=Selecting "Disable Wifi" in networm menu does not crash Chrome
Review URL: http://codereview.chromium.org/1305002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1222003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
properly on ChromeOS.
BUG=None
TEST=Open the app launcher on ChromeOS it should show
entirely without any scrollbar.
Review URL: http://codereview.chromium.org/1297001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Create base class for Chromium OS tests mocking CrosLibrary.
Fix CrosLibrary mocks.
TEST=out/Debug/browser_tests --gtest_filter=NetworkScreenTest*
Review URL: http://codereview.chromium.org/1279002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27570
TEST=none
TBR=estade
Review URL: http://codereview.chromium.org/1302001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Removed duplicated windows closing from OnLoginSignInSelected().
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1267002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Tests if Browser::ToggleCompactNavigationBar() turns on/off
compact navigation bar and tool bar.
* Tests if the accelerator works.
BUG=http://crosbug.com/2028
TEST=new tests CompactNativationBarTest.TestBasic/TestAccelerator should pass.
Review URL: http://codereview.chromium.org/1200001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
causing the library to appear already loaded in a failed state.
Review URL: http://codereview.chromium.org/1251001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
access to all *Libray classes that used to be singletons. This registry adds an indirection layer that will let is replace the actual objects with mocks during test runs.
BUG=chromium-os:2026
TEST=none
Review URL: http://codereview.chromium.org/1142005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
notifications during the port to mac & linux and making behavior more consistent.
BUG=34826
TEST=notifications on each platform.
Review URL: http://codereview.chromium.org/1055005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Check that the app launcher is displayed correctly on ChromeOS
and Windows (when using the --app-launcher-new-tab)
Review URL: http://codereview.chromium.org/1171002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1130008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
That way it is easier to keep track of those constants in reporting tools.
TEST=Covered with standard ui tests
Patch by Frank Mantek <fmantek@google.com>.
Review URL: http://codereview.chromium.org/811005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1132006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Replaced "closed_by_user, update_pane_on_leave_" flags with KEEP_SIZE state. The panel moves to this state when a user interacts with the panel. It keeps its size unless a notification is added, or removed, or it has more space than neccessary when mouse leaves the panel.
* Fixed the crash when the preferred size is calculated to zero (can happen depending on timing) by adding minimum size.
* fixed wrong return type (bool -> int)
* GetNewBounds was using the panel's bounds instead of notification's bounds.
* Refactored and clean up in tests..
BUG=33306
TEST=added two more browser tests for state transition.
Review URL: http://codereview.chromium.org/1164004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
so the app launcher shows when you open a new tab.
Also removing the graying-out of the browser when the app launcher is showng for now, as
it is not clear how to make it cross-platform.
BUG=None
TEST=Start Chrome with --app-launcher-new-tab. Opening a new tab
should bring the app launcher (still a prototype at this point).
Review URL: http://codereview.chromium.org/1145001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it would always run with the Default profile. This meant that two
different users could see the same data...a big problem.
We patched in the OS by deleting the profile directory each time
but this is the right fix.
When the session_manager reruns Chrome on a crash it will now
pass a new flag (--login-user). Chrome uses this and ensures that
the profile dir (specified by --login-profile) is mounted as an
encrypted drive. If this flag isn't specified then Chrome uses the
Default profile, but in incognito mode so no data is written.
BUG=chromiumos:1967
TEST=Login to chromeos as user1, in a terminal kill the browser process, chrome relaunches, log into gmail, sign out (using menu or power button). Login as user2, kill browser process, chrome relaunches, go to gmail. Ensure that user1 isn't logged in.
Review URL: http://codereview.chromium.org/1094009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1073005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the panel)
so that a user can delete multiple notification by clicking mouse on the same position.
BUG=33306
TEST=none. I will add tests next week.
Review URL: http://codereview.chromium.org/1147003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=521
TEST=none
Review URL: http://codereview.chromium.org/1079007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=open login dialog, type in password, and click on the lock image to toggle showing password.
Review URL: http://codereview.chromium.org/1113004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Functionality protected behind --in-chrome-auth flag.
TEST=unittests, also run on Chromium OS with --in-chrome-auth flag. Log in should work.
Review URL: http://codereview.chromium.org/1026001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Pass browser to ctor as AppLauncher is created per browser instance.
BUG=chromium-os:1795
TEST=none
Review URL: http://codereview.chromium.org/1085006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Allows widget to go transparent even if wm says it isn't
supported. See comment I added as to why I'm allowing it.
. Makes font bold.
. Sets property on window so window manager knows chrome has
painted. This avoids the gray flash.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1149001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=37985
TEST=no functional change.
Review URL: http://codereview.chromium.org/1060001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=35248
TEST=Switch the language used by the ChromiumOS using the top left corner menu of the Network selection wizard.
Or you may use the following command on desktop using Chromium (built with GYP_DEFINES="chromeos=1"):
out/Debug/chrome --login-manager --login-screen=network
Review URL: http://codereview.chromium.org/1107003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42092 0039d316-1c4b-4281-b951-d872f2087c98
|