summaryrefslogtreecommitdiffstats
path: root/chrome/browser/cocoa/autocomplete_text_field_cell.h
Commit message (Collapse)AuthorAgeFilesLines
* Re-instate the temporary revert from r45267. That reverted certainshess@chromium.org2010-04-231-21/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Omnibox, toolbar, tab animations, and other UI changes for purposes of testing and merging into mstone-5. Additionally reverts these CLs to fix the earlier revert: r45271: [Mac] Image references missing from Omnibox revert. r45268: GTK fix merge failure in uber-revert. Additional revert which fixed a bug for the branch: r45381: [Mac] Omnibox popup icons and text lined up under toolbar. Slight merge conflict which should be good: r45322: GTK: Implement OnDragCanceled() for autocomplete... Also ++kThemePackVersion and regenerate the cached theme pak. Re-instated changes: r45213: GTK: Override cursor colors in chrome-theme mode. r45103: Support drawing nano tabs in the tabstrip. r45084: GTK: Position the EV certificate stuff inside a green bubble. r44979: Subclassing the InfoBubble to handle anchoring bubbles basedon... r44957: GTK: Tint the geolocation icons in gtk mode. r44943: Changes FormatURL to not strip http if the host starts with ft... r44930: Remove an icon that is no longer used. r44929: SSL UI changes, Windows, code side (images are separate). r44859: SSL UI changes (icons). TBRed since trybots hate binary patches. r44822: GTK: Select better greens in the native omnibox popup. r44814: GTK: navigate to URL on PRIMARY when middle-clicking the locat... r44789: [Mac] Bookmark star missing on NTP and BMM. r44775: [Mac] Centralize hack to make tests work with AutocompleteClas... r44678: Display the SECURITY_WARNING status in the location bar for the r44648: [Mac] Add an arrow cursor rect for the location image. r44615: Revert r44611 because it may have broken "unit_tests" on "Vist... r44611: Display the SECURITY_WARNING status in the location bar for the r44577: Revert 44572 - [Mac] Update locationbar icon as user types. r44572: [Mac] Update location-bar icon as user types. r44555: GTK: Use correct button mask on reload button. r44545: [Mac] Omnibox text drag drag URL when select-all. r44523: GTK: Prevent inappropriate drag of location bar location icon. r44519: GTK: make the primary selection include the url's scheme when ... r44492: [Mac] Fix search icon in keyword search to be right-side-up. r44415: GTK: Update top padding on icons in the autocomplete popup. r44401: GTK: Tint omnibox icons in GTK mode differently. r44380: GTK: Move reload in gtk mode and fix omnibox popup location. r44282: Fixes crash in autocomplete when typing some URLs. The problem r44273: [Mac] PDF icons for omnibox nits. r44269: Fix build break due to bad merge resolve r44268: Shift omnibox dropdown in and up on Windows, and square off th... r44178: GTK: fix TTS padding. r44177: Round the top left and right edges of the toolbar. r44171: Images only checkin for try server goodness. r44163: GTK: fix padding of autocomplete popup. r44152: [Mac] PDF icons for omnibox. r44145: GTK: Theme the icons in the location bar and use GTK colors fo... r44140: Strips http from the omnibox r44131: Fixes bugs in new tab strip animations where they weren't doin... r44116: Change the default theme colors. r44117: Add newline to EOF to fix CrOS builder. r44115: Make the bottom edges of the opaque frame rounded. r44091: [Mac] No star icon or page actions in omnibox on popups. r44087: Don't allow drag or click on location icon when editing in omn... r44021: [GTK] Add TTS lens graphic to linux TTS box. r44008: [Mac] Tweak location icon spacing in omnibox. r43977: GTK: don't show the star or page actions in ShouldOnlyShowLoca... r43972: Make the firstrun bubble point at a better spot now that the l... r43971: [Mac] Location icon in omnibox as drag source. r43970: Make the star and page action icons not appear on popup windows. r43954: Fixes bug in TabStrip where dragging tab out then back in rapidly r43864: Tweaks to BoundsAnimator/SlideAnimation and TabStrip: r43787: Allow location icon to be dragged & dropped. This also fixes ... r43759: Changes end cap of tab-to-search images. r43740: Change bookmark bar toggle to ctrl-shift-b. r43723: Show Page Info dialog on mouse up, not mouse down. r43677: Fix Mac build failure. r43676: Replace omnibox icons with new set that are all the same size ... r43596: Fix browser test TestStarButtonAccObj. r43593: Disables TestStarButtonAccObj. r43582: Changes tab strip to use BoundsAnimator for tab strip animatio... r43563: GTK: don't show reload button for popup/app windows. r43562: Star/reload shuffle, Windows version. r43540: [Mac] Magnifying glass in keyword-search bubble. r43482: Adds images needed for new tab animation. I'm separating this ... r43422: Add reload mask resource. r43392: GTK: make the location icon a drag source. r43376: [Mac] Move star button into page-actions area of omnibox. r43357: [Mac] Line up omnibox popup under field. r43290: gtk: fix display of icons in omnibox popup r43269: GTK: fix reload button. r43249: [Mac] Rearrange SSL status icon/label in omnibox. r43248: BrowserThemePack: Adds persistant ids for the reload endcaps. r43241: GTK: more location bar updates. r43191: Fix memory leak in BrowserThemePack. r43154: GTK: set the new star button's ID r43151: Fix bad conflict resolution for r43146. r43146: GTK: toolbar reload/star shuffle. r43025: Show the location bar icon (almost) all the time, and have its... r43023: Add new images for new reload button. No code change. r42782: Remove this icon, now that it's no longer used (due to my secu... r42502: Omnibox M5 work, part 1: Security changes r42245: Check in new icons for omnibox security changes alone, so that... BUG=none TEST=People go back to complaining about missing http://. R=pkasting@chromium.org,beng@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45474 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily revert certain Omnibox, toolbar, tab animations, and othershess@chromium.org2010-04-221-64/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | UI changes for purposes of testing and merging into mstone-5. Also ++kThemePackVersion and regenerate the cached theme pak. Reverted changes: r45213: GTK: Override cursor colors in chrome-theme mode. r45103: Support drawing nano tabs in the tabstrip. r45084: GTK: Position the EV certificate stuff inside a green bubble. r44979: Subclassing the InfoBubble to handle anchoring bubbles basedon... r44957: GTK: Tint the geolocation icons in gtk mode. r44943: Changes FormatURL to not strip http if the host starts with ft... r44930: Remove an icon that is no longer used. r44929: SSL UI changes, Windows, code side (images are separate). r44859: SSL UI changes (icons). TBRed since trybots hate binary patches. r44822: GTK: Select better greens in the native omnibox popup. r44814: GTK: navigate to URL on PRIMARY when middle-clicking the locat... r44789: [Mac] Bookmark star missing on NTP and BMM. r44775: [Mac] Centralize hack to make tests work with AutocompleteClas... r44678: Display the SECURITY_WARNING status in the location bar for the r44648: [Mac] Add an arrow cursor rect for the location image. r44615: Revert r44611 because it may have broken "unit_tests" on "Vist... r44611: Display the SECURITY_WARNING status in the location bar for the r44577: Revert 44572 - [Mac] Update locationbar icon as user types. r44572: [Mac] Update location-bar icon as user types. r44555: GTK: Use correct button mask on reload button. r44545: [Mac] Omnibox text drag drag URL when select-all. r44523: GTK: Prevent inappropriate drag of location bar location icon. r44519: GTK: make the primary selection include the url's scheme when ... r44492: [Mac] Fix search icon in keyword search to be right-side-up. r44415: GTK: Update top padding on icons in the autocomplete popup. r44401: GTK: Tint omnibox icons in GTK mode differently. r44380: GTK: Move reload in gtk mode and fix omnibox popup location. r44282: Fixes crash in autocomplete when typing some URLs. The problem r44273: [Mac] PDF icons for omnibox nits. r44269: Fix build break due to bad merge resolve r44268: Shift omnibox dropdown in and up on Windows, and square off th... r44178: GTK: fix TTS padding. r44177: Round the top left and right edges of the toolbar. r44171: Images only checkin for try server goodness. r44163: GTK: fix padding of autocomplete popup. r44152: [Mac] PDF icons for omnibox. r44145: GTK: Theme the icons in the location bar and use GTK colors fo... r44140: Strips http from the omnibox r44131: Fixes bugs in new tab strip animations where they weren't doin... r44116: Change the default theme colors. r44117: Add newline to EOF to fix CrOS builder. r44115: Make the bottom edges of the opaque frame rounded. r44091: [Mac] No star icon or page actions in omnibox on popups. r44087: Don't allow drag or click on location icon when editing in omn... r44021: [GTK] Add TTS lens graphic to linux TTS box. r44008: [Mac] Tweak location icon spacing in omnibox. r43977: GTK: don't show the star or page actions in ShouldOnlyShowLoca... r43972: Make the firstrun bubble point at a better spot now that the l... r43971: [Mac] Location icon in omnibox as drag source. r43970: Make the star and page action icons not appear on popup windows. r43954: Fixes bug in TabStrip where dragging tab out then back in rapidly r43864: Tweaks to BoundsAnimator/SlideAnimation and TabStrip: r43787: Allow location icon to be dragged & dropped. This also fixes ... r43759: Changes end cap of tab-to-search images. r43740: Change bookmark bar toggle to ctrl-shift-b. r43723: Show Page Info dialog on mouse up, not mouse down. r43677: Fix Mac build failure. r43676: Replace omnibox icons with new set that are all the same size ... r43596: Fix browser test TestStarButtonAccObj. r43593: Disables TestStarButtonAccObj. r43582: Changes tab strip to use BoundsAnimator for tab strip animatio... r43563: GTK: don't show reload button for popup/app windows. r43562: Star/reload shuffle, Windows version. r43540: [Mac] Magnifying glass in keyword-search bubble. r43482: Adds images needed for new tab animation. I'm separating this ... r43422: Add reload mask resource. r43392: GTK: make the location icon a drag source. r43376: [Mac] Move star button into page-actions area of omnibox. r43357: [Mac] Line up omnibox popup under field. r43290: gtk: fix display of icons in omnibox popup r43269: GTK: fix reload button. r43249: [Mac] Rearrange SSL status icon/label in omnibox. r43248: BrowserThemePack: Adds persistant ids for the reload endcaps. r43241: GTK: more location bar updates. r43191: Fix memory leak in BrowserThemePack. r43154: GTK: set the new star button's ID r43151: Fix bad conflict resolution for r43146. r43146: GTK: toolbar reload/star shuffle. r43025: Show the location bar icon (almost) all the time, and have its... r43023: Add new images for new reload button. No code change. r42782: Remove this icon, now that it's no longer used (due to my secu... r42502: Omnibox M5 work, part 1: Security changes r42245: Check in new icons for omnibox security changes alone, so that... BUG=none TEST=Eyjafjallajokull R=pkasting@chromium.org,beng@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45267 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Add an arrow cursor rect for the location image.rohitrao@chromium.org2010-04-151-4/+4
| | | | | | | | BUG=41229 TEST=Mouse over the location image. Should show the arrow cursor, not an ibeam cursor. Review URL: http://codereview.chromium.org/1574028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44648 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Omnibox text drag drag URL when select-all.shess@chromium.org2010-04-141-0/+3
| | | | | | | | | | | | If the entire field is selected, make the drag contents match those which would be dragged from the location icon. BUG=41218 TEST=Browser to www.google.com. Select-all, drag&drop to bookmarks. Review URL: http://codereview.chromium.org/1622024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44545 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Move star button into page-actions area of omnibox.shess@chromium.org2010-04-011-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | Removes the star button from the toolbar entirely. Adds a LocationBarImageView subclass for the star icon and wires it to the RHS of the field. Adjust the bookmark bubble to move the arrow to the RHS and position appropriately. BookmarkBubble.xib: outlet to view so that controller can change the arrow from left to right. Toolbar.xib: Move reload icon to where star was, remove star icon, adjust spacing. All spacing was adjusted to specific positions in the relevant inspector, not by mouse drag, so hopefully there's nothing awry there. BUG=37865 TEST=No star icon on toolbar. TEST=Optional home button adjustments should work right. TEST=Star action in omnibox when showing an URL. TEST=Star action can be clicked to bookmark current page. TEST=Bookmark bubble arrow points at star like before. TEST=Command-d brings up bookmark bubble. TEST=Star action changes from blank to yellow depending on state. TEST=Star action tooltip changes depending on state. Review URL: http://codereview.chromium.org/1540009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43376 0039d316-1c4b-4281-b951-d872f2087c98
* Enable inspection of extension popupsfeldstein@chromium.org2010-04-011-0/+5
| | | | | | | | | | | | | When developer mode is enabled from the extensions page, you can right click on browser actions or page actions to inspect the popup. It will stay open until you close the Inspector (or open another popup, or close the main window, etc). BUG=24477 TEST=Inspect the popup Review URL: http://codereview.chromium.org/1606001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43363 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Rearrange SSL status icon/label in omnibox.shess@chromium.org2010-03-311-17/+49
| | | | | | | | | | | | | | | Refactor action icons with an eye towards adding additional icons in the future. Renames the SSL status icon to be compatible with pkasting's upcoming changes, and splits it between the icon on the left and the label floating on the right. BUG=37865 TEST=SSL icon should be to the left, and clickable. TEST=SSL label should float to the left of page actions and not be clickable. Review URL: http://codereview.chromium.org/1566004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43249 0039d316-1c4b-4281-b951-d872f2087c98
* Show the location bar icon (almost) all the time, and have its contents ↵pkasting@chromium.org2010-03-301-8/+7
| | | | | | | | | | | | | | | | | | match what the user is doing. There are a couple major moving parts here: * Change AutocompletePopupModel::URLsForCurrentText() to InfoForCurrentText() and have it return an AutocompleteMatch, which callers can use to parse out whatever they want. I needed to get at the match type for the current text and found the proliferation of arguments here ridiculous. This had major ripple effects throughout the codebase, including changing the name and location of SearchVersusNavigateClassifier as it no longer had an "is_search" parameter directly, so the name became misleading and too narrow. I also ended up adding a null constructor for AutocompleteMatch because it was too cumbersome otherwise. * Change the name of the "SecurityImageView" (or similar) to reflect its broader purpose, and plumb it to the edit to get an icon instead of to the toolbar model. * Add an AutocompleteMatch::Type to icon mapping function, and use it not only in the new code but also to simplify showing the popup contents. BUG=27570,39725 TEST=An icon should appear next to the address at all times. It should be a globe on non-secure pages, a magnifying glass on the NTP, and a match for whatever the user is typing as he types. Review URL: http://codereview.chromium.org/1457002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43025 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Refactor page-action context menus.shess@chromium.org2010-03-261-0/+6
| | | | | | | | | | | | | | Push the code to handle finding menus into the cell, which knows most about page actions. Also more thoroughly work around issues with Control-click context menus. BUG=none TEST=Right-click and Control-click work the same in the Omnibox proper. TEST=Right-click and control-click bring up appropriate menu on page actions. Review URL: http://codereview.chromium.org/1431001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42814 0039d316-1c4b-4281-b951-d872f2087c98
* Renames ContentBlockedImageView to ContentSettingImageView.bulach@chromium.org2010-03-051-3/+3
| | | | | | | | | | | | | | Adds ContentSettingImageModel to provide icon and tooltips for platform-specific ContentBlockedImageView. (in preparation for: http://codereview.chromium.org/650180/show ) TEST=chrome/browser/content_setting_image_model_unittest.cc Review URL: http://codereview.chromium.org/660279 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40732 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Content blocked icons.thakis@chromium.org2010-02-161-22/+37
| | | | | | | | | | | | | Also rewrite how omnibox icons are handled, to make it less repetitive to add the content blocked icons. Remove a O(n^2) while I'm at it. BUG=35594,34894 TEST=Go to a page with popups. "popups blocked" icon should appear in omnibox. It should have a tooltip, and a normal arrow cursor on mouse over. Switching tabs should make it go away, coming back to the tab with the blocked popup should make it go back. Page actions should still work (tooltips, clicking, context menu, display). Security icon should still work. Install rss extension; the preview bubble should point to the right icon. http://imgur.com/Yo0Ss Review URL: http://codereview.chromium.org/600133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39158 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Implements context menus for Page and Browser Actions. Introduces a ↵andybons@chromium.org2010-01-121-0/+6
| | | | | | | | | | reusable subclass of NSMenu that is used by both. BUG=30655 TEST=Right click on any Page action or Browser Action, observe a context menu appears. Review URL: http://codereview.chromium.org/525098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36021 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Implementation of Page Action tooltips. Also adds cursor rects to the ↵andybons@chromium.org2009-12-291-0/+4
| | | | | | | | | | address bar for any icon you can click within it so that the default pointer is shown instead of the I-beam. BUG=12281 TEST=Hover over a Page Action that has a tooltip, observe that the tooltip shows up and that the cursor is a pointer, not an I-Beam. Review URL: http://codereview.chromium.org/523015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35347 0039d316-1c4b-4281-b951-d872f2087c98
* First steps toward page actions on Mac. Page action icons shold show andpamg@google.com2009-12-141-1/+19
| | | | | | | | | | | | | | | | | | | | | perform their click actions when clicked. This is very rough, being committed in an early form so more people can contribute to the effort. Includes some early work from andybons too, toward making popups work. Known issues: * Icons don't refresh properly when an extension is installed or removed. Switching windows, then back again, updates the location bar properly. * Right- and middle-clicks do nothing * No tooltips, badges, installation previews, or popups yet * No unit tests yet BUG=12281 TEST=none yet Review URL: http://codereview.chromium.org/427009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34509 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Draw the results label correctly in the findbar.rohitrao@chromium.org2009-11-061-18/+8
| | | | | | | | | | | Adds common base classes (StyledTextField and StyledTextFieldCell) for both the find bar and omnibox text fields. BUG=http://crbug.com/19550 TEST=Findbar results label should not be overdrawn by find text. TEST=Autocomplete drawing (keyword, hint, lock icon) should not be affected. Review URL: http://codereview.chromium.org/319005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31186 0039d316-1c4b-4281-b951-d872f2087c98
* Restoring r29827. The skia file is new to this attempt, and may be what was ↵pamg@google.com2009-11-041-13/+13
| | | | | | | | | | | | | | | causing a unit test to crash last time. Refactor security-icon code to a more general form, also more consistent with the Windows implementation, in preparation for implementing page actions. Review URL: http://codereview.chromium.org/264037 BUG=14899, 22922, 12281 TEST=unit tests included Review URL: http://codereview.chromium.org/348069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31023 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 29827 - Refactor securityicon code to a more general form, also more ↵nsylvain@chromium.org2009-10-231-13/+13
| | | | | | | | | | | | | | | | consistent with the Windows implementation, in preparation for implementing page actions. BUG=14899, 22922, 12281 TEST=unit tests included Review URL: http://codereview.chromium.org/264037 TBR=pamg@google.com Review URL: http://codereview.chromium.org/333002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29847 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor security-icon code to a more general form, also more consistent withpamg@google.com2009-10-221-13/+13
| | | | | | | | | | | the Windows implementation, in preparation for implementing page actions. BUG=14899, 22922, 12281 TEST=unit tests included Review URL: http://codereview.chromium.org/264037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29827 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Simplify field editor code which tracks whether editor rect changed.shess@chromium.org2009-10-211-18/+0
| | | | | | | | | | | | | | Previous code used an elaborate system of checks, which was gradually becoming unmaintainable. Now that -resetFieldEditorFrameIfNeeded is implemented using dirty tricks, it is pretty easy to just check if it changed rather than trying to predict it. BUGS=none TEST=none Review URL: http://codereview.chromium.org/295036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29727 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Trim Omnibox hints as field shrinks.shess@chromium.org2009-10-151-8/+16
| | | | | | | | | | | | | | | | | When user text doesn't fit with the full hint: "Type to search" hint goes away "Tab to search" condenses to "Tab" "Search Engine:" is truncated http://crbug.com/20285 TEST=Type a sentence. Resize window to see if type-hint goes away. TEST=Type "google". Resize window to see if tab-hint goes away. TEST=Type "google" then TAB, then sentence. Resize window to see if "Search Google:" is truncated. TEST=In all cases, text should not scroll before truncation (though it might move as part of truncation). Review URL: http://codereview.chromium.org/262034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29202 0039d316-1c4b-4281-b951-d872f2087c98
* Add EV certificate text to the Mac location barhawk@chromium.org2009-10-091-1/+9
| | | | | | | | BUG=10910 TEST=EV sites (e.g., http://www.paypal.com and most bank sites) get a green text description next to the lock icon in the location bar, non-EV (and non-SSL) sites do not Review URL: http://codereview.chromium.org/216031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28627 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Show the page info window after clicking the security icon in the URL barrsesek@chromium.org2009-10-071-0/+3
| | | | | | | | | BUG=22922 TEST=Go to https://twitter.com, click the lock icon, see page info window. Review URL: http://codereview.chromium.org/222020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28221 0039d316-1c4b-4281-b951-d872f2087c98
* Comment changes from post-LGTM comments on 219031.shess@chromium.org2009-09-251-1/+1
| | | | | | | | TBR=rohitrao@chromium.org Review URL: http://codereview.chromium.org/246003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27220 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Manually reposition Omnibox field editor rather than using focus ↵shess@chromium.org2009-09-251-1/+2
| | | | | | | | | | | | | | | | | machinery. Previously this code abused the Cocoa focus machinery to move the field editor around when needed, which required the code to mess around with delegation to make sure the changes didn't leak out to the core autocomplete code. Unfortunately, it also messes with other features, like undo. This change does the positioning manually, which should let everything just work. TEST=Tab-to-search and keyword hints shouldn't cause the field to break. Review URL: http://codereview.chromium.org/219031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27217 0039d316-1c4b-4281-b951-d872f2087c98
* Add SSL icons on Mac OS Xhawk@chromium.org2009-09-161-0/+6
| | | | | | | | BUG=14899 TEST=https sites have a lock icon in the address field, plain http sites do not Review URL: http://codereview.chromium.org/199072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26307 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make I-beam cursor match editing area.shess@chromium.org2009-09-031-0/+3
| | | | | | | | | | | | Due to our tweaking of the text area, the I-beam cursor was sometimes janky. http://crbug.com/20238 TEST=I don't even know how to really test this. Review URL: http://codereview.chromium.org/181011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25346 0039d316-1c4b-4281-b951-d872f2087c98
* OSX: Fix the select-all-on-mouse-down in Omnibox.shess@chromium.org2009-08-251-3/+3
| | | | | | | | | | | | | | | Getting clicks in the decoration areas right caused a change to how clicks on the unfocused field worked. NSTextField also forwards the event to get click-drag selection right, this does the same thing for clicks in the decorations (other clicks are passed to super). http://crbug.com/20142 TEST=Browse to www.google.com. Click in page. Click in omnibox without releasing. You should get a caret insertion point. Review URL: http://codereview.chromium.org/173362 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24325 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Omnibox keyword, keyword hint, and search hint support.rohitrao@chromium.org2009-08-211-1/+60
| | | | | | | | | | | | | | | | | BUG=http://crbug.com/10944 BUG=http://crbug.com/10943 BUG=http://crbug.com/12285 TEST=With empty field, should see "Type to search" in light text on the RHS of the omnibox. Type "google" and should see "Press [Tab] to search Google" in light text on the RHS. Hit TAB, should see a rounded [Search Google:] item on the left and the cursor is now right of that. Popup should show "Keyword:" in some entries. Patch by shess@chromium.org. Review URL: http://codereview.chromium.org/173194 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23964 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Refactor location-bar autocomplete cell classes.shess@chromium.org2009-07-161-0/+11
LocationBarCell -> AutocompleteTextFieldCell. LocationBarFieldEditor -> AutocompleteTextFieldEditor. AutocompleteTextField added as placeholder for future work (hints and keyword search). Review URL: http://codereview.chromium.org/149717 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20853 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-17 05:51:39 +0000