summaryrefslogtreecommitdiffstats
path: root/chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm
Commit message (Collapse)AuthorAgeFilesLines
* Enable and implement last 2 items in bookmark bar context menu: "Openjrg@chromium.org2009-11-121-4/+2
| | | | | | | | | | | | | | | | | | | | | | | All In New Window" and "Open All In Incognito Window" (17616). Bookmark Folders have the bar context menu, not the bookmark context menu (26748). Disable bookmark manager item on bookmark contextual menus (26944). BUG=http://crbug.com/17616, http://crbug.com/26748, http://crbug.com/26944 TEST=Add some bookmarks. Make sure "Open All In New Window" and "Open All In Incognito Window" work from the bar context menu. Add a bookmark folder. Make sure the context menu of the folder is the bar conetxt menu, not the 'mark context menu. Make sure Bookmark Manager item is DISabled in both context menus. nib change: hook up actions in the "Open All Blah" items just like the normal "Open All". Review URL: http://codereview.chromium.org/373022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31748 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Implements the special bookmark bar on NTP.erg@chromium.org2009-10-061-5/+7
| | | | | | | | | | | | | Based mostly on Ben's patch, but made it compile, work, and descoped moving the bookmark bar around the view heiarchy. XIB modification: The root view is now a BookmarkBarToolbarView instead of an NSView and is [BookmarkBarController view]. BUG=17625 Review URL: http://codereview.chromium.org/246034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28074 0039d316-1c4b-4281-b951-d872f2087c98
* Make all of our unit tests be PlatformTests to get an autorelease pool.pinkerton@chromium.org2009-09-011-1/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/178037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25035 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts the revert of 22517.rohitrao@chromium.org2009-08-071-19/+5
| | | | | | | | | | | | | | | | | | | | Rewrites the Mac view resizing logic to have the BrowserWindowController directly resize and relayout its children views. Now when a view needs to be resized, it asks its resize delegate (typically its controller's parent) to perform the resize. BUG=http://crbug.com/17619 TEST=Make sure that views are laid out correctly, even when they change size. Open and close the bookmark bar. Trigger an infobar and then close it. Trigger the download shelf and then close it. Trigger a download shelf with the infobar open, or with the bookmark bar open. Switch to and from fullscreen with various bars open. Resize the browser window with various bars open. Start the browser with and without the bookmark bar open. Try all of the above in a popup window. Review URL: http://codereview.chromium.org/165014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22721 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 22517.rohitrao@chromium.org2009-08-051-5/+19
| | | | | | Review URL: http://codereview.chromium.org/165001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22541 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrites the Mac view resizing logic to have the BrowserWindowControllerrohitrao@chromium.org2009-08-051-19/+5
| | | | | | | | | | | | | | | | | | | directly resize and relayout its children views. Now when a view needs to be resized, it asks its resize delegate (typically its controller's parent) to perform the resize. BUG=http://crbug.com/17619 TEST=Make sure that views are laid out correctly, even when they change size. Open and close the bookmark bar. Trigger an infobar and then close it. Trigger the download shelf and then close it. Trigger a download shelf with the infobar open, or with the bookmark bar open. Switch to and from fullscreen with various bars open. Resize the browser window with various bars open. Start the browser with and without the bookmark bar open. Try all of the above in a popup window. Review URL: http://codereview.chromium.org/159776 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22517 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at infobars on Mac. These are not expected to berohitrao@chromium.org2009-07-171-2/+7
| | | | | | | | | | | | | | pretty. Animations and aesthetic appeal will come in a future CL. BUG=http://crbug.com/14462 BUG=http://crbug.com/14937 BUG=http://crbug.com/15839 BUG=http://crbug.com/16487 TEST=Infobars should show up when expected. Review URL: http://codereview.chromium.org/155494 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20930 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/155428 for Thiago, which changessky@chromium.org2009-07-151-1/+1
| | | | | | | | | | | | | | from me to get the thing to work. Merging two versions of BookmarkNodeRemoved into one. BUG=None TEST=Remove some bookmarks from BookmarkBar or Bookmarks Manager and make sure everything works ok. Review URL: http://codereview.chromium.org/155572 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20739 0039d316-1c4b-4281-b951-d872f2087c98
* More bookmark bar changes.jrg@chromium.org2009-07-141-11/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Applied memory cleanliness fix in unit test; follow-up from http://codereview.chromium.org/149308. * Move bookmark bar into it's own nib; minor code refactor to accomodate. * The toolbar STAR button somehow lost it's action; added it back in. * Implemented delete bookmark notification callback so we behave (remove button from the screen) when a bookmark is deleted. * Added context menus for the bookmark bar and bookmark buttons. * Hooked up a handful of these menu items. E.g. - open in new tab, window, incog window - delete bookmark (finally) - bookmark manager (which then hits a NOTIMPLEMENTED()) - always show bookmark bar * Truncate bookmark button text on end, not on middle. Experimental to look more like Windows. It looks cleaner but is less Mac-like. * Add "draws border when mouse goes over" for bookmark buttons. Need to do it by hand since we have a custom button drawing method. BUG=crbug.com/8381 TEST=Here's a list: - Make sure the bookmark buttons don't have a border unless the mouse is over them - Toolbar "STAR" should now add bookmarks when clicked - Test context menus on bookmark buttons, and the bar itself - Confirm a few of the behaviors as listed in the 'what I hooked up'; e.g. Right click on bookmark --> delete menu item should delete button Review URL: http://codereview.chromium.org/155358 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20591 0039d316-1c4b-4281-b951-d872f2087c98
* - Fix janklist issue #1: "there is a pixel line below the mainjrg@chromium.org2009-07-091-5/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | toolbar. The main toolbar should blend in with the bookmark bar when it's open" - Fix janklist issue #2: "It's way too tall - the distance from the bottom of the bar to a bookmark button bottom edge should be the same as the distance from the omnibox to the bookmark button top edge (this will probably mean that the bar has to overlap the toolbar)." - Fix janklist issue #4 (first part): "the bookmark bar bookmark buttons have a frame around them ... " - Fix janklist issue #9: "the show/hide animation is very janky... I see a dark gray area behind". Even with animators the grey is gone, but animators are disabled for now due to races. - Fix unlisted jank related to 9: don't use animator when opening bar on launch. - Also chipped away on unit tests. TEST=Launch with bookmark bar both open and closed. Make sure OK on launch. In each case open and close a few times fast. Repeat with multiple windows open. Sanity check jank descriptions listed above are fixed. BUG=crbug.com/14139, crbug.com/8381, crbug.com/14724 Review URL: http://codereview.chromium.org/149308 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20244 0039d316-1c4b-4281-b951-d872f2087c98
* Make bookmark model public interface use const BookmarkNode* instead ofmunjal@chromium.org2009-06-261-6/+6
| | | | | | | | | | | | | | | BookmarkNode*. This helps in making the BookmarkNode class setters public also without worrying about someone inadvertently changing BookmarkNode properties directly for bookmark model bookmarks. Change all the call sites to reflect this. BUG=none TEST=none Review URL: http://codereview.chromium.org/146116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19428 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark bar, now with buttons.jrg@chromium.org2009-06-081-0/+129
Much of this CL is refactoring; it's not as large as it looks. (Do I always claim that? It's really true this time.) Review URL: http://codereview.chromium.org/115150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17872 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-06 09:01:12 +0000