summaryrefslogtreecommitdiffstats
path: root/chrome/browser/cocoa/bookmark_bar_folder_controller.h
Commit message (Collapse)AuthorAgeFilesLines
* Move chrome/browser/cocoa/bookmark_* to chrome/browser/cocoa/bookmarks/.viettrungluu@chromium.org2010-10-151-183/+0
| | | | | | | | | BUG=none TEST=builds Review URL: http://codereview.chromium.org/3828006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62792 0039d316-1c4b-4281-b951-d872f2087c98
* Must clear all references to buttons representing a bookmark when that ↵mrossetti@chromium.org2010-07-301-0/+1
| | | | | | | | | | | bookmark gets deleted. BUG=50381 TEST=1) Bring up a bookmark folder which can be scrolled. 2) Scroll it a bit. 3) Cut or delete a bookmark using the contextual menu. 4) Scroll using the mouse scroll wheel. If there is no crash at this point then the bug has been fixed. Review URL: http://codereview.chromium.org/3030029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54262 0039d316-1c4b-4281-b951-d872f2087c98
* Cascading menus change growth dirction (right or left) when we hit thejrg@chromium.org2010-07-041-1/+7
| | | | | | | | | | | | | | | side of the screen. BUG=42808 TEST=Add a 100-level deep list of folders (or whatever). Open them --> grow to the right until side of the screen. Keep opening subfolders --> starts growing to the left. Keep going until left side of screen --> grows right again. Review URL: http://codereview.chromium.org/2802025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51622 0039d316-1c4b-4281-b951-d872f2087c98
* Mac/clang: First pass over unit_teststhakis@chromium.org2010-06-231-0/+1
| | | | | | Review URL: http://codereview.chromium.org/2876002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50590 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent valgrind errors due to incomplete animations by providing a test ↵mrossetti@chromium.org2010-05-201-0/+6
| | | | | | | | | | | setting to have animations ignored. Apply it to the BookmarkBarControllerTest.OffTheSideButtonHidden unit test. BookmarkBarController and BookmarkBarFolderController now have a -[setIgnoreAnimations:] function for accomplishing this. BUG=44563 TEST=None Review URL: http://codereview.chromium.org/2095017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47799 0039d316-1c4b-4281-b951-d872f2087c98
* Discontinue tracking folder menus as soon as any bookmark is clicked.mrossetti@chromium.org2010-05-101-0/+1
| | | | | | | | | BUG=43622 TEST=Pop open a folder on the bookmark bar and verify that mousing over various folders causes their menus to appear. Find a bookmark within one of those folders and click on it. Verify that mousing over folders in the bookmark bar no longer cause the folder menus to appear. Review URL: http://codereview.chromium.org/2044006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46827 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor menu window height, position, and presence of scrolling arrows code ↵mrossetti@chromium.org2010-05-071-0/+2
| | | | | | | | | | out of configureWindow and into a new adjustWindowForHeight: method. Call this method when adding or removing bookmark nodes to the menu, such as for dropping or pasting. When adjusting the button widths consider the best cell width, which may be less than the current button width, so that folder menus can shrink as well as grow. When adding the first bookmark to an empty folder remove the '(empty)' placeholder and when removing the last real bookmark from a folder insert the '(empty)' placeholder. BUG=42868,43227 TEST=In addition to attempting to recreate the problems as described in the bug reports: 1) Add (by dragging in or pasting) a new bookmark to a folder which is on the edge of being too big and needing to scroll and verify that it does become scrollable, 2) remove a bookmark (by cutting or deleting) from the folder which just became scrollable and verify that it is no longer scrollable, 3) create a new, empty folder and verify that it shows '(empty)' , 4) add a bookmark (by dragging or pasting) to the newly created empty folder and verify that there is only one bookmark shown and that it is not the '(empty)' placeholder, and 5) remove the single bookmark just added to the folder (by cutting or deleting) and verify that the menu now shows the '(empty)' placeholder. Review URL: http://codereview.chromium.org/2024004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46744 0039d316-1c4b-4281-b951-d872f2087c98
* Vertical scrolling arrows in bookmark bar folder windows when needed.jrg@chromium.org2010-04-301-0/+12
| | | | | | | | | | | | | | | | | | | | | | pdfs from Cole. BUG=42026 TEST=\ 1) Small folders --> no arrows. 2) Big folders --> arrow at bottom initially. 3) Move browser to bottom of screen so a small folder falls off the bottom and has an arrow. Open it and gently use scroll wheel to scroll. Make sure transition to "no arrow" looks good. Close and reopen. Scroll super-fast. Make sure it ends up in the same nice place. 4) Open big big folder. Scroll so top goes offscreen so you now have 2 scroll arrows. Use scroll wheel to gently go up and down (arrow hides and shows). Make sure transitions OK. Scroll all the way so bottom arrow disappears. Gently up and down; watch for transitions. Now FAST up and down. Make sure destination looks OK. BookmarkBarFolderWindow.xib change: BookmarkBarFolderWindowScrollView border turned off. Review URL: http://codereview.chromium.org/1813003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46114 0039d316-1c4b-4281-b951-d872f2087c98
* Add and implement cut/copy/paste to the bookmark bar and folder context ↵mrossetti@chromium.org2010-04-291-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | menus.Prevent dropping bookmark folders onto their children to avoid creating cycles and crashing. Keep folder menu windows open after a cut/copy/paste/delete and drop operation. Add test helpers for easing comparison of bookmark model changes. BUG=41217,36614,32064, 41404 Add and implement cut/copy/paste to the bookmark bar and folder context menus.Prevent dropping bookmark folders onto their children to avoid creating cycles and crashing. Keep folder menu windows open after a cut/copy/paste/delete and drop operation. TEST=1) Present the context menu for the bookmark bar in various places and insure that the cut/copy/paste menu items are shown and properly enabled or disabled. 2) Present the context menu for a folder menu in various places and insure that the cut/copy/paste menu items are shown and properly enabled or disabled. 3) Perform cut/copy/paste/delete operations in a folder menu and subfolder menu and verify that the menu remains presented after the operation completes. 4) Drag a bookmark item from the bar to another location on the bar and verify that the button no longer shows up in the old location but does show up in the new location. 5) Drag a bookmark item from the bar to be within a folder located _after_ the item being dragged. Verify the bar no longer shows the bookmark item. Verify the folder does show the bookmark item. Verify that the folder window has shifted to the left so that it remains aligned with it corresponding bar folder indicator. 6) Drag a bookmark item from the bar to be within a folder located _before_ the item being dragged. Verify the bar no longer shows the bookmark item. Verify the folder does show the bookmark item. Verify that the folder window has _not_ shifted to the left and that it remains aligned with it corresponding bar folder indicator. 7) Drag a bookmark around within the same folder and verify that the folder window does not move. 8) Drag a bookmark item from a folder to the bar in a position _after_ the folder form which the item comes. The folder menu window should close. 9) Drag a bookmark item from a folder to a different folder and verify that the original folder closes and the new folder remains open. 10) Drag an item from a parent folder to a child folder and verify that both folders remain open. Verify that the subfolder remains aligned to its associated folder icon in the parent folder. 11) Drag an item from a child folder to a parent folder. Verify that the child folder closes and the parent folder remains open. 12) Try dragging a parent folder onto a child folder and verify that the drag is not allowed to complete. 13) Hover over a folder item in a folder menu window. Verify that the folder opens up a subview menu window. Now drag the original folder (the one being hovered over) and verify that its subfolder menu automatically closes. 14) Slowly shrink window width until "off the side" menu appears; make sure it appears as soon as the last button gets removed. Now slowly grow window and make sure it goes away at the right time. 15) Add enough bookmarks to the bookmark bar to nearly fill the width of the window. Verify that the off-the-side chevron is not showing. Slowly shrink the width of the window until the off-the-side-chevron appears. Verify that the right-most bookmark button has disappeared and does not draw over the top of the chevron. Continue to shrink the window and verify that bookmark buttons disappear. View the contents of the chevron and verify that the bookmark buttons which previously appeared on the bar now appear in the chevron. Slowly grow the window and verify that bookmark buttons reappear without drawing over the top of the chevron. Verify that those bookmark buttons no longer appear in the chevron when it is popped up. Continue growing the window until all bookmark buttons appear in the bar and the chevron disappears. 16) Shrink the window so that the off-the-side chevron appears and contains three or more bookmarks. Pop open the chevron. Drag bookmarks up and down in the chevron menu and verify that moves and copies are performed. Drag a bar bookmark into the chevron and verify that the chevron pops up and allows the drag. Verify that the bar and chevron contents rearrange such that buttons on the bar fill but do not overflow the bar. Drag a chevron bookmark out onto the bar. Once again verify that the bar and chevron buttons rearrange such that the bar is full but not overflowing. Review URL: http://codereview.chromium.org/1742003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45965 0039d316-1c4b-4281-b951-d872f2087c98
* (jrg@chromium.org2010-04-211-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | Retry of http://codereview.chromium.org/1731001 Try servers not helpful since this includes a binary file. Unfortunately I did a --gtest_filter=BookmarkBar\* to self-test which did not include BookmarkButton* tests :-( Only change is "size" to "cellSize" on 2nd to last line of TEST_F(BookmarkButtonCellTest, FolderArrow) ) UI review follow-up for m5 bookmark bar deliverables Remove border of the (empty) bookmark item. Add arrow icons for folders in bookmark bar folder windows (but not on the bar) Scroll wheel events now scroll the bookmark bar folder windows (mostly works; has a little leak-thru) BUG=42026 TEST=see description xib change: NSScrollView changes to a BookmarkBarFolderWindowScrollView Review URL: http://codereview.chromium.org/1709004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45196 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 45151 - UI review followup for m5 bookmark bar deliverablesjrg@chromium.org2010-04-211-4/+0
| | | | | | | | | | | | | | | | | | | Remove border of the (empty) bookmark item. Add arrow icons for folders in bookmark bar folder windows (but not on the bar) Scroll wheel events now scroll the bookmark bar folder windows (mostly works; has a little leakthru) BUG=42026 TEST=see description xib change: NSScrollView changes to a BookmarkBarFolderWindowScrollView Review URL: http://codereview.chromium.org/1731001 TBR=jrg@chromium.org Review URL: http://codereview.chromium.org/1727004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45152 0039d316-1c4b-4281-b951-d872f2087c98
* UI review follow-up for m5 bookmark bar deliverablesjrg@chromium.org2010-04-211-0/+4
| | | | | | | | | | | | | | | | Remove border of the (empty) bookmark item. Add arrow icons for folders in bookmark bar folder windows (but not on the bar) Scroll wheel events now scroll the bookmark bar folder windows (mostly works; has a little leak-thru) BUG=42026 TEST=see description xib change: NSScrollView changes to a BookmarkBarFolderWindowScrollView Review URL: http://codereview.chromium.org/1731001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45151 0039d316-1c4b-4281-b951-d872f2087c98
* Mac Bookmarks Folder Bar hover state refactor.dhollowa@chromium.org2010-04-201-31/+2
| | | | | | | | | | | Refactoring to encapsulate hover state in a separate class. BUG=40006 TEST=BookmarkBarFolderHoverStateTest.HoverState Review URL: http://codereview.chromium.org/1676001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45053 0039d316-1c4b-4281-b951-d872f2087c98
* Mac Bookmarks bar crash hovering from one folder to another.dhollowa@chromium.org2010-04-161-5/+29
| | | | | | | | | | | | | Fix for race condition where the BookmarkBarFolderController was trying to simultaneously open and close its hover view. This code serializes the opening and closing. BUG=40006 TEST=BookmarkBarFolderControllerTest.HoverState Review URL: http://codereview.chromium.org/1593031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44783 0039d316-1c4b-4281-b951-d872f2087c98
* Improve bookmark bar folder scroll.jrg@chromium.org2010-04-161-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | BUG=39791 TEST=\ Create bookmark folders with various quantites of bookmarks. Make sure normal folders work. Open some that don't fit on the screen. See rounded corners on bottom. Try and move mouse to bottom of screen --> window grows and scrolls. Move mouse to top of screen --> window does NOT change size but does scroll. Move mouse off folder while scrolling --> scrolling stops. Make sure no buttons get "stuck" with a mouse-enter (highlit). Make sure no "getting stuck" or "window scrolls off the screen". Briefly test subfolders. xib changes: - Window content view is now BookmarkBarFolderWindowContentView - BookmaerkBarFolderView now wrapped in an NSScrollView - Some view autosizing changed Review URL: http://codereview.chromium.org/1593025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44755 0039d316-1c4b-4281-b951-d872f2087c98
* Implement cut and paste and rework copy and delete bookmark actions from ↵mrossetti@chromium.org2010-04-141-6/+31
| | | | | | | | | | | | | | | context menus. Eliminate bifurcated 'parentController_' data member (leaving this common behavior to the BookmarkFolderTarget class). Provide context menus (one for button and another for folder) for the folder controller thus allowing far easier identification of the target of the action. BookmarkBar.xib changes: Added Cut and Paste menu items to the button and folder contextual menus. Reconfigured the menus with separators and some rearranging to match Windows. BookmarkBarFolderWindow.xib changes: Copied the button and folder contextual menus from the BookmarkBar.xib and wired them up to the folder controller instead. BUG=23541 TEST=Present context menu for bookmark bar and verify the presence of Cut/Copy/Paste/Delete. Verify proper enabling (i.e. Paste should not be enabled until a bookmark or folder has been Cut or Copied). Perform each action Cut, Copy, Delete and Paste. Perform these tests for the contents of a folder coming off of the bookmark bar and for subfolders, too. Insure that pasting can be performed from the bar to a folder, a folder to the bar, bar to bar, folder to folder, at the beginning and at the end of each. Review URL: http://codereview.chromium.org/1611027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44505 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 44201 - Once the initial URL is opened in a new window, insure that ↵mrossetti@chromium.org2010-04-111-5/+0
| | | | | | | | | | | | | | subsequent URLs are opened in the new window instead of the original window. This change hinges on having URL opening code return the browser into which the URL was opened so that subsequent openings may now into which browser to do so. BUG=39901 TEST=Bring up context menu on a folder with two or more bookmarks and select "Open All in Incognito Window". Insure that all of the URLs are opened in the newly created, topmost window. Verify that no new tabs were created in the original window. Perform this same test using "Open All in New Window". Review URL: http://codereview.chromium.org/1634004 TBR=mrossetti@chromium.org Review URL: http://codereview.chromium.org/1520032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44202 0039d316-1c4b-4281-b951-d872f2087c98
* Once the initial URL is opened in a new window, insure that subsequent URLs ↵mrossetti@chromium.org2010-04-111-0/+5
| | | | | | | | | | | are opened in the new window instead of the original window. This change hinges on having URL opening code return the browser into which the URL was opened so that subsequent openings may now into which browser to do so. BUG=39901 TEST=Bring up context menu on a folder with two or more bookmarks and select "Open All in Incognito Window". Insure that all of the URLs are opened in the newly created, top-most window. Verify that no new tabs were created in the original window. Perform this same test using "Open All in New Window". Review URL: http://codereview.chromium.org/1634004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44201 0039d316-1c4b-4281-b951-d872f2087c98
* Set bookmark bar menu windows to the correct level.jrg@chromium.org2010-04-011-0/+1
| | | | | | | | | | | | | | | Fixes some menu awkwardness (e.g. is below the menubar and dock). Fixes some scroll awkwardness related dock overlap. Does NOT cause awkwardness if you Expose' which is smart enough to hide popup menus when exposeeing. BUG=http://crbug.com/36225 Review URL: http://codereview.chromium.org/1547010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43303 0039d316-1c4b-4281-b951-d872f2087c98
* Cmd-click in bookmark subfolders will open all.jrg@chromium.org2010-03-241-0/+5
| | | | | | | | | | | | | | | Refactor code for better sharing. BUG=http://crbug.com/26380 (cmd-click in subfolders now opens all) BUG=http://crbug.com/35966 (code dup reduced) TEST=\ Cmd-click a folder in the bar --> open all Cmd-click a folder in a SUBfolder of the bar --> open all Review URL: http://codereview.chromium.org/1134008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42546 0039d316-1c4b-4281-b951-d872f2087c98
* Quick and dirty bookmark folder/menu scrolling for Beta.jrg@chromium.org2010-03-161-0/+10
| | | | | | | | | | | | Intended as a temporary fix. BUG=36225 Review URL: http://codereview.chromium.org/998004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41678 0039d316-1c4b-4281-b951-d872f2087c98
* Custom "menus" for the bookmark bar folders. jrg@chromium.org2010-02-241-0/+92
Full behavior: http://JRG_WRITE_FULL_DOC_AND_TEST_PLAN_TOMORROW BUG=17608 (and a slew of others) Brief details on how to test: - add some bookmarks and bookmark folders. - at a basic level, make sure bookmark folders feel like menus e.g. -- click to open -- can open "submenus" and sub-sub-menus -- can open (click on) bookmarks in any of these submenus - click-drag does NOT open a menu (different than Mac menus); it initiates a Drag - click on folder in bookmark bar initiates "hover open"; moving mouse over other folders will pop them open immediately (much like Mac menus) - Bookmark bar non-drag hover-open is immediate, but bookmark folder hover-open has a brief delay so quick "move down" a folder does not trigger them all to open while you travel (much like Mac menus). - DnD of bookmarks and folders on bookmark bar. - While doing DnD of bookmark, "hover" over a folder and see it open. - Bookmark folder menus have normal DnD "drop indicators" like the bookmark bar. - Can "hover open" a nested subfolder. - Can drag a bookmark from one deep sub-sub-folder to a different deep one. - Confirm buttons and folders in submenus are themed, both with the theme set at launch time and the theme we change to after launch. - Empty folders have an "(empty)" item which is not selectable. - Intentional delay in closing a sub-sub-folder when hovering over another one. E.g. When moving to a sub-sub-menu, 'brief' travel over a different submenu does not close the destination sub-menu. - can use bookmark context menus in folder "menus". - confirm DnD from "Other bookmarks" to any other random folder and vice versa. - While non-drag hover open is active, clicking anywhere other than the bookmark bar or folder (e.g. the main web view) turns it off. TODO: - random bugs (e.g. "add folder" over a folder doesn't put it in there) - (empty) needs to be revisited, both visually and for a drop indication - core animations instead of drop indicators - ... Review URL: http://codereview.chromium.org/551226 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39947 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-17 23:28:45 +0000