Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Bookmark context menus reference bookmark IDs, not pointers, in case | jrg@chromium.org | 2010-03-18 | 1 | -3/+5 |
| | | | | | | | | | | | | | | | they go away while the menu is open. BUG=34522 TEST=\ 1) Confirm bookmark context menus continue to work (e.g. rename, delete). 2) Repeat the "sync and delete while context menu" is open test from the bug; make sure the op is ignored (and we don't crash). Review URL: http://codereview.chromium.org/1041003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41903 0039d316-1c4b-4281-b951-d872f2087c98 | ||||
* | Fix "open all" on a folder node to open only 'marks in that folder, | jrg@chromium.org | 2009-11-15 | 1 | -0/+18 |
not ALL all. Make Delete and Rename enabled for folder context menu (but disabled for "Other Bookmarks"). nib changes (related to the context menus): - Telegate is the bookmark bar controller. - Switched type from NSMenu to BookmarkMenu. TEST=New window. Create folder "empty" with nothing in it. Create folder "two" with 2 bookmarks in it. Create a final bookmark in the top level of the bar. Context menu (right click) over all folders. Make sure Delete and Rename enabled for folders but not "Other Bookmarks". Make sure "Open All" (and friends) disabled over "empty", enabled over "two". "Open All" on "two" --> see 2 opened. "Open All" on the bar itself --> see 3 opened. Ditto for "Open all in new window" and "open all in incognito window". Create a new window. In new window, make sure folders have context menus. BUG=http://crbug.com/27522, http://crbug.com/27529 Review URL: http://codereview.chromium.org/391046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32029 0039d316-1c4b-4281-b951-d872f2087c98 |