| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
| |
BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/3828006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62792 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
| |
As discussed on irc, we're getting rid of const NSObjects, and we're making all properties nonatomic.
const: All of cocoa takes nonconst NSObjects, and passing a const NSString to a function that takes NSString is a const violation. gcc doesn't complain about this, but clang intentionally does. constness is usually done via immutable base classes and mutable subclasses in cocoa anyway, so getting rid of const isn't that bad. Also, we don't really have a choice.
nonatomic: Some of our classes have custom setters that are not @synchronized. If the @property for that is not non-atomic, then the interface claims that the method is synchronized but the implementation actually isn't. That's a bug. gcc happens not to complain about this, but clang does. Since we shouldn't need atomic properties anywhere, the simple rule is now to just make all properties nonatomic.
Review URL: http://codereview.chromium.org/2769014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49808 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
they go away while the menu is open.
BUG=34522
TEST=\
1) Confirm bookmark context menus continue to work (e.g. rename, delete).
2) Repeat the "sync and delete while context menu" is open test from the
bug; make sure the op is ignored (and we don't crash).
Review URL: http://codereview.chromium.org/1041003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
not ALL all. Make Delete and Rename enabled for folder context menu
(but disabled for "Other Bookmarks").
nib changes (related to the context menus):
- Telegate is the bookmark bar controller.
- Switched type from NSMenu to BookmarkMenu.
TEST=New window. Create folder "empty" with nothing in it. Create
folder "two" with 2 bookmarks in it. Create a final bookmark in the
top level of the bar.
Context menu (right click) over all folders.
Make sure Delete and Rename enabled for folders but not "Other Bookmarks".
Make sure "Open All" (and friends) disabled over "empty", enabled over "two".
"Open All" on "two" --> see 2 opened.
"Open All" on the bar itself --> see 3 opened.
Ditto for "Open all in new window" and "open all in incognito window".
Create a new window. In new window, make sure folders have context menus.
BUG=http://crbug.com/27522, http://crbug.com/27529
Review URL: http://codereview.chromium.org/391046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32029 0039d316-1c4b-4281-b951-d872f2087c98
|
