| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5197001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
an omnibox keyword.
BUG=54353
TEST=Install chrome_search from the extension examples folder. You should see a help bubble pointing to the omnibox explaining how to use the omnibox keyword.
Review URL: http://codereview.chromium.org/4724005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make ExtensionsService hold const Extension pointers only. This ensures that
extensions can't be modified after they're created, and lets us share them
between threads.
BUG=56558
TEST=no functional change
Review URL: http://codereview.chromium.org/4138006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the ExtensionInstalledBubble.
The info bubble was closing after the extension was uninstalled. This wouldn't
always happen - sometimes the browser shut down first, so we didn't crash.
BUG=56558
TEST=covered by browser_test
Review URL: http://codereview.chromium.org/4112007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Rename entries under appcache, automation, chromeos, cocoa,
file_system, metrics, policy, prefs, remoting, search_engines
and tab_contents.
BUG=56926
TEST=trybots
Review URL: http://codereview.chromium.org/3660002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to GetTitle().
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3279005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LocationBarViewMac::GetPageActionBubblePoint() calculates the
info-bubble point directly, rather than exposing multiple entry points
so that extension code can calculate it.
Also convert -locationBarBridge from returning |LocationBar*| to
returning |LocationBarViewMac*|. Various code was doing
static_cast<LocationBarViewMac*>() on the result, so it wasn't safe
anyhow.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2998004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a BaseBubbleController. Move ContentBlockedBubbleController to use it (other bubbles will follow in later CLs), add FIrstRunBubbleController which uses it.
Move some l10n stuff to l10n_util and use that, too.
Update first run code to actually call the bubble code. Fix a double free while I'm at it (the scoped_ptr<> in DoFirstRun() already does the freeing, no need to do it in FirstRunDone())
BUG=27489,36366
TEST=Firstrun bubble shows up when starting chrome with --first-run, doesn't if starting chrome without that flag. Content blocked bubbles still work.
Review URL: http://codereview.chromium.org/2822026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move these files from cocoa/ to cocoa/location_bar/:
autocomplete_text_field.h
autocomplete_text_field.mm
autocomplete_text_field_cell.h
autocomplete_text_field_cell.mm
autocomplete_text_field_cell_unittest.mm
autocomplete_text_field_editor.h
autocomplete_text_field_editor.mm
autocomplete_text_field_editor_unittest.mm
autocomplete_text_field_unittest.mm
autocomplete_text_field_unittest_helper.h
autocomplete_text_field_unittest_helper.mm
location_bar_view_mac.h
location_bar_view_mac.mm
location_bar_view_mac_unittest.mm
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2807024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Push the AutocompleteTextFieldCell knowledge into LocationBarViewMac.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2806031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=if it compiles, it is perfect
BUG=none
Review URL: http://codereview.chromium.org/2001007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=everything still builds
Review URL: http://codereview.chromium.org/1787001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
action icon.
BUG= 41374
TEST= install a page action extension. "installed bubble" points at the icon that was installed. it should work for multiple icons.
Review URL: http://codereview.chromium.org/1762001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Known issues:
o The ordering of the Browser Actions is not consistent within the menu.
o Icons for the actions within the menu are not implemented yet.
o It is a standard NSMenu, so drag and drop will not work and right click does not work for now.
TEST=none
BUG=32101
Review URL: http://codereview.chromium.org/1083001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
resolution independence.
BUG=http://crbug.com/19476, http://crbug.com/36366
TEST=click the star in RI and the bubble should position itself correctly; status bubble should have adequate height for text
Review URL: http://codereview.chromium.org/851009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
o Icons fade out as they are moved off screen by resizing the window.
o Dragging the resizer actually resizes the container.
o Known issues include:
+ no chevron.
+ no updating of other windows if the size of the container changes.
+ the cursor is a bit wonky in updating its state.
o Fixes a slew of janky UI bugs relating to having a lot of extensions installed.
BUG=26990,29838
TEST=none
Review URL: http://codereview.chromium.org/657038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also rewrite how omnibox icons are handled, to make it less repetitive to add the content blocked icons. Remove a O(n^2) while I'm at it.
BUG=35594,34894
TEST=Go to a page with popups. "popups blocked" icon should appear in omnibox. It should have a tooltip, and a normal arrow cursor on mouse over. Switching tabs should make it go away, coming back to the tab with the blocked popup should make it go back. Page actions should still work (tooltips, clicking, context menu, display). Security icon should still work. Install rss extension; the preview bubble should point to the right icon.
http://imgur.com/Yo0Ss
Review URL: http://codereview.chromium.org/600133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
install bubble showing.
BUG= 34282
TEST= in release version, create a page action. close browser window while page action install bubble is showing. no crash, ever.
Review URL: http://codereview.chromium.org/561028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
extension bubble.
BUG= none
TEST= none
Review URL: http://codereview.chromium.org/556098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
Adds ExtensionInstalledBubble.xib, which contains the framework for the bubble itself (icon view, close button, and three message fields).
BUG= 26974
TEST= Install an extension. Bubble should show same information as windows bubble.
Review URL: http://codereview.chromium.org/527012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37671 0039d316-1c4b-4281-b951-d872f2087c98
|