summaryrefslogtreecommitdiffstats
path: root/chrome/browser/cocoa/fullscreen_controller.mm
Commit message (Collapse)AuthorAgeFilesLines
* Move browser/cocoa to browser/ui/cocoaben@chromium.org2010-12-011-633/+0
| | | | | | | | | BUG=none TEST=none TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67854 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Snap fullscreen window to screen after exiting spaces rohitrao@chromium.org2010-09-071-0/+9
| | | | | | | | | | | | | | | | | | | | Users can arbitrarily move fullscreen windows. If the fullscreen window changes screen then the fullscreen controller will snap it to the screen. If the fullscreen window doesn't change screen then the window will remain where it is which looks weird. This patch fixes the issue by always snapping the window's frame to the screen any time it has moved. An alternative fix would be to override a new 10.6 API: -[NSWindow isMovable] and return NO. This would allow users to move windows between spaces but not the position inside a space. I think detecting window move is better because: - it works on 10.5 also - users with multiple monitors can uses space to move the window between monitors Patch by Sailesh Agrawal <fnepal@gmail.com>. BUG=41693 TEST=Verified that the full screen window snaps to the screen when moved in Spaces. Verified that changing the screen resolution, mirroring, etc... all correct cause the full screen window to snap to the screen. Review URL: http://codereview.chromium.org/3343009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58740 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Some clang appeasing.thakis@chromium.org2010-08-041-2/+2
| | | | | | | | BUG=TEST=none Review URL: http://codereview.chromium.org/3089004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54870 0039d316-1c4b-4281-b951-d872f2087c98
* Send away bookmark bar folder when going fullscreen with menu.jrg@chromium.org2010-07-201-0/+13
| | | | | | | | | | | | | | BUG=http://crbug.com/49340 TEST=Open a bookmark folder. With the VIEW MENU (not the keystroke), go fullscreen. --> see "chrome" gone (unless mouse at top of screen); see bookmark menu gone. With the VIEW MENU (not the keystroke), go normal-screen. --> see no bookmark menu. Review URL: http://codereview.chromium.org/3044012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53087 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Tracking-area hygiene.shess@chromium.org2010-06-211-0/+1
| | | | | | | | | | | | | When tracking areas have an owner different from the view they are added to, they can exist past the owner's death. These have not been implicated in any crashes, but it's the best idea I have for the bug. BUG=38441 TEST=none Review URL: http://codereview.chromium.org/2823013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50387 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Remove all pending timers and callbacks before destroying the ↵rohitrao@chromium.org2010-04-131-3/+5
| | | | | | | | | | fullscreen controller. BUG=41263 TEST=See test case in bug. Review URL: http://codereview.chromium.org/1654002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44386 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Do not hide the menubar if going fullscreen on a secondary monitor.rohitrao@chromium.org2010-03-111-5/+13
| | | | | | | | BUG=37989 TEST=Go fullscreen on a secondary monitor. Should not hide the menubar. Review URL: http://codereview.chromium.org/872003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41327 0039d316-1c4b-4281-b951-d872f2087c98
* Pick up a GTM roll and update the apis that changed in this roll.thomasvl@chromium.org2010-03-111-0/+1
| | | | | | | | BUG=none TEST=everything still works Review URL: http://codereview.chromium.org/793003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41295 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: fix fullscreen floating bar in popup windows.viettrungluu@chromium.org2010-03-091-4/+5
| | | | | | | | | BUG=37699 TEST=Make sure the following types of windows look correct in fullscreen mode (in particular, the toolbar/menu should slide down properly and look nice): (1) normal windows (with tab strip), (2) popup windows with location bar, (3) "app" windows such as the dev tools window. Also make sure these things show correctly with themes and the bookmark bar enabled. Review URL: http://codereview.chromium.org/747001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41073 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] When in fullscreen mode, ties the menubar shown state to the overlay ↵rohitrao@chromium.org2010-03-031-19/+52
| | | | | | | | | | | shown state. BUG=36610 TEST=Go fullscreen. Menubar should only be shown when the overlay is fully visible. TEST=While in fullscreen mode, fullscreen a youtube video. Menubar should be autohidden (mousing to the top of the screen should show it). Review URL: http://codereview.chromium.org/661380 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40529 0039d316-1c4b-4281-b951-d872f2087c98
* Base coordinate system != Window base coordinate system. Fixing.avi@chromium.org2010-03-031-2/+1
| | | | | | | | | BUG=http://crbug.com/36485 TEST=everything should still work Review URL: http://codereview.chromium.org/661322 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40519 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Clean up fullscreen tracking rectangle code.viettrungluu@chromium.org2010-03-031-44/+44
| | | | | | | | | BUG=none TEST=Make sure sliding bar still works properly in fullscreen mode. Review URL: http://codereview.chromium.org/660419 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40470 0039d316-1c4b-4281-b951-d872f2087c98
* Base coordinate system != Window base coordinate system. Marking things to ↵avi@chromium.org2010-02-251-0/+2
| | | | | | | | | | | be fixed. BUG=http://crbug.com/36485 TEST=none; marking things to be fixed Review URL: http://codereview.chromium.org/661047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40026 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Remove the 14px vertical offset for fullscreen windows that are not on ↵rohitrao@chromium.org2010-02-241-4/+20
| | | | | | | | | | the primary monitor. BUG=36579 TEST=Fullscreen a window on a secondary monitor. The tab strip should not be taller than normal. Review URL: http://codereview.chromium.org/652203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39863 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Register for screen changed notifications and resize the fullscreen ↵rohitrao@chromium.org2010-02-241-18/+56
| | | | | | | | | | window appropriately. Also register for main status notifications, allowing us to move some code out of BWC and into FSC. BUG=None TEST=Fullscreen a window on a 1024x768 monitor. Go into display preferences and change the monitor resolution to something higher. The fullscreen window should continue to fill the whole screen. Review URL: http://codereview.chromium.org/656020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39820 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Only hide the menubar if the fullscreen window is on the main screen.rohitrao@chromium.org2010-02-231-5/+10
| | | | | | | | BUG=35973 TEST=Fullscreen a window on a non-main screen. Menubar should still be visible on the main screen. Review URL: http://codereview.chromium.org/650187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39685 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Request/Release the fullscreen lock whenever a window gains or loses ↵rohitrao@chromium.org2010-02-221-0/+24
| | | | | | | | | | main status. BUG=35973 TEST=Fullscreen one window, then Cmd-N to open a new window. Menubar should be visible. Review URL: http://codereview.chromium.org/628006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39620 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: prevent the overlay from sliding in and out on fullscreen mode switch.viettrungluu@chromium.org2010-02-171-4/+7
| | | | | | | | | BUG=35959 TEST=Go to various web pages, focus various things, switch in and out of fullscreen mode; overlay should never slide in and then out (it should either be and stay in, if appropriate, or be out and stay out). Review URL: http://codereview.chromium.org/601090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39258 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: fullscreen mode work (still not enabled).viettrungluu@chromium.org2010-02-101-150/+282
| | | | | | | | | | | | | Change the way different things ensure the floating bar is visible. The new model is that things can "lock bar visibility" (and this locking can continue even outside fullscreen mode). Set up explicit timers for showing/hiding. BUG=31638 TEST=Things still work normally. Review URL: http://codereview.chromium.org/587015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38574 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Adds code for fullscreen mode, including a floating dropdown toolbar ↵rohitrao@chromium.org2010-02-031-0/+346
and tabstrip. This change does not enable the fullscreen menu item; a future CL will do that. BUG=31638 TEST=No visible changes. Unittests should pass. Review URL: http://codereview.chromium.org/542013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37932 0039d316-1c4b-4281-b951-d872f2087c98