summaryrefslogtreecommitdiffstats
path: root/chrome/browser/cocoa/infobar_controller.mm
Commit message (Collapse)AuthorAgeFilesLines
* [Mac] Enables animations for the infobar. Changes the control flow for ↵rohitrao@chromium.org2009-11-031-16/+83
| | | | | | | | | | | | | | | infobar opening/closing to match Windows more closely. Nib file changes: - Embedded the InfoBarGradientView inside an AnimatableView. - Rebound [controller view] to the AnimatableView and added an infoBarView_ IBOutlet. - Bound the AnimatableView's delegate_ to the InfoBarController. BUG=http://crbug.com/25599 TEST=Infobars should animate in and out, except for during tab switches. Review URL: http://codereview.chromium.org/354008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30893 0039d316-1c4b-4281-b951-d872f2087c98
* Infobar l10n passthomasvl@chromium.org2009-10-051-58/+87
| | | | | | | | | | | | | | | | | | - remove the close button outlet (unused) - add a helper to hide the buttons and resize the text field to use the same. - if no image, move the text field - tweak the xib to make it clear the values aren't used - tweak the xib to remove the NSEveryone image - make the link text use the control's font so it matches what's in the xib and other infobar modes (if we ever had to tweak it). - use the GTM helper for autosizing buttons - reflow how we position the buttons/textfield for the button infobars so it updates the textfield once. TEST=if you make the window skinny, any infobars that don't have buttons shouldn't reserve space for them. the the plugin crashed info bar shouldn't show a bogus graphic (currently we have none set). BUG=20535 BUG=19183 Review URL: http://codereview.chromium.org/251075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27983 0039d316-1c4b-4281-b951-d872f2087c98
* This changelist represents the necessary merger of two others:ben@chromium.org2009-08-191-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | http://codereview.chromium.org/172082 Create new event_utils.h file for Cocoa-specific event to WindowOpenDisposition cracking. Hook this up to BookmarkBarController so that clicks to bookmark items use the oracle function to determine where the bookmark should be opened. BUG=17301 TEST=Cmd+Click etc on bookmark items should work. See bug and unit test attached. http://codereview.chromium.org/174021 Convert users of the "get last active browser, get selected tab contents, open url" pattern to just call OpenURL on Browser directly. Makes GetOrCreateTabbedBrowser public on Browser, and makes it static so it can be called with a provided profile. BUG=none TEST=Try opening links from the bookmark/history menus on mac, with and without an existing window open, with an active incognito window, etc. The links should all open in the last active non-incognito window, or create a new non-incognito window if none is open. Review URL: http://codereview.chromium.org/173044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23693 0039d316-1c4b-4281-b951-d872f2087c98
* Add modifier key support for window open dispositions throught the Mac UIrohitrao@chromium.org2009-08-181-2/+3
| | | | | | | | | | | | | | | | * Add cocoa_utils.{h,mm} and a unit test for the one method it contains: event_utils::DispositionFromEventFlags(). * Add modifier key support to the history menu, bookmark menu, infobars, bookmark bar, and Omnibox. BUG=17912,17301 TEST=When using the aforementioned UI elements, Cmd should open in new foreground tab, Cmd+Shift should open in new background tab, and Shift should open in a new window. Patch by Robert Sesek. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23636 0039d316-1c4b-4281-b951-d872f2087c98
* Infobar UI cleanup on Mac. Adds the yellow background gradient androhitrao@chromium.org2009-07-201-52/+65
| | | | | | | | | | | | | | | centers all of the buttons. Also adds the ok/cancel buttons to the xib file. Infobars that do not need the buttons can remove them from the view before displaying. BUG=http://crbug.com/14462 BUG=http://crbug.com/17195 TEST=Infobars should have yellow background, look less ugly. Review URL: http://codereview.chromium.org/155788 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21128 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a leak in [LinkInfoBarController addAdditionalControls].rohitrao@chromium.org2009-07-171-2/+2
| | | | | | | | | | | | Removes the valgrind suppression for this leak. Valgrind: 1, rohitrao: 0 BUG=17002 TEST=No more leaky. Review URL: http://codereview.chromium.org/159005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20955 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at infobars on Mac. These are not expected to berohitrao@chromium.org2009-07-171-0/+283
pretty. Animations and aesthetic appeal will come in a future CL. BUG=http://crbug.com/14462 BUG=http://crbug.com/14937 BUG=http://crbug.com/15839 BUG=http://crbug.com/16487 TEST=Infobars should show up when expected. Review URL: http://codereview.chromium.org/155494 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20930 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-09 01:36:58 +0000