summaryrefslogtreecommitdiffstats
path: root/chrome/browser/cocoa/location_bar
Commit message (Collapse)AuthorAgeFilesLines
* [Mac] Fix build break with r52223.shess@chromium.org2010-07-131-2/+2
| | | | | | | | | | | | image and pboard were always initialized, but warning that they couldn't only happened on opt build, which I didn't, mea culpa... BUG=none TEST=none Review URL: http://codereview.chromium.org/2951012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52232 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] First part of Omnibox decoration refactor. Enable ev bubble.shess@chromium.org2010-07-1320-876/+1183
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The views implementation of the little things floating around in the Omnibox uses nested views which are manually laid out by the location-bar code. The Mac code has a variety of different implementations for these items, with the layout distributed across many files. This change creates something called a "decoration" which is similar (different name because Mac has a strong sense of what a "view" is). Decorations are kind of like a C++ NSCell, which the AutocompleteTextFieldCell handles generically and the LocationBarViewMac::Layout() code will lay out. The overall goal is to loosely parallel the views code for decorations and Layout(), so that future coders can do the right thing more easily. This CL converts the left-hand items, namely: - the location icon - the search-keyword bubble - the ev security bubble (new) The Layout() function does not yet deal with trimming things to fit when space is tight. location_bar_view_mac_unittest.mm was always a sham, so I'm going to stop pretending. BUG=41998 TEST=EV bubble for secure sites. TEST=location icon can be clicked (page info panel) and dragged. TEST=EV bubble can be clicked (page info panel) and dragged. TEST=keyword-search mode shows appropriately. Review URL: http://codereview.chromium.org/2805070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52223 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Mouse clicks in omnibox close popup.shess@chromium.org2010-07-125-11/+45
| | | | | | | | | | | | | | | | | | Previously a right-click in omnibox or on a page action would have a context menu _and_ the omnibox popup. Clicking a page action or star would mess up the omnibox selection. This brings things in line with other platforms. Also fix to not change selection if an omnibox decoration handles the click. BUG=40145 TEST=Clicking star with omnibox popup up should close popup. TEST=Clicking star should not change omnibox selection. TEST=Right-click in omnibox with popup up should close popup. Review URL: http://codereview.chromium.org/2900006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52126 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Redraw omnibox when updating star status.shess@chromium.org2010-07-121-0/+1
| | | | | | | | | BUG=46696 TEST=Put an url on BMB. Click to it. Right-click delete, star in omnibox should update. Review URL: http://codereview.chromium.org/2915002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52102 0039d316-1c4b-4281-b951-d872f2087c98
* Change a bunch of string types.estade@chromium.org2010-06-291-3/+4
| | | | | | | | | | | | | Started out just trying to change PrefService::GetString and ::SetString. This snowballed a little bit. Had to change a bunch of url strings in search_engines/ from wstring to string (some of them may be better off as GURLs, but UTF-8 is a step in the right direction, since that's what GURL uses internally, as well as externally via its setters/getters). TODO (later patch): things that ask for accepted languages should use std::string, not std::wstring. BUG=none TEST=try bots Review URL: http://codereview.chromium.org/2854015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51157 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Tweak first-run bubble position.thakis@chromium.org2010-06-281-1/+1
| | | | | | Review URL: http://codereview.chromium.org/2805041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50980 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: First run bubble.thakis@chromium.org2010-06-262-6/+30
| | | | | | | | | | | | | | | Add a BaseBubbleController. Move ContentBlockedBubbleController to use it (other bubbles will follow in later CLs), add FIrstRunBubbleController which uses it. Move some l10n stuff to l10n_util and use that, too. Update first run code to actually call the bubble code. Fix a double free while I'm at it (the scoped_ptr<> in DoFirstRun() already does the freeing, no need to do it in FirstRunDone()) BUG=27489,36366 TEST=Firstrun bubble shows up when starting chrome with --first-run, doesn't if starting chrome without that flag. Content blocked bubbles still work. Review URL: http://codereview.chromium.org/2822026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50940 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Push location bar implementation into subdir.shess@chromium.org2010-06-2514-0/+5205
Move these files from cocoa/ to cocoa/location_bar/: autocomplete_text_field.h autocomplete_text_field.mm autocomplete_text_field_cell.h autocomplete_text_field_cell.mm autocomplete_text_field_cell_unittest.mm autocomplete_text_field_editor.h autocomplete_text_field_editor.mm autocomplete_text_field_editor_unittest.mm autocomplete_text_field_unittest.mm autocomplete_text_field_unittest_helper.h autocomplete_text_field_unittest_helper.mm location_bar_view_mac.h location_bar_view_mac.mm location_bar_view_mac_unittest.mm BUG=none TEST=none Review URL: http://codereview.chromium.org/2807024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50873 0039d316-1c4b-4281-b951-d872f2087c98