summaryrefslogtreecommitdiffstats
path: root/chrome/browser/cocoa/rwhvm_editcommand_helper.h
Commit message (Collapse)AuthorAgeFilesLines
* Forward edit commands to be executed for shortcuts which aren't handled bythakis@chromium.org2009-09-211-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | javascript. As a result, cocoa keybindings work. The approach: We instantiate a vanilla NSResponder, call interpretKeyEvents on it, and record all of the selectors passed into doCommandBySelector while interpreting the key event. The selectors are converted into edit commands which can be passed to the render process. Caveats: - Shortcuts involving a sequence of key combinations (chords) don't work, because we instantiate a new responder for each event. - We ignore key combinations that don't include a modifier (ctrl, cmd, alt) because this was causing strange behavior (e.g. tab always inserted a tab rather than moving to the next field on the page). BUG=12538 TEST=go to a page with a text field. make sure that ctrl-a moves cursor to beginning of line, ctrl-e goes to the end, ctrl-d deletes to the right, ctrl-h to the left, etc Review URL: http://codereview.chromium.org/209046 Patch from matt@tolton.com. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26694 0039d316-1c4b-4281-b951-d872f2087c98
* Some cleanup around WebCore EditCommands:jeremy@chromium.org2009-06-231-1/+1
| | | | | | | | | Renamed CoreCommand -> EditCommand Renamed the ViewMsg_HandleExecuteEditCommand IPC message to ViewMsg_ExecuteEditCommand Review URL: http://codereview.chromium.org/147034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19055 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land r18853jeremy@chromium.org2009-06-231-0/+65
| | | | | | Review URL: http://codereview.chromium.org/141008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19023 0039d316-1c4b-4281-b951-d872f2087c98
* back out r18853jeremy@chromium.org2009-06-191-65/+0
| | | | | | | | This reverts commit f2f30e9d0108f4a776672c6b29d25ed3a8ad19ad. Review URL: http://codereview.chromium.org/140013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18856 0039d316-1c4b-4281-b951-d872f2087c98
* This patch adds Cocoa editing selectors to the RenderViewWidgetHostMac class.jeremy@chromium.org2009-06-191-0/+65
This makes us a better citizen in OSX text-editing land and is a first step in getting our text entry story to work more natively on OSX. The selectors are added at runtime to the Cocoa class and invoking them causes the appropriate WebKit core command to be invoked on the currently focused WebFrame. As a side-effect bug 10862 is fixed. BUG=10862 TEST=Open a new tab and type some text into an input element, change to a Hebrew keyboard layout and hit command-a, all text should be selected. Review URL: http://codereview.chromium.org/114070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18853 0039d316-1c4b-4281-b951-d872f2087c98